From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 13F90C433EF for ; Thu, 24 Mar 2022 09:58:15 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id A1E2D8409A; Thu, 24 Mar 2022 10:58:08 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=sartura.hr Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=sartura-hr.20210112.gappssmtp.com header.i=@sartura-hr.20210112.gappssmtp.com header.b="ovdWYMaE"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 8D70684091; Thu, 24 Mar 2022 10:57:54 +0100 (CET) Received: from mail-ej1-x62d.google.com (mail-ej1-x62d.google.com [IPv6:2a00:1450:4864:20::62d]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 97C3584096 for ; Thu, 24 Mar 2022 10:57:48 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=sartura.hr Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=robert.marko@sartura.hr Received: by mail-ej1-x62d.google.com with SMTP id qx21so7990413ejb.13 for ; Thu, 24 Mar 2022 02:57:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sartura-hr.20210112.gappssmtp.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=0/DmUJAcsYmhyBeAwT2bIkfklWkoDpcphhQCZJk5la8=; b=ovdWYMaE6iiqn71ekce54HH7gjX7U6UHPNZ7csueyBhV2bMzJZMNep8HGAEjS8N+H9 u63q2D98b85vs0oKxEFGGVh2wemgh+XpJwGG2b60rsUy4FFG9THkpowm/sB+HTDQG2BE Q7YbMLqd4l56c10UOhg7sd4o4HraHuBoft/AV0Od8QXkEhegP7bZW47p37APoSb97FD4 YTzNB85eHc/9ZhQoxA2uDVdoBx3jcez3dXiHQdWwnfcySBRMED3ltGPgA+xe+6X2rG3f stm1KZFp55zgQt744VucUgsYbVt1Yvoj3DC2RFExU0wBiC/Q381/ZQMe0UD9nh7Zr3n5 FB7g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=0/DmUJAcsYmhyBeAwT2bIkfklWkoDpcphhQCZJk5la8=; b=aEdZyRGHeIdTHc2bCQgy6cl6LuYh02Dz14+YHPMEHKoouSry0/8+etrU/awCYdSGG4 xr6p1CoD2XFL3d9bBaPFB0i83a+a0Lmlsc5Sh4y73sKhG1XxkYE+KREGSUgWLLnvWIQs N5Ux+eui45G5m8GP4RNWHhGwz19ohPZ6nT4EKAtJeHjoi7dcqbhpx8qTdqEt0BXy5qR3 +D4WvInwv/VYh8QbVDaX922JR0i1e6muZMIDKgESoi7mFdJfa+CqaHOR4sqmGDSidIxD noY2yHCns4Chw7MZpRig4K0GeMpUsLuUXaSD/GpkDXEHFy4CI+MN9eOfyfSaem/Qo0Io 4iSw== X-Gm-Message-State: AOAM530g7MWxrKK0CGIa6OD63Q6wp9QP/cw6kaBHazietzs4vb9xkQeX pnzNnmO/XxSs9kfM7iDNAFD1eBPa9R6hHDNRUh6DvZcuEn2iK471v26YqoUs6C92l6u782om9GD +MkJxr6yTv46VvjBWagkkJeZCi7tpkccVZJoWaYUB9Fs0ASFy30fZh/MmZe/71HkVtQeM9Jn/9i k= X-Google-Smtp-Source: ABdhPJzCtMUaJeJTw9MFbq6ujdRMDneX8HSs40+2YvHdjFQ9LmCZS8XgacZvDabPS+aQh0+IPfGPvQ== X-Received: by 2002:a17:906:58ce:b0:6da:b548:1bbb with SMTP id e14-20020a17090658ce00b006dab5481bbbmr4702576ejs.14.1648115867977; Thu, 24 Mar 2022 02:57:47 -0700 (PDT) Received: from fedora.robimarko.hr (cpezg-94-253-144-14-cbl.xnet.hr. [94.253.144.14]) by smtp.googlemail.com with ESMTPSA id r29-20020a50c01d000000b00415fb0dc793sm1207130edb.47.2022.03.24.02.57.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 24 Mar 2022 02:57:47 -0700 (PDT) From: Robert Marko To: u-boot@lists.denx.de, sr@denx.de, pali@kernel.org, marek.behun@nic.cz Cc: Robert Marko Subject: [PATCH v3 3/4] arm: mvebu: dts: uDPU: fix non-working networking Date: Thu, 24 Mar 2022 10:57:38 +0100 Message-Id: <20220324095739.1162965-3-robert.marko@sartura.hr> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220324095739.1162965-1-robert.marko@sartura.hr> References: <20220324095739.1162965-1-robert.marko@sartura.hr> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean uDPU is a bit of a specific device in that it does not have any copper ports nor any ethernet PHY-s but 2 SFP ports. This is an issue since MVNETA requires a PHY phandle or a fixed-link to be defined under its node. Since U-boot has no SFP support this is reasonable in order to know how to configure the MAC. However this also means that networking does not work on uDPU at all currently, and fails with: uDPU>> dhcp Could not get PHY for neta@30000: addr 0 phy_connect failed Could not get PHY for neta@40000: addr 1 phy_connect failed So, to provide working networking using only SFP-s let add the fixed-link at 1G which is much more common than 2.5G SFP-s as well as disable the TX_DISABLE pins like done on Armada 7040 and 8040 platforms. Since uDPU is not using any of the GPIO-s on the SB controller for any purpose other than GPIO, a call to the pinctrl must be made in order for it to get probed and thus register the SB GPIO bank, otherwise SB GPIO-s are not registered at all. Signed-off-by: Robert Marko --- Changes in v2: * Drop the custom SFP TX GPIO properties as they are parsed from the SFP nodes now arch/arm/dts/armada-3720-uDPU-u-boot.dtsi | 24 +++++++++++++++++++++++ 1 file changed, 24 insertions(+) diff --git a/arch/arm/dts/armada-3720-uDPU-u-boot.dtsi b/arch/arm/dts/armada-3720-uDPU-u-boot.dtsi index cf8ae4412b..47d87d4bd8 100644 --- a/arch/arm/dts/armada-3720-uDPU-u-boot.dtsi +++ b/arch/arm/dts/armada-3720-uDPU-u-boot.dtsi @@ -31,3 +31,27 @@ &sdhci0 { u-boot,dm-pre-reloc; }; + +&pinctrl_sb { + sfp_pin: sfp-pin { + groups = "pcie1_clkreq"; + function = "gpio"; + }; +}; + +ð0 { + pinctrl-names = "default"; + pinctrl-0 = <&sfp_pin>; + + fixed-link { + speed = <1000>; + full-duplex; + }; +}; + +ð1 { + fixed-link { + speed = <1000>; + full-duplex; + }; +}; -- 2.35.1