From: kernel test robot <lkp@intel.com>
To: kbuild@lists.01.org
Subject: kernel/trace/trace_events_user.c:915 user_events_ioctl_reg() warn: ignoring unreachable code.
Date: Fri, 25 Mar 2022 01:06:03 +0800 [thread overview]
Message-ID: <202203250156.4y3pbrrJ-lkp@intel.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 3940 bytes --]
CC: kbuild-all(a)lists.01.org
BCC: lkp(a)intel.com
CC: linux-kernel(a)vger.kernel.org
TO: Beau Belgrave <beaub@linux.microsoft.com>
CC: "Steven Rostedt (Google)" <rostedt@goodmis.org>
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: ed4643521e6af8ab8ed1e467630a85884d2696cf
commit: 7f5a08c79df35e68f1a43033450c5050f12bc155 user_events: Add minimal support for trace_event into ftrace
date: 6 weeks ago
:::::: branch date: 15 hours ago
:::::: commit date: 6 weeks ago
config: s390-randconfig-m031-20220324 (https://download.01.org/0day-ci/archive/20220325/202203250156.4y3pbrrJ-lkp(a)intel.com/config)
compiler: s390-linux-gcc (GCC) 11.2.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
smatch warnings:
kernel/trace/trace_events_user.c:915 user_events_ioctl_reg() warn: ignoring unreachable code.
vim +915 kernel/trace/trace_events_user.c
7f5a08c79df35e Beau Belgrave 2022-01-18 877
7f5a08c79df35e Beau Belgrave 2022-01-18 878 /*
7f5a08c79df35e Beau Belgrave 2022-01-18 879 * Registers a user_event on behalf of a user process.
7f5a08c79df35e Beau Belgrave 2022-01-18 880 */
7f5a08c79df35e Beau Belgrave 2022-01-18 881 static long user_events_ioctl_reg(struct file *file, unsigned long uarg)
7f5a08c79df35e Beau Belgrave 2022-01-18 882 {
7f5a08c79df35e Beau Belgrave 2022-01-18 883 struct user_reg __user *ureg = (struct user_reg __user *)uarg;
7f5a08c79df35e Beau Belgrave 2022-01-18 884 struct user_reg reg;
7f5a08c79df35e Beau Belgrave 2022-01-18 885 struct user_event *user;
7f5a08c79df35e Beau Belgrave 2022-01-18 886 char *name;
7f5a08c79df35e Beau Belgrave 2022-01-18 887 long ret;
7f5a08c79df35e Beau Belgrave 2022-01-18 888
7f5a08c79df35e Beau Belgrave 2022-01-18 889 ret = user_reg_get(ureg, ®);
7f5a08c79df35e Beau Belgrave 2022-01-18 890
7f5a08c79df35e Beau Belgrave 2022-01-18 891 if (ret)
7f5a08c79df35e Beau Belgrave 2022-01-18 892 return ret;
7f5a08c79df35e Beau Belgrave 2022-01-18 893
7f5a08c79df35e Beau Belgrave 2022-01-18 894 name = strndup_user((const char __user *)(uintptr_t)reg.name_args,
7f5a08c79df35e Beau Belgrave 2022-01-18 895 MAX_EVENT_DESC);
7f5a08c79df35e Beau Belgrave 2022-01-18 896
7f5a08c79df35e Beau Belgrave 2022-01-18 897 if (IS_ERR(name)) {
7f5a08c79df35e Beau Belgrave 2022-01-18 898 ret = PTR_ERR(name);
7f5a08c79df35e Beau Belgrave 2022-01-18 899 return ret;
7f5a08c79df35e Beau Belgrave 2022-01-18 900 }
7f5a08c79df35e Beau Belgrave 2022-01-18 901
7f5a08c79df35e Beau Belgrave 2022-01-18 902 ret = user_event_parse_cmd(name, &user);
7f5a08c79df35e Beau Belgrave 2022-01-18 903
7f5a08c79df35e Beau Belgrave 2022-01-18 904 if (ret) {
7f5a08c79df35e Beau Belgrave 2022-01-18 905 kfree(name);
7f5a08c79df35e Beau Belgrave 2022-01-18 906 return ret;
7f5a08c79df35e Beau Belgrave 2022-01-18 907 }
7f5a08c79df35e Beau Belgrave 2022-01-18 908
7f5a08c79df35e Beau Belgrave 2022-01-18 909 ret = user_events_ref_add(file, user);
7f5a08c79df35e Beau Belgrave 2022-01-18 910
7f5a08c79df35e Beau Belgrave 2022-01-18 911 /* Positive number is index and valid */
7f5a08c79df35e Beau Belgrave 2022-01-18 912 if (ret < 0)
7f5a08c79df35e Beau Belgrave 2022-01-18 913 return ret;
7f5a08c79df35e Beau Belgrave 2022-01-18 914
7f5a08c79df35e Beau Belgrave 2022-01-18 @915 put_user((u32)ret, &ureg->write_index);
7f5a08c79df35e Beau Belgrave 2022-01-18 916 put_user(user->index, &ureg->status_index);
7f5a08c79df35e Beau Belgrave 2022-01-18 917
7f5a08c79df35e Beau Belgrave 2022-01-18 918 return 0;
7f5a08c79df35e Beau Belgrave 2022-01-18 919 }
7f5a08c79df35e Beau Belgrave 2022-01-18 920
--
0-DAY CI Kernel Test Service
https://01.org/lkp
next reply other threads:[~2022-03-24 17:06 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-24 17:06 kernel test robot [this message]
-- strict thread matches above, loose matches on Subject: below --
2022-11-03 7:04 kernel/trace/trace_events_user.c:915 user_events_ioctl_reg() warn: ignoring unreachable code kernel test robot
2022-11-02 3:16 kernel test robot
2022-09-22 0:50 kernel test robot
2022-09-19 7:47 kernel test robot
2022-08-13 16:53 kernel test robot
2022-03-24 11:29 kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202203250156.4y3pbrrJ-lkp@intel.com \
--to=lkp@intel.com \
--cc=kbuild@lists.01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.