From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 08296C433F5 for ; Fri, 25 Mar 2022 01:58:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1357632AbiCYCA2 (ORCPT ); Thu, 24 Mar 2022 22:00:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54242 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1346335AbiCYCAZ (ORCPT ); Thu, 24 Mar 2022 22:00:25 -0400 Received: from mail-pj1-x1029.google.com (mail-pj1-x1029.google.com [IPv6:2607:f8b0:4864:20::1029]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 037423A72E for ; Thu, 24 Mar 2022 18:58:53 -0700 (PDT) Received: by mail-pj1-x1029.google.com with SMTP id o68-20020a17090a0a4a00b001c686a48263so6438273pjo.1 for ; Thu, 24 Mar 2022 18:58:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=7UqoxnexRZIYgAmaCT2NR/FFNg3pbUIhHD5KY1C8P0o=; b=avCYBKKvdypfuoJNrbhAIMEIcgShk1Zj1USbl3poWtUPT8Bet+mLntrgUKSMss/bh6 92lgLD5ty7Pdq2r9sxykimbuw1qTH9fvdhiAjnHYjB/W8osj/rVq5wbl3n9tcv2BA4ym ytk27+4wen2ceHQDcHck6NQ0n4dBzYM7zcNmfIJzgfuHIkChyjz4TZOlLwwnUxNLiUmv LWI4lHe13uN83Zd7vyAzK0YSK8nvZ2DiCIdcEkJO6nUUYIz+2md2TtyEYb3Qza6OaiZq rokEQhRpK7j/KhCyzhJN7vZgMxaH0wLvz4q0m+9K9qWhvhLxw7JbzOnLYEPw9wcoKEFd iRSw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=7UqoxnexRZIYgAmaCT2NR/FFNg3pbUIhHD5KY1C8P0o=; b=jy62chh7LXNx1lGSdIZOzt2fj6Cxxw4LAWtyJPEG/K3joypHKt7Q41/YiFflMZzGjt TQnv0WmR6f1xVAjYqV7u+GPNZcyvvN84MP/MOmwQLkHq4UxbHaBO5JBGrjIQrAXYLjoY cbw0D4m8/5e6xr8NvG465VGZOhARyfmKHWJBn9Q1zj296cw0Gxhclc83QW3pYVI47w4g XdkSJx0II+YyGQOXC0ByPEsqdR/wUc1ze8hqnwI9n8evEK9sV+5dyZAnveVtNvB5LArs HRk04qEKGAmFrnLZhfLLffcff2SUBr2aTX5VTx12topUFGfe15eH42e24fJW/oyam70V HBrQ== X-Gm-Message-State: AOAM531OGorkYsmN3d0Dmt6A/IO5zU/BxW1dJSbKw/WMpVLur33ynzTl YJrXPHXtQTlu4AdSMFD30cLvsA== X-Google-Smtp-Source: ABdhPJxZJhn3xGpOGCemBqjUHadgwgd6nBeVTCB5L3NUi0Odrw/tF5FzN0TXzKmg1SnC8nj7Jbx6zQ== X-Received: by 2002:a17:902:e801:b0:154:19ec:53a2 with SMTP id u1-20020a170902e80100b0015419ec53a2mr8886398plg.151.1648173532485; Thu, 24 Mar 2022 18:58:52 -0700 (PDT) Received: from localhost ([223.184.83.228]) by smtp.gmail.com with ESMTPSA id l185-20020a6388c2000000b0038614ed80c0sm3931676pgd.41.2022.03.24.18.58.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 24 Mar 2022 18:58:51 -0700 (PDT) Date: Fri, 25 Mar 2022 07:28:49 +0530 From: Viresh Kumar To: Kuldeep Singh Cc: Rob Herring , Viresh Kumar , Shiraz Hashim , soc@kernel.org, Arnd Bergmann , linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] ARM: dts: spear13xx: Update SPI dma properties Message-ID: <20220325015849.sazvlevnvdqj5z42@vireshk-i7> References: <20220323175920.93155-1-singh.kuldeep87k@gmail.com> <20220324023904.h2qfxzxlznggbsyr@vireshk-i7> <20220324062547.GA15504@9a2d8922b8f1> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220324062547.GA15504@9a2d8922b8f1> User-Agent: NeoMutt/20180716-391-311a52 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 24-03-22, 11:55, Kuldeep Singh wrote: > Fixed order of values is important in case of properties like > compatibles etc. In case of dma-names, yes order shouldn't matter here. > > This patch is more of appeasing dtbs_check warning rather than fixing > something. Exactly my point. We have seen similar type of issues with other tools, like coccinelle, earlier and such patches were rejected as the kernel was just fine and tooling needs to be fixed. > It's safe to go with this patch. > I am not sure if there's a provision to exclude dma-names from fix > ordering checks. Rob can help here in providing better insights. -- viresh From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5E8EEC433EF for ; Fri, 25 Mar 2022 02:00:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ge216HOoh0whWw23+uNFkh/JXrlobYBvDYhCfZoxa3w=; b=VSRfy99NDVq30F LMu4FpL3L5cr4Js1Vc6hZAbISGnGZsArFuhbYcDkNy7caVU9rV3rl7jhYrsSO27Uc57ygYelQkdR3 X8DL3DlHd2NLqwKZ7M+nMPMVjB4bXOpsqW4LlSw5w3c4Eq/TWRG8nvh24RcazhRycxL/4mjGY1LlJ AEvKnnFHz4pgfqPj0Izi+QSnLktHZD5n54e6EvRW3GpTVvaplYnjotAMouVroAiBcnRBHkqJjh6NV lbLe2fICKy1usdiAKC8UJn/91J+RM6SsFytIPQbQnWkDMC/RIsSSjpIY3Dh7DUTgIfThU7j+p+mBa +lG10nFyaTR2u3fkQVIg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nXZEQ-000rPu-UV; Fri, 25 Mar 2022 01:59:15 +0000 Received: from mail-pl1-x634.google.com ([2607:f8b0:4864:20::634]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nXZEN-000rLD-7k for linux-arm-kernel@lists.infradead.org; Fri, 25 Mar 2022 01:59:12 +0000 Received: by mail-pl1-x634.google.com with SMTP id k6so6601528plg.12 for ; Thu, 24 Mar 2022 18:58:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=7UqoxnexRZIYgAmaCT2NR/FFNg3pbUIhHD5KY1C8P0o=; b=avCYBKKvdypfuoJNrbhAIMEIcgShk1Zj1USbl3poWtUPT8Bet+mLntrgUKSMss/bh6 92lgLD5ty7Pdq2r9sxykimbuw1qTH9fvdhiAjnHYjB/W8osj/rVq5wbl3n9tcv2BA4ym ytk27+4wen2ceHQDcHck6NQ0n4dBzYM7zcNmfIJzgfuHIkChyjz4TZOlLwwnUxNLiUmv LWI4lHe13uN83Zd7vyAzK0YSK8nvZ2DiCIdcEkJO6nUUYIz+2md2TtyEYb3Qza6OaiZq rokEQhRpK7j/KhCyzhJN7vZgMxaH0wLvz4q0m+9K9qWhvhLxw7JbzOnLYEPw9wcoKEFd iRSw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=7UqoxnexRZIYgAmaCT2NR/FFNg3pbUIhHD5KY1C8P0o=; b=DTkXyUrPpJ7Eam8NKgZCKZnf5nYQFC0dq8pUKPLjScyaBkeeD5f9EuPh2uuYKqznnh VG9wah2x1uI69ZfNaUCzC9BdDaQ6SoBzqhaKLAd2W+LTYAY5xwvqmGSWa1RyMXuXmiTQ n9lWCGao7q/aZVlB5nUXVdH43IcUKnsmzOD1jGm1pMPEIXAe4m7J5wJE04dmzTGaiKRM 4Zgju55jFz8TxSSKvqDnsvJH7LQmTIqsXepjhHcZrMxjwINcPonfilPZeVh2e9UJ1xUW 1c6WxRcf4PE4MCeUSfvdE5fIPzopH94BXTSP3K3hKSPlF3Wa58cOA7nNBM8Jmy2Jp9mt ZDtg== X-Gm-Message-State: AOAM531WF0NxUzqGE/jVh24u3Hysv3HYcnCGln6naJEA7CQh53cISFPN 6P8pfzrEyEKlkzn7lsIFy5ej/A== X-Google-Smtp-Source: ABdhPJxZJhn3xGpOGCemBqjUHadgwgd6nBeVTCB5L3NUi0Odrw/tF5FzN0TXzKmg1SnC8nj7Jbx6zQ== X-Received: by 2002:a17:902:e801:b0:154:19ec:53a2 with SMTP id u1-20020a170902e80100b0015419ec53a2mr8886398plg.151.1648173532485; Thu, 24 Mar 2022 18:58:52 -0700 (PDT) Received: from localhost ([223.184.83.228]) by smtp.gmail.com with ESMTPSA id l185-20020a6388c2000000b0038614ed80c0sm3931676pgd.41.2022.03.24.18.58.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 24 Mar 2022 18:58:51 -0700 (PDT) Date: Fri, 25 Mar 2022 07:28:49 +0530 From: Viresh Kumar To: Kuldeep Singh Cc: Rob Herring , Viresh Kumar , Shiraz Hashim , soc@kernel.org, Arnd Bergmann , linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] ARM: dts: spear13xx: Update SPI dma properties Message-ID: <20220325015849.sazvlevnvdqj5z42@vireshk-i7> References: <20220323175920.93155-1-singh.kuldeep87k@gmail.com> <20220324023904.h2qfxzxlznggbsyr@vireshk-i7> <20220324062547.GA15504@9a2d8922b8f1> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220324062547.GA15504@9a2d8922b8f1> User-Agent: NeoMutt/20180716-391-311a52 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220324_185911_293718_FB9DE9A4 X-CRM114-Status: GOOD ( 12.70 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 24-03-22, 11:55, Kuldeep Singh wrote: > Fixed order of values is important in case of properties like > compatibles etc. In case of dma-names, yes order shouldn't matter here. > > This patch is more of appeasing dtbs_check warning rather than fixing > something. Exactly my point. We have seen similar type of issues with other tools, like coccinelle, earlier and such patches were rejected as the kernel was just fine and tooling needs to be fixed. > It's safe to go with this patch. > I am not sure if there's a provision to exclude dma-names from fix > ordering checks. Rob can help here in providing better insights. -- viresh _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel