From: Vladimir Oltean <vladimir.oltean@nxp.com>
To: "tharvey@gateworks.com" <tharvey@gateworks.com>
Cc: u-boot <u-boot@lists.denx.de>,
Joe Hershberger <joe.hershberger@ni.com>,
Ramon Fried <rfried.dev@gmail.com>
Subject: Re: [PATCH 1/2] net: dsa: fix phydev->speed being uninitialized for the CPU port fixed PHY
Date: Fri, 25 Mar 2022 18:07:06 +0000 [thread overview]
Message-ID: <20220325180706.w3faqca3xt5jakcj@skbuf> (raw)
In-Reply-To: <CAJ+vNU1UvBGm7drnC_eM0SkSa4ZqWW-Rkzz=jtDr0i7MpJ_W4g@mail.gmail.com>
Hi Tim,
On Fri, Mar 25, 2022 at 09:53:20AM -0700, Tim Harvey wrote:
> Vladimir,
>
> I came across this while looking for the best place to configure cpu
> port interface mode (ie rgmii id) for the mv88e61xx dsa driver I'm
> working on. Note that this patch causes port_probe to be called on the
> cpu port 'before' the master device has been probed. I'm not sure if
> this is intended or not?
>
> In my case I was looking to configure the cpu port interface mode when
> the port was probed but I can't do that because it happens before the
> switch is probed because of some things that need to happen there.
> Best Regards,
>
> Tim
You're past the DM_MDIO probing issues now? Glad to hear that.
Probing the DSA CPU port before the master wasn't necessarily the
intention, but then again, I'm not sure that there's a strict ordering
guarantee between the two that needs to be satisfied?
What do you need exactly? We could probably always reverse the
device_probe(master) call with the probing of the CPU port if the
ordering turns out to be a real problem. I can regression-test the
change on my boards, but I'd like to understand the need you have, maybe
even document it so that future changes are aware of it.
next prev parent reply other threads:[~2022-03-25 18:07 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-04 23:00 [PATCH 0/2] DSA switch fixes Vladimir Oltean
2021-12-04 23:00 ` [PATCH 1/2] net: dsa: fix phydev->speed being uninitialized for the CPU port fixed PHY Vladimir Oltean
2022-01-15 16:46 ` Ramon Fried
2022-01-15 16:47 ` Ramon Fried
2022-03-25 16:53 ` Tim Harvey
2022-03-25 18:07 ` Vladimir Oltean [this message]
2022-03-25 21:03 ` Tim Harvey
2022-03-28 9:26 ` Vladimir Oltean
2022-03-28 22:23 ` Tim Harvey
2022-03-29 0:03 ` Vladimir Oltean
2022-03-29 21:19 ` Tim Harvey
2021-12-04 23:00 ` [PATCH 2/2] net: dsa: sja1105: fix device id detection Vladimir Oltean
2022-01-15 16:48 ` Ramon Fried
2022-01-15 16:48 ` Ramon Fried
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220325180706.w3faqca3xt5jakcj@skbuf \
--to=vladimir.oltean@nxp.com \
--cc=joe.hershberger@ni.com \
--cc=rfried.dev@gmail.com \
--cc=tharvey@gateworks.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.