From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B73D2C433EF for ; Fri, 25 Mar 2022 18:22:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=7fNffaZ2RBEhrUDJ14az4QhfWiwze/c6p5JG5eMErSE=; b=1XTG3QKpgb9n8t jXrU+FyUxHbmeiWkAdJnvWcOmeUnTFVOvGoQGpf0yOXiOURXXeUtsto7tKqEtmKbGIi2ZCKCpb8i7 1vN01xbxC/PNKxiDmbUopiDv2NX5negJ2QwTqHU3DCtcrK7HXsF+SIcT0qz2yOlpZHJXp1Bvw48LN 9qR+9qcZ2j3UJHVEGRov3Huqg7AmKT/Bdy9eFPO4lvrV6u7nDHDW9qPCHIWBWUpc/hX7Q955IrKWM AebqTvwy49Eqe5tYoLLPoc927iPpWUHapxfqdcPH8Z212qEWUAqGo3skMLJE1UUAiPmrEeFI9BkSP ckSHaKl7fwVmmwmL+YDA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nXoaH-002zxt-By; Fri, 25 Mar 2022 18:22:49 +0000 Received: from wout4-smtp.messagingengine.com ([64.147.123.20]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nXoaE-002zxF-JE for linux-rockchip@lists.infradead.org; Fri, 25 Mar 2022 18:22:48 +0000 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.west.internal (Postfix) with ESMTP id C08543200E60; Fri, 25 Mar 2022 14:22:40 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute5.internal (MEProxy); Fri, 25 Mar 2022 14:22:41 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fastmail.com; h= cc:cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm3; bh=ZQaUt0eCTfYL4u 8m73mJTEsm09yFeWFLaBKPQ1lqkjA=; b=o139iP8rjeQyQna4QS4rWAjpKEjClX U+gE56Bz7w8B5rU5P3HvqKZ1Mv2KI68XZRahUahNLbFw/ua4KXqnKRSge0nOykOr fMKmDLZt56tkP4T1qaYkgTEn8OuIvgvhKiNJFIcPoRTLKtRUTwdwjnzOO1IE0c4P iWECV3FTZv99/O+JMYwilnaY6MciHuNCDa42rKMDcrZz4cjajIJGFwPdW8SK3UBY hxCvqirdM+MrvEZ9GGXTnORbKJmuR0FmXseO51ALX2BEigGsDMzRLamYsgQhtIoe CbaIhfpEXoRAJhwXNfL2pLaElOWvco1EJDOVPjYAJoEA4Wkz3lxyO+Cg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=ZQaUt0eCTfYL4u8m73mJTEsm09yFeWFLaBKPQ1lqk jA=; b=PpmnFm73cuD/U+3b9pRgdVOBThLK6fVGpHfkTHdCmBZoFevpO76OYr1O5 qLRwDUl95NwBlS7Mc9kAiZc+aZJpkpT6FlwjSZn6r4U7HHvpC+wy93+Qwusl8fU/ DLOjQUybuIqV1FMKy7q71Id7YL3dJXSyJUNnyNMvzeDgA+wdZDtzP9JXrrYhvHig +9rhFBtxKnVJT1J/5zAAD9b5a9pUQq13HbRWMJ6J5CGdP8FsXAN8FhBwZWW6Fyd0 ivc42qG3hpqaLo03+y52wVawqdTODAGyYO1dPNvhEyjYCVUg76QmBip75Uvjoe6N For/YYUcWXEAxk4nU0auSrq5QMGmA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvvddrudehuddguddufecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpeffhffvuffkfhggtggugfgjsehtkeertddttdejnecuhfhrohhmpeffrghf nhgrucfjihhrshgthhhfvghlugcuoegurghfnhgrsehfrghsthhmrghilhdrtghomheqne cuggftrfgrthhtvghrnhepvedtgedugeetueeuueetueefheekuddvgeffgeejffejledv ueeigeekkeevveefnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilh hfrhhomhepuggrfhhnrgesfhgrshhtmhgrihhlrdgtohhm X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 25 Mar 2022 14:22:38 -0400 (EDT) Date: Fri, 25 Mar 2022 21:22:34 +0300 From: Dafna Hirschfeld To: Laurent Pinchart Cc: linux-media@vger.kernel.org, Heiko Stuebner , Paul Elder , Tomasz Figa , linux-rockchip@lists.infradead.org Subject: Re: [PATCH v3 14/17] media: rkisp1: debug: Collect input status by sampling ISP_FLAGS_SHD Message-ID: <20220325182234.dba4h4fglqsnj6d2@guri> References: <20220319163100.3083-1-laurent.pinchart@ideasonboard.com> <20220319163100.3083-15-laurent.pinchart@ideasonboard.com> <20220322035624.mpkrod4g42xgpyfy@guri> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220325_112246_753658_22A16519 X-CRM114-Status: GOOD ( 33.84 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org T24gMjIuMDMuMjAyMiAxMDozMiwgTGF1cmVudCBQaW5jaGFydCB3cm90ZToKPiBIaSBEYWZuYSwK PiAKPiBPbiBUdWUsIE1hciAyMiwgMjAyMiBhdCAwNTo1NjoyNEFNICswMjAwLCBEYWZuYSBIaXJz Y2hmZWxkIHdyb3RlOgo+ID4gT24gMTkuMDMuMjAyMiAxODozMCwgTGF1cmVudCBQaW5jaGFydCB3 cm90ZToKPiA+ID4gVGhlIElTUF9GTEFHU19TSEQgcmVnaXN0ZXIgZXhwb3NlcyB0aGUgSVNQIHBh cmFsbGVsIGlucHV0IHNpZ25hbHMgKGRhdGEKPiA+ID4gYW5kIHN5bmNocm9uaXphdGlvbikgaW4g cmVhbCB0aW1lLiBUaGlzIGNhbiBoZWxwIGRlYnVnZ2luZyB3aGVuIHRoZQo+ID4gPiBkZXZpY2Ug ZG9lc24ndCBvdXRwdXQgYW55IGltYWdlLiBTYW1wbGUgdGhlIHJlZ2lzdGVyIDEwMDAwIHRpbWVz IHdpdGggYQo+ID4gPiAxwrVzIGRlbGF5IGFuZCBleHBvc2UgdGhlIHJlc3VsdCB0aHJvdWdoIGRl YnVnZnMuCj4gPiA+IAo+ID4gPiBTaWduZWQtb2ZmLWJ5OiBMYXVyZW50IFBpbmNoYXJ0IDxsYXVy ZW50LnBpbmNoYXJ0QGlkZWFzb25ib2FyZC5jb20+Cj4gPiA+IFNpZ25lZC1vZmYtYnk6IFBhdWwg RWxkZXIgPHBhdWwuZWxkZXJAaWRlYXNvbmJvYXJkLmNvbT4KPiA+ID4gLS0tCj4gPiA+ICAuLi4v cGxhdGZvcm0vcm9ja2NoaXAvcmtpc3AxL3JraXNwMS1kZWJ1Zy5jICAgfCA1NCArKysrKysrKysr KysrKysrKysrCj4gPiA+ICAuLi4vcGxhdGZvcm0vcm9ja2NoaXAvcmtpc3AxL3JraXNwMS1yZWdz LmggICAgfCAgOSArKysrCj4gPiA+ICAyIGZpbGVzIGNoYW5nZWQsIDYzIGluc2VydGlvbnMoKykK PiA+ID4gCj4gPiA+IGRpZmYgLS1naXQgYS9kcml2ZXJzL21lZGlhL3BsYXRmb3JtL3JvY2tjaGlw L3JraXNwMS9ya2lzcDEtZGVidWcuYyBiL2RyaXZlcnMvbWVkaWEvcGxhdGZvcm0vcm9ja2NoaXAv cmtpc3AxL3JraXNwMS1kZWJ1Zy5jCj4gPiA+IGluZGV4IDY0YjMzNzc0Y2JkZi4uZGEzZWQwYWI2 OTdhIDEwMDY0NAo+ID4gPiAtLS0gYS9kcml2ZXJzL21lZGlhL3BsYXRmb3JtL3JvY2tjaGlwL3Jr aXNwMS9ya2lzcDEtZGVidWcuYwo+ID4gPiArKysgYi9kcml2ZXJzL21lZGlhL3BsYXRmb3JtL3Jv Y2tjaGlwL3JraXNwMS9ya2lzcDEtZGVidWcuYwo+ID4gPiBAQCAtOSw5ICs5LDYxIEBACj4gPiA+ ICAgKi8KPiA+ID4gIAo+ID4gPiAgI2luY2x1ZGUgPGxpbnV4L2RlYnVnZnMuaD4KPiA+ID4gKyNp bmNsdWRlIDxsaW51eC9kZWxheS5oPgo+ID4gPiAgI2luY2x1ZGUgPGxpbnV4L2RldmljZS5oPgo+ ID4gPiArI2luY2x1ZGUgPGxpbnV4L3BtX3J1bnRpbWUuaD4KPiA+ID4gKyNpbmNsdWRlIDxsaW51 eC9zZXFfZmlsZS5oPgo+ID4gPiAgCj4gPiA+ICAjaW5jbHVkZSAicmtpc3AxLWNvbW1vbi5oIgo+ ID4gPiArI2luY2x1ZGUgInJraXNwMS1yZWdzLmgiCj4gPiA+ICsKPiA+ID4gKyNkZWZpbmUgUktJ U1AxX0RFQlVHX0RBVEFfQ09VTlRfQklOUwkzMgo+ID4gPiArI2RlZmluZSBSS0lTUDFfREVCVUdf REFUQV9DT1VOVF9TVEVQCSg0MDk2IC8gUktJU1AxX0RFQlVHX0RBVEFfQ09VTlRfQklOUykKPiA+ ID4gKwo+ID4gPiArc3RhdGljIGludCBya2lzcDFfZGVidWdfaW5wdXRfc3RhdHVzX3Nob3coc3Ry dWN0IHNlcV9maWxlICptLCB2b2lkICpwKQo+ID4gPiArewo+ID4gPiArCXN0cnVjdCBya2lzcDFf ZGV2aWNlICpya2lzcDEgPSBtLT5wcml2YXRlOwo+ID4gPiArCXUxNiBkYXRhX2NvdW50W1JLSVNQ MV9ERUJVR19EQVRBX0NPVU5UX0JJTlNdID0geyB9Owo+ID4gCj4gPiBTaW5jZSB0aGlzIGlzIGp1 c3QgYSBjb3VudGVyLCBpdCBjb3VsZCBiZSBpbnQvc2hvcnQKPiAKPiBJc24ndCB1MTYgYSBzaG9y dCBhbHJlYWR5ID8gT3IgZG8geW91IG1lYW4gdXNpbmcgInNob3J0IiBpbnN0ZWFkIG9mCj4gInUx NiIgPyBUaGF0IHdvdWxkIGJlIGZ1bmN0aW9uYWxseSBlcXVpdmFsZW50LCBidXQgSSBwaWNrZWQg dTE2IHRvIG1ha2UKPiB0aGUgc2l6ZSBleHBsaWNpdCwgZ2l2ZW4gdGhhdCBpdCBoYXMgdG8gaG9s ZCB2YWx1ZXMgdXAgdG8gMTAwMDAuCgpJIGtub3cgdGhhdCB1IyB0eXBlcyBhcmUgbWVhbnQgbWFp bmx5L29ubHkgdG8gY29uZmlndXJlIGhhcmR3YXJlLCBzbyBJCnN1Z2dlc3RlZCAncy91MTYvc2hv cnQvJyAsIGJ1dCBJIGRvbid0IHJlYWxseSBjYXJlLgoKVGhhbmtzLApEYWZuYQoKPiAKPiA+ID4g Kwl1bnNpZ25lZCBpbnQgaHN5bmNfY291bnQgPSAwOwo+ID4gPiArCXVuc2lnbmVkIGludCB2c3lu Y19jb3VudCA9IDA7Cj4gPiA+ICsJdW5zaWduZWQgaW50IGk7Cj4gPiA+ICsJdTMyIGRhdGE7Cj4g PiA+ICsJdTMyIHZhbDsKPiA+ID4gKwlpbnQgcmV0Owo+ID4gPiArCj4gPiA+ICsJcmV0ID0gcG1f cnVudGltZV9nZXRfaWZfaW5fdXNlKHJraXNwMS0+ZGV2KTsKPiA+ID4gKwlpZiAocmV0KQo+ID4g PiArCQlyZXR1cm4gcmV0Owo+ID4gCj4gPiBXZSB3YW50IHRvIHJldHVybiBoZXJlIGlmIHRoZSBk ZXZpY2UgaXMgbm90IGlzIHVzZSByaWdodD8KPiA+IElmIHNvIHdlIHNob3VsZCByZXR1cm4gaWYg KHJldCA8PSAwKQo+IAo+IENvcnJlY3QsIEknbGwgZml4IHRoYXQuCj4gCj4gPiA+ICsKPiA+ID4g KwkvKiBTYW1wbGUgdGhlIElTUCBpbnB1dCBwb3J0IHN0YXR1cyAxMDAwMCB0aW1lcyB3aXRoIGEg McK1cyBpbnRlcnZhbC4gKi8KPiA+ID4gKwlmb3IgKGkgPSAwOyBpIDwgMTAwMDA7ICsraSkgewo+ ID4gPiArCQl2YWwgPSBya2lzcDFfcmVhZChya2lzcDEsIFJLSVNQMV9DSUZfSVNQX0ZMQUdTX1NI RCk7Cj4gPiA+ICsKPiA+ID4gKwkJZGF0YSA9ICh2YWwgJiBSS0lTUDFfQ0lGX0lTUF9GTEFHU19T SERfU19EQVRBX01BU0spCj4gPiA+ICsJCSAgICAgPj4gUktJU1AxX0NJRl9JU1BfRkxBR1NfU0hE X1NfREFUQV9TSElGVDsKPiA+IAo+ID4gV2hhdCBpcyB0aGlzIGRhdGE/IHRoZSBkb2NzIG9ubHkg c2F5cwo+ID4gInN0YXRlIG9mIElTUCBpbnB1dCBwb3J0IHNfZGF0YSwgZm9yIHRlc3QgcHVycG9z ZXMiCj4gPiBJIGd1ZXNzIGl0IGluZGljYXRlIHNvbWVob3cgdGhlIGFtb3VudCBvZiBhY3R1YWxs IHNlbnNvciBkYXRhIGFycml2ZWQ/Cj4gPiBDb3VsZCBiZSBuaWNlIHRvIGFkZCBleHBsYW5hdGlv biBoZXJlLgo+IAo+IEknZCB0aGUgMTItYml0IHBhcmFsbGVsIChwaXhlbCkgZGF0YSBhdCB0aGUg SVNQIGlucHV0LiBJIGNhbiBhZGQgYQo+IGNvbW1lbnQuCj4gCj4gPiA+ICsJCWRhdGFfY291bnRb ZGF0YSAvIFJLSVNQMV9ERUJVR19EQVRBX0NPVU5UX1NURVBdKys7Cj4gPiA+ICsKPiA+ID4gKwkJ aWYgKHZhbCAmIFJLSVNQMV9DSUZfSVNQX0ZMQUdTX1NIRF9TX0hTWU5DKQo+ID4gPiArCQkJaHN5 bmNfY291bnQrKzsKPiA+ID4gKwkJaWYgKHZhbCAmIFJLSVNQMV9DSUZfSVNQX0ZMQUdTX1NIRF9T X1ZTWU5DKQo+ID4gPiArCQkJdnN5bmNfY291bnQrKzsKPiA+ID4gKwo+ID4gPiArCQl1ZGVsYXko MSk7Cj4gPiA+ICsJfQo+ID4gPiArCj4gPiA+ICsJcG1fcnVudGltZV9wdXQocmtpc3AxLT5kZXYp Owo+ID4gPiArCj4gPiA+ICsJc2VxX3ByaW50ZihtLCAidnN5bmM6ICV1LCBoc3luYzogJXVcbiIs IHZzeW5jX2NvdW50LCBoc3luY19jb3VudCk7Cj4gPiA+ICsJc2VxX3B1dHMobSwgImRhdGE6XG4i KTsKPiA+ID4gKwlmb3IgKGkgPSAwOyBpIDwgQVJSQVlfU0laRShkYXRhX2NvdW50KTsgKytpKQo+ ID4gPiArCQlzZXFfcHJpbnRmKG0sICItIFslMDR1OiUwNHVdOiAldVxuIiwKPiA+ID4gKwkJCSAg IGkgKiBSS0lTUDFfREVCVUdfREFUQV9DT1VOVF9TVEVQLAo+ID4gPiArCQkJICAgKGkgKyAxKSAq IFJLSVNQMV9ERUJVR19EQVRBX0NPVU5UX1NURVAgLSAxLAo+ID4gPiArCQkJICAgZGF0YV9jb3Vu dFtpXSk7Cj4gPiA+ICsKPiA+ID4gKwlyZXR1cm4gMDsKPiA+ID4gK30KPiA+ID4gK0RFRklORV9T SE9XX0FUVFJJQlVURShya2lzcDFfZGVidWdfaW5wdXRfc3RhdHVzKTsKPiA+ID4gIAo+ID4gPiAg dm9pZCBya2lzcDFfZGVidWdfaW5pdChzdHJ1Y3Qgcmtpc3AxX2RldmljZSAqcmtpc3AxKQo+ID4g PiAgewo+ID4gPiBAQCAtNDIsNiArOTQsOCBAQCB2b2lkIHJraXNwMV9kZWJ1Z19pbml0KHN0cnVj dCBya2lzcDFfZGV2aWNlICpya2lzcDEpCj4gPiA+ICAJCQkgICAgICZkZWJ1Zy0+ZnJhbWVfZHJv cFtSS0lTUDFfTUFJTlBBVEhdKTsKPiA+ID4gIAlkZWJ1Z2ZzX2NyZWF0ZV91bG9uZygic3BfZnJh bWVfZHJvcCIsIDA0NDQsIGRlYnVnLT5kZWJ1Z2ZzX2RpciwKPiA+ID4gIAkJCSAgICAgJmRlYnVn LT5mcmFtZV9kcm9wW1JLSVNQMV9TRUxGUEFUSF0pOwo+ID4gPiArCWRlYnVnZnNfY3JlYXRlX2Zp bGUoImlucHV0X3N0YXR1cyIsIDA0NDQsIGRlYnVnLT5kZWJ1Z2ZzX2Rpciwgcmtpc3AxLAo+ID4g PiArCQkJICAgICZya2lzcDFfZGVidWdfaW5wdXRfc3RhdHVzX2ZvcHMpOwo+ID4gPiAgfQo+ID4g PiAgCj4gPiA+ICB2b2lkIHJraXNwMV9kZWJ1Z19jbGVhbnVwKHN0cnVjdCBya2lzcDFfZGV2aWNl ICpya2lzcDEpCj4gPiA+IGRpZmYgLS1naXQgYS9kcml2ZXJzL21lZGlhL3BsYXRmb3JtL3JvY2tj aGlwL3JraXNwMS9ya2lzcDEtcmVncy5oIGIvZHJpdmVycy9tZWRpYS9wbGF0Zm9ybS9yb2NrY2hp cC9ya2lzcDEvcmtpc3AxLXJlZ3MuaAo+ID4gPiBpbmRleCAwODNkOTJhZGE3M2YuLjQ0N2M1ZjI0 MWQ2OSAxMDA2NDQKPiA+ID4gLS0tIGEvZHJpdmVycy9tZWRpYS9wbGF0Zm9ybS9yb2NrY2hpcC9y a2lzcDEvcmtpc3AxLXJlZ3MuaAo+ID4gPiArKysgYi9kcml2ZXJzL21lZGlhL3BsYXRmb3JtL3Jv Y2tjaGlwL3JraXNwMS9ya2lzcDEtcmVncy5oCj4gPiA+IEBAIC00NTQsNiArNDU0LDE1IEBACj4g PiA+ICAjZGVmaW5lIFJLSVNQMV9DSUZfSVNQX0RFTU9TQUlDX0JZUEFTUwkJCUJJVCgxMCkKPiA+ ID4gICNkZWZpbmUgUktJU1AxX0NJRl9JU1BfREVNT1NBSUNfVEgoeCkJCQkoKHgpICYgMHhGRikK PiA+ID4gIAo+ID4gPiArLyogSVNQX0ZMQUdTX1NIRCAqLwo+ID4gPiArI2RlZmluZSBSS0lTUDFf Q0lGX0lTUF9GTEFHU19TSERfSVNQX0VOQUJMRV9TSEQJCUJJVCgwKQo+ID4gPiArI2RlZmluZSBS S0lTUDFfQ0lGX0lTUF9GTEFHU19TSERfSVNQX0VOQUJMRV9JTkZPUk1fU0hECUJJVCgxKQo+ID4g PiArI2RlZmluZSBSS0lTUDFfQ0lGX0lTUF9GTEFHU19TSERfSU5GT1JNX0ZJRUxECQlCSVQoMikK PiA+ID4gKyNkZWZpbmUgUktJU1AxX0NJRl9JU1BfRkxBR1NfU0hEX1NfREFUQV9NQVNLCQlHRU5N QVNLKDI3LCAxNikKPiA+ID4gKyNkZWZpbmUgUktJU1AxX0NJRl9JU1BfRkxBR1NfU0hEX1NfREFU QV9TSElGVAkJMTYKPiA+ID4gKyNkZWZpbmUgUktJU1AxX0NJRl9JU1BfRkxBR1NfU0hEX1NfVlNZ TkMJCUJJVCgzMCkKPiA+ID4gKyNkZWZpbmUgUktJU1AxX0NJRl9JU1BfRkxBR1NfU0hEX1NfSFNZ TkMJCUJJVCgzMSkKPiA+ID4gKwo+ID4gPiAgLyogQVdCICovCj4gPiA+ICAvKiBJU1BfQVdCX1BS T1AgKi8KPiA+ID4gICNkZWZpbmUgUktJU1AxX0NJRl9JU1BfQVdCX1lNQVhfQ01QX0VOCQkJQklU KDIpCj4gCj4gLS0gCj4gUmVnYXJkcywKPiAKPiBMYXVyZW50IFBpbmNoYXJ0CgpfX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpMaW51eC1yb2NrY2hpcCBtYWls aW5nIGxpc3QKTGludXgtcm9ja2NoaXBAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMu aW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LXJvY2tjaGlwCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B635FC433FE for ; Fri, 25 Mar 2022 19:29:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229732AbiCYTb2 (ORCPT ); Fri, 25 Mar 2022 15:31:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58542 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229843AbiCYTbQ (ORCPT ); Fri, 25 Mar 2022 15:31:16 -0400 Received: from wout4-smtp.messagingengine.com (wout4-smtp.messagingengine.com [64.147.123.20]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 73DF32986C3 for ; Fri, 25 Mar 2022 12:06:04 -0700 (PDT) Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.west.internal (Postfix) with ESMTP id C08543200E60; Fri, 25 Mar 2022 14:22:40 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute5.internal (MEProxy); Fri, 25 Mar 2022 14:22:41 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fastmail.com; h= cc:cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm3; bh=ZQaUt0eCTfYL4u 8m73mJTEsm09yFeWFLaBKPQ1lqkjA=; b=o139iP8rjeQyQna4QS4rWAjpKEjClX U+gE56Bz7w8B5rU5P3HvqKZ1Mv2KI68XZRahUahNLbFw/ua4KXqnKRSge0nOykOr fMKmDLZt56tkP4T1qaYkgTEn8OuIvgvhKiNJFIcPoRTLKtRUTwdwjnzOO1IE0c4P iWECV3FTZv99/O+JMYwilnaY6MciHuNCDa42rKMDcrZz4cjajIJGFwPdW8SK3UBY hxCvqirdM+MrvEZ9GGXTnORbKJmuR0FmXseO51ALX2BEigGsDMzRLamYsgQhtIoe CbaIhfpEXoRAJhwXNfL2pLaElOWvco1EJDOVPjYAJoEA4Wkz3lxyO+Cg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=ZQaUt0eCTfYL4u8m73mJTEsm09yFeWFLaBKPQ1lqk jA=; b=PpmnFm73cuD/U+3b9pRgdVOBThLK6fVGpHfkTHdCmBZoFevpO76OYr1O5 qLRwDUl95NwBlS7Mc9kAiZc+aZJpkpT6FlwjSZn6r4U7HHvpC+wy93+Qwusl8fU/ DLOjQUybuIqV1FMKy7q71Id7YL3dJXSyJUNnyNMvzeDgA+wdZDtzP9JXrrYhvHig +9rhFBtxKnVJT1J/5zAAD9b5a9pUQq13HbRWMJ6J5CGdP8FsXAN8FhBwZWW6Fyd0 ivc42qG3hpqaLo03+y52wVawqdTODAGyYO1dPNvhEyjYCVUg76QmBip75Uvjoe6N For/YYUcWXEAxk4nU0auSrq5QMGmA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvvddrudehuddguddufecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpeffhffvuffkfhggtggugfgjsehtkeertddttdejnecuhfhrohhmpeffrghf nhgrucfjihhrshgthhhfvghlugcuoegurghfnhgrsehfrghsthhmrghilhdrtghomheqne cuggftrfgrthhtvghrnhepvedtgedugeetueeuueetueefheekuddvgeffgeejffejledv ueeigeekkeevveefnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilh hfrhhomhepuggrfhhnrgesfhgrshhtmhgrihhlrdgtohhm X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 25 Mar 2022 14:22:38 -0400 (EDT) Date: Fri, 25 Mar 2022 21:22:34 +0300 From: Dafna Hirschfeld To: Laurent Pinchart Cc: linux-media@vger.kernel.org, Heiko Stuebner , Paul Elder , Tomasz Figa , linux-rockchip@lists.infradead.org Subject: Re: [PATCH v3 14/17] media: rkisp1: debug: Collect input status by sampling ISP_FLAGS_SHD Message-ID: <20220325182234.dba4h4fglqsnj6d2@guri> References: <20220319163100.3083-1-laurent.pinchart@ideasonboard.com> <20220319163100.3083-15-laurent.pinchart@ideasonboard.com> <20220322035624.mpkrod4g42xgpyfy@guri> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org On 22.03.2022 10:32, Laurent Pinchart wrote: > Hi Dafna, > > On Tue, Mar 22, 2022 at 05:56:24AM +0200, Dafna Hirschfeld wrote: > > On 19.03.2022 18:30, Laurent Pinchart wrote: > > > The ISP_FLAGS_SHD register exposes the ISP parallel input signals (data > > > and synchronization) in real time. This can help debugging when the > > > device doesn't output any image. Sample the register 10000 times with a > > > 1µs delay and expose the result through debugfs. > > > > > > Signed-off-by: Laurent Pinchart > > > Signed-off-by: Paul Elder > > > --- > > > .../platform/rockchip/rkisp1/rkisp1-debug.c | 54 +++++++++++++++++++ > > > .../platform/rockchip/rkisp1/rkisp1-regs.h | 9 ++++ > > > 2 files changed, 63 insertions(+) > > > > > > diff --git a/drivers/media/platform/rockchip/rkisp1/rkisp1-debug.c b/drivers/media/platform/rockchip/rkisp1/rkisp1-debug.c > > > index 64b33774cbdf..da3ed0ab697a 100644 > > > --- a/drivers/media/platform/rockchip/rkisp1/rkisp1-debug.c > > > +++ b/drivers/media/platform/rockchip/rkisp1/rkisp1-debug.c > > > @@ -9,9 +9,61 @@ > > > */ > > > > > > #include > > > +#include > > > #include > > > +#include > > > +#include > > > > > > #include "rkisp1-common.h" > > > +#include "rkisp1-regs.h" > > > + > > > +#define RKISP1_DEBUG_DATA_COUNT_BINS 32 > > > +#define RKISP1_DEBUG_DATA_COUNT_STEP (4096 / RKISP1_DEBUG_DATA_COUNT_BINS) > > > + > > > +static int rkisp1_debug_input_status_show(struct seq_file *m, void *p) > > > +{ > > > + struct rkisp1_device *rkisp1 = m->private; > > > + u16 data_count[RKISP1_DEBUG_DATA_COUNT_BINS] = { }; > > > > Since this is just a counter, it could be int/short > > Isn't u16 a short already ? Or do you mean using "short" instead of > "u16" ? That would be functionally equivalent, but I picked u16 to make > the size explicit, given that it has to hold values up to 10000. I know that u# types are meant mainly/only to configure hardware, so I suggested 's/u16/short/' , but I don't really care. Thanks, Dafna > > > > + unsigned int hsync_count = 0; > > > + unsigned int vsync_count = 0; > > > + unsigned int i; > > > + u32 data; > > > + u32 val; > > > + int ret; > > > + > > > + ret = pm_runtime_get_if_in_use(rkisp1->dev); > > > + if (ret) > > > + return ret; > > > > We want to return here if the device is not is use right? > > If so we should return if (ret <= 0) > > Correct, I'll fix that. > > > > + > > > + /* Sample the ISP input port status 10000 times with a 1µs interval. */ > > > + for (i = 0; i < 10000; ++i) { > > > + val = rkisp1_read(rkisp1, RKISP1_CIF_ISP_FLAGS_SHD); > > > + > > > + data = (val & RKISP1_CIF_ISP_FLAGS_SHD_S_DATA_MASK) > > > + >> RKISP1_CIF_ISP_FLAGS_SHD_S_DATA_SHIFT; > > > > What is this data? the docs only says > > "state of ISP input port s_data, for test purposes" > > I guess it indicate somehow the amount of actuall sensor data arrived? > > Could be nice to add explanation here. > > I'd the 12-bit parallel (pixel) data at the ISP input. I can add a > comment. > > > > + data_count[data / RKISP1_DEBUG_DATA_COUNT_STEP]++; > > > + > > > + if (val & RKISP1_CIF_ISP_FLAGS_SHD_S_HSYNC) > > > + hsync_count++; > > > + if (val & RKISP1_CIF_ISP_FLAGS_SHD_S_VSYNC) > > > + vsync_count++; > > > + > > > + udelay(1); > > > + } > > > + > > > + pm_runtime_put(rkisp1->dev); > > > + > > > + seq_printf(m, "vsync: %u, hsync: %u\n", vsync_count, hsync_count); > > > + seq_puts(m, "data:\n"); > > > + for (i = 0; i < ARRAY_SIZE(data_count); ++i) > > > + seq_printf(m, "- [%04u:%04u]: %u\n", > > > + i * RKISP1_DEBUG_DATA_COUNT_STEP, > > > + (i + 1) * RKISP1_DEBUG_DATA_COUNT_STEP - 1, > > > + data_count[i]); > > > + > > > + return 0; > > > +} > > > +DEFINE_SHOW_ATTRIBUTE(rkisp1_debug_input_status); > > > > > > void rkisp1_debug_init(struct rkisp1_device *rkisp1) > > > { > > > @@ -42,6 +94,8 @@ void rkisp1_debug_init(struct rkisp1_device *rkisp1) > > > &debug->frame_drop[RKISP1_MAINPATH]); > > > debugfs_create_ulong("sp_frame_drop", 0444, debug->debugfs_dir, > > > &debug->frame_drop[RKISP1_SELFPATH]); > > > + debugfs_create_file("input_status", 0444, debug->debugfs_dir, rkisp1, > > > + &rkisp1_debug_input_status_fops); > > > } > > > > > > void rkisp1_debug_cleanup(struct rkisp1_device *rkisp1) > > > diff --git a/drivers/media/platform/rockchip/rkisp1/rkisp1-regs.h b/drivers/media/platform/rockchip/rkisp1/rkisp1-regs.h > > > index 083d92ada73f..447c5f241d69 100644 > > > --- a/drivers/media/platform/rockchip/rkisp1/rkisp1-regs.h > > > +++ b/drivers/media/platform/rockchip/rkisp1/rkisp1-regs.h > > > @@ -454,6 +454,15 @@ > > > #define RKISP1_CIF_ISP_DEMOSAIC_BYPASS BIT(10) > > > #define RKISP1_CIF_ISP_DEMOSAIC_TH(x) ((x) & 0xFF) > > > > > > +/* ISP_FLAGS_SHD */ > > > +#define RKISP1_CIF_ISP_FLAGS_SHD_ISP_ENABLE_SHD BIT(0) > > > +#define RKISP1_CIF_ISP_FLAGS_SHD_ISP_ENABLE_INFORM_SHD BIT(1) > > > +#define RKISP1_CIF_ISP_FLAGS_SHD_INFORM_FIELD BIT(2) > > > +#define RKISP1_CIF_ISP_FLAGS_SHD_S_DATA_MASK GENMASK(27, 16) > > > +#define RKISP1_CIF_ISP_FLAGS_SHD_S_DATA_SHIFT 16 > > > +#define RKISP1_CIF_ISP_FLAGS_SHD_S_VSYNC BIT(30) > > > +#define RKISP1_CIF_ISP_FLAGS_SHD_S_HSYNC BIT(31) > > > + > > > /* AWB */ > > > /* ISP_AWB_PROP */ > > > #define RKISP1_CIF_ISP_AWB_YMAX_CMP_EN BIT(2) > > -- > Regards, > > Laurent Pinchart