From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5AA27C433FE for ; Sat, 26 Mar 2022 01:10:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229484AbiCZBLm (ORCPT ); Fri, 25 Mar 2022 21:11:42 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53400 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229446AbiCZBLk (ORCPT ); Fri, 25 Mar 2022 21:11:40 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9A15416D8E6; Fri, 25 Mar 2022 18:10:05 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 4C463B82ACC; Sat, 26 Mar 2022 01:10:04 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 223E1C2BBE4; Sat, 26 Mar 2022 01:09:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1648257002; bh=2xiQISCsw2cy2y6MHShJ4Jqd9uPswPsIo+/nl7cHzog=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=u7TxL5wBkuAlU15aDeVXpEFVdmxwEHp9frlni9CwXVreMtiz/irA1vVwyeRfo8ZcY LgzdQEGx5vleNMqyJT636GsqvBAyJWNAty7wo0SvCvrzgqEXnn448oe3ZU7eLsPCP4 9s5U6EjoL8yNonMtnWKR5Z2A6mo/QiM54lpmJOlypIMt7GBKCdRq71PXmdu/jn2KbL tBAow0/9xo7PXG2lpo4FlKLMdQXua4ZdoHqfgm7dDp//t2LLlUSPJp8U0zlPENnP0j tiO/b5rh/zvV1onpmurAETgfzGg2DwRExU/CpMrxf0kmbZxpusON8bgTgwKY3SD3EZ pynU1B70Q8MxA== Date: Sat, 26 Mar 2022 10:09:56 +0900 From: Masami Hiramatsu To: Peter Zijlstra Cc: Alexei Starovoitov , Andrii Nakryiko , x86@kernel.org, Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , Dan Carpenter , kernel-janitors@vger.kernel.org, Steven Rostedt , Jiri Olsa , bpf@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH bpf-next v2 0/4] kprobes: rethook: x86: Replace kretprobe trampoline with rethook Message-Id: <20220326100956.2d8acf1df409a890403eefcc@kernel.org> In-Reply-To: References: <164821817332.2373735.12048266953420821089.stgit@devnote2> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.32; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 25 Mar 2022 15:43:14 +0100 Peter Zijlstra wrote: > On Fri, Mar 25, 2022 at 11:22:53PM +0900, Masami Hiramatsu wrote: > > > Masami Hiramatsu (3): > > kprobes: Use rethook for kretprobe if possible > > rethook: kprobes: x86: Replace kretprobe with rethook on x86 > > x86,kprobes: Fix optprobe trampoline to generate complete pt_regs > > > > Peter Zijlstra (1): > > Subject: x86,rethook: Fix arch_rethook_trampoline() to generate a complete pt_regs > > You fat-fingered the subject there ^ > Oops, I missed to import the patch... > Other than that: > > Acked-by: Peter Zijlstra (Intel) Thanks! > > Hopefully the ftrace return trampoline can also be switched over.. The rethook clarifies the interfaces for the return trampoline, so I think this can step the integration forward. -- Masami Hiramatsu