* [PATCH 0/4] rockchip: support configuring pins as input
@ 2022-03-28 0:50 ` Caleb Connolly
0 siblings, 0 replies; 24+ messages in thread
From: Caleb Connolly @ 2022-03-28 0:50 UTC (permalink / raw)
To: Caleb Connolly, Rob Herring, Heiko Stuebner, Linus Walleij,
Bartosz Golaszewski, devicetree, linux-arm-kernel,
linux-rockchip, linux-kernel, linux-gpio
Cc: ~postmarketos/upstreaming, martijn, Arnaud Ferraris
Add support for configuring pins as input to the rockchip pinctrl
driver. This is required for example for devices which use non-standard
configurations for gpio interrupts, specifically for the light/proximity
sensor on the RK3399 powered PinePhone Pro (which will be coming
upstream in a future patch series).
Due to the complicated layout of the RK pinctrl/gpio drivers, some extra
work is required to handle deferring the GPIO configuration. On RK3399
the pinctrl driver always probes before the GPIO controller driver, so
the PIN_CONFIG_OUTPUT and PIN_CONFIG_INPUT_ENABLE params both have to be
deferred, this series also reworks the deferred pin handling to be
generic and support any param rather than only the PIN_CONFIG_OUTPUT
param.
---
Caleb Connolly (4):
pinctrl/rockchip: support deferring other gpio params
pinctrl/rockchip: support setting input-enable param
gpio/rockchip: handle deferring input-enable pinconfs
arm64: dts: rockchip: rk3399: add an input enable pinconf
arch/arm64/boot/dts/rockchip/rk3399.dtsi | 16 ++++++
drivers/gpio/gpio-rockchip.c | 29 ++++++++---
drivers/pinctrl/pinctrl-rockchip.c | 64 +++++++++++++++---------
drivers/pinctrl/pinctrl-rockchip.h | 7 ++-
4 files changed, 81 insertions(+), 35 deletions(-)
--
2.35.1
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
^ permalink raw reply [flat|nested] 24+ messages in thread
* [PATCH 0/4] rockchip: support configuring pins as input
@ 2022-03-28 0:50 ` Caleb Connolly
0 siblings, 0 replies; 24+ messages in thread
From: Caleb Connolly @ 2022-03-28 0:50 UTC (permalink / raw)
To: Caleb Connolly, Rob Herring, Heiko Stuebner, Linus Walleij,
Bartosz Golaszewski, devicetree, linux-arm-kernel,
linux-rockchip, linux-kernel, linux-gpio
Cc: ~postmarketos/upstreaming, martijn, Arnaud Ferraris
Add support for configuring pins as input to the rockchip pinctrl
driver. This is required for example for devices which use non-standard
configurations for gpio interrupts, specifically for the light/proximity
sensor on the RK3399 powered PinePhone Pro (which will be coming
upstream in a future patch series).
Due to the complicated layout of the RK pinctrl/gpio drivers, some extra
work is required to handle deferring the GPIO configuration. On RK3399
the pinctrl driver always probes before the GPIO controller driver, so
the PIN_CONFIG_OUTPUT and PIN_CONFIG_INPUT_ENABLE params both have to be
deferred, this series also reworks the deferred pin handling to be
generic and support any param rather than only the PIN_CONFIG_OUTPUT
param.
---
Caleb Connolly (4):
pinctrl/rockchip: support deferring other gpio params
pinctrl/rockchip: support setting input-enable param
gpio/rockchip: handle deferring input-enable pinconfs
arm64: dts: rockchip: rk3399: add an input enable pinconf
arch/arm64/boot/dts/rockchip/rk3399.dtsi | 16 ++++++
drivers/gpio/gpio-rockchip.c | 29 ++++++++---
drivers/pinctrl/pinctrl-rockchip.c | 64 +++++++++++++++---------
drivers/pinctrl/pinctrl-rockchip.h | 7 ++-
4 files changed, 81 insertions(+), 35 deletions(-)
--
2.35.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 24+ messages in thread
* [PATCH 0/4] rockchip: support configuring pins as input
@ 2022-03-28 0:50 ` Caleb Connolly
0 siblings, 0 replies; 24+ messages in thread
From: Caleb Connolly @ 2022-03-28 0:50 UTC (permalink / raw)
To: Caleb Connolly, Rob Herring, Heiko Stuebner, Linus Walleij,
Bartosz Golaszewski, devicetree, linux-arm-kernel,
linux-rockchip, linux-kernel, linux-gpio
Cc: ~postmarketos/upstreaming, martijn, Arnaud Ferraris
Add support for configuring pins as input to the rockchip pinctrl
driver. This is required for example for devices which use non-standard
configurations for gpio interrupts, specifically for the light/proximity
sensor on the RK3399 powered PinePhone Pro (which will be coming
upstream in a future patch series).
Due to the complicated layout of the RK pinctrl/gpio drivers, some extra
work is required to handle deferring the GPIO configuration. On RK3399
the pinctrl driver always probes before the GPIO controller driver, so
the PIN_CONFIG_OUTPUT and PIN_CONFIG_INPUT_ENABLE params both have to be
deferred, this series also reworks the deferred pin handling to be
generic and support any param rather than only the PIN_CONFIG_OUTPUT
param.
---
Caleb Connolly (4):
pinctrl/rockchip: support deferring other gpio params
pinctrl/rockchip: support setting input-enable param
gpio/rockchip: handle deferring input-enable pinconfs
arm64: dts: rockchip: rk3399: add an input enable pinconf
arch/arm64/boot/dts/rockchip/rk3399.dtsi | 16 ++++++
drivers/gpio/gpio-rockchip.c | 29 ++++++++---
drivers/pinctrl/pinctrl-rockchip.c | 64 +++++++++++++++---------
drivers/pinctrl/pinctrl-rockchip.h | 7 ++-
4 files changed, 81 insertions(+), 35 deletions(-)
--
2.35.1
^ permalink raw reply [flat|nested] 24+ messages in thread
* [PATCH 1/4] pinctrl/rockchip: support deferring other gpio params
2022-03-28 0:50 ` Caleb Connolly
(?)
@ 2022-03-28 0:50 ` Caleb Connolly
-1 siblings, 0 replies; 24+ messages in thread
From: Caleb Connolly @ 2022-03-28 0:50 UTC (permalink / raw)
To: Caleb Connolly, Rob Herring, Heiko Stuebner, Linus Walleij,
Bartosz Golaszewski, devicetree, linux-arm-kernel,
linux-rockchip, linux-kernel, linux-gpio
Cc: ~postmarketos/upstreaming, martijn, Arnaud Ferraris
Add support for deferring other params like PIN_CONFIG_INPUT_ENABLE.
This will be used to add support for PIN_CONFIG_INPUT_ENABLE to the
driver.
Fixes: e7165b1d ("pinctrl/rockchip: add a queue for deferred pin output settings on probe")
Fixes: 59dd178e ("gpio/rockchip: fetch deferred output settings on probe")
Signed-off-by: Caleb Connolly <kc@postmarketos.org>
---
drivers/gpio/gpio-rockchip.c | 24 ++++++++-----
drivers/pinctrl/pinctrl-rockchip.c | 54 ++++++++++++++++--------------
drivers/pinctrl/pinctrl-rockchip.h | 7 ++--
3 files changed, 50 insertions(+), 35 deletions(-)
diff --git a/drivers/gpio/gpio-rockchip.c b/drivers/gpio/gpio-rockchip.c
index 099e358d2491..bcf5214e3586 100644
--- a/drivers/gpio/gpio-rockchip.c
+++ b/drivers/gpio/gpio-rockchip.c
@@ -19,6 +19,7 @@
#include <linux/of_address.h>
#include <linux/of_device.h>
#include <linux/of_irq.h>
+#include <linux/pinctrl/pinconf-generic.h>
#include <linux/regmap.h>
#include "../pinctrl/core.h"
@@ -706,7 +707,7 @@ static int rockchip_gpio_probe(struct platform_device *pdev)
struct device_node *pctlnp = of_get_parent(np);
struct pinctrl_dev *pctldev = NULL;
struct rockchip_pin_bank *bank = NULL;
- struct rockchip_pin_output_deferred *cfg;
+ struct rockchip_pin_deferred *cfg;
static int gpio;
int id, ret;
@@ -747,15 +748,22 @@ static int rockchip_gpio_probe(struct platform_device *pdev)
return ret;
}
- while (!list_empty(&bank->deferred_output)) {
- cfg = list_first_entry(&bank->deferred_output,
- struct rockchip_pin_output_deferred, head);
+ while (!list_empty(&bank->deferred_pins)) {
+ cfg = list_first_entry(&bank->deferred_pins,
+ struct rockchip_pin_deferred, head);
list_del(&cfg->head);
- ret = rockchip_gpio_direction_output(&bank->gpio_chip, cfg->pin, cfg->arg);
- if (ret)
- dev_warn(dev, "setting output pin %u to %u failed\n", cfg->pin, cfg->arg);
-
+ switch (cfg->param) {
+ case PIN_CONFIG_OUTPUT:
+ ret = rockchip_gpio_direction_output(&bank->gpio_chip, cfg->pin, cfg->arg);
+ if (ret)
+ dev_warn(dev, "setting output pin %u to %u failed\n", cfg->pin,
+ cfg->arg);
+ break;
+ default:
+ dev_warn(dev, "unknown deferred config param %d\n", cfg->param);
+ break;
+ }
kfree(cfg);
}
diff --git a/drivers/pinctrl/pinctrl-rockchip.c b/drivers/pinctrl/pinctrl-rockchip.c
index d8dd8415fa81..d54fc1cdf609 100644
--- a/drivers/pinctrl/pinctrl-rockchip.c
+++ b/drivers/pinctrl/pinctrl-rockchip.c
@@ -2095,19 +2095,20 @@ static bool rockchip_pinconf_pull_valid(struct rockchip_pin_ctrl *ctrl,
return false;
}
-static int rockchip_pinconf_defer_output(struct rockchip_pin_bank *bank,
- unsigned int pin, u32 arg)
+static int rockchip_pinconf_defer_pin(struct rockchip_pin_bank *bank,
+ unsigned int pin, u32 param, u32 arg)
{
- struct rockchip_pin_output_deferred *cfg;
+ struct rockchip_pin_deferred *cfg;
cfg = kzalloc(sizeof(*cfg), GFP_KERNEL);
if (!cfg)
return -ENOMEM;
cfg->pin = pin;
+ cfg->param = param;
cfg->arg = arg;
- list_add_tail(&cfg->head, &bank->deferred_output);
+ list_add_tail(&cfg->head, &bank->deferred_pins);
return 0;
}
@@ -2128,6 +2129,25 @@ static int rockchip_pinconf_set(struct pinctrl_dev *pctldev, unsigned int pin,
param = pinconf_to_config_param(configs[i]);
arg = pinconf_to_config_argument(configs[i]);
+ if (param == (PIN_CONFIG_OUTPUT | PIN_CONFIG_INPUT_ENABLE)) {
+ /*
+ * Check for gpio driver not being probed yet.
+ * The lock makes sure that either gpio-probe has completed
+ * or the gpio driver hasn't probed yet.
+ */
+ mutex_lock(&bank->deferred_lock);
+ if (!gpio || !gpio->direction_output) {
+ rc = rockchip_pinconf_defer_pin(bank, pin - bank->pin_base, param,
+ arg);
+ mutex_unlock(&bank->deferred_lock);
+ if (rc)
+ return rc;
+
+ break;
+ }
+ mutex_unlock(&bank->deferred_lock);
+ }
+
switch (param) {
case PIN_CONFIG_BIAS_DISABLE:
rc = rockchip_set_pull(bank, pin - bank->pin_base,
@@ -2156,22 +2176,6 @@ static int rockchip_pinconf_set(struct pinctrl_dev *pctldev, unsigned int pin,
if (rc != RK_FUNC_GPIO)
return -EINVAL;
- /*
- * Check for gpio driver not being probed yet.
- * The lock makes sure that either gpio-probe has completed
- * or the gpio driver hasn't probed yet.
- */
- mutex_lock(&bank->deferred_lock);
- if (!gpio || !gpio->direction_output) {
- rc = rockchip_pinconf_defer_output(bank, pin - bank->pin_base, arg);
- mutex_unlock(&bank->deferred_lock);
- if (rc)
- return rc;
-
- break;
- }
- mutex_unlock(&bank->deferred_lock);
-
rc = gpio->direction_output(gpio, pin - bank->pin_base,
arg);
if (rc)
@@ -2485,7 +2489,7 @@ static int rockchip_pinctrl_register(struct platform_device *pdev,
pdesc++;
}
- INIT_LIST_HEAD(&pin_bank->deferred_output);
+ INIT_LIST_HEAD(&pin_bank->deferred_pins);
mutex_init(&pin_bank->deferred_lock);
}
@@ -2746,7 +2750,7 @@ static int rockchip_pinctrl_remove(struct platform_device *pdev)
{
struct rockchip_pinctrl *info = platform_get_drvdata(pdev);
struct rockchip_pin_bank *bank;
- struct rockchip_pin_output_deferred *cfg;
+ struct rockchip_pin_deferred *cfg;
int i;
of_platform_depopulate(&pdev->dev);
@@ -2755,9 +2759,9 @@ static int rockchip_pinctrl_remove(struct platform_device *pdev)
bank = &info->ctrl->pin_banks[i];
mutex_lock(&bank->deferred_lock);
- while (!list_empty(&bank->deferred_output)) {
- cfg = list_first_entry(&bank->deferred_output,
- struct rockchip_pin_output_deferred, head);
+ while (!list_empty(&bank->deferred_pins)) {
+ cfg = list_first_entry(&bank->deferred_pins,
+ struct rockchip_pin_deferred, head);
list_del(&cfg->head);
kfree(cfg);
}
diff --git a/drivers/pinctrl/pinctrl-rockchip.h b/drivers/pinctrl/pinctrl-rockchip.h
index 91f10279d084..98a01a616da6 100644
--- a/drivers/pinctrl/pinctrl-rockchip.h
+++ b/drivers/pinctrl/pinctrl-rockchip.h
@@ -171,7 +171,7 @@ struct rockchip_pin_bank {
u32 toggle_edge_mode;
u32 recalced_mask;
u32 route_mask;
- struct list_head deferred_output;
+ struct list_head deferred_pins;
struct mutex deferred_lock;
};
@@ -247,9 +247,12 @@ struct rockchip_pin_config {
unsigned int nconfigs;
};
-struct rockchip_pin_output_deferred {
+enum pin_config_param;
+
+struct rockchip_pin_deferred {
struct list_head head;
unsigned int pin;
+ enum pin_config_param param;
u32 arg;
};
--
2.35.1
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
^ permalink raw reply related [flat|nested] 24+ messages in thread
* [PATCH 1/4] pinctrl/rockchip: support deferring other gpio params
@ 2022-03-28 0:50 ` Caleb Connolly
0 siblings, 0 replies; 24+ messages in thread
From: Caleb Connolly @ 2022-03-28 0:50 UTC (permalink / raw)
To: Caleb Connolly, Rob Herring, Heiko Stuebner, Linus Walleij,
Bartosz Golaszewski, devicetree, linux-arm-kernel,
linux-rockchip, linux-kernel, linux-gpio
Cc: ~postmarketos/upstreaming, martijn, Arnaud Ferraris
Add support for deferring other params like PIN_CONFIG_INPUT_ENABLE.
This will be used to add support for PIN_CONFIG_INPUT_ENABLE to the
driver.
Fixes: e7165b1d ("pinctrl/rockchip: add a queue for deferred pin output settings on probe")
Fixes: 59dd178e ("gpio/rockchip: fetch deferred output settings on probe")
Signed-off-by: Caleb Connolly <kc@postmarketos.org>
---
drivers/gpio/gpio-rockchip.c | 24 ++++++++-----
drivers/pinctrl/pinctrl-rockchip.c | 54 ++++++++++++++++--------------
drivers/pinctrl/pinctrl-rockchip.h | 7 ++--
3 files changed, 50 insertions(+), 35 deletions(-)
diff --git a/drivers/gpio/gpio-rockchip.c b/drivers/gpio/gpio-rockchip.c
index 099e358d2491..bcf5214e3586 100644
--- a/drivers/gpio/gpio-rockchip.c
+++ b/drivers/gpio/gpio-rockchip.c
@@ -19,6 +19,7 @@
#include <linux/of_address.h>
#include <linux/of_device.h>
#include <linux/of_irq.h>
+#include <linux/pinctrl/pinconf-generic.h>
#include <linux/regmap.h>
#include "../pinctrl/core.h"
@@ -706,7 +707,7 @@ static int rockchip_gpio_probe(struct platform_device *pdev)
struct device_node *pctlnp = of_get_parent(np);
struct pinctrl_dev *pctldev = NULL;
struct rockchip_pin_bank *bank = NULL;
- struct rockchip_pin_output_deferred *cfg;
+ struct rockchip_pin_deferred *cfg;
static int gpio;
int id, ret;
@@ -747,15 +748,22 @@ static int rockchip_gpio_probe(struct platform_device *pdev)
return ret;
}
- while (!list_empty(&bank->deferred_output)) {
- cfg = list_first_entry(&bank->deferred_output,
- struct rockchip_pin_output_deferred, head);
+ while (!list_empty(&bank->deferred_pins)) {
+ cfg = list_first_entry(&bank->deferred_pins,
+ struct rockchip_pin_deferred, head);
list_del(&cfg->head);
- ret = rockchip_gpio_direction_output(&bank->gpio_chip, cfg->pin, cfg->arg);
- if (ret)
- dev_warn(dev, "setting output pin %u to %u failed\n", cfg->pin, cfg->arg);
-
+ switch (cfg->param) {
+ case PIN_CONFIG_OUTPUT:
+ ret = rockchip_gpio_direction_output(&bank->gpio_chip, cfg->pin, cfg->arg);
+ if (ret)
+ dev_warn(dev, "setting output pin %u to %u failed\n", cfg->pin,
+ cfg->arg);
+ break;
+ default:
+ dev_warn(dev, "unknown deferred config param %d\n", cfg->param);
+ break;
+ }
kfree(cfg);
}
diff --git a/drivers/pinctrl/pinctrl-rockchip.c b/drivers/pinctrl/pinctrl-rockchip.c
index d8dd8415fa81..d54fc1cdf609 100644
--- a/drivers/pinctrl/pinctrl-rockchip.c
+++ b/drivers/pinctrl/pinctrl-rockchip.c
@@ -2095,19 +2095,20 @@ static bool rockchip_pinconf_pull_valid(struct rockchip_pin_ctrl *ctrl,
return false;
}
-static int rockchip_pinconf_defer_output(struct rockchip_pin_bank *bank,
- unsigned int pin, u32 arg)
+static int rockchip_pinconf_defer_pin(struct rockchip_pin_bank *bank,
+ unsigned int pin, u32 param, u32 arg)
{
- struct rockchip_pin_output_deferred *cfg;
+ struct rockchip_pin_deferred *cfg;
cfg = kzalloc(sizeof(*cfg), GFP_KERNEL);
if (!cfg)
return -ENOMEM;
cfg->pin = pin;
+ cfg->param = param;
cfg->arg = arg;
- list_add_tail(&cfg->head, &bank->deferred_output);
+ list_add_tail(&cfg->head, &bank->deferred_pins);
return 0;
}
@@ -2128,6 +2129,25 @@ static int rockchip_pinconf_set(struct pinctrl_dev *pctldev, unsigned int pin,
param = pinconf_to_config_param(configs[i]);
arg = pinconf_to_config_argument(configs[i]);
+ if (param == (PIN_CONFIG_OUTPUT | PIN_CONFIG_INPUT_ENABLE)) {
+ /*
+ * Check for gpio driver not being probed yet.
+ * The lock makes sure that either gpio-probe has completed
+ * or the gpio driver hasn't probed yet.
+ */
+ mutex_lock(&bank->deferred_lock);
+ if (!gpio || !gpio->direction_output) {
+ rc = rockchip_pinconf_defer_pin(bank, pin - bank->pin_base, param,
+ arg);
+ mutex_unlock(&bank->deferred_lock);
+ if (rc)
+ return rc;
+
+ break;
+ }
+ mutex_unlock(&bank->deferred_lock);
+ }
+
switch (param) {
case PIN_CONFIG_BIAS_DISABLE:
rc = rockchip_set_pull(bank, pin - bank->pin_base,
@@ -2156,22 +2176,6 @@ static int rockchip_pinconf_set(struct pinctrl_dev *pctldev, unsigned int pin,
if (rc != RK_FUNC_GPIO)
return -EINVAL;
- /*
- * Check for gpio driver not being probed yet.
- * The lock makes sure that either gpio-probe has completed
- * or the gpio driver hasn't probed yet.
- */
- mutex_lock(&bank->deferred_lock);
- if (!gpio || !gpio->direction_output) {
- rc = rockchip_pinconf_defer_output(bank, pin - bank->pin_base, arg);
- mutex_unlock(&bank->deferred_lock);
- if (rc)
- return rc;
-
- break;
- }
- mutex_unlock(&bank->deferred_lock);
-
rc = gpio->direction_output(gpio, pin - bank->pin_base,
arg);
if (rc)
@@ -2485,7 +2489,7 @@ static int rockchip_pinctrl_register(struct platform_device *pdev,
pdesc++;
}
- INIT_LIST_HEAD(&pin_bank->deferred_output);
+ INIT_LIST_HEAD(&pin_bank->deferred_pins);
mutex_init(&pin_bank->deferred_lock);
}
@@ -2746,7 +2750,7 @@ static int rockchip_pinctrl_remove(struct platform_device *pdev)
{
struct rockchip_pinctrl *info = platform_get_drvdata(pdev);
struct rockchip_pin_bank *bank;
- struct rockchip_pin_output_deferred *cfg;
+ struct rockchip_pin_deferred *cfg;
int i;
of_platform_depopulate(&pdev->dev);
@@ -2755,9 +2759,9 @@ static int rockchip_pinctrl_remove(struct platform_device *pdev)
bank = &info->ctrl->pin_banks[i];
mutex_lock(&bank->deferred_lock);
- while (!list_empty(&bank->deferred_output)) {
- cfg = list_first_entry(&bank->deferred_output,
- struct rockchip_pin_output_deferred, head);
+ while (!list_empty(&bank->deferred_pins)) {
+ cfg = list_first_entry(&bank->deferred_pins,
+ struct rockchip_pin_deferred, head);
list_del(&cfg->head);
kfree(cfg);
}
diff --git a/drivers/pinctrl/pinctrl-rockchip.h b/drivers/pinctrl/pinctrl-rockchip.h
index 91f10279d084..98a01a616da6 100644
--- a/drivers/pinctrl/pinctrl-rockchip.h
+++ b/drivers/pinctrl/pinctrl-rockchip.h
@@ -171,7 +171,7 @@ struct rockchip_pin_bank {
u32 toggle_edge_mode;
u32 recalced_mask;
u32 route_mask;
- struct list_head deferred_output;
+ struct list_head deferred_pins;
struct mutex deferred_lock;
};
@@ -247,9 +247,12 @@ struct rockchip_pin_config {
unsigned int nconfigs;
};
-struct rockchip_pin_output_deferred {
+enum pin_config_param;
+
+struct rockchip_pin_deferred {
struct list_head head;
unsigned int pin;
+ enum pin_config_param param;
u32 arg;
};
--
2.35.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 24+ messages in thread
* [PATCH 1/4] pinctrl/rockchip: support deferring other gpio params
@ 2022-03-28 0:50 ` Caleb Connolly
0 siblings, 0 replies; 24+ messages in thread
From: Caleb Connolly @ 2022-03-28 0:50 UTC (permalink / raw)
To: Caleb Connolly, Rob Herring, Heiko Stuebner, Linus Walleij,
Bartosz Golaszewski, devicetree, linux-arm-kernel,
linux-rockchip, linux-kernel, linux-gpio
Cc: ~postmarketos/upstreaming, martijn, Arnaud Ferraris
Add support for deferring other params like PIN_CONFIG_INPUT_ENABLE.
This will be used to add support for PIN_CONFIG_INPUT_ENABLE to the
driver.
Fixes: e7165b1d ("pinctrl/rockchip: add a queue for deferred pin output settings on probe")
Fixes: 59dd178e ("gpio/rockchip: fetch deferred output settings on probe")
Signed-off-by: Caleb Connolly <kc@postmarketos.org>
---
drivers/gpio/gpio-rockchip.c | 24 ++++++++-----
drivers/pinctrl/pinctrl-rockchip.c | 54 ++++++++++++++++--------------
drivers/pinctrl/pinctrl-rockchip.h | 7 ++--
3 files changed, 50 insertions(+), 35 deletions(-)
diff --git a/drivers/gpio/gpio-rockchip.c b/drivers/gpio/gpio-rockchip.c
index 099e358d2491..bcf5214e3586 100644
--- a/drivers/gpio/gpio-rockchip.c
+++ b/drivers/gpio/gpio-rockchip.c
@@ -19,6 +19,7 @@
#include <linux/of_address.h>
#include <linux/of_device.h>
#include <linux/of_irq.h>
+#include <linux/pinctrl/pinconf-generic.h>
#include <linux/regmap.h>
#include "../pinctrl/core.h"
@@ -706,7 +707,7 @@ static int rockchip_gpio_probe(struct platform_device *pdev)
struct device_node *pctlnp = of_get_parent(np);
struct pinctrl_dev *pctldev = NULL;
struct rockchip_pin_bank *bank = NULL;
- struct rockchip_pin_output_deferred *cfg;
+ struct rockchip_pin_deferred *cfg;
static int gpio;
int id, ret;
@@ -747,15 +748,22 @@ static int rockchip_gpio_probe(struct platform_device *pdev)
return ret;
}
- while (!list_empty(&bank->deferred_output)) {
- cfg = list_first_entry(&bank->deferred_output,
- struct rockchip_pin_output_deferred, head);
+ while (!list_empty(&bank->deferred_pins)) {
+ cfg = list_first_entry(&bank->deferred_pins,
+ struct rockchip_pin_deferred, head);
list_del(&cfg->head);
- ret = rockchip_gpio_direction_output(&bank->gpio_chip, cfg->pin, cfg->arg);
- if (ret)
- dev_warn(dev, "setting output pin %u to %u failed\n", cfg->pin, cfg->arg);
-
+ switch (cfg->param) {
+ case PIN_CONFIG_OUTPUT:
+ ret = rockchip_gpio_direction_output(&bank->gpio_chip, cfg->pin, cfg->arg);
+ if (ret)
+ dev_warn(dev, "setting output pin %u to %u failed\n", cfg->pin,
+ cfg->arg);
+ break;
+ default:
+ dev_warn(dev, "unknown deferred config param %d\n", cfg->param);
+ break;
+ }
kfree(cfg);
}
diff --git a/drivers/pinctrl/pinctrl-rockchip.c b/drivers/pinctrl/pinctrl-rockchip.c
index d8dd8415fa81..d54fc1cdf609 100644
--- a/drivers/pinctrl/pinctrl-rockchip.c
+++ b/drivers/pinctrl/pinctrl-rockchip.c
@@ -2095,19 +2095,20 @@ static bool rockchip_pinconf_pull_valid(struct rockchip_pin_ctrl *ctrl,
return false;
}
-static int rockchip_pinconf_defer_output(struct rockchip_pin_bank *bank,
- unsigned int pin, u32 arg)
+static int rockchip_pinconf_defer_pin(struct rockchip_pin_bank *bank,
+ unsigned int pin, u32 param, u32 arg)
{
- struct rockchip_pin_output_deferred *cfg;
+ struct rockchip_pin_deferred *cfg;
cfg = kzalloc(sizeof(*cfg), GFP_KERNEL);
if (!cfg)
return -ENOMEM;
cfg->pin = pin;
+ cfg->param = param;
cfg->arg = arg;
- list_add_tail(&cfg->head, &bank->deferred_output);
+ list_add_tail(&cfg->head, &bank->deferred_pins);
return 0;
}
@@ -2128,6 +2129,25 @@ static int rockchip_pinconf_set(struct pinctrl_dev *pctldev, unsigned int pin,
param = pinconf_to_config_param(configs[i]);
arg = pinconf_to_config_argument(configs[i]);
+ if (param == (PIN_CONFIG_OUTPUT | PIN_CONFIG_INPUT_ENABLE)) {
+ /*
+ * Check for gpio driver not being probed yet.
+ * The lock makes sure that either gpio-probe has completed
+ * or the gpio driver hasn't probed yet.
+ */
+ mutex_lock(&bank->deferred_lock);
+ if (!gpio || !gpio->direction_output) {
+ rc = rockchip_pinconf_defer_pin(bank, pin - bank->pin_base, param,
+ arg);
+ mutex_unlock(&bank->deferred_lock);
+ if (rc)
+ return rc;
+
+ break;
+ }
+ mutex_unlock(&bank->deferred_lock);
+ }
+
switch (param) {
case PIN_CONFIG_BIAS_DISABLE:
rc = rockchip_set_pull(bank, pin - bank->pin_base,
@@ -2156,22 +2176,6 @@ static int rockchip_pinconf_set(struct pinctrl_dev *pctldev, unsigned int pin,
if (rc != RK_FUNC_GPIO)
return -EINVAL;
- /*
- * Check for gpio driver not being probed yet.
- * The lock makes sure that either gpio-probe has completed
- * or the gpio driver hasn't probed yet.
- */
- mutex_lock(&bank->deferred_lock);
- if (!gpio || !gpio->direction_output) {
- rc = rockchip_pinconf_defer_output(bank, pin - bank->pin_base, arg);
- mutex_unlock(&bank->deferred_lock);
- if (rc)
- return rc;
-
- break;
- }
- mutex_unlock(&bank->deferred_lock);
-
rc = gpio->direction_output(gpio, pin - bank->pin_base,
arg);
if (rc)
@@ -2485,7 +2489,7 @@ static int rockchip_pinctrl_register(struct platform_device *pdev,
pdesc++;
}
- INIT_LIST_HEAD(&pin_bank->deferred_output);
+ INIT_LIST_HEAD(&pin_bank->deferred_pins);
mutex_init(&pin_bank->deferred_lock);
}
@@ -2746,7 +2750,7 @@ static int rockchip_pinctrl_remove(struct platform_device *pdev)
{
struct rockchip_pinctrl *info = platform_get_drvdata(pdev);
struct rockchip_pin_bank *bank;
- struct rockchip_pin_output_deferred *cfg;
+ struct rockchip_pin_deferred *cfg;
int i;
of_platform_depopulate(&pdev->dev);
@@ -2755,9 +2759,9 @@ static int rockchip_pinctrl_remove(struct platform_device *pdev)
bank = &info->ctrl->pin_banks[i];
mutex_lock(&bank->deferred_lock);
- while (!list_empty(&bank->deferred_output)) {
- cfg = list_first_entry(&bank->deferred_output,
- struct rockchip_pin_output_deferred, head);
+ while (!list_empty(&bank->deferred_pins)) {
+ cfg = list_first_entry(&bank->deferred_pins,
+ struct rockchip_pin_deferred, head);
list_del(&cfg->head);
kfree(cfg);
}
diff --git a/drivers/pinctrl/pinctrl-rockchip.h b/drivers/pinctrl/pinctrl-rockchip.h
index 91f10279d084..98a01a616da6 100644
--- a/drivers/pinctrl/pinctrl-rockchip.h
+++ b/drivers/pinctrl/pinctrl-rockchip.h
@@ -171,7 +171,7 @@ struct rockchip_pin_bank {
u32 toggle_edge_mode;
u32 recalced_mask;
u32 route_mask;
- struct list_head deferred_output;
+ struct list_head deferred_pins;
struct mutex deferred_lock;
};
@@ -247,9 +247,12 @@ struct rockchip_pin_config {
unsigned int nconfigs;
};
-struct rockchip_pin_output_deferred {
+enum pin_config_param;
+
+struct rockchip_pin_deferred {
struct list_head head;
unsigned int pin;
+ enum pin_config_param param;
u32 arg;
};
--
2.35.1
^ permalink raw reply related [flat|nested] 24+ messages in thread
* [PATCH 2/4] pinctrl/rockchip: support setting input-enable param
2022-03-28 0:50 ` Caleb Connolly
(?)
@ 2022-03-28 0:50 ` Caleb Connolly
-1 siblings, 0 replies; 24+ messages in thread
From: Caleb Connolly @ 2022-03-28 0:50 UTC (permalink / raw)
To: Caleb Connolly, Rob Herring, Heiko Stuebner, Linus Walleij,
Bartosz Golaszewski, devicetree, linux-arm-kernel,
linux-rockchip, linux-kernel, linux-gpio
Cc: ~postmarketos/upstreaming, martijn, Arnaud Ferraris
Handle the PIN_CONFIG_INPUT_ENABLE param for configuring GPIOs as input.
Signed-off-by: Caleb Connolly <kc@postmarketos.org>
---
drivers/pinctrl/pinctrl-rockchip.c | 12 +++++++++++-
1 file changed, 11 insertions(+), 1 deletion(-)
diff --git a/drivers/pinctrl/pinctrl-rockchip.c b/drivers/pinctrl/pinctrl-rockchip.c
index d54fc1cdf609..9d50d9756bb9 100644
--- a/drivers/pinctrl/pinctrl-rockchip.c
+++ b/drivers/pinctrl/pinctrl-rockchip.c
@@ -2129,7 +2129,7 @@ static int rockchip_pinconf_set(struct pinctrl_dev *pctldev, unsigned int pin,
param = pinconf_to_config_param(configs[i]);
arg = pinconf_to_config_argument(configs[i]);
- if (param == (PIN_CONFIG_OUTPUT | PIN_CONFIG_INPUT_ENABLE)) {
+ if (param == PIN_CONFIG_OUTPUT || param == PIN_CONFIG_INPUT_ENABLE) {
/*
* Check for gpio driver not being probed yet.
* The lock makes sure that either gpio-probe has completed
@@ -2181,6 +2181,16 @@ static int rockchip_pinconf_set(struct pinctrl_dev *pctldev, unsigned int pin,
if (rc)
return rc;
break;
+ case PIN_CONFIG_INPUT_ENABLE:
+ rc = rockchip_set_mux(bank, pin - bank->pin_base,
+ RK_FUNC_GPIO);
+ if (rc != RK_FUNC_GPIO)
+ return -EINVAL;
+
+ rc = gpio->direction_input(gpio, pin - bank->pin_base);
+ if (rc)
+ return rc;
+ break;
case PIN_CONFIG_DRIVE_STRENGTH:
/* rk3288 is the first with per-pin drive-strength */
if (!info->ctrl->drv_calc_reg)
--
2.35.1
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
^ permalink raw reply related [flat|nested] 24+ messages in thread
* [PATCH 2/4] pinctrl/rockchip: support setting input-enable param
@ 2022-03-28 0:50 ` Caleb Connolly
0 siblings, 0 replies; 24+ messages in thread
From: Caleb Connolly @ 2022-03-28 0:50 UTC (permalink / raw)
To: Caleb Connolly, Rob Herring, Heiko Stuebner, Linus Walleij,
Bartosz Golaszewski, devicetree, linux-arm-kernel,
linux-rockchip, linux-kernel, linux-gpio
Cc: ~postmarketos/upstreaming, martijn, Arnaud Ferraris
Handle the PIN_CONFIG_INPUT_ENABLE param for configuring GPIOs as input.
Signed-off-by: Caleb Connolly <kc@postmarketos.org>
---
drivers/pinctrl/pinctrl-rockchip.c | 12 +++++++++++-
1 file changed, 11 insertions(+), 1 deletion(-)
diff --git a/drivers/pinctrl/pinctrl-rockchip.c b/drivers/pinctrl/pinctrl-rockchip.c
index d54fc1cdf609..9d50d9756bb9 100644
--- a/drivers/pinctrl/pinctrl-rockchip.c
+++ b/drivers/pinctrl/pinctrl-rockchip.c
@@ -2129,7 +2129,7 @@ static int rockchip_pinconf_set(struct pinctrl_dev *pctldev, unsigned int pin,
param = pinconf_to_config_param(configs[i]);
arg = pinconf_to_config_argument(configs[i]);
- if (param == (PIN_CONFIG_OUTPUT | PIN_CONFIG_INPUT_ENABLE)) {
+ if (param == PIN_CONFIG_OUTPUT || param == PIN_CONFIG_INPUT_ENABLE) {
/*
* Check for gpio driver not being probed yet.
* The lock makes sure that either gpio-probe has completed
@@ -2181,6 +2181,16 @@ static int rockchip_pinconf_set(struct pinctrl_dev *pctldev, unsigned int pin,
if (rc)
return rc;
break;
+ case PIN_CONFIG_INPUT_ENABLE:
+ rc = rockchip_set_mux(bank, pin - bank->pin_base,
+ RK_FUNC_GPIO);
+ if (rc != RK_FUNC_GPIO)
+ return -EINVAL;
+
+ rc = gpio->direction_input(gpio, pin - bank->pin_base);
+ if (rc)
+ return rc;
+ break;
case PIN_CONFIG_DRIVE_STRENGTH:
/* rk3288 is the first with per-pin drive-strength */
if (!info->ctrl->drv_calc_reg)
--
2.35.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 24+ messages in thread
* [PATCH 2/4] pinctrl/rockchip: support setting input-enable param
@ 2022-03-28 0:50 ` Caleb Connolly
0 siblings, 0 replies; 24+ messages in thread
From: Caleb Connolly @ 2022-03-28 0:50 UTC (permalink / raw)
To: Caleb Connolly, Rob Herring, Heiko Stuebner, Linus Walleij,
Bartosz Golaszewski, devicetree, linux-arm-kernel,
linux-rockchip, linux-kernel, linux-gpio
Cc: ~postmarketos/upstreaming, martijn, Arnaud Ferraris
Handle the PIN_CONFIG_INPUT_ENABLE param for configuring GPIOs as input.
Signed-off-by: Caleb Connolly <kc@postmarketos.org>
---
drivers/pinctrl/pinctrl-rockchip.c | 12 +++++++++++-
1 file changed, 11 insertions(+), 1 deletion(-)
diff --git a/drivers/pinctrl/pinctrl-rockchip.c b/drivers/pinctrl/pinctrl-rockchip.c
index d54fc1cdf609..9d50d9756bb9 100644
--- a/drivers/pinctrl/pinctrl-rockchip.c
+++ b/drivers/pinctrl/pinctrl-rockchip.c
@@ -2129,7 +2129,7 @@ static int rockchip_pinconf_set(struct pinctrl_dev *pctldev, unsigned int pin,
param = pinconf_to_config_param(configs[i]);
arg = pinconf_to_config_argument(configs[i]);
- if (param == (PIN_CONFIG_OUTPUT | PIN_CONFIG_INPUT_ENABLE)) {
+ if (param == PIN_CONFIG_OUTPUT || param == PIN_CONFIG_INPUT_ENABLE) {
/*
* Check for gpio driver not being probed yet.
* The lock makes sure that either gpio-probe has completed
@@ -2181,6 +2181,16 @@ static int rockchip_pinconf_set(struct pinctrl_dev *pctldev, unsigned int pin,
if (rc)
return rc;
break;
+ case PIN_CONFIG_INPUT_ENABLE:
+ rc = rockchip_set_mux(bank, pin - bank->pin_base,
+ RK_FUNC_GPIO);
+ if (rc != RK_FUNC_GPIO)
+ return -EINVAL;
+
+ rc = gpio->direction_input(gpio, pin - bank->pin_base);
+ if (rc)
+ return rc;
+ break;
case PIN_CONFIG_DRIVE_STRENGTH:
/* rk3288 is the first with per-pin drive-strength */
if (!info->ctrl->drv_calc_reg)
--
2.35.1
^ permalink raw reply related [flat|nested] 24+ messages in thread
* [PATCH 3/4] gpio/rockchip: handle deferring input-enable pinconfs
2022-03-28 0:50 ` Caleb Connolly
(?)
@ 2022-03-28 0:50 ` Caleb Connolly
-1 siblings, 0 replies; 24+ messages in thread
From: Caleb Connolly @ 2022-03-28 0:50 UTC (permalink / raw)
To: Caleb Connolly, Rob Herring, Heiko Stuebner, Linus Walleij,
Bartosz Golaszewski, devicetree, linux-arm-kernel,
linux-rockchip, linux-kernel, linux-gpio
Cc: ~postmarketos/upstreaming, martijn, Arnaud Ferraris
Add support for deferred PIN_CONFIG_INPUT_ENABLE handling.
Signed-off-by: Caleb Connolly <kc@postmarketos.org>
---
drivers/gpio/gpio-rockchip.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/drivers/gpio/gpio-rockchip.c b/drivers/gpio/gpio-rockchip.c
index bcf5214e3586..e342a6dc4c6c 100644
--- a/drivers/gpio/gpio-rockchip.c
+++ b/drivers/gpio/gpio-rockchip.c
@@ -760,6 +760,11 @@ static int rockchip_gpio_probe(struct platform_device *pdev)
dev_warn(dev, "setting output pin %u to %u failed\n", cfg->pin,
cfg->arg);
break;
+ case PIN_CONFIG_INPUT_ENABLE:
+ ret = rockchip_gpio_direction_input(&bank->gpio_chip, cfg->pin);
+ if (ret)
+ dev_warn(dev, "setting input pin %u failed\n", cfg->pin);
+ break;
default:
dev_warn(dev, "unknown deferred config param %d\n", cfg->param);
break;
--
2.35.1
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
^ permalink raw reply related [flat|nested] 24+ messages in thread
* [PATCH 3/4] gpio/rockchip: handle deferring input-enable pinconfs
@ 2022-03-28 0:50 ` Caleb Connolly
0 siblings, 0 replies; 24+ messages in thread
From: Caleb Connolly @ 2022-03-28 0:50 UTC (permalink / raw)
To: Caleb Connolly, Rob Herring, Heiko Stuebner, Linus Walleij,
Bartosz Golaszewski, devicetree, linux-arm-kernel,
linux-rockchip, linux-kernel, linux-gpio
Cc: ~postmarketos/upstreaming, martijn, Arnaud Ferraris
Add support for deferred PIN_CONFIG_INPUT_ENABLE handling.
Signed-off-by: Caleb Connolly <kc@postmarketos.org>
---
drivers/gpio/gpio-rockchip.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/drivers/gpio/gpio-rockchip.c b/drivers/gpio/gpio-rockchip.c
index bcf5214e3586..e342a6dc4c6c 100644
--- a/drivers/gpio/gpio-rockchip.c
+++ b/drivers/gpio/gpio-rockchip.c
@@ -760,6 +760,11 @@ static int rockchip_gpio_probe(struct platform_device *pdev)
dev_warn(dev, "setting output pin %u to %u failed\n", cfg->pin,
cfg->arg);
break;
+ case PIN_CONFIG_INPUT_ENABLE:
+ ret = rockchip_gpio_direction_input(&bank->gpio_chip, cfg->pin);
+ if (ret)
+ dev_warn(dev, "setting input pin %u failed\n", cfg->pin);
+ break;
default:
dev_warn(dev, "unknown deferred config param %d\n", cfg->param);
break;
--
2.35.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 24+ messages in thread
* [PATCH 3/4] gpio/rockchip: handle deferring input-enable pinconfs
@ 2022-03-28 0:50 ` Caleb Connolly
0 siblings, 0 replies; 24+ messages in thread
From: Caleb Connolly @ 2022-03-28 0:50 UTC (permalink / raw)
To: Caleb Connolly, Rob Herring, Heiko Stuebner, Linus Walleij,
Bartosz Golaszewski, devicetree, linux-arm-kernel,
linux-rockchip, linux-kernel, linux-gpio
Cc: ~postmarketos/upstreaming, martijn, Arnaud Ferraris
Add support for deferred PIN_CONFIG_INPUT_ENABLE handling.
Signed-off-by: Caleb Connolly <kc@postmarketos.org>
---
drivers/gpio/gpio-rockchip.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/drivers/gpio/gpio-rockchip.c b/drivers/gpio/gpio-rockchip.c
index bcf5214e3586..e342a6dc4c6c 100644
--- a/drivers/gpio/gpio-rockchip.c
+++ b/drivers/gpio/gpio-rockchip.c
@@ -760,6 +760,11 @@ static int rockchip_gpio_probe(struct platform_device *pdev)
dev_warn(dev, "setting output pin %u to %u failed\n", cfg->pin,
cfg->arg);
break;
+ case PIN_CONFIG_INPUT_ENABLE:
+ ret = rockchip_gpio_direction_input(&bank->gpio_chip, cfg->pin);
+ if (ret)
+ dev_warn(dev, "setting input pin %u failed\n", cfg->pin);
+ break;
default:
dev_warn(dev, "unknown deferred config param %d\n", cfg->param);
break;
--
2.35.1
^ permalink raw reply related [flat|nested] 24+ messages in thread
* [PATCH 4/4] arm64: dts: rockchip: rk3399: add an input enable pinconf
2022-03-28 0:50 ` Caleb Connolly
(?)
@ 2022-03-28 0:50 ` Caleb Connolly
-1 siblings, 0 replies; 24+ messages in thread
From: Caleb Connolly @ 2022-03-28 0:50 UTC (permalink / raw)
To: Caleb Connolly, Rob Herring, Heiko Stuebner, Linus Walleij,
Bartosz Golaszewski, devicetree, linux-arm-kernel,
linux-rockchip, linux-kernel, linux-gpio
Cc: ~postmarketos/upstreaming, martijn, Arnaud Ferraris
Add a pinconf to configure pins as input-enable.
Signed-off-by: Caleb Connolly <kc@postmarketos.org>
---
arch/arm64/boot/dts/rockchip/rk3399.dtsi | 16 ++++++++++++++++
1 file changed, 16 insertions(+)
diff --git a/arch/arm64/boot/dts/rockchip/rk3399.dtsi b/arch/arm64/boot/dts/rockchip/rk3399.dtsi
index 080457a68e3c..9b111bd89f0a 100644
--- a/arch/arm64/boot/dts/rockchip/rk3399.dtsi
+++ b/arch/arm64/boot/dts/rockchip/rk3399.dtsi
@@ -2188,6 +2188,22 @@ pcfg_output_low: pcfg-output-low {
output-low;
};
+ pcfg_input_enable: pcfg-input-enable {
+ input-enable;
+ };
+
+ pcfg_input_pull_up: pcfg-input-pull-up {
+ input-enable;
+ bias-pull-up;
+ drive-strength = <2>;
+ };
+
+ pcfg_input_pull_down: pcfg-input-pull-down {
+ input-enable;
+ bias-pull-down;
+ drive-strength = <2>;
+ };
+
clock {
clk_32k: clk-32k {
rockchip,pins = <0 RK_PA0 2 &pcfg_pull_none>;
--
2.35.1
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
^ permalink raw reply related [flat|nested] 24+ messages in thread
* [PATCH 4/4] arm64: dts: rockchip: rk3399: add an input enable pinconf
@ 2022-03-28 0:50 ` Caleb Connolly
0 siblings, 0 replies; 24+ messages in thread
From: Caleb Connolly @ 2022-03-28 0:50 UTC (permalink / raw)
To: Caleb Connolly, Rob Herring, Heiko Stuebner, Linus Walleij,
Bartosz Golaszewski, devicetree, linux-arm-kernel,
linux-rockchip, linux-kernel, linux-gpio
Cc: ~postmarketos/upstreaming, martijn, Arnaud Ferraris
Add a pinconf to configure pins as input-enable.
Signed-off-by: Caleb Connolly <kc@postmarketos.org>
---
arch/arm64/boot/dts/rockchip/rk3399.dtsi | 16 ++++++++++++++++
1 file changed, 16 insertions(+)
diff --git a/arch/arm64/boot/dts/rockchip/rk3399.dtsi b/arch/arm64/boot/dts/rockchip/rk3399.dtsi
index 080457a68e3c..9b111bd89f0a 100644
--- a/arch/arm64/boot/dts/rockchip/rk3399.dtsi
+++ b/arch/arm64/boot/dts/rockchip/rk3399.dtsi
@@ -2188,6 +2188,22 @@ pcfg_output_low: pcfg-output-low {
output-low;
};
+ pcfg_input_enable: pcfg-input-enable {
+ input-enable;
+ };
+
+ pcfg_input_pull_up: pcfg-input-pull-up {
+ input-enable;
+ bias-pull-up;
+ drive-strength = <2>;
+ };
+
+ pcfg_input_pull_down: pcfg-input-pull-down {
+ input-enable;
+ bias-pull-down;
+ drive-strength = <2>;
+ };
+
clock {
clk_32k: clk-32k {
rockchip,pins = <0 RK_PA0 2 &pcfg_pull_none>;
--
2.35.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 24+ messages in thread
* [PATCH 4/4] arm64: dts: rockchip: rk3399: add an input enable pinconf
@ 2022-03-28 0:50 ` Caleb Connolly
0 siblings, 0 replies; 24+ messages in thread
From: Caleb Connolly @ 2022-03-28 0:50 UTC (permalink / raw)
To: Caleb Connolly, Rob Herring, Heiko Stuebner, Linus Walleij,
Bartosz Golaszewski, devicetree, linux-arm-kernel,
linux-rockchip, linux-kernel, linux-gpio
Cc: ~postmarketos/upstreaming, martijn, Arnaud Ferraris
Add a pinconf to configure pins as input-enable.
Signed-off-by: Caleb Connolly <kc@postmarketos.org>
---
arch/arm64/boot/dts/rockchip/rk3399.dtsi | 16 ++++++++++++++++
1 file changed, 16 insertions(+)
diff --git a/arch/arm64/boot/dts/rockchip/rk3399.dtsi b/arch/arm64/boot/dts/rockchip/rk3399.dtsi
index 080457a68e3c..9b111bd89f0a 100644
--- a/arch/arm64/boot/dts/rockchip/rk3399.dtsi
+++ b/arch/arm64/boot/dts/rockchip/rk3399.dtsi
@@ -2188,6 +2188,22 @@ pcfg_output_low: pcfg-output-low {
output-low;
};
+ pcfg_input_enable: pcfg-input-enable {
+ input-enable;
+ };
+
+ pcfg_input_pull_up: pcfg-input-pull-up {
+ input-enable;
+ bias-pull-up;
+ drive-strength = <2>;
+ };
+
+ pcfg_input_pull_down: pcfg-input-pull-down {
+ input-enable;
+ bias-pull-down;
+ drive-strength = <2>;
+ };
+
clock {
clk_32k: clk-32k {
rockchip,pins = <0 RK_PA0 2 &pcfg_pull_none>;
--
2.35.1
^ permalink raw reply related [flat|nested] 24+ messages in thread
* Re: [PATCH 3/4] gpio/rockchip: handle deferring input-enable pinconfs
2022-03-28 0:50 ` Caleb Connolly
(?)
@ 2022-04-18 19:47 ` Bartosz Golaszewski
-1 siblings, 0 replies; 24+ messages in thread
From: Bartosz Golaszewski @ 2022-04-18 19:47 UTC (permalink / raw)
To: Caleb Connolly
Cc: Rob Herring, Heiko Stuebner, Linus Walleij, devicetree,
Linux ARM, open list:ARM/Rockchip SoC...,
Linux Kernel Mailing List, open list:GPIO SUBSYSTEM,
~postmarketos/upstreaming, martijn, Arnaud Ferraris
On Mon, Mar 28, 2022 at 2:50 AM Caleb Connolly <kc@postmarketos.org> wrote:
>
> Add support for deferred PIN_CONFIG_INPUT_ENABLE handling.
>
> Signed-off-by: Caleb Connolly <kc@postmarketos.org>
> ---
> drivers/gpio/gpio-rockchip.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/drivers/gpio/gpio-rockchip.c b/drivers/gpio/gpio-rockchip.c
> index bcf5214e3586..e342a6dc4c6c 100644
> --- a/drivers/gpio/gpio-rockchip.c
> +++ b/drivers/gpio/gpio-rockchip.c
> @@ -760,6 +760,11 @@ static int rockchip_gpio_probe(struct platform_device *pdev)
> dev_warn(dev, "setting output pin %u to %u failed\n", cfg->pin,
> cfg->arg);
> break;
> + case PIN_CONFIG_INPUT_ENABLE:
> + ret = rockchip_gpio_direction_input(&bank->gpio_chip, cfg->pin);
> + if (ret)
> + dev_warn(dev, "setting input pin %u failed\n", cfg->pin);
> + break;
> default:
> dev_warn(dev, "unknown deferred config param %d\n", cfg->param);
> break;
> --
> 2.35.1
>
Does this depend on patches 1 & 2 or does patch 4 depend on this one? If so:
Acked-by: Bartosz Golaszewski <brgl@bgdev.pl>
Otherwise I can take it through the GPIO tree.
Bart
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [PATCH 3/4] gpio/rockchip: handle deferring input-enable pinconfs
@ 2022-04-18 19:47 ` Bartosz Golaszewski
0 siblings, 0 replies; 24+ messages in thread
From: Bartosz Golaszewski @ 2022-04-18 19:47 UTC (permalink / raw)
To: Caleb Connolly
Cc: Rob Herring, Heiko Stuebner, Linus Walleij, devicetree,
Linux ARM, open list:ARM/Rockchip SoC...,
Linux Kernel Mailing List, open list:GPIO SUBSYSTEM,
~postmarketos/upstreaming, martijn, Arnaud Ferraris
On Mon, Mar 28, 2022 at 2:50 AM Caleb Connolly <kc@postmarketos.org> wrote:
>
> Add support for deferred PIN_CONFIG_INPUT_ENABLE handling.
>
> Signed-off-by: Caleb Connolly <kc@postmarketos.org>
> ---
> drivers/gpio/gpio-rockchip.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/drivers/gpio/gpio-rockchip.c b/drivers/gpio/gpio-rockchip.c
> index bcf5214e3586..e342a6dc4c6c 100644
> --- a/drivers/gpio/gpio-rockchip.c
> +++ b/drivers/gpio/gpio-rockchip.c
> @@ -760,6 +760,11 @@ static int rockchip_gpio_probe(struct platform_device *pdev)
> dev_warn(dev, "setting output pin %u to %u failed\n", cfg->pin,
> cfg->arg);
> break;
> + case PIN_CONFIG_INPUT_ENABLE:
> + ret = rockchip_gpio_direction_input(&bank->gpio_chip, cfg->pin);
> + if (ret)
> + dev_warn(dev, "setting input pin %u failed\n", cfg->pin);
> + break;
> default:
> dev_warn(dev, "unknown deferred config param %d\n", cfg->param);
> break;
> --
> 2.35.1
>
Does this depend on patches 1 & 2 or does patch 4 depend on this one? If so:
Acked-by: Bartosz Golaszewski <brgl@bgdev.pl>
Otherwise I can take it through the GPIO tree.
Bart
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [PATCH 3/4] gpio/rockchip: handle deferring input-enable pinconfs
@ 2022-04-18 19:47 ` Bartosz Golaszewski
0 siblings, 0 replies; 24+ messages in thread
From: Bartosz Golaszewski @ 2022-04-18 19:47 UTC (permalink / raw)
To: Caleb Connolly
Cc: Rob Herring, Heiko Stuebner, Linus Walleij, devicetree,
Linux ARM, open list:ARM/Rockchip SoC...,
Linux Kernel Mailing List, open list:GPIO SUBSYSTEM,
~postmarketos/upstreaming, martijn, Arnaud Ferraris
On Mon, Mar 28, 2022 at 2:50 AM Caleb Connolly <kc@postmarketos.org> wrote:
>
> Add support for deferred PIN_CONFIG_INPUT_ENABLE handling.
>
> Signed-off-by: Caleb Connolly <kc@postmarketos.org>
> ---
> drivers/gpio/gpio-rockchip.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/drivers/gpio/gpio-rockchip.c b/drivers/gpio/gpio-rockchip.c
> index bcf5214e3586..e342a6dc4c6c 100644
> --- a/drivers/gpio/gpio-rockchip.c
> +++ b/drivers/gpio/gpio-rockchip.c
> @@ -760,6 +760,11 @@ static int rockchip_gpio_probe(struct platform_device *pdev)
> dev_warn(dev, "setting output pin %u to %u failed\n", cfg->pin,
> cfg->arg);
> break;
> + case PIN_CONFIG_INPUT_ENABLE:
> + ret = rockchip_gpio_direction_input(&bank->gpio_chip, cfg->pin);
> + if (ret)
> + dev_warn(dev, "setting input pin %u failed\n", cfg->pin);
> + break;
> default:
> dev_warn(dev, "unknown deferred config param %d\n", cfg->param);
> break;
> --
> 2.35.1
>
Does this depend on patches 1 & 2 or does patch 4 depend on this one? If so:
Acked-by: Bartosz Golaszewski <brgl@bgdev.pl>
Otherwise I can take it through the GPIO tree.
Bart
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [PATCH 0/4] rockchip: support configuring pins as input
2022-03-28 0:50 ` Caleb Connolly
(?)
@ 2022-04-19 22:37 ` Linus Walleij
-1 siblings, 0 replies; 24+ messages in thread
From: Linus Walleij @ 2022-04-19 22:37 UTC (permalink / raw)
To: Caleb Connolly
Cc: Rob Herring, Heiko Stuebner, Bartosz Golaszewski, devicetree,
linux-arm-kernel, linux-rockchip, linux-kernel, linux-gpio,
~postmarketos/upstreaming, martijn, Arnaud Ferraris
Hi Caleb,
On Mon, Mar 28, 2022 at 2:50 AM Caleb Connolly <kc@postmarketos.org> wrote:
Caleb Connolly (4):
> pinctrl/rockchip: support deferring other gpio params
> pinctrl/rockchip: support setting input-enable param
> gpio/rockchip: handle deferring input-enable pinconfs
Those three applied to the pinctrl tree.
> arm64: dts: rockchip: rk3399: add an input enable pinconf
Please submit this through the SoC tree.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [PATCH 0/4] rockchip: support configuring pins as input
@ 2022-04-19 22:37 ` Linus Walleij
0 siblings, 0 replies; 24+ messages in thread
From: Linus Walleij @ 2022-04-19 22:37 UTC (permalink / raw)
To: Caleb Connolly
Cc: Rob Herring, Heiko Stuebner, Bartosz Golaszewski, devicetree,
linux-arm-kernel, linux-rockchip, linux-kernel, linux-gpio,
~postmarketos/upstreaming, martijn, Arnaud Ferraris
Hi Caleb,
On Mon, Mar 28, 2022 at 2:50 AM Caleb Connolly <kc@postmarketos.org> wrote:
Caleb Connolly (4):
> pinctrl/rockchip: support deferring other gpio params
> pinctrl/rockchip: support setting input-enable param
> gpio/rockchip: handle deferring input-enable pinconfs
Those three applied to the pinctrl tree.
> arm64: dts: rockchip: rk3399: add an input enable pinconf
Please submit this through the SoC tree.
Yours,
Linus Walleij
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [PATCH 0/4] rockchip: support configuring pins as input
@ 2022-04-19 22:37 ` Linus Walleij
0 siblings, 0 replies; 24+ messages in thread
From: Linus Walleij @ 2022-04-19 22:37 UTC (permalink / raw)
To: Caleb Connolly
Cc: Rob Herring, Heiko Stuebner, Bartosz Golaszewski, devicetree,
linux-arm-kernel, linux-rockchip, linux-kernel, linux-gpio,
~postmarketos/upstreaming, martijn, Arnaud Ferraris
Hi Caleb,
On Mon, Mar 28, 2022 at 2:50 AM Caleb Connolly <kc@postmarketos.org> wrote:
Caleb Connolly (4):
> pinctrl/rockchip: support deferring other gpio params
> pinctrl/rockchip: support setting input-enable param
> gpio/rockchip: handle deferring input-enable pinconfs
Those three applied to the pinctrl tree.
> arm64: dts: rockchip: rk3399: add an input enable pinconf
Please submit this through the SoC tree.
Yours,
Linus Walleij
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: (subset) [PATCH 0/4] rockchip: support configuring pins as input
2022-03-28 0:50 ` Caleb Connolly
(?)
@ 2022-04-30 14:05 ` Heiko Stuebner
-1 siblings, 0 replies; 24+ messages in thread
From: Heiko Stuebner @ 2022-04-30 14:05 UTC (permalink / raw)
To: linux-rockchip, linux-kernel, Linus Walleij, linux-gpio,
Caleb Connolly, Bartosz Golaszewski, Rob Herring,
linux-arm-kernel, devicetree
Cc: Heiko Stuebner, Arnaud Ferraris, ~postmarketos/upstreaming, martijn
On Mon, 28 Mar 2022 01:50:01 +0100, Caleb Connolly wrote:
> Add support for configuring pins as input to the rockchip pinctrl
> driver. This is required for example for devices which use non-standard
> configurations for gpio interrupts, specifically for the light/proximity
> sensor on the RK3399 powered PinePhone Pro (which will be coming
> upstream in a future patch series).
>
> Due to the complicated layout of the RK pinctrl/gpio drivers, some extra
> work is required to handle deferring the GPIO configuration. On RK3399
> the pinctrl driver always probes before the GPIO controller driver, so
> the PIN_CONFIG_OUTPUT and PIN_CONFIG_INPUT_ENABLE params both have to be
> deferred, this series also reworks the deferred pin handling to be
> generic and support any param rather than only the PIN_CONFIG_OUTPUT
> param.
Applied, thanks!
[4/4] arm64: dts: rockchip: rk3399: add an input enable pinconf
commit: ec48c3e82ca36a66ae37ba8b1fdb9a7561dcab14
Best regards,
--
Heiko Stuebner <heiko@sntech.de>
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: (subset) [PATCH 0/4] rockchip: support configuring pins as input
@ 2022-04-30 14:05 ` Heiko Stuebner
0 siblings, 0 replies; 24+ messages in thread
From: Heiko Stuebner @ 2022-04-30 14:05 UTC (permalink / raw)
To: linux-rockchip, linux-kernel, Linus Walleij, linux-gpio,
Caleb Connolly, Bartosz Golaszewski, Rob Herring,
linux-arm-kernel, devicetree
Cc: Heiko Stuebner, Arnaud Ferraris, ~postmarketos/upstreaming, martijn
On Mon, 28 Mar 2022 01:50:01 +0100, Caleb Connolly wrote:
> Add support for configuring pins as input to the rockchip pinctrl
> driver. This is required for example for devices which use non-standard
> configurations for gpio interrupts, specifically for the light/proximity
> sensor on the RK3399 powered PinePhone Pro (which will be coming
> upstream in a future patch series).
>
> Due to the complicated layout of the RK pinctrl/gpio drivers, some extra
> work is required to handle deferring the GPIO configuration. On RK3399
> the pinctrl driver always probes before the GPIO controller driver, so
> the PIN_CONFIG_OUTPUT and PIN_CONFIG_INPUT_ENABLE params both have to be
> deferred, this series also reworks the deferred pin handling to be
> generic and support any param rather than only the PIN_CONFIG_OUTPUT
> param.
Applied, thanks!
[4/4] arm64: dts: rockchip: rk3399: add an input enable pinconf
commit: ec48c3e82ca36a66ae37ba8b1fdb9a7561dcab14
Best regards,
--
Heiko Stuebner <heiko@sntech.de>
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: (subset) [PATCH 0/4] rockchip: support configuring pins as input
@ 2022-04-30 14:05 ` Heiko Stuebner
0 siblings, 0 replies; 24+ messages in thread
From: Heiko Stuebner @ 2022-04-30 14:05 UTC (permalink / raw)
To: linux-rockchip, linux-kernel, Linus Walleij, linux-gpio,
Caleb Connolly, Bartosz Golaszewski, Rob Herring,
linux-arm-kernel, devicetree
Cc: Heiko Stuebner, Arnaud Ferraris, ~postmarketos/upstreaming, martijn
On Mon, 28 Mar 2022 01:50:01 +0100, Caleb Connolly wrote:
> Add support for configuring pins as input to the rockchip pinctrl
> driver. This is required for example for devices which use non-standard
> configurations for gpio interrupts, specifically for the light/proximity
> sensor on the RK3399 powered PinePhone Pro (which will be coming
> upstream in a future patch series).
>
> Due to the complicated layout of the RK pinctrl/gpio drivers, some extra
> work is required to handle deferring the GPIO configuration. On RK3399
> the pinctrl driver always probes before the GPIO controller driver, so
> the PIN_CONFIG_OUTPUT and PIN_CONFIG_INPUT_ENABLE params both have to be
> deferred, this series also reworks the deferred pin handling to be
> generic and support any param rather than only the PIN_CONFIG_OUTPUT
> param.
Applied, thanks!
[4/4] arm64: dts: rockchip: rk3399: add an input enable pinconf
commit: ec48c3e82ca36a66ae37ba8b1fdb9a7561dcab14
Best regards,
--
Heiko Stuebner <heiko@sntech.de>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 24+ messages in thread
end of thread, other threads:[~2022-04-30 14:07 UTC | newest]
Thread overview: 24+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-03-28 0:50 [PATCH 0/4] rockchip: support configuring pins as input Caleb Connolly
2022-03-28 0:50 ` Caleb Connolly
2022-03-28 0:50 ` Caleb Connolly
2022-03-28 0:50 ` [PATCH 1/4] pinctrl/rockchip: support deferring other gpio params Caleb Connolly
2022-03-28 0:50 ` Caleb Connolly
2022-03-28 0:50 ` Caleb Connolly
2022-03-28 0:50 ` [PATCH 2/4] pinctrl/rockchip: support setting input-enable param Caleb Connolly
2022-03-28 0:50 ` Caleb Connolly
2022-03-28 0:50 ` Caleb Connolly
2022-03-28 0:50 ` [PATCH 3/4] gpio/rockchip: handle deferring input-enable pinconfs Caleb Connolly
2022-03-28 0:50 ` Caleb Connolly
2022-03-28 0:50 ` Caleb Connolly
2022-04-18 19:47 ` Bartosz Golaszewski
2022-04-18 19:47 ` Bartosz Golaszewski
2022-04-18 19:47 ` Bartosz Golaszewski
2022-03-28 0:50 ` [PATCH 4/4] arm64: dts: rockchip: rk3399: add an input enable pinconf Caleb Connolly
2022-03-28 0:50 ` Caleb Connolly
2022-03-28 0:50 ` Caleb Connolly
2022-04-19 22:37 ` [PATCH 0/4] rockchip: support configuring pins as input Linus Walleij
2022-04-19 22:37 ` Linus Walleij
2022-04-19 22:37 ` Linus Walleij
2022-04-30 14:05 ` (subset) " Heiko Stuebner
2022-04-30 14:05 ` Heiko Stuebner
2022-04-30 14:05 ` Heiko Stuebner
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.