From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 75E89C433EF for ; Mon, 28 Mar 2022 06:24:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238415AbiC1G0J (ORCPT ); Mon, 28 Mar 2022 02:26:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56514 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235004AbiC1G0C (ORCPT ); Mon, 28 Mar 2022 02:26:02 -0400 Received: from mail-yw1-x1149.google.com (mail-yw1-x1149.google.com [IPv6:2607:f8b0:4864:20::1149]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 56BB34E3AA for ; Sun, 27 Mar 2022 23:24:22 -0700 (PDT) Received: by mail-yw1-x1149.google.com with SMTP id 00721157ae682-2e68c93bb30so110961577b3.18 for ; Sun, 27 Mar 2022 23:24:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=date:message-id:mime-version:subject:from:to:cc; bh=x0B3czyjsM+UfZLmfIxDKqt01DOoxfjklLpknwf6OIA=; b=BKA5tvIg1VJxcH3DbfLPgKEmNl0vjbLvRfkVXAU5KOW6bVmQ2bhanMOPwMHb8ztUmQ J5mchyAWm/UvwWoxDViWBVmO8GuuadAnKIkOWzyk5xLtFVBDV9Yb4qOLjl1EJ43ikEIx Oc9YwXCZIFhR1xRWdxe3Po1vWtRWfs3+v/HLJDdepOd5ORa/7ZKd95V6aXVjrRuO4yGx ikmBGu/ZQn57GynRRE3t5Ntqw2S3tlVptup2j2rRCvF/Ntq609BDHgmPPpys2mfXv15g MFbseTvzaVUmkNfqrCI/LJ2CxU9x0kmUVc4/nvoQTg4gP/bBKKL6IQ1HoA43KgvWFefJ kw5Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:message-id:mime-version:subject:from:to:cc; bh=x0B3czyjsM+UfZLmfIxDKqt01DOoxfjklLpknwf6OIA=; b=xZ4jtfE8h5L/ETAGsoQniAplUHkD/lPu8+3YO5edp18lFNk/HL3fhPe3dDsWx00LM2 upq3ALFZbi3U34yF3k8rg7K06ee+Y3YZxtFlb4khaejvPURclBMkIU4fs1lu/U/T+etK 4iCOpmU3+OrlcBPuOSh5vJiHzalj1bXYazgbZC2Jo12bqi4r3tc+LKhPUoRehtO6Bfhz ArRWyOlpfU74rgC6Y7B0e3hat48rTfARmmoizZHT3BS+QPhE1bmuf2HM9QnULso11sMH UYoj3gPXX+EfoRZVXz37vHUov5k9m4wRz+7r85VwkmRJXph7Ux84U2hn4TVLHdDJFu9J estQ== X-Gm-Message-State: AOAM530dpnMm26AntQwpQRyrbjYyd48Kyb+Qfe+b+aFpmv+6GRYAEw18 +SsDLZLUSrWO5RZgTVOSzgv8vRcrzuOK X-Google-Smtp-Source: ABdhPJxWHgdCIIH4SXciDGG4Nax8iqLB+oB99XOa+1GirXx4Tq9c1PYuzpznG8p4LqOmcttKMzoe42FGpUSW X-Received: from irogers.svl.corp.google.com ([2620:15c:2cd:202:ef08:ed1b:261f:77fa]) (user=irogers job=sendgmr) by 2002:a81:7802:0:b0:2e5:c28d:171b with SMTP id t2-20020a817802000000b002e5c28d171bmr23999477ywc.236.1648448661434; Sun, 27 Mar 2022 23:24:21 -0700 (PDT) Date: Sun, 27 Mar 2022 23:24:09 -0700 Message-Id: <20220328062414.1893550-1-irogers@google.com> Mime-Version: 1.0 X-Mailer: git-send-email 2.35.1.1021.g381101b075-goog Subject: [PATCH 0/5] Make evlist CPUs more accurate From: Ian Rogers To: Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Mathieu Poirier , Suzuki K Poulose , Mike Leach , Leo Yan , John Garry , Will Deacon , Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , Martin KaFai Lau , Song Liu , Yonghong Song , John Fastabend , KP Singh , Kajol Jain , James Clark , German Gomez , Adrian Hunter , Riccardo Mancini , Andi Kleen , Alexey Bayduraev , Alexander Antonov , linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org, coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org, netdev@vger.kernel.org, bpf@vger.kernel.org Cc: Stephane Eranian , Ian Rogers Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org evlist has all_cpus, computed to be the merge of all evsel CPU maps, and cpus. cpus may contain more CPUs than all_cpus, as by default cpus holds all online CPUs whilst all_cpus holds the merge/union from evsels. For an uncore event there may just be 1 CPU per socket, which will be a far smaller CPU map than all online CPUs. These patches change cpus to be called user_cpus, to reflect their potential user specified nature. The user_cpus are set to be the current value intersected with all_cpus, so that user_cpus is always a subset of all_cpus. This fixes printing code for metrics so that unnecessary blank lines aren't printed. To make the intersect function perform well, a perf_cpu_map__is_subset function is added. While adding this function, also use it in perf_cpu_map__merge to avoid creating a new CPU map for some currently missed patterns. Ian Rogers (5): perf evlist: Rename cpus to user_cpus perf cpumap: More cpu map reuse by merge. perf cpumap: Add intersect function. perf stat: Avoid segv if core.user_cpus isn't set. perf evlist: Respect all_cpus when setting user_cpus tools/lib/perf/cpumap.c | 76 ++++++++++++++++++++---- tools/lib/perf/evlist.c | 28 ++++----- tools/lib/perf/include/internal/evlist.h | 4 +- tools/lib/perf/include/perf/cpumap.h | 2 + tools/perf/arch/arm/util/cs-etm.c | 8 +-- tools/perf/arch/arm64/util/arm-spe.c | 2 +- tools/perf/arch/x86/util/intel-bts.c | 2 +- tools/perf/arch/x86/util/intel-pt.c | 4 +- tools/perf/bench/evlist-open-close.c | 2 +- tools/perf/builtin-ftrace.c | 2 +- tools/perf/builtin-record.c | 6 +- tools/perf/builtin-stat.c | 11 ++-- tools/perf/builtin-top.c | 2 +- tools/perf/util/auxtrace.c | 2 +- tools/perf/util/bpf_ftrace.c | 4 +- tools/perf/util/evlist.c | 16 ++--- tools/perf/util/record.c | 6 +- tools/perf/util/sideband_evlist.c | 2 +- tools/perf/util/stat-display.c | 2 +- tools/perf/util/synthetic-events.c | 2 +- tools/perf/util/top.c | 6 +- 21 files changed, 127 insertions(+), 62 deletions(-) -- 2.35.1.1021.g381101b075-goog From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id F31C4C433F5 for ; Mon, 28 Mar 2022 06:25:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:From:Subject:Mime-Version: Message-Id:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To: References:List-Owner; bh=VOD2mPi0VcQ8mg5SftlIcNOAIQ9tKSWM2ZxmdhgVyMk=; b=BKS +DAMUUlbjdPBUvkd1+0j1J7Zg4x5sh9dbgRYRiAOSz770JwesbaTfkaZo+lj7Q7kJctKMwo3WW1K2 ll9bPRiaSa0qhc5MJFj/ZimL+gR+QCHX54utmzEwM0pe4FoJpdoLcsT0i8R6TTihrFqMp1DnNouMb a43Aj41VJ5x7yb6y0I/i9qWtW7EhJhi4hIm1wbpyx36Ef4+U1FREwDZ48fitft81Yp/3FfmdqL0pd KRTizF0+xN7tPsVpf13GhnReC/9BA13hO8EkB0ZPrVd+kn6Y3XRC8AtIFi586AaRwjLL3ARIwHATU 2F0gGooHQYgUyWxEH5K2KpJNnNOE5yQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nYinj-007StA-CV; Mon, 28 Mar 2022 06:24:27 +0000 Received: from mail-yw1-x1149.google.com ([2607:f8b0:4864:20::1149]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nYinf-007Sqz-D4 for linux-arm-kernel@lists.infradead.org; Mon, 28 Mar 2022 06:24:24 +0000 Received: by mail-yw1-x1149.google.com with SMTP id 00721157ae682-2e689dfe112so110824937b3.20 for ; Sun, 27 Mar 2022 23:24:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=date:message-id:mime-version:subject:from:to:cc; bh=x0B3czyjsM+UfZLmfIxDKqt01DOoxfjklLpknwf6OIA=; b=BKA5tvIg1VJxcH3DbfLPgKEmNl0vjbLvRfkVXAU5KOW6bVmQ2bhanMOPwMHb8ztUmQ J5mchyAWm/UvwWoxDViWBVmO8GuuadAnKIkOWzyk5xLtFVBDV9Yb4qOLjl1EJ43ikEIx Oc9YwXCZIFhR1xRWdxe3Po1vWtRWfs3+v/HLJDdepOd5ORa/7ZKd95V6aXVjrRuO4yGx ikmBGu/ZQn57GynRRE3t5Ntqw2S3tlVptup2j2rRCvF/Ntq609BDHgmPPpys2mfXv15g MFbseTvzaVUmkNfqrCI/LJ2CxU9x0kmUVc4/nvoQTg4gP/bBKKL6IQ1HoA43KgvWFefJ kw5Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:message-id:mime-version:subject:from:to:cc; bh=x0B3czyjsM+UfZLmfIxDKqt01DOoxfjklLpknwf6OIA=; b=LlavL3DwSQCq0RCIjZvGg1CP4rkaku+ZEYTuLtMbC7v0+ivZkazeBfAYO5u25idwdX aQVCGSc8oFux0p8HEyzi2p7LBHJtSp+kRQ+w2udURJUhbK/C5mHrwIjRuccrfRiDx7WA rlPAns3Pn3BN6MwjVW+TvO0bqOCWQJHM6dGIxXcHE114helNS/DxqjDb7LzJwDNm6g5U rGc+fyvSd6dXIP5HE2ffDmeN3gT5+oL6wWO2j2IKceffNURB1bCCDBPl4J+VaZGX2Tfv 5LV7I3bvfMb14u2lkPBWhkUFI42/V5bXJWJAQBZRtFNE6KLna0JFv4A0Cx9gEe2JXyQd IquA== X-Gm-Message-State: AOAM530JogDSd2kZUiFjySKnbX0Vmf0tJaWS+J26yw4x4AF/QjQC7+eE EGDJprkdBEZQtuWw6fAURweYvG+nC2CU X-Google-Smtp-Source: ABdhPJxWHgdCIIH4SXciDGG4Nax8iqLB+oB99XOa+1GirXx4Tq9c1PYuzpznG8p4LqOmcttKMzoe42FGpUSW X-Received: from irogers.svl.corp.google.com ([2620:15c:2cd:202:ef08:ed1b:261f:77fa]) (user=irogers job=sendgmr) by 2002:a81:7802:0:b0:2e5:c28d:171b with SMTP id t2-20020a817802000000b002e5c28d171bmr23999477ywc.236.1648448661434; Sun, 27 Mar 2022 23:24:21 -0700 (PDT) Date: Sun, 27 Mar 2022 23:24:09 -0700 Message-Id: <20220328062414.1893550-1-irogers@google.com> Mime-Version: 1.0 X-Mailer: git-send-email 2.35.1.1021.g381101b075-goog Subject: [PATCH 0/5] Make evlist CPUs more accurate From: Ian Rogers To: Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Mathieu Poirier , Suzuki K Poulose , Mike Leach , Leo Yan , John Garry , Will Deacon , Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , Martin KaFai Lau , Song Liu , Yonghong Song , John Fastabend , KP Singh , Kajol Jain , James Clark , German Gomez , Adrian Hunter , Riccardo Mancini , Andi Kleen , Alexey Bayduraev , Alexander Antonov , linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org, coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org, netdev@vger.kernel.org, bpf@vger.kernel.org Cc: Stephane Eranian , Ian Rogers X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220327_232423_472616_0F02A6B1 X-CRM114-Status: GOOD ( 14.08 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org evlist has all_cpus, computed to be the merge of all evsel CPU maps, and cpus. cpus may contain more CPUs than all_cpus, as by default cpus holds all online CPUs whilst all_cpus holds the merge/union from evsels. For an uncore event there may just be 1 CPU per socket, which will be a far smaller CPU map than all online CPUs. These patches change cpus to be called user_cpus, to reflect their potential user specified nature. The user_cpus are set to be the current value intersected with all_cpus, so that user_cpus is always a subset of all_cpus. This fixes printing code for metrics so that unnecessary blank lines aren't printed. To make the intersect function perform well, a perf_cpu_map__is_subset function is added. While adding this function, also use it in perf_cpu_map__merge to avoid creating a new CPU map for some currently missed patterns. Ian Rogers (5): perf evlist: Rename cpus to user_cpus perf cpumap: More cpu map reuse by merge. perf cpumap: Add intersect function. perf stat: Avoid segv if core.user_cpus isn't set. perf evlist: Respect all_cpus when setting user_cpus tools/lib/perf/cpumap.c | 76 ++++++++++++++++++++---- tools/lib/perf/evlist.c | 28 ++++----- tools/lib/perf/include/internal/evlist.h | 4 +- tools/lib/perf/include/perf/cpumap.h | 2 + tools/perf/arch/arm/util/cs-etm.c | 8 +-- tools/perf/arch/arm64/util/arm-spe.c | 2 +- tools/perf/arch/x86/util/intel-bts.c | 2 +- tools/perf/arch/x86/util/intel-pt.c | 4 +- tools/perf/bench/evlist-open-close.c | 2 +- tools/perf/builtin-ftrace.c | 2 +- tools/perf/builtin-record.c | 6 +- tools/perf/builtin-stat.c | 11 ++-- tools/perf/builtin-top.c | 2 +- tools/perf/util/auxtrace.c | 2 +- tools/perf/util/bpf_ftrace.c | 4 +- tools/perf/util/evlist.c | 16 ++--- tools/perf/util/record.c | 6 +- tools/perf/util/sideband_evlist.c | 2 +- tools/perf/util/stat-display.c | 2 +- tools/perf/util/synthetic-events.c | 2 +- tools/perf/util/top.c | 6 +- 21 files changed, 127 insertions(+), 62 deletions(-) -- 2.35.1.1021.g381101b075-goog _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel