From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B72CEC433FE for ; Mon, 28 Mar 2022 09:59:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240111AbiC1KAx (ORCPT ); Mon, 28 Mar 2022 06:00:53 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48658 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240113AbiC1KAw (ORCPT ); Mon, 28 Mar 2022 06:00:52 -0400 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6118142490; Mon, 28 Mar 2022 02:59:12 -0700 (PDT) Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out1.suse.de (Postfix) with ESMTP id 1E2C5210EA; Mon, 28 Mar 2022 09:59:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1648461551; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=iiTWiXg3repmNdg1Lg6AudefAR3R2YTlD7u2pBnhmOA=; b=w3cAsglSQAeuB3h4e410ghJ6wveRSYL5MoAGtutSdr5DyPqRIma30N9GW3aRZviT5xIJsv qOAznb33JI4wPbrwf6cxuZTwQpzte4dLJ76iCfhkaSJR1+NjACvVuXiUDYsKagOCmuR4Cl gZAco2jNRzlPTd3Qw6+Qf55HdIIf8x4= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1648461551; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=iiTWiXg3repmNdg1Lg6AudefAR3R2YTlD7u2pBnhmOA=; b=7adj626p536xHfFhrfQaKE1zb3vuXgCKxRB71Gjs+N+KVl840ivPB6N+1XgnyWzDFgdt4i TdAi7TPxP2R33iCw== Received: from quack3.suse.cz (unknown [10.163.43.118]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by relay2.suse.de (Postfix) with ESMTPS id 0FA13A3B82; Mon, 28 Mar 2022 09:59:11 +0000 (UTC) Received: by quack3.suse.cz (Postfix, from userid 1000) id BB4BDA0610; Mon, 28 Mar 2022 11:59:10 +0200 (CEST) Date: Mon, 28 Mar 2022 11:59:10 +0200 From: Jan Kara To: Jiri Slaby Cc: axboe@kernel.dk, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, Christoph Hellwig , Jan Kara Subject: Re: [PATCH] block: restore the old set_task_ioprio() behaviour wrt PF_EXITING Message-ID: <20220328095910.fyifhw6ry4ggcdbc@quack3.lan> References: <20220328085928.7899-1-jslaby@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220328085928.7899-1-jslaby@suse.cz> Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org On Mon 28-03-22 10:59:28, Jiri Slaby wrote: > PF_EXITING tasks were silently ignored before the below commits. > Continue doing so. Otherwise python-psutil tests fail: > ERROR: psutil.tests.test_process.TestProcess.test_zombie_process > ---------------------------------------------------------------------- > Traceback (most recent call last): > File "/home/abuild/rpmbuild/BUILD/psutil-5.9.0/build/lib.linux-x86_64-3.9/psutil/_pslinux.py", line 1661, in wrapper > return fun(self, *args, **kwargs) > File "/home/abuild/rpmbuild/BUILD/psutil-5.9.0/build/lib.linux-x86_64-3.9/psutil/_pslinux.py", line 2133, in ionice_set > return cext.proc_ioprio_set(self.pid, ioclass, value) > ProcessLookupError: [Errno 3] No such process > > During handling of the above exception, another exception occurred: > > Traceback (most recent call last): > File "/home/abuild/rpmbuild/BUILD/psutil-5.9.0/psutil/tests/test_process.py", line 1313, in test_zombie_process > succeed_or_zombie_p_exc(fun) > File "/home/abuild/rpmbuild/BUILD/psutil-5.9.0/psutil/tests/test_process.py", line 1288, in succeed_or_zombie_p_exc > return fun() > File "/home/abuild/rpmbuild/BUILD/psutil-5.9.0/build/lib.linux-x86_64-3.9/psutil/__init__.py", line 792, in ionice > return self._proc.ionice_set(ioclass, value) > File "/home/abuild/rpmbuild/BUILD/psutil-5.9.0/build/lib.linux-x86_64-3.9/psutil/_pslinux.py", line 1665, in wrapper > raise NoSuchProcess(self.pid, self._name) > psutil.NoSuchProcess: process no longer exists (pid=2057) > > Cc: Christoph Hellwig > Cc: Jan Kara > Cc: Jens Axboe > Fixes: 5fc11eebb4 (block: open code create_task_io_context in set_task_ioprio) > Fixes: a957b61254 (block: fix error in handling dead task for ioprio setting) > Signed-off-by: Jiri Slaby OK, as much as I find it disputable what ioprio_set() should be doing for PF_EXITTING task, I guess there's no harm in maintaining the old behavior and just ignoring the call. So feel free to add: Reviewed-by: Jan Kara Honza > --- > block/blk-ioc.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/block/blk-ioc.c b/block/blk-ioc.c > index 11f49f78db32..df9cfe4ca532 100644 > --- a/block/blk-ioc.c > +++ b/block/blk-ioc.c > @@ -280,7 +280,6 @@ int set_task_ioprio(struct task_struct *task, int ioprio) > > task_lock(task); > if (task->flags & PF_EXITING) { > - err = -ESRCH; > kmem_cache_free(iocontext_cachep, ioc); > goto out; > } > @@ -292,7 +291,7 @@ int set_task_ioprio(struct task_struct *task, int ioprio) > task->io_context->ioprio = ioprio; > out: > task_unlock(task); > - return err; > + return 0; > } > EXPORT_SYMBOL_GPL(set_task_ioprio); > > -- > 2.35.1 > -- Jan Kara SUSE Labs, CR