From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2BD2EC4167D for ; Mon, 28 Mar 2022 13:47:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243438AbiC1Nsy (ORCPT ); Mon, 28 Mar 2022 09:48:54 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52440 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239926AbiC1Nsw (ORCPT ); Mon, 28 Mar 2022 09:48:52 -0400 Received: from mail-wm1-x32a.google.com (mail-wm1-x32a.google.com [IPv6:2a00:1450:4864:20::32a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 30D9B5EBD4 for ; Mon, 28 Mar 2022 06:47:10 -0700 (PDT) Received: by mail-wm1-x32a.google.com with SMTP id l7-20020a05600c1d0700b0038c99618859so13013004wms.2 for ; Mon, 28 Mar 2022 06:47:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=lqWUovhT3deFfz1zrmG2BdScTmfXFTXlEBWbC7kOkUc=; b=Casp3ieHRH0PsmFMjKH7TFdpT/TNQBYWEewfJb+0xu+uR1ofg9WJFp8XZHfsoJ6hWp C3nRcv1dmEeOPPKeVzOxrD+erWCy3JA6tU8mIHsAGm/8BjsYzwvx7P5mI7L1KmNHeogG 38uNEFuvu5fJtLpThq9lRBZu4UJTQpGAB9zPox6v7iYfXD/Z14PGXT9t5owO2tQYWh0P 3dUo+G/1/czVs79WbHUKkU/6h2niPOopvKPMU5QpP07x/qfD1LrC5Cesac25l5SMzvon esMFddga3HKSH7nNwn2IpXtOjAEGaytpRSosc2jrznnt1TPvUIg3fMjEdTz9d4Vfr7yu igag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=lqWUovhT3deFfz1zrmG2BdScTmfXFTXlEBWbC7kOkUc=; b=vqGDSDigCL+vCxZKJBpIRA37z4/+RdN/HKU8M9XWZ2/WUWppWRGAjn6RixKLtVeqc7 rHHzSi0JIXPMGbGo+XWc3DlMK+APAj/eOqKo+YuqKjCovwmNNYIy6VnkfZjPg4t1IZzV s9dY3K1GHAHQ8LR8N+V0zt/3KlZEHiAjZ2L23pSzDGUeBo/UNjlYTujSOmIDfyT54Eei gSw3CXq360oFsgBEr7knpU3wUrtpOc1ACtJaHMasxZaWQTbj/Lz2f+pJtNH4VRp/ibb8 sfkrTSU71rrxYEOwWfajlcUGVreILoOnVdMiag7x2WiqpZwlOpYimFjNlbYT7TmWcz5A WmRA== X-Gm-Message-State: AOAM530z88YZS6hlPXgUycnjIAcNwC22DVDDWwbOICpNjjAP5EUwOxST svJdJINy/GvzGC0K3uG6TYI4gg== X-Google-Smtp-Source: ABdhPJwB0pYnLloiCs6wa/2INWNx44L+qT5u6Nb9H+6gXgQ9TsmBu3vjwmvbBF2kaoxeBO0KJ0MWbQ== X-Received: by 2002:a05:600c:4401:b0:38c:8df8:9797 with SMTP id u1-20020a05600c440100b0038c8df89797mr35783652wmn.13.1648475228582; Mon, 28 Mar 2022 06:47:08 -0700 (PDT) Received: from maple.lan (cpc141216-aztw34-2-0-cust174.18-1.cable.virginm.net. [80.7.220.175]) by smtp.gmail.com with ESMTPSA id t4-20020a05600001c400b00203fb5dcf29sm12145898wrx.40.2022.03.28.06.47.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 28 Mar 2022 06:47:08 -0700 (PDT) Date: Mon, 28 Mar 2022 14:47:05 +0100 From: Daniel Thompson To: Benjamin =?utf-8?B?U3TDvHJ6?= Cc: sebastian.hesselbarth@gmail.com, gregory.clement@bootlin.com, linux@armlinux.org.uk, linux@simtec.co.uk, krzk@kernel.org, alim.akhtar@samsung.com, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com, hpa@zytor.com, robert.moore@intel.com, rafael.j.wysocki@intel.com, lenb@kernel.org, 3chas3@gmail.com, laforge@gnumonks.org, arnd@arndb.de, gregkh@linuxfoundation.org, mchehab@kernel.org, tony.luck@intel.com, james.morse@arm.com, rric@kernel.org, linus.walleij@linaro.org, brgl@bgdev.pl, mike.marciniszyn@cornelisnetworks.com, dennis.dalessandro@cornelisnetworks.com, jgg@ziepe.ca, pali@kernel.org, dmitry.torokhov@gmail.com, isdn@linux-pingi.de, benh@kernel.crashing.org, fbarrat@linux.ibm.com, ajd@linux.ibm.com, davem@davemloft.net, kuba@kernel.org, pabeni@redhat.com, nico@fluxnic.net, loic.poulain@linaro.org, kvalo@kernel.org, pkshih@realtek.com, bhelgaas@google.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-ia64@vger.kernel.org, linux-acpi@vger.kernel.org, devel@acpica.org, linux-atm-general@lists.sourceforge.net, netdev@vger.kernel.org, linux-edac@vger.kernel.org, linux-gpio@vger.kernel.org, linux-rdma@vger.kernel.org, linux-input@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-media@vger.kernel.org, wcn36xx@lists.infradead.org, linux-wireless@vger.kernel.org, linux-pci@vger.kernel.org Subject: Re: [PATCH 00/22] Replace comments with C99 initializers Message-ID: <20220328134705.lnxwwznhw622r2pr@maple.lan> References: <20220326165909.506926-1-benni@stuerz.xyz> <8f9271b6-0381-70a9-f0c2-595b2235866a@stuerz.xyz> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <8f9271b6-0381-70a9-f0c2-595b2235866a@stuerz.xyz> Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On Sun, Mar 27, 2022 at 02:46:00PM +0200, Benjamin Stürz wrote: > This patch series replaces comments with C99's designated initializers > in a few places. It also adds some enum initializers. This is my first > time contributing to the Linux kernel, therefore I'm probably doing a > lot of things the wrong way. I'm sorry for that. Welcome! > I've gotten a few emails so far stating that this patch series is > unnecessary. Yes, in fact this patch series is not necessary by itself, > but it could help me understand how the whole process works and maybe I > could help somewhere, where help is actually needed. Have you been told the series is unnecessary or too big? Although all patches represent a variant of the same mechanical transformation but they are mostly unrelated to each other and, if accepted, they will be applied by many different people. Taken as a whole presenting this to maintainers as a 22 patch set is too big. I'd recommend starting with a smaller patch or patch series where all the patches get picked up by the same maintainer. > This patch itself is a no-op. PATCH 0/XX is for the covering letter. You should generate a template for it using the --cover-letter option of git format-patch. That way patch 0 will contain the diffstat for the whole series (which is often useful to help understand what the series is for) and there is no need to make no-op changes. Daniel. > > Signed-off-by: Benjamin Stürz > --- > .gitignore | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/.gitignore b/.gitignore > index 7afd412dadd2..706f667261eb 100644 > --- a/.gitignore > +++ b/.gitignore > @@ -20,7 +20,7 @@ > *.dtb > *.dtbo > *.dtb.S > -*.dwo > +*.dwo > *.elf > *.gcno > *.gz > -- > 2.35.1 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 647B6C433EF for ; Mon, 28 Mar 2022 13:47:53 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4KRvCW46mKz3c5Q for ; Tue, 29 Mar 2022 00:47:51 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=Casp3ieH; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=linaro.org (client-ip=2a00:1450:4864:20::32c; helo=mail-wm1-x32c.google.com; envelope-from=daniel.thompson@linaro.org; receiver=) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=Casp3ieH; dkim-atps=neutral Received: from mail-wm1-x32c.google.com (mail-wm1-x32c.google.com [IPv6:2a00:1450:4864:20::32c]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4KRvBp6q9gz3073 for ; Tue, 29 Mar 2022 00:47:12 +1100 (AEDT) Received: by mail-wm1-x32c.google.com with SMTP id 10-20020a1c020a000000b0038d043aac51so256247wmc.0 for ; Mon, 28 Mar 2022 06:47:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=lqWUovhT3deFfz1zrmG2BdScTmfXFTXlEBWbC7kOkUc=; b=Casp3ieHRH0PsmFMjKH7TFdpT/TNQBYWEewfJb+0xu+uR1ofg9WJFp8XZHfsoJ6hWp C3nRcv1dmEeOPPKeVzOxrD+erWCy3JA6tU8mIHsAGm/8BjsYzwvx7P5mI7L1KmNHeogG 38uNEFuvu5fJtLpThq9lRBZu4UJTQpGAB9zPox6v7iYfXD/Z14PGXT9t5owO2tQYWh0P 3dUo+G/1/czVs79WbHUKkU/6h2niPOopvKPMU5QpP07x/qfD1LrC5Cesac25l5SMzvon esMFddga3HKSH7nNwn2IpXtOjAEGaytpRSosc2jrznnt1TPvUIg3fMjEdTz9d4Vfr7yu igag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=lqWUovhT3deFfz1zrmG2BdScTmfXFTXlEBWbC7kOkUc=; b=0etZ7h8U/6+exPrZzJZpNrk2qwPjKmvuCEGOSwXVeZh9j7dNwFhc+2gJy6gD42C7AS xam/1jKSOgWT31K7gC9O9lPl2rL5pMMCSzAoHQSclf/w2t99qNJ/DAhiwciTzDmCZlXD dRxMRVna+kCONxLGqoUOpFrrtWtB9/f/XERLpdNEa10RlbLnv7uh/Z6cvdVBtjzNA8wp 2TZkdl2f6BWyQFCTs4aGUJROVDd7MRTm5QtwE9AY/NRRxS/IP2p5IGBqOClrx/OsHlCu HAmFQYj4AqG8Fe0Wd4QWu+KbYoVI5//umQxm2dF8oKU7CUSO3i2xP/FqCm8cBniEAj+t wQng== X-Gm-Message-State: AOAM530+B3eXpqg5IggjmvawcngslfSxjc0Tg+fvp4Cc1GyYBLqzgmEh am+TiHpr1WOs3h9UDMyNqmX2hA== X-Google-Smtp-Source: ABdhPJwB0pYnLloiCs6wa/2INWNx44L+qT5u6Nb9H+6gXgQ9TsmBu3vjwmvbBF2kaoxeBO0KJ0MWbQ== X-Received: by 2002:a05:600c:4401:b0:38c:8df8:9797 with SMTP id u1-20020a05600c440100b0038c8df89797mr35783652wmn.13.1648475228582; Mon, 28 Mar 2022 06:47:08 -0700 (PDT) Received: from maple.lan (cpc141216-aztw34-2-0-cust174.18-1.cable.virginm.net. [80.7.220.175]) by smtp.gmail.com with ESMTPSA id t4-20020a05600001c400b00203fb5dcf29sm12145898wrx.40.2022.03.28.06.47.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 28 Mar 2022 06:47:08 -0700 (PDT) Date: Mon, 28 Mar 2022 14:47:05 +0100 From: Daniel Thompson To: Benjamin =?utf-8?B?U3TDvHJ6?= Subject: Re: [PATCH 00/22] Replace comments with C99 initializers Message-ID: <20220328134705.lnxwwznhw622r2pr@maple.lan> References: <20220326165909.506926-1-benni@stuerz.xyz> <8f9271b6-0381-70a9-f0c2-595b2235866a@stuerz.xyz> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <8f9271b6-0381-70a9-f0c2-595b2235866a@stuerz.xyz> X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-atm-general@lists.sourceforge.net, linux-ia64@vger.kernel.org, linus.walleij@linaro.org, dave.hansen@linux.intel.com, linux-pci@vger.kernel.org, robert.moore@intel.com, laforge@gnumonks.org, alim.akhtar@samsung.com, hpa@zytor.com, wcn36xx@lists.infradead.org, pkshih@realtek.com, linux-samsung-soc@vger.kernel.org, linux-acpi@vger.kernel.org, linux-edac@vger.kernel.org, dennis.dalessandro@cornelisnetworks.com, linux-rdma@vger.kernel.org, gregory.clement@bootlin.com, rafael.j.wysocki@intel.com, linux@armlinux.org.uk, krzk@kernel.org, jgg@ziepe.ca, mingo@redhat.com, 3chas3@gmail.com, linux-input@vger.kernel.org, kuba@kernel.org, pabeni@redhat.com, lenb@kernel.org, mike.marciniszyn@cornelisnetworks.com, rric@kernel.org, ajd@linux.ibm.com, arnd@arndb.de, kvalo@kernel.org, linuxppc-dev@lists.ozlabs.org, linux-gpio@vger.kernel.org, loic.poulain@linaro.org, bp@alien8.de, bhelgaas@google.com, tglx@linutronix.de, mchehab@kernel.org, linux-media@vger.kernel.org, linux@simtec.co.uk, linux-arm-kernel@lists.infradead.org, devel@acpica.org, isdn@linux-pingi.de, tony.luck@intel.com, nico@fluxnic.net, gregkh@linuxfoundation.org, dmitry.torokhov@gmail.com, linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org, davem@davemloft.net, james.morse@arm.com, netdev@vger.kernel.org, fbarrat@linux.ibm.com, sebastian.hesselbarth@gmail.com, pali@kernel.org, brgl@bgdev.pl Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Sun, Mar 27, 2022 at 02:46:00PM +0200, Benjamin Stürz wrote: > This patch series replaces comments with C99's designated initializers > in a few places. It also adds some enum initializers. This is my first > time contributing to the Linux kernel, therefore I'm probably doing a > lot of things the wrong way. I'm sorry for that. Welcome! > I've gotten a few emails so far stating that this patch series is > unnecessary. Yes, in fact this patch series is not necessary by itself, > but it could help me understand how the whole process works and maybe I > could help somewhere, where help is actually needed. Have you been told the series is unnecessary or too big? Although all patches represent a variant of the same mechanical transformation but they are mostly unrelated to each other and, if accepted, they will be applied by many different people. Taken as a whole presenting this to maintainers as a 22 patch set is too big. I'd recommend starting with a smaller patch or patch series where all the patches get picked up by the same maintainer. > This patch itself is a no-op. PATCH 0/XX is for the covering letter. You should generate a template for it using the --cover-letter option of git format-patch. That way patch 0 will contain the diffstat for the whole series (which is often useful to help understand what the series is for) and there is no need to make no-op changes. Daniel. > > Signed-off-by: Benjamin Stürz > --- > .gitignore | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/.gitignore b/.gitignore > index 7afd412dadd2..706f667261eb 100644 > --- a/.gitignore > +++ b/.gitignore > @@ -20,7 +20,7 @@ > *.dtb > *.dtbo > *.dtb.S > -*.dwo > +*.dwo > *.elf > *.gcno > *.gz > -- > 2.35.1 From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Thompson Date: Mon, 28 Mar 2022 13:47:05 +0000 Subject: Re: [PATCH 00/22] Replace comments with C99 initializers Message-Id: <20220328134705.lnxwwznhw622r2pr@maple.lan> List-Id: References: <20220326165909.506926-1-benni@stuerz.xyz> <8f9271b6-0381-70a9-f0c2-595b2235866a@stuerz.xyz> In-Reply-To: <8f9271b6-0381-70a9-f0c2-595b2235866a@stuerz.xyz> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable To: Benjamin =?utf-8?B?U3TDvHJ6?= Cc: sebastian.hesselbarth@gmail.com, gregory.clement@bootlin.com, linux@armlinux.org.uk, linux@simtec.co.uk, krzk@kernel.org, alim.akhtar@samsung.com, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com, hpa@zytor.com, robert.moore@intel.com, rafael.j.wysocki@intel.com, lenb@kernel.org, 3chas3@gmail.com, laforge@gnumonks.org, arnd@arndb.de, gregkh@linuxfoundation.org, mchehab@kernel.org, tony.luck@intel.com, james.morse@arm.com, rric@kernel.org, linus.walleij@linaro.org, brgl@bgdev.pl, mike.marciniszyn@cornelisnetworks.com, dennis.dalessandro@cornelisnetworks.com, jgg@ziepe.ca, pali@kernel.org, dmitry.torokhov@gmail.com, isdn@linux-pingi.de, benh@kernel.crashing.org, fbarrat@linux.ibm.com, ajd@linux.ibm.com, davem@davemloft.net, kuba@kernel.org, pabeni@redhat.com, nico@fluxnic.net, loic.poulain@linaro.org, kvalo@kernel.org, pkshih@realtek.com, bhelgaas@google.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-ia64@vger.kernel.org, linux-acpi@vger.kernel.org, devel@acpica.org, linux-atm-general@lists.sourceforge.net, netdev@vger.kernel.org, linux-edac@vger.kernel.org, linux-gpio@vger.kernel.org, linux-rdma@vger.kernel.org, linux-input@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-media@vger.kernel.org, wcn36xx@lists.infradead.org, linux-wireless@vger.kernel.org, linux-pci@vger.kernel.org On Sun, Mar 27, 2022 at 02:46:00PM +0200, Benjamin St=FCrz wrote: > This patch series replaces comments with C99's designated initializers > in a few places. It also adds some enum initializers. This is my first > time contributing to the Linux kernel, therefore I'm probably doing a > lot of things the wrong way. I'm sorry for that. Welcome! > I've gotten a few emails so far stating that this patch series is > unnecessary. Yes, in fact this patch series is not necessary by itself, > but it could help me understand how the whole process works and maybe I > could help somewhere, where help is actually needed. Have you been told the series is unnecessary or too big? Although all patches represent a variant of the same mechanical transformation but they are mostly unrelated to each other and, if accepted, they will be applied by many different people. Taken as a whole presenting this to maintainers as a 22 patch set is too big. I'd recommend starting with a smaller patch or patch series where all the patches get picked up by the same maintainer. > This patch itself is a no-op. PATCH 0/XX is for the covering letter. You should generate a template for it using the --cover-letter option of git format-patch. That way patch 0 will contain the diffstat for the whole series (which is often useful to help understand what the series is for) and there is no need to make no-op changes. Daniel. >=20 > Signed-off-by: Benjamin St=FCrz > --- > .gitignore | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/.gitignore b/.gitignore > index 7afd412dadd2..706f667261eb 100644 > --- a/.gitignore > +++ b/.gitignore > @@ -20,7 +20,7 @@ > *.dtb > *.dtbo > *.dtb.S > -*.dwo > +*.dwo > *.elf > *.gcno > *.gz > --=20 > 2.35.1