From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B0655C433EF for ; Mon, 28 Mar 2022 19:49:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244552AbiC1Tv0 (ORCPT ); Mon, 28 Mar 2022 15:51:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51218 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1344067AbiC1TsI (ORCPT ); Mon, 28 Mar 2022 15:48:08 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3B31F6A017; Mon, 28 Mar 2022 12:43:52 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id AD40AB81213; Mon, 28 Mar 2022 19:43:39 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 61E19C3410F; Mon, 28 Mar 2022 19:43:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1648496618; bh=JDgnhN3MSlCM+3tBS3nKBXEXX80jRKTZVSXwNmSC/NM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=esJcMItHETTRiJzns4eLzvRTSMUURLZCx3Rp0Vk3yGt5ISePtb8MYrTDhXYkfJYP8 XGUNwH+TS6LtFJQG8NWp89t06iLVRO8VIH0T7/K6klJPDPZEUT+L3zFaZJOGRCeQqX r/ANWe57VKhr0QEWC3wRoLCPhbDSPD5HgFbjQwbx74cYG/6PttgmFptKKTQzLINWjM QpdnU+S1FPTGBqDoAq5OGlBo7AVFa8v5eOlA/g2rrmgTeomUQO07P5Jd2RTIebJ3rQ To0LpkKtqnREwYYwbJh+YTi1GIexk1h1k1QWdrUSEtBMI5egJ7vAlikkSP1KxCtC2l jxijX3fj6r27Q== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Dongliang Mu , syzbot+3c765c5248797356edaa@syzkaller.appspotmail.com, Anton Altaparmakov , Andrew Morton , Linus Torvalds , Sasha Levin , linux-ntfs-dev@lists.sourceforge.net Subject: [PATCH AUTOSEL 5.4 2/2] ntfs: add sanity check on allocation size Date: Mon, 28 Mar 2022 15:43:33 -0400 Message-Id: <20220328194334.1586542-2-sashal@kernel.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220328194334.1586542-1-sashal@kernel.org> References: <20220328194334.1586542-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Dongliang Mu [ Upstream commit 714fbf2647b1a33d914edd695d4da92029c7e7c0 ] ntfs_read_inode_mount invokes ntfs_malloc_nofs with zero allocation size. It triggers one BUG in the __ntfs_malloc function. Fix this by adding sanity check on ni->attr_list_size. Link: https://lkml.kernel.org/r/20220120094914.47736-1-dzm91@hust.edu.cn Reported-by: syzbot+3c765c5248797356edaa@syzkaller.appspotmail.com Signed-off-by: Dongliang Mu Acked-by: Anton Altaparmakov Signed-off-by: Andrew Morton Signed-off-by: Linus Torvalds Signed-off-by: Sasha Levin --- fs/ntfs/inode.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/fs/ntfs/inode.c b/fs/ntfs/inode.c index ea18e4a2a691..cf222c9225d6 100644 --- a/fs/ntfs/inode.c +++ b/fs/ntfs/inode.c @@ -1881,6 +1881,10 @@ int ntfs_read_inode_mount(struct inode *vi) } /* Now allocate memory for the attribute list. */ ni->attr_list_size = (u32)ntfs_attr_size(a); + if (!ni->attr_list_size) { + ntfs_error(sb, "Attr_list_size is zero"); + goto put_err_out; + } ni->attr_list = ntfs_malloc_nofs(ni->attr_list_size); if (!ni->attr_list) { ntfs_error(sb, "Not enough memory to allocate buffer " -- 2.34.1