All of lore.kernel.org
 help / color / mirror / Atom feed
From: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
To: intel-gfx@lists.freedesktop.org
Cc: alexander.usyskin@intel.com
Subject: [Intel-gfx] [CI 5/6] mei: gsc: retrieve the firmware version
Date: Mon, 28 Mar 2022 14:53:57 -0700	[thread overview]
Message-ID: <20220328215358.2866707-6-daniele.ceraolospurio@intel.com> (raw)
In-Reply-To: <20220328215358.2866707-1-daniele.ceraolospurio@intel.com>

From: Alexander Usyskin <alexander.usyskin@intel.com>

Add a hook to retrieve the firmware version of the
GSC devices to bus-fixup.
GSC has a different MKHI clients GUIDs but the same message structure
to retrieve the firmware version as MEI so mei_fwver() can be reused.

CC: Ashutosh Dixit <ashutosh.dixit@intel.com>
Signed-off-by: Alexander Usyskin <alexander.usyskin@intel.com>
Signed-off-by: Tomas Winkler <tomas.winkler@intel.com>
Reviewed-by: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
---
 drivers/misc/mei/bus-fixup.c | 25 +++++++++++++++++++++++++
 drivers/misc/mei/hw-me.c     |  2 ++
 2 files changed, 27 insertions(+)

diff --git a/drivers/misc/mei/bus-fixup.c b/drivers/misc/mei/bus-fixup.c
index 67844089db216..59506ba6fc48f 100644
--- a/drivers/misc/mei/bus-fixup.c
+++ b/drivers/misc/mei/bus-fixup.c
@@ -30,6 +30,12 @@ static const uuid_le mei_nfc_info_guid = MEI_UUID_NFC_INFO;
 #define MEI_UUID_MKHIF_FIX UUID_LE(0x55213584, 0x9a29, 0x4916, \
 			0xba, 0xdf, 0xf, 0xb7, 0xed, 0x68, 0x2a, 0xeb)
 
+#define MEI_UUID_IGSC_MKHI UUID_LE(0xE2C2AFA2, 0x3817, 0x4D19, \
+			0x9D, 0x95, 0x06, 0xB1, 0x6B, 0x58, 0x8A, 0x5D)
+
+#define MEI_UUID_IGSC_MKHI_FIX UUID_LE(0x46E0C1FB, 0xA546, 0x414F, \
+			0x91, 0x70, 0xB7, 0xF4, 0x6D, 0x57, 0xB4, 0xAD)
+
 #define MEI_UUID_HDCP UUID_LE(0xB638AB7E, 0x94E2, 0x4EA2, \
 			      0xA5, 0x52, 0xD1, 0xC5, 0x4B, 0x62, 0x7F, 0x04)
 
@@ -241,6 +247,23 @@ static void mei_mkhi_fix(struct mei_cl_device *cldev)
 	mei_cldev_disable(cldev);
 }
 
+static void mei_gsc_mkhi_ver(struct mei_cl_device *cldev)
+{
+	int ret;
+
+	/* No need to enable the client if nothing is needed from it */
+	if (!cldev->bus->fw_f_fw_ver_supported)
+		return;
+
+	ret = mei_cldev_enable(cldev);
+	if (ret)
+		return;
+
+	ret = mei_fwver(cldev);
+	if (ret < 0)
+		dev_err(&cldev->dev, "FW version command failed %d\n", ret);
+	mei_cldev_disable(cldev);
+}
 /**
  * mei_wd - wd client on the bus, change protocol version
  *   as the API has changed.
@@ -492,6 +515,8 @@ static struct mei_fixup {
 	MEI_FIXUP(MEI_UUID_NFC_HCI, mei_nfc),
 	MEI_FIXUP(MEI_UUID_WD, mei_wd),
 	MEI_FIXUP(MEI_UUID_MKHIF_FIX, mei_mkhi_fix),
+	MEI_FIXUP(MEI_UUID_IGSC_MKHI, mei_gsc_mkhi_ver),
+	MEI_FIXUP(MEI_UUID_IGSC_MKHI_FIX, mei_gsc_mkhi_ver),
 	MEI_FIXUP(MEI_UUID_HDCP, whitelist),
 	MEI_FIXUP(MEI_UUID_ANY, vt_support),
 	MEI_FIXUP(MEI_UUID_PAVP, whitelist),
diff --git a/drivers/misc/mei/hw-me.c b/drivers/misc/mei/hw-me.c
index 9748d14849a13..7e77328142ff1 100644
--- a/drivers/misc/mei/hw-me.c
+++ b/drivers/misc/mei/hw-me.c
@@ -1577,12 +1577,14 @@ static const struct mei_cfg mei_me_pch15_sps_cfg = {
 static const struct mei_cfg mei_me_gsc_cfg = {
 	MEI_CFG_TYPE_GSC,
 	MEI_CFG_PCH8_HFS,
+	MEI_CFG_FW_VER_SUPP,
 };
 
 /* Graphics System Controller Firmware Interface */
 static const struct mei_cfg mei_me_gscfi_cfg = {
 	MEI_CFG_TYPE_GSCFI,
 	MEI_CFG_PCH8_HFS,
+	MEI_CFG_FW_VER_SUPP,
 };
 
 /*
-- 
2.25.1


  parent reply	other threads:[~2022-03-28 21:59 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-28 21:53 [Intel-gfx] [CI 0/6] Add driver for GSC controller Daniele Ceraolo Spurio
2022-03-28 21:53 ` [Intel-gfx] [CI 1/6] drm/i915/gsc: add gsc as a mei auxiliary device Daniele Ceraolo Spurio
2022-03-28 21:53 ` [Intel-gfx] [CI 2/6] mei: add support for graphics system controller (gsc) devices Daniele Ceraolo Spurio
2022-03-28 21:53 ` [Intel-gfx] [CI 3/6] mei: gsc: setup char driver alive in spite of firmware handshake failure Daniele Ceraolo Spurio
2022-03-28 21:53 ` [Intel-gfx] [CI 4/6] mei: gsc: add runtime pm handlers Daniele Ceraolo Spurio
2022-03-28 21:53 ` Daniele Ceraolo Spurio [this message]
2022-03-28 21:53 ` [Intel-gfx] [CI 6/6] HAX: drm/i915: force INTEL_MEI_GSC on for CI Daniele Ceraolo Spurio
2022-03-29  1:57 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Add driver for GSC controller (rev12) Patchwork
2022-03-29  1:58 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork
2022-03-29  2:02 ` [Intel-gfx] ✗ Fi.CI.DOCS: " Patchwork
2022-03-29  2:20 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2022-03-29  5:01 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
2022-03-29 17:16 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Add driver for GSC controller (rev13) Patchwork
2022-03-29 17:18 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork
2022-03-29 17:22 ` [Intel-gfx] ✗ Fi.CI.DOCS: " Patchwork
2022-03-29 17:48 ` [Intel-gfx] ✗ Fi.CI.BAT: failure " Patchwork
2022-03-30 20:53 [Intel-gfx] [CI 0/6] Add driver for GSC controller Daniele Ceraolo Spurio
2022-03-30 20:53 ` [Intel-gfx] [CI 5/6] mei: gsc: retrieve the firmware version Daniele Ceraolo Spurio
2022-04-04 18:17 [Intel-gfx] [CI 0/6] GSC support Daniele Ceraolo Spurio
2022-04-04 18:17 ` [Intel-gfx] [CI 5/6] mei: gsc: retrieve the firmware version Daniele Ceraolo Spurio

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220328215358.2866707-6-daniele.ceraolospurio@intel.com \
    --to=daniele.ceraolospurio@intel.com \
    --cc=alexander.usyskin@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.