From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id F1F7CC433EF for ; Mon, 28 Mar 2022 21:51:41 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id CF53E83F8D; Mon, 28 Mar 2022 23:51:39 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=kernel.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.b="EOFPu9Df"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 5310183FAE; Mon, 28 Mar 2022 23:51:38 +0200 (CEST) Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id F0D7683F8D for ; Mon, 28 Mar 2022 23:51:35 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=kernel.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=kabel@kernel.org Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 4EF416152F; Mon, 28 Mar 2022 21:51:34 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id BD5F6C340ED; Mon, 28 Mar 2022 21:51:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1648504293; bh=rg5Ua3LPz26Xmv3Bpg+QRXB+esvA5/4ChsDQSWydXU0=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=EOFPu9DfQw0pKo2ZNmqAyL14+BU4ccVQt3Kl3em7IHaOwpK1R9CUj+CqPnOegDhIt RTfNa/FszEwIDp8SbqV0EAJSAisaTmR6IQtdFaJ/poIjoKzdYdJLEriWYPI9Ty1yoB n8zUrKmB4UJX6xpi7jGgFCidswo+mpoBI3Ykn2X/57iPUJ1n6+Wldphbx4UGX1lQko LbFoG+JvQ4Vi6I2Gy7kNt4hh5En6Dq1Yq159wPOg8BxTJIx2dAkSTlK96SlU31a+EM kZnDj1qbUxM2XN6KFvlJoguXIFj5XmkhfLRvaODaGIHdtrQGPEhvX6xxKnaDX1Be8s JAj0W60XOwj0w== Date: Mon, 28 Mar 2022 23:51:23 +0200 From: Marek =?UTF-8?B?QmVow7pu?= To: Simon Glass Cc: Joe Hershberger , Ramon Fried , U-Boot Mailing List , Marek =?UTF-8?B?QmVow7pu?= , Bin Meng , Chen Guanqiao , Dario Binacchi , Jagan Teki , Kishon Vijay Abraham I , Leo Yu-Chi Liang , Lokesh Vutla , Michael Walle , Miquel Raynal , Patrick Delaunay , Priyanka Jain , Vladimir Oltean Subject: Re: [PATCH u-boot-net 03/14] net: introduce helpers to get PHY ofnode from MAC Message-ID: <20220328235123.5bd7391d@thinkpad> In-Reply-To: References: <20220317124958.27921-1-kabel@kernel.org> <20220317124958.27921-4-kabel@kernel.org> X-Mailer: Claws Mail 3.18.0 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean On Mon, 28 Mar 2022 00:35:00 -0600 Simon Glass wrote: > Hi Marek, >=20 > On Thu, 17 Mar 2022 at 06:50, Marek Beh=C3=BAn wrote: > > > > From: Marek Beh=C3=BAn > > > > Add helpers ofnode_get_phy_node() and dev_get_phy_node() and use it in > > net/mdio-uclass.c function dm_eth_connect_phy_handle(). > > > > This is useful because other part's of U-Boot may want to get PHY ofnode > > without connecting a PHY. > > > > Signed-off-by: Marek Beh=C3=BAn > > --- > > drivers/core/ofnode.c | 21 +++++++++++++++++++++ > > drivers/core/read.c | 5 +++++ > > include/dm/ofnode.h | 14 ++++++++++++++ > > include/dm/read.h | 19 +++++++++++++++++++ > > net/mdio-uclass.c | 24 ++++++------------------ > > 5 files changed, 65 insertions(+), 18 deletions(-) =20 >=20 > Please add a test for your new function. With that: >=20 > Reviewed-by: Simon Glass Dear Simon, OK, I added test for ofnode_get_phy_node(). Should I also add one for dev_get_phy_node() ? That one is implemented in drivers/core/read.c or include/dm/read.h, and it just calls ofnode_get_phy_node()... Also adding test for ofnode_get_phy_mode() (node -> mode) which is implemented in patch 07/14. Can I add your reviewde-by for that patch also? That patch is rather big, touches many files treewide... Marek