All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Sterba <dsterba@suse.cz>
To: Qu Wenruo <quwenruo.btrfs@gmx.com>
Cc: Matt Corallo <blnxfsl@bluematt.me>,
	Btrfs BTRFS <linux-btrfs@vger.kernel.org>
Subject: Re: [5.16.14] csum mismatch on free space cache on subpage
Date: Tue, 29 Mar 2022 14:58:38 +0200	[thread overview]
Message-ID: <20220329125838.GX2237@twin.jikos.cz> (raw)
In-Reply-To: <9e32aa01-c712-1def-6d54-1db450fd2750@gmx.com>

On Tue, Mar 29, 2022 at 01:57:18PM +0800, Qu Wenruo wrote:
> 
> 
> On 2022/3/29 05:18, Matt Corallo wrote:
> > Basically what the subject says. Any time I mount an fs on my 64K-page
> > PPC host mount a 4K-page device (so far two-of-two - once a flash drive
> > with mirror and nothing else, once a many-TB volume across multiple
> > disks) I see a stream of csum mismatches in the space cache in dmesg.
> > The FS' otherwise seem to work.
> >
> > Matt
> 
> Oh, so you're using the subpage feature recently introduced, awesome!
> 
> But it looks like there are still some v1 cache code using hardcoded
> PAGE_SIZE instead of sectorsize, thus it's reporting the problem.
> 
> You're completely fine to continue using the fs, as such PAGE_SIZE usage
> will invalidate all old cache, thus there is no chance of corruption.
> 
> Or you can convert to v2 cache as a workaround.
> 
> I'll need to investigate some time for this fix.

We can mandate free space tree for subpage, don't try to fix the v1 code
as it's going to be deleted in a year timeframe anyway.

  reply	other threads:[~2022-03-29 13:02 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-28 21:18 [5.16.14] csum mismatch on free space cache on subpage Matt Corallo
2022-03-29  5:57 ` Qu Wenruo
2022-03-29 12:58   ` David Sterba [this message]
2022-03-29 16:02   ` Matt Corallo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220329125838.GX2237@twin.jikos.cz \
    --to=dsterba@suse.cz \
    --cc=blnxfsl@bluematt.me \
    --cc=linux-btrfs@vger.kernel.org \
    --cc=quwenruo.btrfs@gmx.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.