[virtio-comment] [PATCH v2] vsock: add documentation about len header field

[virtio-comment] [PATCH v2] vsock: add documentation about len header field

[Laura Loghin]

Signed-off-by: Laura Loghin <lauralg@amazon.com>
---
 virtio-vsock.tex | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/virtio-vsock.tex b/virtio-vsock.tex
index d79984d..26855d3 100644
--- a/virtio-vsock.tex
+++ b/virtio-vsock.tex
@@ -107,6 +107,10 @@ \subsection{Device Operation}\label{sec:Device Types / Socket Device / Device Op
 #define VIRTIO_VSOCK_OP_CREDIT_REQUEST 7
 \end{lstlisting}
 
+\field{len} is the size of the payload, in bytes. However, the driver may
+provide buffer(s) for the payload that have a total size longer than
+\field{len}.
+
 \subsubsection{Virtqueue Flow Control}\label{sec:Device Types / Socket Device / Device Operation / Virtqueue Flow Control}
 
 The tx virtqueue carries packets initiated by applications and replies to
-- 
2.17.1




Amazon Development Center (Romania) S.R.L. registered office: 27A Sf. Lazar Street, UBC5, floor 2, Iasi, Iasi County, 700045, Romania. Registered in Romania. Registration number J22/2621/2005.


This publicly archived list offers a means to provide input to the
OASIS Virtual I/O Device (VIRTIO) TC.

In order to verify user consent to the Feedback License terms and
to minimize spam in the list archive, subscription is required
before posting.

Subscribe: virtio-comment-subscribe@lists.oasis-open.org
Unsubscribe: virtio-comment-unsubscribe@lists.oasis-open.org
List help: virtio-comment-help@lists.oasis-open.org
List archive: https://lists.oasis-open.org/archives/virtio-comment/
Feedback License: https://www.oasis-open.org/who/ipr/feedback_license.pdf
List Guidelines: https://www.oasis-open.org/policies-guidelines/mailing-lists
Committee: https://www.oasis-open.org/committees/virtio/
Join OASIS: https://www.oasis-open.org/join/

Re: [virtio-comment] [PATCH v2] vsock: add documentation about len header field

[Stefano Garzarella]

On Tue, Mar 29, 2022 at 06:01:04PM +0300, Laura Loghin wrote:
>Signed-off-by: Laura Loghin <lauralg@amazon.com>
>---
> virtio-vsock.tex | 4 ++++
> 1 file changed, 4 insertions(+)

Reviewed-by: Stefano Garzarella <sgarzare@redhat.com>

>
>diff --git a/virtio-vsock.tex b/virtio-vsock.tex
>index d79984d..26855d3 100644
>--- a/virtio-vsock.tex
>+++ b/virtio-vsock.tex
>@@ -107,6 +107,10 @@ \subsection{Device Operation}\label{sec:Device Types / Socket Device / Device Op
> #define VIRTIO_VSOCK_OP_CREDIT_REQUEST 7
> \end{lstlisting}
>
>+\field{len} is the size of the payload, in bytes. However, the driver may
>+provide buffer(s) for the payload that have a total size longer than
>+\field{len}.
>+
> \subsubsection{Virtqueue Flow Control}\label{sec:Device Types / Socket Device / Device Operation / Virtqueue Flow Control}
>
> The tx virtqueue carries packets initiated by applications and replies to
>-- 
>2.17.1
>
>
>
>
>Amazon Development Center (Romania) S.R.L. registered office: 27A Sf. Lazar Street, UBC5, floor 2, Iasi, Iasi County, 700045, Romania. Registered in Romania. Registration number J22/2621/2005.
>
>
>This publicly archived list offers a means to provide input to the
>OASIS Virtual I/O Device (VIRTIO) TC.
>
>In order to verify user consent to the Feedback License terms and
>to minimize spam in the list archive, subscription is required
>before posting.
>
>Subscribe: virtio-comment-subscribe@lists.oasis-open.org
>Unsubscribe: virtio-comment-unsubscribe@lists.oasis-open.org
>List help: virtio-comment-help@lists.oasis-open.org
>List archive: https://lists.oasis-open.org/archives/virtio-comment/
>Feedback License: https://www.oasis-open.org/who/ipr/feedback_license.pdf
>List Guidelines: https://www.oasis-open.org/policies-guidelines/mailing-lists
>Committee: https://www.oasis-open.org/committees/virtio/
>Join OASIS: https://www.oasis-open.org/join/
>


This publicly archived list offers a means to provide input to the
OASIS Virtual I/O Device (VIRTIO) TC.

In order to verify user consent to the Feedback License terms and
to minimize spam in the list archive, subscription is required
before posting.

Subscribe: virtio-comment-subscribe@lists.oasis-open.org
Unsubscribe: virtio-comment-unsubscribe@lists.oasis-open.org
List help: virtio-comment-help@lists.oasis-open.org
List archive: https://lists.oasis-open.org/archives/virtio-comment/
Feedback License: https://www.oasis-open.org/who/ipr/feedback_license.pdf
List Guidelines: https://www.oasis-open.org/policies-guidelines/mailing-lists
Committee: https://www.oasis-open.org/committees/virtio/
Join OASIS: https://www.oasis-open.org/join/

Re: [virtio-comment] [PATCH v2] vsock: add documentation about len header field

[Stefan Hajnoczi]

[-- Attachment #1: Type: text/plain, Size: 518 bytes --]

On Thu, Mar 31, 2022 at 09:14:39AM +0200, Stefano Garzarella wrote:
> On Tue, Mar 29, 2022 at 06:01:04PM +0300, Laura Loghin wrote:
> > Signed-off-by: Laura Loghin <lauralg@amazon.com>
> > ---
> > virtio-vsock.tex | 4 ++++
> > 1 file changed, 4 insertions(+)
> 
> Reviewed-by: Stefano Garzarella <sgarzare@redhat.com>

Hi Laura,
Please see
https://github.com/oasis-tcs/virtio-spec/#use-of-github-issues for
information on how to request a vote so this can be added to the VIRTIO
specification.

Stefan

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: [virtio-comment] [PATCH v2] vsock: add documentation about len header field

[Laura Loghin]

[-- Attachment #1: Type: text/plain, Size: 933 bytes --]

On 4/4/22 13:01, Stefan Hajnoczi wrote:
> On Thu, Mar 31, 2022 at 09:14:39AM +0200, Stefano Garzarella wrote:
>> On Tue, Mar 29, 2022 at 06:01:04PM +0300, Laura Loghin wrote:
>>> Signed-off-by: Laura Loghin<lauralg@amazon.com>
>>> ---
>>> virtio-vsock.tex | 4 ++++
>>> 1 file changed, 4 insertions(+)
>> Reviewed-by: Stefano Garzarella<sgarzare@redhat.com>
> Hi Laura,
> Please see
> https://github.com/oasis-tcs/virtio-spec/#use-of-github-issues  for
> information on how to request a vote so this can be added to the VIRTIO
> specification.
>
> Stefan

Hello,


Thanks for the pointer.

Requesting a vote.
Fixes:https://github.com/oasis-tcs/virtio-spec/issues/137  <https://github.com/oasis-tcs/virtio-spec/issues/136>


Thanks,
Laura



Amazon Development Center (Romania) S.R.L. registered office: 27A Sf. Lazar Street, UBC5, floor 2, Iasi, Iasi County, 700045, Romania. Registered in Romania. Registration number J22/2621/2005.

[-- Attachment #2: Type: text/html, Size: 1850 bytes --]