From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2F18DC433EF for ; Tue, 29 Mar 2022 18:36:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239098AbiC2Sie (ORCPT ); Tue, 29 Mar 2022 14:38:34 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43414 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240603AbiC2Sic (ORCPT ); Tue, 29 Mar 2022 14:38:32 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3D2B4185452 for ; Tue, 29 Mar 2022 11:36:48 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id C301EB817F7 for ; Tue, 29 Mar 2022 18:36:46 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 80391C2BBE4; Tue, 29 Mar 2022 18:36:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1648579005; bh=b9eMg+HdZXnqKiC8V2d+mu03B4Z962oua246cclibqE=; h=In-Reply-To:References:Subject:From:Cc:To:Date:From; b=X0SnTRJxe3SAdljGSG7cFaO4ojkHJmVLUsfKswY2T1VaAb0ZTTUjwjhp66PejsMgB 31LU8H8ZZ8wIcqeOYtsEhuIcDgzEAvdLcN+5U6GGv6YdymflME/nS1cXrzKiKpf+kJ 4CY/POjmDHetMjEQqU+p5kMufIiZZAiJUg8qzcHQqGSwOAuBlXXEFtaQGrtJvhtFGw s2MvihF5Z9OO9epAyGQbNW4AWYNuRCO0gAWQmhvTBEJFz0oG6l5ba002US06r0sbg/ g9Ynu3NZ4Hr7htWXQoyFR0uoX6nyPPcLnt281nkv4K0RSZAAcz0EFtE+XhTd2McLjK 7Oi7b5nquB66g== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable In-Reply-To: <20220325161144.1901695-4-maxime@cerno.tech> References: <20220325161144.1901695-1-maxime@cerno.tech> <20220325161144.1901695-4-maxime@cerno.tech> Subject: Re: [PATCH v2 3/3] clk: Drop the rate range on clk_put From: Stephen Boyd Cc: Dmitry Osipenko , Maxime Ripard To: Maxime Ripard , Mike Turquette , linux-clk@vger.kernel.org Date: Tue, 29 Mar 2022 11:36:43 -0700 User-Agent: alot/0.10 Message-Id: <20220329183645.80391C2BBE4@smtp.kernel.org> Precedence: bulk List-ID: X-Mailing-List: linux-clk@vger.kernel.org Quoting Maxime Ripard (2022-03-25 09:11:44) > While the current code will trigger a new clk_set_rate call whenever the > rate boundaries are changed through clk_set_rate_range, this doesn't > occur when clk_put() is called. >=20 > However, this is essentially equivalent since, after clk_put() > completes, those boundaries won't be enforced anymore. >=20 > Let's add a call to clk_set_rate_range in clk_put to make sure those > rate boundaries are dropped and the clock drivers can react. >=20 > Let's also add a few tests to make sure this case is covered. >=20 > Fixes: c80ac50cbb37 ("clk: Always set the rate on clk_set_range_rate") > Signed-off-by: Maxime Ripard > --- Applied to clk-next