From: Peter Zijlstra <peterz@infradead.org>
To: Tony Luck <tony.luck@intel.com>
Cc: Borislav Petkov <bp@alien8.de>,
x86@kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] x86/cpu: Add a third Alderlake CPU model number
Date: Wed, 30 Mar 2022 15:43:25 +0200 [thread overview]
Message-ID: <20220330134325.GM8939@worktop.programming.kicks-ass.net> (raw)
In-Reply-To: <20220310215652.32025-1-tony.luck@intel.com>
On Thu, Mar 10, 2022 at 01:56:52PM -0800, Tony Luck wrote:
> Existing suffix conventions only cover mobile/desktop/server options.
> But this isn't any of those. Use "_N" as it matches the Intel naming
> convention for this part.
>
> Signed-off-by: Tony Luck <tony.luck@intel.com>
> ---
>
> Peter: What do you think about suffix proliferation? I tried to
> get an answer about the target market segment for this CPU, but
> didn't get an answer that is at all useful.
I'm not loving it, but seeing how they keep making these things into
model numbers (instead of using a different differentiator), there's
little we can do about it :-(
> arch/x86/include/asm/intel-family.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/x86/include/asm/intel-family.h b/arch/x86/include/asm/intel-family.h
> index 048b6d5aff50..2f7b608f3e55 100644
> --- a/arch/x86/include/asm/intel-family.h
> +++ b/arch/x86/include/asm/intel-family.h
> @@ -107,6 +107,7 @@
>
> #define INTEL_FAM6_ALDERLAKE 0x97 /* Golden Cove / Gracemont */
> #define INTEL_FAM6_ALDERLAKE_L 0x9A /* Golden Cove / Gracemont */
> +#define INTEL_FAM6_ALDERLAKE_N 0xBE
This is missing the /* Gracemont */ comment. That is, according to
Google, Alder Lake N is an E core only SKU. So alternatively, we can
call it: INTEL_FAM6_ATOM_GRACEMONT ....
/me runs like heck :-)
> #define INTEL_FAM6_RAPTORLAKE 0xB7
That too is missing the comment, but I can't actually find what it
should be on wikichip so I suppose that's still sekrit or something.
next prev parent reply other threads:[~2022-03-30 13:44 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-10 21:56 [PATCH] x86/cpu: Add a third Alderlake CPU model number Tony Luck
2022-03-30 13:43 ` Peter Zijlstra [this message]
2022-03-30 19:57 ` Luck, Tony
2022-04-11 23:37 ` [PATCH] x86/cpu: Add new Alderlake and Raptorlake CPU model numbers Luck, Tony
2022-04-19 8:56 ` Peter Zijlstra
2022-04-19 10:01 ` Borislav Petkov
2022-04-19 10:16 ` [tip: x86/urgent] " tip-bot2 for Tony Luck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220330134325.GM8939@worktop.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=bp@alien8.de \
--cc=linux-kernel@vger.kernel.org \
--cc=tony.luck@intel.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.