From: Kent Gibson <warthog618@gmail.com>
To: linux-gpio@vger.kernel.org, brgl@bgdev.pl
Cc: Kent Gibson <warthog618@gmail.com>
Subject: [libgpiod v2][PATCH 0/4] core: add gpiod_request_lines
Date: Thu, 31 Mar 2022 09:11:37 +0800 [thread overview]
Message-ID: <20220331011141.53489-1-warthog618@gmail.com> (raw)
In my review of the CXX bindings I suggested a top-level version of
Chip.request_lines(), and possibly a C API version as well, so here
is the C version, plus a couple of semi-related tweaks I made along
the way.
The first patch adds the gpiod_request_lines().
Patch 3 migrates the appropriate tools.
Patch 4 minimizes the lifetimes of objects in the tools as I've
previously seen confusion over how long lived objects need to be.
Patch 2 is just a rename cos "inexistent" looks weird to me.
Strictly speaking it is fine, but unless there is a problem with
using "nonexistent" I would go with the latter.
This series may be require my unsigned values patch.
Cheers,
Kent.
Kent Gibson (4):
core: add gpiod_request_lines
tools: rename inexistent to nonexistent
tools: migrate to gpiod_request_lines
tools: minimize object lifetimes
include/gpiod.h | 15 ++++++++
lib/line-request.c | 17 +++++++++
tests/tests-line-request.c | 73 ++++++++++++++++++++++++++++++++++++++
tools/gpio-tools-test.bats | 4 +--
tools/gpiodetect.c | 2 +-
tools/gpiofind.c | 2 +-
tools/gpioget.c | 25 +++++++------
tools/gpioinfo.c | 4 +--
tools/gpiomon.c | 16 ++++-----
tools/gpioset.c | 18 +++++-----
tools/tools-common.c | 50 ++++++++++----------------
tools/tools-common.h | 5 +--
12 files changed, 164 insertions(+), 67 deletions(-)
--
2.35.1
next reply other threads:[~2022-03-31 1:12 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-31 1:11 Kent Gibson [this message]
2022-03-31 1:11 ` [libgpiod v2][PATCH 1/4] core: add gpiod_request_lines Kent Gibson
2022-03-31 1:11 ` [libgpiod v2][PATCH 2/4] tools: rename inexistent to nonexistent Kent Gibson
2022-03-31 1:11 ` [libgpiod v2][PATCH 3/4] tools: migrate to gpiod_request_lines Kent Gibson
2022-03-31 1:11 ` [libgpiod v2][PATCH 4/4] tools: minimize object lifetimes Kent Gibson
2022-04-02 12:47 ` [libgpiod v2][PATCH 0/4] core: add gpiod_request_lines Bartosz Golaszewski
2022-04-04 9:54 ` Kent Gibson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220331011141.53489-1-warthog618@gmail.com \
--to=warthog618@gmail.com \
--cc=brgl@bgdev.pl \
--cc=linux-gpio@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.