From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0D263C433F5 for ; Thu, 31 Mar 2022 19:00:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237997AbiCaTCH (ORCPT ); Thu, 31 Mar 2022 15:02:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49152 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237948AbiCaTCF (ORCPT ); Thu, 31 Mar 2022 15:02:05 -0400 Received: from mail-pf1-x42e.google.com (mail-pf1-x42e.google.com [IPv6:2607:f8b0:4864:20::42e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7768C1BD9A6 for ; Thu, 31 Mar 2022 12:00:16 -0700 (PDT) Received: by mail-pf1-x42e.google.com with SMTP id s11so404972pfu.13 for ; Thu, 31 Mar 2022 12:00:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=YCOslDIO/0W733/ujDklGbRX/ha6VpRvkSSUEoU714s=; b=nzw9o0AJLtRqnDYEvjxXTLiWlKWPs/MTqSc49MT79Nvi0jxqks7k/DYO3nbr+/O2MV xdNUqABzyfe3o+DPmH2ee8ccnTZyBR2yPKjOjzJpGF6TF5zLrLnHm/B5RXRf3HkkOcer p/YeAjvZaGsKXrWiKaqcsc3srAIykbXCJBxXA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=YCOslDIO/0W733/ujDklGbRX/ha6VpRvkSSUEoU714s=; b=uQFe68lLJmEDKLjRUEqWzv2mOn03oNzzhd7LIJScZ8qnWVDuojvbfoiyU5yUaEd21M wjSWecNf4md/X1klat1WhAWwfwEpG5GPz9/VOLLeMFOY4pUsrK+AltiY+9SbRFIcDziR G5QK2MF8n4Fc/QMcsBeErwm0ZXO5UIES3bgRSkwcyKg1w5S/NvgGLDsZprnaOwukELHz ycuknE6lw2aDqbC1Naa24FzCLWsJv+4Z0jHKCNLp3nchjvWCJGAQkcgfqaA7UpvVx7VV Hi9btaFM8LKvPhJAFmgsfzooeED+HqAy7vUgvkZWorIDik/QdiIl1E5oCMUD9glYkeBm 8J8Q== X-Gm-Message-State: AOAM5331ohJ3mb4rc+46jLRUh5iMud+UgcW58Ejm9tAqps6j2slIGFdR ybnq1K3AFZfur5q39OhYXv1MSg== X-Google-Smtp-Source: ABdhPJwPAbG0pC/w9f4u+f4/nphD+UfXfd7YySe+QBeu9aUDnnXE9J1pLUD5Y3njX+cudadqUA6UPA== X-Received: by 2002:a05:6a00:188f:b0:4fa:ece9:15d9 with SMTP id x15-20020a056a00188f00b004faece915d9mr7009932pfh.28.1648753215947; Thu, 31 Mar 2022 12:00:15 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id s3-20020a056a00194300b004f6664d26eesm222905pfk.88.2022.03.31.12.00.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 31 Mar 2022 12:00:15 -0700 (PDT) Date: Thu, 31 Mar 2022 12:00:15 -0700 From: Kees Cook To: Linus Torvalds Cc: Linux Kernel Mailing List , Andrew Morton , Christoph Hellwig , David Hildenbrand , Hari Bathini , Linux ARM , Logan Gunthorpe , Martin Oliveira , "Matthew Wilcox (Oracle)" , Mike Kravetz , Minchan Kim , Russell King , Stephen Rothwell , Zi Yan Subject: Re: [GIT PULL] hardening fixes for v5.18-rc1 Message-ID: <202203311157.F7FA779@keescook> References: <202203311127.503A3110@keescook> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Mar 31, 2022 at 11:49:42AM -0700, Linus Torvalds wrote: > On Thu, Mar 31, 2022 at 11:35 AM Kees Cook wrote: > > > > Please pull these hardening fixes for v5.18-rc1. This addresses an > > -Warray-bounds warning found under a few ARM defconfigs, and disables > > long-broken CONFIG_HARDENED_USERCOPY_PAGESPAN. > > Can't we just remove that HARDENED_USERCOPY_PAGESPAN thing entirely? > > Yes, yes, I know Matthew did that as part of other patches that is too > late to go in any more in this merge window, but just the removal > patch is a no-brainer. I can do that, but it seemed like more work for folks: a larger diff to look at, and a rebase for Matthew or me. It's not MUCH more work, but given the timing of the merge window, I wanted to have a minimal diff. > IOW, why not just do the attached? But I can certainly respin it, if you'd prefer? -- Kees Cook From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 99482C433F5 for ; Thu, 31 Mar 2022 19:01:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=GwfC231dRrH9bAeKBiXpwtryqvLvs+GzwM2he0DJGYc=; b=rdoU8HbxD8Ls7s NITWArRMh0+mQA/IgyFAZtrLtuIhxjTYZdzUY/1NSaIH6cjZ+sUUxPsPDXaZ+jw1Bsx6dRIkC4NGm IdGijw0hEzaIVu0RLh5tCToodxqHhU92+/IfYvygwcjXjYaLEDAd/N7h6YiwRr9BBlz+1+n14BMBC r97cIWgG1g5RWKeME0ksxqoVoTtGIQEnMck1rmNZjs3S+Roi1N7N+eV3wBw8RbYQ7ox1DoHSVTS+X kSPM5vhrlDI0fyTk3fskEA3uDL8faF0Yg3K818ZlRnj/bpfzHKMtXV6zOmkfIM/7LVh0MR3BVV83Y 3SXG22TS8fMj7TxpbOQg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1na021-003KNv-L7; Thu, 31 Mar 2022 19:00:29 +0000 Received: from mail-pf1-x42b.google.com ([2607:f8b0:4864:20::42b]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1na01v-003KIX-3f for linux-arm-kernel@lists.infradead.org; Thu, 31 Mar 2022 19:00:26 +0000 Received: by mail-pf1-x42b.google.com with SMTP id h19so473269pfv.1 for ; Thu, 31 Mar 2022 12:00:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=YCOslDIO/0W733/ujDklGbRX/ha6VpRvkSSUEoU714s=; b=nzw9o0AJLtRqnDYEvjxXTLiWlKWPs/MTqSc49MT79Nvi0jxqks7k/DYO3nbr+/O2MV xdNUqABzyfe3o+DPmH2ee8ccnTZyBR2yPKjOjzJpGF6TF5zLrLnHm/B5RXRf3HkkOcer p/YeAjvZaGsKXrWiKaqcsc3srAIykbXCJBxXA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=YCOslDIO/0W733/ujDklGbRX/ha6VpRvkSSUEoU714s=; b=sB8Ysm1XspAIhA+/HgaF6ao+QCgLgVO/CE5XevMeD0d1uRAukqt/v78F0CY9BX65o6 thxaTLW0pAwq6dsuk6O0qW88LTKygJqDUMFwX26Hcht7eMorkCsQWxfASAgLinebBu45 X2dUJ61EXkt7BrdR+PXHtuG8Pvmwb+xly7pJ1SM91D35iaT9Ot7cwWHvGLzOMARjfPcm 2zaozucKu9+MPGqfxxXHveUvYTTvLFG9BRt6XakRaDxheDV0zCJMR2q+FcvhvJ+X01PT AuqflE7CWV279TP6PqYNzQNHKVxaPx0RQASAehrPKKLROv3ftpUYi13/wDMDgeoXsUMM cwxg== X-Gm-Message-State: AOAM532ieA6bx/riGpi0fyy24qtVS5wLA3o/7KojaW3IfBA0tD2/+5dP R41wTDOFiUlG9ZxWcJjmHroyNw== X-Google-Smtp-Source: ABdhPJwPAbG0pC/w9f4u+f4/nphD+UfXfd7YySe+QBeu9aUDnnXE9J1pLUD5Y3njX+cudadqUA6UPA== X-Received: by 2002:a05:6a00:188f:b0:4fa:ece9:15d9 with SMTP id x15-20020a056a00188f00b004faece915d9mr7009932pfh.28.1648753215947; Thu, 31 Mar 2022 12:00:15 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id s3-20020a056a00194300b004f6664d26eesm222905pfk.88.2022.03.31.12.00.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 31 Mar 2022 12:00:15 -0700 (PDT) Date: Thu, 31 Mar 2022 12:00:15 -0700 From: Kees Cook To: Linus Torvalds Cc: Linux Kernel Mailing List , Andrew Morton , Christoph Hellwig , David Hildenbrand , Hari Bathini , Linux ARM , Logan Gunthorpe , Martin Oliveira , "Matthew Wilcox (Oracle)" , Mike Kravetz , Minchan Kim , Russell King , Stephen Rothwell , Zi Yan Subject: Re: [GIT PULL] hardening fixes for v5.18-rc1 Message-ID: <202203311157.F7FA779@keescook> References: <202203311127.503A3110@keescook> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220331_120023_197322_DB9A76BD X-CRM114-Status: GOOD ( 17.10 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Mar 31, 2022 at 11:49:42AM -0700, Linus Torvalds wrote: > On Thu, Mar 31, 2022 at 11:35 AM Kees Cook wrote: > > > > Please pull these hardening fixes for v5.18-rc1. This addresses an > > -Warray-bounds warning found under a few ARM defconfigs, and disables > > long-broken CONFIG_HARDENED_USERCOPY_PAGESPAN. > > Can't we just remove that HARDENED_USERCOPY_PAGESPAN thing entirely? > > Yes, yes, I know Matthew did that as part of other patches that is too > late to go in any more in this merge window, but just the removal > patch is a no-brainer. I can do that, but it seemed like more work for folks: a larger diff to look at, and a rebase for Matthew or me. It's not MUCH more work, but given the timing of the merge window, I wanted to have a minimal diff. > IOW, why not just do the attached? But I can certainly respin it, if you'd prefer? -- Kees Cook _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel