From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B93EDC433EF for ; Fri, 1 Apr 2022 12:28:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S245726AbiDAMad (ORCPT ); Fri, 1 Apr 2022 08:30:33 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42768 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241810AbiDAMac (ORCPT ); Fri, 1 Apr 2022 08:30:32 -0400 Received: from wout2-smtp.messagingengine.com (wout2-smtp.messagingengine.com [64.147.123.25]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6FCD3BCB8; Fri, 1 Apr 2022 05:28:42 -0700 (PDT) Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.west.internal (Postfix) with ESMTP id 5F5CA3201E3E; Fri, 1 Apr 2022 08:28:41 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Fri, 01 Apr 2022 08:28:42 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cerno.tech; h=cc :cc:content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm3; bh=jtNk93FHUU49ZARhas5dzjR17GmPtHtxE5P78n 7e4qc=; b=o+KidCfPuXcoLyv+Uu2vlONlM4XZ6M55f9+nk1/hTQMnYR8FSEQ01d 8pc2iOrb73MxEhbDT9W135wNdLh5DVxqF97o3HD+9d26a6uZD0tfU1p15X5H9sps h6S1AJJCUsjiyRFF3XSpJHPwto0zttTcmkL+1mVp26T0OqVqicnoIBsJIOYAHb4D Z0X1QAXES4H5/sh2xaE4i4+BZWvOeZJTp32E3p40yo/IjVW3iS5sZLMA7IUZJs3P zVhA6vF5JECgy0VOZuBCg3Fywd8mu+8QrmDlwx80EcBwjmQ4gsOeh+y0iaxYGOEt +Y22Gxbm24YjH58TU1kIUt+E+tPZ7P5Q== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=jtNk93FHUU49ZARha s5dzjR17GmPtHtxE5P78n7e4qc=; b=Qm+M5EF2/a5lVwE2HRiKOiZo5kfbV7lJk Zz7MQ8AfLwEnc6JABD/G8GjiikqpZ5vZZL1VZiKuldP1yWGGgNCNRAo+4yusqqQa Z1wyNkIqDdV52BFrJa3jVYQkosN1sOer2xUhEAD2KisfWN8FY0m1Q7vsY98tjX8n wJ+gl+OVRpPocHhHogU+Iq1pWKF4UiSVwmUJMwnrxWDvcD4D2NrV7WmjMLDy58E2 z4NNNQywCL/PfwjeSi4lsmrzh948McNuRPmYFYVcekxIz3c7YAFKuZ5RFoxJQsab m9fsrcWpalPL11D5PAy8gVfTW+f54Ts6DVZejOtTMHDbo4f+wfjAA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvvddrudeiiedgheefucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvffukfhfgggtuggjsehgtderredttddvnecuhfhrohhmpeforgigihhm vgcutfhiphgrrhguuceomhgrgihimhgvsegtvghrnhhordhtvggthheqnecuggftrfgrth htvghrnhepleekgeehhfdutdeljefgleejffehfffgieejhffgueefhfdtveetgeehieeh gedunecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepmh grgihimhgvsegtvghrnhhordhtvggthh X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 1 Apr 2022 08:28:40 -0400 (EDT) Date: Fri, 1 Apr 2022 14:28:39 +0200 From: Maxime Ripard To: Stephen Boyd Cc: Tony Lindgren , Marek Szyprowski , Mike Turquette , linux-clk@vger.kernel.org, Dmitry Osipenko , 'Linux Samsung SOC' , linux-amlogic@lists.infradead.org, linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v2 3/3] clk: Drop the rate range on clk_put Message-ID: <20220401122839.nn74rtftvzgjqjrg@houat> References: <20220325161144.1901695-4-maxime@cerno.tech> <366a0232-bb4a-c357-6aa8-636e398e05eb@samsung.com> <20220330084710.3r6b5pjspz5hdmy6@houat> <20220331095456.dyyxsiu2b3yw2vvs@houat> <20220331153134.h3alp24hzquajkly@houat> <20220331215818.F11BEC340F0@smtp.kernel.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="cbzadlu2wn45hprg" Content-Disposition: inline In-Reply-To: <20220331215818.F11BEC340F0@smtp.kernel.org> Precedence: bulk List-ID: X-Mailing-List: linux-clk@vger.kernel.org --cbzadlu2wn45hprg Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi, On Thu, Mar 31, 2022 at 02:58:17PM -0700, Stephen Boyd wrote: > Quoting Tony Lindgren (2022-03-31 10:00:09) > > * Maxime Ripard [220331 15:29]: > > > On Thu, Mar 31, 2022 at 06:00:42PM +0300, Tony Lindgren wrote: > > > > * Maxime Ripard [220331 09:52]: > > > > > On Thu, Mar 31, 2022 at 12:42:10PM +0300, Tony Lindgren wrote: > > > > > > It seems the dts assigned-clock-parents no longer works now? > > > > >=20 > > > > > That would make some kind of sense, __set_clk_parents calls clk_p= ut on > > > > > both the assigned clock and its parent. > > > > >=20 > > > > > Could you see what parent (and why?) it tries to enforce then? > > > >=20 > > > > It picks the other option available for the mux clock that only has > > > > two options. No idea why, but if you have some debug patch in mind I > > > > can give it a try. > > > >=20 > > > > > It looks like the gpt1_fck driver might favor another parent for = that > > > > > rate, which, if it's an invalid configuration, shouldn't really h= appen? > > > >=20 > > > > Hmm there's a gate clock and a mux clock, there's not really a rate > > > > selection available here for the sources. > > >=20 > > > If I followed the OMAP driver properly, clk_mux_determine_rate_flags = is > > > doing the heavy lifting, could you run your test with > >=20 > > Thanks that produces some interesting output. In the working case with > > the $subject patch reverted we have: >=20 > I don't think clk_put() dropping a range request is very important right > now. If this isn't fixed tomorrow then we should revert out this patch > so systems can boot -rc1 and try to fix it in parallel. Yeah, it can definitely be reverted. I'm not so sure that the issue is with this patch itself though but more that it now triggers a fault reliably. Maxime --cbzadlu2wn45hprg Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYKAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCYkbv9gAKCRDj7w1vZxhR xS1lAQDlzhXShXYyvRXWBAMz9rbYVpXxhlVfXcSkFRoybpK0agD8D6P1JMu8K2kP 6PnQ5mQa5YSBF/ZysmWXUJksfhpk+wc= =0WDl -----END PGP SIGNATURE----- --cbzadlu2wn45hprg-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2ABF4C433EF for ; Fri, 1 Apr 2022 12:28:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Reply-To:Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date :Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=PdE7D8vOMsK9ZUPRFrSY77E86tV9QFs591KkLzt+dL8=; b=stc2aBlIne2N2ZXe6P8LQQmU32 MSag1yotb/FvnzkLFO1a9K4ZFoRjBStbEAEq2QZxmUVXGIswghater6wu3cUtW8Y3Y6S/wcfvxbao WAss5RX5zKKojmjQMBId+lQKBBobpEcOdt0lc2edATFOKrePJF5bQvuhcpHky776tOOJdrlBHmm9q aKsicmw+Yc8SERVhEHThnVjJ2CHJrWegXSNdhd3BBLcdnt3AFQndLIXsbHklAhtuKXE1L6oJoOYEm pJ3Ipxmd+tLXD+0U2cNXT3t9OwAPIyvIW0q95G5RAKBgpRVCYfLnVH8oA4J0oug1GAilAkMNGhL1S p1RZp1Yw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1naGOT-005csk-D1; Fri, 01 Apr 2022 12:28:45 +0000 Received: from wout2-smtp.messagingengine.com ([64.147.123.25]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1naGOQ-005crj-G4; Fri, 01 Apr 2022 12:28:43 +0000 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.west.internal (Postfix) with ESMTP id 5F5CA3201E3E; Fri, 1 Apr 2022 08:28:41 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Fri, 01 Apr 2022 08:28:42 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cerno.tech; h=cc :cc:content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm3; bh=jtNk93FHUU49ZARhas5dzjR17GmPtHtxE5P78n 7e4qc=; b=o+KidCfPuXcoLyv+Uu2vlONlM4XZ6M55f9+nk1/hTQMnYR8FSEQ01d 8pc2iOrb73MxEhbDT9W135wNdLh5DVxqF97o3HD+9d26a6uZD0tfU1p15X5H9sps h6S1AJJCUsjiyRFF3XSpJHPwto0zttTcmkL+1mVp26T0OqVqicnoIBsJIOYAHb4D Z0X1QAXES4H5/sh2xaE4i4+BZWvOeZJTp32E3p40yo/IjVW3iS5sZLMA7IUZJs3P zVhA6vF5JECgy0VOZuBCg3Fywd8mu+8QrmDlwx80EcBwjmQ4gsOeh+y0iaxYGOEt +Y22Gxbm24YjH58TU1kIUt+E+tPZ7P5Q== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=jtNk93FHUU49ZARha s5dzjR17GmPtHtxE5P78n7e4qc=; b=Qm+M5EF2/a5lVwE2HRiKOiZo5kfbV7lJk Zz7MQ8AfLwEnc6JABD/G8GjiikqpZ5vZZL1VZiKuldP1yWGGgNCNRAo+4yusqqQa Z1wyNkIqDdV52BFrJa3jVYQkosN1sOer2xUhEAD2KisfWN8FY0m1Q7vsY98tjX8n wJ+gl+OVRpPocHhHogU+Iq1pWKF4UiSVwmUJMwnrxWDvcD4D2NrV7WmjMLDy58E2 z4NNNQywCL/PfwjeSi4lsmrzh948McNuRPmYFYVcekxIz3c7YAFKuZ5RFoxJQsab m9fsrcWpalPL11D5PAy8gVfTW+f54Ts6DVZejOtTMHDbo4f+wfjAA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvvddrudeiiedgheefucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvffukfhfgggtuggjsehgtderredttddvnecuhfhrohhmpeforgigihhm vgcutfhiphgrrhguuceomhgrgihimhgvsegtvghrnhhordhtvggthheqnecuggftrfgrth htvghrnhepleekgeehhfdutdeljefgleejffehfffgieejhffgueefhfdtveetgeehieeh gedunecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepmh grgihimhgvsegtvghrnhhordhtvggthh X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 1 Apr 2022 08:28:40 -0400 (EDT) Date: Fri, 1 Apr 2022 14:28:39 +0200 From: Maxime Ripard To: Stephen Boyd Cc: Tony Lindgren , Marek Szyprowski , Mike Turquette , linux-clk@vger.kernel.org, Dmitry Osipenko , 'Linux Samsung SOC' , linux-amlogic@lists.infradead.org, linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v2 3/3] clk: Drop the rate range on clk_put Message-ID: <20220401122839.nn74rtftvzgjqjrg@houat> References: <20220325161144.1901695-4-maxime@cerno.tech> <366a0232-bb4a-c357-6aa8-636e398e05eb@samsung.com> <20220330084710.3r6b5pjspz5hdmy6@houat> <20220331095456.dyyxsiu2b3yw2vvs@houat> <20220331153134.h3alp24hzquajkly@houat> <20220331215818.F11BEC340F0@smtp.kernel.org> MIME-Version: 1.0 In-Reply-To: <20220331215818.F11BEC340F0@smtp.kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220401_052842_594141_3DAD3C37 X-CRM114-Status: GOOD ( 27.38 ) X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============5845324821330231819==" Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org --===============5845324821330231819== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="cbzadlu2wn45hprg" Content-Disposition: inline --cbzadlu2wn45hprg Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi, On Thu, Mar 31, 2022 at 02:58:17PM -0700, Stephen Boyd wrote: > Quoting Tony Lindgren (2022-03-31 10:00:09) > > * Maxime Ripard [220331 15:29]: > > > On Thu, Mar 31, 2022 at 06:00:42PM +0300, Tony Lindgren wrote: > > > > * Maxime Ripard [220331 09:52]: > > > > > On Thu, Mar 31, 2022 at 12:42:10PM +0300, Tony Lindgren wrote: > > > > > > It seems the dts assigned-clock-parents no longer works now? > > > > >=20 > > > > > That would make some kind of sense, __set_clk_parents calls clk_p= ut on > > > > > both the assigned clock and its parent. > > > > >=20 > > > > > Could you see what parent (and why?) it tries to enforce then? > > > >=20 > > > > It picks the other option available for the mux clock that only has > > > > two options. No idea why, but if you have some debug patch in mind I > > > > can give it a try. > > > >=20 > > > > > It looks like the gpt1_fck driver might favor another parent for = that > > > > > rate, which, if it's an invalid configuration, shouldn't really h= appen? > > > >=20 > > > > Hmm there's a gate clock and a mux clock, there's not really a rate > > > > selection available here for the sources. > > >=20 > > > If I followed the OMAP driver properly, clk_mux_determine_rate_flags = is > > > doing the heavy lifting, could you run your test with > >=20 > > Thanks that produces some interesting output. In the working case with > > the $subject patch reverted we have: >=20 > I don't think clk_put() dropping a range request is very important right > now. If this isn't fixed tomorrow then we should revert out this patch > so systems can boot -rc1 and try to fix it in parallel. Yeah, it can definitely be reverted. I'm not so sure that the issue is with this patch itself though but more that it now triggers a fault reliably. Maxime --cbzadlu2wn45hprg Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYKAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCYkbv9gAKCRDj7w1vZxhR xS1lAQDlzhXShXYyvRXWBAMz9rbYVpXxhlVfXcSkFRoybpK0agD8D6P1JMu8K2kP 6PnQ5mQa5YSBF/ZysmWXUJksfhpk+wc= =0WDl -----END PGP SIGNATURE----- --cbzadlu2wn45hprg-- --===============5845324821330231819== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic --===============5845324821330231819==-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 42840C433F5 for ; Fri, 1 Apr 2022 12:29:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Reply-To:Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date :Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=1WxrztondVcbcBSr60thSgrFBZtuKVxohM53qYoXFl8=; b=Fw4LRbHHLFSoCQMMeDZwV7tJlf oJUXMIOSPy25AWWyNNVxomm9/bi9SqrCXL4zrcAOFNcjQNQOYV2xSpMW6FHShoiFdlBZY7J5D4pTO lahFzzHnodgN9kcjK4l/f2ZyF273U8J5MxBXDwl6jFSRsGB/R3Quhqmo6pTlgY9o/SkhTacBVQUin Bx3j21NdCsmsB2f0RfgggX2vOe0SBEu6Q+3OzpO07k3CsEfRPgiTw+Ai6/EkbG23Nzp05jPQOJMYn v/N6vQ2s+GIQaGeE/Y/Uqs1t3ZzLxwtfCwfv9CTYBaqbVzdvOp8EvhGwbSErykHx9v3eZ45IivQ7z kUPOyibA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1naGOU-005ct1-MS; Fri, 01 Apr 2022 12:28:46 +0000 Received: from wout2-smtp.messagingengine.com ([64.147.123.25]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1naGOQ-005crj-G4; Fri, 01 Apr 2022 12:28:43 +0000 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.west.internal (Postfix) with ESMTP id 5F5CA3201E3E; Fri, 1 Apr 2022 08:28:41 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Fri, 01 Apr 2022 08:28:42 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cerno.tech; h=cc :cc:content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm3; bh=jtNk93FHUU49ZARhas5dzjR17GmPtHtxE5P78n 7e4qc=; b=o+KidCfPuXcoLyv+Uu2vlONlM4XZ6M55f9+nk1/hTQMnYR8FSEQ01d 8pc2iOrb73MxEhbDT9W135wNdLh5DVxqF97o3HD+9d26a6uZD0tfU1p15X5H9sps h6S1AJJCUsjiyRFF3XSpJHPwto0zttTcmkL+1mVp26T0OqVqicnoIBsJIOYAHb4D Z0X1QAXES4H5/sh2xaE4i4+BZWvOeZJTp32E3p40yo/IjVW3iS5sZLMA7IUZJs3P zVhA6vF5JECgy0VOZuBCg3Fywd8mu+8QrmDlwx80EcBwjmQ4gsOeh+y0iaxYGOEt +Y22Gxbm24YjH58TU1kIUt+E+tPZ7P5Q== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=jtNk93FHUU49ZARha s5dzjR17GmPtHtxE5P78n7e4qc=; b=Qm+M5EF2/a5lVwE2HRiKOiZo5kfbV7lJk Zz7MQ8AfLwEnc6JABD/G8GjiikqpZ5vZZL1VZiKuldP1yWGGgNCNRAo+4yusqqQa Z1wyNkIqDdV52BFrJa3jVYQkosN1sOer2xUhEAD2KisfWN8FY0m1Q7vsY98tjX8n wJ+gl+OVRpPocHhHogU+Iq1pWKF4UiSVwmUJMwnrxWDvcD4D2NrV7WmjMLDy58E2 z4NNNQywCL/PfwjeSi4lsmrzh948McNuRPmYFYVcekxIz3c7YAFKuZ5RFoxJQsab m9fsrcWpalPL11D5PAy8gVfTW+f54Ts6DVZejOtTMHDbo4f+wfjAA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvvddrudeiiedgheefucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvffukfhfgggtuggjsehgtderredttddvnecuhfhrohhmpeforgigihhm vgcutfhiphgrrhguuceomhgrgihimhgvsegtvghrnhhordhtvggthheqnecuggftrfgrth htvghrnhepleekgeehhfdutdeljefgleejffehfffgieejhffgueefhfdtveetgeehieeh gedunecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepmh grgihimhgvsegtvghrnhhordhtvggthh X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 1 Apr 2022 08:28:40 -0400 (EDT) Date: Fri, 1 Apr 2022 14:28:39 +0200 From: Maxime Ripard To: Stephen Boyd Cc: Tony Lindgren , Marek Szyprowski , Mike Turquette , linux-clk@vger.kernel.org, Dmitry Osipenko , 'Linux Samsung SOC' , linux-amlogic@lists.infradead.org, linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v2 3/3] clk: Drop the rate range on clk_put Message-ID: <20220401122839.nn74rtftvzgjqjrg@houat> References: <20220325161144.1901695-4-maxime@cerno.tech> <366a0232-bb4a-c357-6aa8-636e398e05eb@samsung.com> <20220330084710.3r6b5pjspz5hdmy6@houat> <20220331095456.dyyxsiu2b3yw2vvs@houat> <20220331153134.h3alp24hzquajkly@houat> <20220331215818.F11BEC340F0@smtp.kernel.org> MIME-Version: 1.0 In-Reply-To: <20220331215818.F11BEC340F0@smtp.kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220401_052842_594141_3DAD3C37 X-CRM114-Status: GOOD ( 27.38 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============0437272529054381249==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============0437272529054381249== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="cbzadlu2wn45hprg" Content-Disposition: inline --cbzadlu2wn45hprg Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi, On Thu, Mar 31, 2022 at 02:58:17PM -0700, Stephen Boyd wrote: > Quoting Tony Lindgren (2022-03-31 10:00:09) > > * Maxime Ripard [220331 15:29]: > > > On Thu, Mar 31, 2022 at 06:00:42PM +0300, Tony Lindgren wrote: > > > > * Maxime Ripard [220331 09:52]: > > > > > On Thu, Mar 31, 2022 at 12:42:10PM +0300, Tony Lindgren wrote: > > > > > > It seems the dts assigned-clock-parents no longer works now? > > > > >=20 > > > > > That would make some kind of sense, __set_clk_parents calls clk_p= ut on > > > > > both the assigned clock and its parent. > > > > >=20 > > > > > Could you see what parent (and why?) it tries to enforce then? > > > >=20 > > > > It picks the other option available for the mux clock that only has > > > > two options. No idea why, but if you have some debug patch in mind I > > > > can give it a try. > > > >=20 > > > > > It looks like the gpt1_fck driver might favor another parent for = that > > > > > rate, which, if it's an invalid configuration, shouldn't really h= appen? > > > >=20 > > > > Hmm there's a gate clock and a mux clock, there's not really a rate > > > > selection available here for the sources. > > >=20 > > > If I followed the OMAP driver properly, clk_mux_determine_rate_flags = is > > > doing the heavy lifting, could you run your test with > >=20 > > Thanks that produces some interesting output. In the working case with > > the $subject patch reverted we have: >=20 > I don't think clk_put() dropping a range request is very important right > now. If this isn't fixed tomorrow then we should revert out this patch > so systems can boot -rc1 and try to fix it in parallel. Yeah, it can definitely be reverted. I'm not so sure that the issue is with this patch itself though but more that it now triggers a fault reliably. Maxime --cbzadlu2wn45hprg Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYKAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCYkbv9gAKCRDj7w1vZxhR xS1lAQDlzhXShXYyvRXWBAMz9rbYVpXxhlVfXcSkFRoybpK0agD8D6P1JMu8K2kP 6PnQ5mQa5YSBF/ZysmWXUJksfhpk+wc= =0WDl -----END PGP SIGNATURE----- --cbzadlu2wn45hprg-- --===============0437272529054381249== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============0437272529054381249==--