All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sean Anderson <sean.anderson@seco.com>
To: Simon Glass <sjg@chromium.org>
Cc: "Marek Behún" <marek.behun@nic.cz>,
	u-boot@lists.denx.de, "Stefan Roese" <sr@denx.de>,
	"Marek Vasut" <marex@denx.de>, "Pali Rohár" <pali@kernel.org>,
	"Sean Anderson" <sean.anderson@seco.com>
Subject: [RFC PATCH 3/7] spl: Convert fat to spl_load
Date: Fri,  1 Apr 2022 15:04:01 -0400	[thread overview]
Message-ID: <20220401190405.1932697-4-sean.anderson@seco.com> (raw)
In-Reply-To: <20220401190405.1932697-1-sean.anderson@seco.com>

This converts the fat loader to use spl_load.

Signed-off-by: Sean Anderson <sean.anderson@seco.com>
---

 common/spl/spl_fat.c | 36 ++++++------------------------------
 1 file changed, 6 insertions(+), 30 deletions(-)

diff --git a/common/spl/spl_fat.c b/common/spl/spl_fat.c
index 5b270541fc..c092eb3481 100644
--- a/common/spl/spl_fat.c
+++ b/common/spl/spl_fat.c
@@ -61,6 +61,11 @@ int spl_load_image_fat(struct spl_image_info *spl_image,
 {
 	int err;
 	struct image_header *header;
+	struct spl_load_info load = {
+		.read = spl_fit_read,
+		.bl_len = 1,
+		.filename = filename,
+	};
 
 	err = spl_register_fat_device(block_dev, partition);
 	if (err)
@@ -72,36 +77,7 @@ int spl_load_image_fat(struct spl_image_info *spl_image,
 	if (err <= 0)
 		goto end;
 
-	if (IS_ENABLED(CONFIG_SPL_LOAD_FIT_FULL) &&
-	    image_get_magic(header) == FDT_MAGIC) {
-		err = file_fat_read(filename, (void *)CONFIG_SYS_LOAD_ADDR, 0);
-		if (err <= 0)
-			goto end;
-		err = spl_parse_image_header(spl_image, bootdev,
-				(struct image_header *)CONFIG_SYS_LOAD_ADDR);
-		if (err == -EAGAIN)
-			return err;
-		if (err == 0)
-			err = 1;
-	} else if (IS_ENABLED(CONFIG_SPL_LOAD_FIT) &&
-	    image_get_magic(header) == FDT_MAGIC) {
-		struct spl_load_info load;
-
-		debug("Found FIT\n");
-		load.read = spl_fit_read;
-		load.bl_len = 1;
-		load.filename = (void *)filename;
-		load.priv = NULL;
-
-		return spl_load_simple_fit(spl_image, &load, 0, header);
-	} else {
-		err = spl_parse_image_header(spl_image, bootdev, header);
-		if (err)
-			goto end;
-
-		err = file_fat_read(filename,
-				    (u8 *)(uintptr_t)spl_image->load_addr, 0);
-	}
+	err = spl_load(spl_image, bootdev, &load, header, err, 0);
 
 end:
 #ifdef CONFIG_SPL_LIBCOMMON_SUPPORT
-- 
2.35.1.1320.gc452695387.dirty


  parent reply	other threads:[~2022-04-01 19:05 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-01 19:03 [RFC PATCH 0/7] spl: Use common function for loading/parsing images Sean Anderson
2022-04-01 19:03 ` [RFC PATCH 1/7] spl: Add generic spl_load function Sean Anderson
2022-04-06  5:30   ` Stefan Roese
2022-04-07 15:10     ` Sean Anderson
2022-04-08  4:43       ` Stefan Roese
2022-04-01 19:04 ` [RFC PATCH 2/7] spl: Convert ext to use spl_load Sean Anderson
2022-04-06  5:32   ` Stefan Roese
2022-04-01 19:04 ` Sean Anderson [this message]
2022-04-06  5:32   ` [RFC PATCH 3/7] spl: Convert fat to spl_load Stefan Roese
2022-04-01 19:04 ` [RFC PATCH 4/7] spl: Convert mmc " Sean Anderson
2022-04-06  5:32   ` Stefan Roese
2022-04-01 19:04 ` [RFC PATCH 5/7] spl: Convert net " Sean Anderson
2022-04-06  5:32   ` Stefan Roese
2022-04-01 19:04 ` [RFC PATCH 6/7] spl: Convert nor " Sean Anderson
2022-04-06  5:33   ` Stefan Roese
2022-04-01 19:04 ` [RFC PATCH 7/7] spl: Convert spi " Sean Anderson
2022-04-06  5:33   ` Stefan Roese
2022-04-06  5:26 ` [RFC PATCH 0/7] spl: Use common function for loading/parsing images Stefan Roese

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220401190405.1932697-4-sean.anderson@seco.com \
    --to=sean.anderson@seco.com \
    --cc=marek.behun@nic.cz \
    --cc=marex@denx.de \
    --cc=pali@kernel.org \
    --cc=sjg@chromium.org \
    --cc=sr@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.