All of lore.kernel.org
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: Jeffle Xu <jefflexu@linux.alibaba.com>
Cc: llvm@lists.linux.dev, kbuild-all@lists.01.org,
	Xiang Gao <xiang@kernel.org>,
	linux-kernel@vger.kernel.org,
	Gao Xiang <hsiangkao@linux.alibaba.com>
Subject: [xiang:jeffle/fscache 2/19] fs/cachefiles/namei.c:478:8: error: use of undeclared label 'out_unuse'
Date: Sat, 2 Apr 2022 13:28:22 +0800	[thread overview]
Message-ID: <202204021317.7QFcS38O-lkp@intel.com> (raw)

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/xiang/linux.git jeffle/fscache
head:   c536a60b958806d427fb66e3f53a1201826fdcf4
commit: 6e3731398f863eec9b10f9e0cead9f2ec09d8b4d [2/19] cachefiles: notify user daemon with anon_fd when looking up cookie
config: x86_64-randconfig-a012 (https://download.01.org/0day-ci/archive/20220402/202204021317.7QFcS38O-lkp@intel.com/config)
compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project c4a1b07d0979e7ff20d7d541af666d822d66b566)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://git.kernel.org/pub/scm/linux/kernel/git/xiang/linux.git/commit/?id=6e3731398f863eec9b10f9e0cead9f2ec09d8b4d
        git remote add xiang https://git.kernel.org/pub/scm/linux/kernel/git/xiang/linux.git
        git fetch --no-tags xiang jeffle/fscache
        git checkout 6e3731398f863eec9b10f9e0cead9f2ec09d8b4d
        # save the config file to linux build tree
        mkdir build_dir
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash fs/cachefiles/

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

>> fs/cachefiles/namei.c:478:8: error: use of undeclared label 'out_unuse'
                   goto out_unuse;
                        ^
   1 error generated.


vim +/out_unuse +478 fs/cachefiles/namei.c

   434	
   435	/*
   436	 * Create a temporary file and leave it unattached and un-xattr'd until the
   437	 * time comes to discard the object from memory.
   438	 */
   439	struct file *cachefiles_create_tmpfile(struct cachefiles_object *object)
   440	{
   441		struct cachefiles_volume *volume = object->volume;
   442		struct cachefiles_cache *cache = volume->cache;
   443		const struct cred *saved_cred;
   444		struct dentry *fan = volume->fanout[(u8)object->cookie->key_hash];
   445		struct file *file;
   446		struct path path;
   447		uint64_t ni_size;
   448		long ret;
   449	
   450	
   451		cachefiles_begin_secure(cache, &saved_cred);
   452	
   453		path.mnt = cache->mnt;
   454		ret = cachefiles_inject_write_error();
   455		if (ret == 0)
   456			path.dentry = vfs_tmpfile(&init_user_ns, fan, S_IFREG, O_RDWR);
   457		else
   458			path.dentry = ERR_PTR(ret);
   459		if (IS_ERR(path.dentry)) {
   460			trace_cachefiles_vfs_error(object, d_inode(fan), PTR_ERR(path.dentry),
   461						   cachefiles_trace_tmpfile_error);
   462			if (PTR_ERR(path.dentry) == -EIO)
   463				cachefiles_io_error_obj(object, "Failed to create tmpfile");
   464			file = ERR_CAST(path.dentry);
   465			goto out;
   466		}
   467	
   468		trace_cachefiles_tmpfile(object, d_backing_inode(path.dentry));
   469	
   470		if (!cachefiles_mark_inode_in_use(object, path.dentry)) {
   471			file = ERR_PTR(-EBUSY);
   472			goto out_dput;
   473		}
   474	
   475		ret = cachefiles_ondemand_init_object(object);
   476		if (ret < 0) {
   477			file = ERR_PTR(ret);
 > 478			goto out_unuse;
   479		}
   480	
   481		ni_size = object->cookie->object_size;
   482		ni_size = round_up(ni_size, CACHEFILES_DIO_BLOCK_SIZE);
   483	
   484		if (ni_size > 0) {
   485			trace_cachefiles_trunc(object, d_backing_inode(path.dentry), 0, ni_size,
   486					       cachefiles_trunc_expand_tmpfile);
   487			ret = cachefiles_inject_write_error();
   488			if (ret == 0)
   489				ret = vfs_truncate(&path, ni_size);
   490			if (ret < 0) {
   491				trace_cachefiles_vfs_error(
   492					object, d_backing_inode(path.dentry), ret,
   493					cachefiles_trace_trunc_error);
   494				file = ERR_PTR(ret);
   495				goto out_dput;
   496			}
   497		}
   498	
   499		file = open_with_fake_path(&path, O_RDWR | O_LARGEFILE | O_DIRECT,
   500					   d_backing_inode(path.dentry), cache->cache_cred);
   501		if (IS_ERR(file)) {
   502			trace_cachefiles_vfs_error(object, d_backing_inode(path.dentry),
   503						   PTR_ERR(file),
   504						   cachefiles_trace_open_error);
   505			goto out_dput;
   506		}
   507		if (unlikely(!file->f_op->read_iter) ||
   508		    unlikely(!file->f_op->write_iter)) {
   509			fput(file);
   510			pr_notice("Cache does not support read_iter and write_iter\n");
   511			file = ERR_PTR(-EINVAL);
   512		}
   513	
   514	out_dput:
   515		dput(path.dentry);
   516	out:
   517		cachefiles_end_secure(cache, saved_cred);
   518		return file;
   519	}
   520	

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp

                 reply	other threads:[~2022-04-02  5:28 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202204021317.7QFcS38O-lkp@intel.com \
    --to=lkp@intel.com \
    --cc=hsiangkao@linux.alibaba.com \
    --cc=jefflexu@linux.alibaba.com \
    --cc=kbuild-all@lists.01.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=llvm@lists.linux.dev \
    --cc=xiang@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.