All of lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH 1/1] package/python-ujson: needs C++
@ 2022-04-04 20:31 Fabrice Fontaine
  2022-04-10 14:46 ` Arnout Vandecappelle
  2022-04-10 19:54 ` Peter Korsgaard
  0 siblings, 2 replies; 3+ messages in thread
From: Fabrice Fontaine @ 2022-04-04 20:31 UTC (permalink / raw)
  To: buildroot; +Cc: Mauro Condarelli, Fabrice Fontaine, Asaf Kahlon

python-ujson needs C++ since bump to version 4.1.0 in commit
a47f332a20bf3f79ef4903c8ddd2b7917217e354 and
https://github.com/ultrajson/ultrajson/commit/eb7d894f225bb89d269188ba6ec559b914a71b8a:

powerpc-buildroot-linux-gnu-gcc.br_real: error: ./deps/double-conversion/double-conversion/bignum-dtoa.cc: C++ compiler not installed on this system

Fixes:
 - http://autobuild.buildroot.org/results/b11600bdba42be9b211163e92afa3173276c3f8f

Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
 package/python-ujson/Config.in | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/package/python-ujson/Config.in b/package/python-ujson/Config.in
index 81d1bc457c..7af03e6497 100644
--- a/package/python-ujson/Config.in
+++ b/package/python-ujson/Config.in
@@ -1,7 +1,11 @@
 config BR2_PACKAGE_PYTHON_UJSON
 	bool "python-ujson"
+	depends on BR2_INSTALL_LIBSTDCPP
 	help
 	  UltraJSON is an ultra fast JSON encoder and decoder written
 	  in pure C with bindings for Python 3.
 
 	  https://pypi.python.org/pypi/ujson
+
+comment "python-ujson needs a toolchain w/ C++"
+	depends on !BR2_INSTALL_LIBSTDCPP
-- 
2.35.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [Buildroot] [PATCH 1/1] package/python-ujson: needs C++
  2022-04-04 20:31 [Buildroot] [PATCH 1/1] package/python-ujson: needs C++ Fabrice Fontaine
@ 2022-04-10 14:46 ` Arnout Vandecappelle
  2022-04-10 19:54 ` Peter Korsgaard
  1 sibling, 0 replies; 3+ messages in thread
From: Arnout Vandecappelle @ 2022-04-10 14:46 UTC (permalink / raw)
  To: Fabrice Fontaine, buildroot; +Cc: Mauro Condarelli, Asaf Kahlon



On 04/04/2022 22:31, Fabrice Fontaine wrote:
> python-ujson needs C++ since bump to version 4.1.0 in commit
> a47f332a20bf3f79ef4903c8ddd2b7917217e354 and
> https://github.com/ultrajson/ultrajson/commit/eb7d894f225bb89d269188ba6ec559b914a71b8a:
> 
> powerpc-buildroot-linux-gnu-gcc.br_real: error: ./deps/double-conversion/double-conversion/bignum-dtoa.cc: C++ compiler not installed on this system
> 
> Fixes:
>   - http://autobuild.buildroot.org/results/b11600bdba42be9b211163e92afa3173276c3f8f
> 
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>

  Applied to master, thanks.

  Regards,
  Arnout

> ---
>   package/python-ujson/Config.in | 4 ++++
>   1 file changed, 4 insertions(+)
> 
> diff --git a/package/python-ujson/Config.in b/package/python-ujson/Config.in
> index 81d1bc457c..7af03e6497 100644
> --- a/package/python-ujson/Config.in
> +++ b/package/python-ujson/Config.in
> @@ -1,7 +1,11 @@
>   config BR2_PACKAGE_PYTHON_UJSON
>   	bool "python-ujson"
> +	depends on BR2_INSTALL_LIBSTDCPP
>   	help
>   	  UltraJSON is an ultra fast JSON encoder and decoder written
>   	  in pure C with bindings for Python 3.
>   
>   	  https://pypi.python.org/pypi/ujson
> +
> +comment "python-ujson needs a toolchain w/ C++"
> +	depends on !BR2_INSTALL_LIBSTDCPP
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [Buildroot] [PATCH 1/1] package/python-ujson: needs C++
  2022-04-04 20:31 [Buildroot] [PATCH 1/1] package/python-ujson: needs C++ Fabrice Fontaine
  2022-04-10 14:46 ` Arnout Vandecappelle
@ 2022-04-10 19:54 ` Peter Korsgaard
  1 sibling, 0 replies; 3+ messages in thread
From: Peter Korsgaard @ 2022-04-10 19:54 UTC (permalink / raw)
  To: Fabrice Fontaine; +Cc: Mauro Condarelli, Asaf Kahlon, buildroot

>>>>> "Fabrice" == Fabrice Fontaine <fontaine.fabrice@gmail.com> writes:

 > python-ujson needs C++ since bump to version 4.1.0 in commit
 > a47f332a20bf3f79ef4903c8ddd2b7917217e354 and
 > https://github.com/ultrajson/ultrajson/commit/eb7d894f225bb89d269188ba6ec559b914a71b8a:

 > powerpc-buildroot-linux-gnu-gcc.br_real: error:
 > ./deps/double-conversion/double-conversion/bignum-dtoa.cc: C++
 > compiler not installed on this system

 > Fixes:
 >  - http://autobuild.buildroot.org/results/b11600bdba42be9b211163e92afa3173276c3f8f

 > Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>

Committed to 2022.02.x, thanks.

-- 
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2022-04-10 19:54 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-04-04 20:31 [Buildroot] [PATCH 1/1] package/python-ujson: needs C++ Fabrice Fontaine
2022-04-10 14:46 ` Arnout Vandecappelle
2022-04-10 19:54 ` Peter Korsgaard

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.