From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B7184C433F5 for ; Tue, 5 Apr 2022 06:24:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230158AbiDEG00 (ORCPT ); Tue, 5 Apr 2022 02:26:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50820 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229685AbiDEG0J (ORCPT ); Tue, 5 Apr 2022 02:26:09 -0400 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9BE4A3B543; Mon, 4 Apr 2022 23:24:11 -0700 (PDT) Received: by verein.lst.de (Postfix, from userid 2407) id A727D68AFE; Tue, 5 Apr 2022 08:24:07 +0200 (CEST) Date: Tue, 5 Apr 2022 08:24:07 +0200 From: Christoph Hellwig To: Jens Axboe Cc: Christoph Hellwig , Hector Martin , Sven Peter , Keith Busch , Sagi Grimberg , Alyssa Rosenzweig , Rob Herring , Arnd Bergmann , Marc Zyngier , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-nvme@lists.infradead.org Subject: Re: [PATCH 6/9] nvme-apple: Add initial Apple SoC NVMe driver Message-ID: <20220405062407.GA24330@lst.de> References: <20220321165049.35985-1-sven@svenpeter.dev> <20220321165049.35985-7-sven@svenpeter.dev> <20220324061620.GA12330@lst.de> <18f3a7e6-16d1-2037-90e7-1c0b1b2fbb1c@marcan.st> <20220404155924.GA9764@lst.de> <367fe64f-0e57-b264-969a-c7cee6344f05@fb.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <367fe64f-0e57-b264-969a-c7cee6344f05@fb.com> User-Agent: Mutt/1.5.17 (2007-11-01) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Apr 04, 2022 at 12:29:08PM -0600, Jens Axboe wrote: > Please reconsider how you phrase these objections. Saying the code is > "completely unreadable" because it's _1_ character over your hard limit > is just nonsense, and not a very productive way to deal with this. Agreed and sorry. I actually had a piece of code in mind that formatted all the comments way to long that really tripped me off, but it wans't this one. Too much going on right now. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C7727C433EF for ; Tue, 5 Apr 2022 06:25:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=d8YvjgJxL4am6Ihp+h+ofkws5L9yp5cghePTIR+nDgI=; b=ZewKGWiHU2EjFd Tu4G9UnLNnDLN9Rbi09pWsaZSPRecFHg7J9pnoN7sRrqgqyhQkljMPDkKTVGu9LaF4qAoCQTWIbGu MB0xFAVqm4UW9pS6dMO9DMRhE/MOLVuivhfiBJlupwKNL4opqud8R7LjA+gCZzkebPSYTOU0BmpAT TZrN+jC1WgUnnSK9q/krKbuTXpZvldD0WB8++STeWYP/eknpWcY3BTliwAGHNDhnso0Uf+4KQ+N4j 2Zthep6pPVQKq+S+PHMIADDPNoFin8RkUQMYSBBKNYdm6fEHeWs7jMMMxwzJ4JEc9Wjk3exa9YMxo wDYE/i4D1J9tSBFQp7lQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nbcbu-00HIQK-LY; Tue, 05 Apr 2022 06:24:14 +0000 Received: from verein.lst.de ([213.95.11.211]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nbcbr-00HIPn-Ch; Tue, 05 Apr 2022 06:24:12 +0000 Received: by verein.lst.de (Postfix, from userid 2407) id A727D68AFE; Tue, 5 Apr 2022 08:24:07 +0200 (CEST) Date: Tue, 5 Apr 2022 08:24:07 +0200 From: Christoph Hellwig To: Jens Axboe Cc: Christoph Hellwig , Hector Martin , Sven Peter , Keith Busch , Sagi Grimberg , Alyssa Rosenzweig , Rob Herring , Arnd Bergmann , Marc Zyngier , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-nvme@lists.infradead.org Subject: Re: [PATCH 6/9] nvme-apple: Add initial Apple SoC NVMe driver Message-ID: <20220405062407.GA24330@lst.de> References: <20220321165049.35985-1-sven@svenpeter.dev> <20220321165049.35985-7-sven@svenpeter.dev> <20220324061620.GA12330@lst.de> <18f3a7e6-16d1-2037-90e7-1c0b1b2fbb1c@marcan.st> <20220404155924.GA9764@lst.de> <367fe64f-0e57-b264-969a-c7cee6344f05@fb.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <367fe64f-0e57-b264-969a-c7cee6344f05@fb.com> User-Agent: Mutt/1.5.17 (2007-11-01) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220404_232411_614033_E569DE01 X-CRM114-Status: GOOD ( 11.15 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Apr 04, 2022 at 12:29:08PM -0600, Jens Axboe wrote: > Please reconsider how you phrase these objections. Saying the code is > "completely unreadable" because it's _1_ character over your hard limit > is just nonsense, and not a very productive way to deal with this. Agreed and sorry. I actually had a piece of code in mind that formatted all the comments way to long that really tripped me off, but it wans't this one. Too much going on right now. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel