From: Heikki Krogerus <heikki.krogerus@linux.intel.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Jia-Ju Bai <baijiaju1990@gmail.com>,
Jack Pham <quic_jackp@quicinc.com>,
linux-usb@vger.kernel.org
Subject: [PATCH v1 0/2] usb: typec: ucsi: Role swapping fixes
Date: Tue, 5 Apr 2022 16:48:22 +0300 [thread overview]
Message-ID: <20220405134824.68067-1-heikki.krogerus@linux.intel.com> (raw)
Hi,
It appears these role swapping routines have been broken for a while.
The role swap UCSI commands always actually did work, and the roles were
most likely always swapped, but these operations just always appeared to
fail because of these bugs.
I'm guessing that has kept the problem hidden. Nobody cared about the
return values from these operations. It was enough that the roles were
swapped in the end.
thanks,
Heikki Krogerus (2):
usb: typec: ucsi: Fix reuse of completion structure
usb: typec: ucsi: Fix role swapping
drivers/usb/typec/ucsi/ucsi.c | 24 +++++++++++++++++-------
1 file changed, 17 insertions(+), 7 deletions(-)
--
2.35.1
next reply other threads:[~2022-04-05 23:26 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-05 13:48 Heikki Krogerus [this message]
2022-04-05 13:48 ` [PATCH v1 1/2] usb: typec: ucsi: Fix reuse of completion structure Heikki Krogerus
2022-04-05 13:48 ` [PATCH v1 2/2] usb: typec: ucsi: Fix role swapping Heikki Krogerus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220405134824.68067-1-heikki.krogerus@linux.intel.com \
--to=heikki.krogerus@linux.intel.com \
--cc=baijiaju1990@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-usb@vger.kernel.org \
--cc=quic_jackp@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.