All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Yann E. MORIN" <yann.morin.1998@free.fr>
To: Peter Seiderer <ps.report@gmx.net>
Cc: buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH v1] package/spidev_test: fix version determination (SPI_TX_OCTAL support needs linux headers >= 5.8)
Date: Tue, 5 Apr 2022 23:20:19 +0200	[thread overview]
Message-ID: <20220405212019.GK2354230@scaer> (raw)
In-Reply-To: <20220405204254.11147-1-ps.report@gmx.net>

Peter, All,

On 2022-04-05 22:42 +0200, Peter Seiderer spake thusly:
> Fixes:
> 
>   - http://autobuild.buildroot.net/results/a5c008aaff40f4851ffa36439c7340b6243a4842
> 
>   .../build/spidev_test-5.8/spidev_test.c:132:13: error: 'SPI_TX_OCTAL' undeclared (first use in this function); did you mean 'SPI_TX_DUAL'?
>     132 |  if (mode & SPI_TX_OCTAL)
>         |             ^~~~~~~~~~~~
>         |             SPI_TX_DUAL
> 
> Signed-off-by: Peter Seiderer <ps.report@gmx.net>

Applied to master, thanks.

Regards,
Yann E. MORIN.

> ---
>  package/spidev_test/Config.in      | 2 +-
>  package/spidev_test/spidev_test.mk | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/package/spidev_test/Config.in b/package/spidev_test/Config.in
> index 81386adf7a..abfa885b73 100644
> --- a/package/spidev_test/Config.in
> +++ b/package/spidev_test/Config.in
> @@ -9,7 +9,7 @@ config BR2_PACKAGE_SPIDEV_TEST
>  	  proper operation of 'spidev_test'.
>  
>  	  The version used is based on your toolchain headers version,
> -	  if it's older than 3.15 then 3.0 is used, up to headers 4.20
> +	  if it's older than 3.15 then 3.0 is used, up to headers 5.7
>  	  version 4.10 is used and otherwise version 5.8.
>  	  This means you won't have quad-pumped SPI support if your
>  	  toolchain is too old.
> diff --git a/package/spidev_test/spidev_test.mk b/package/spidev_test/spidev_test.mk
> index 6c5a9495a4..bd138b0142 100644
> --- a/package/spidev_test/spidev_test.mk
> +++ b/package/spidev_test/spidev_test.mk
> @@ -10,7 +10,7 @@
>  # If you need quad-pumped spi support you need to upgrade your toolchain.
>  # Note that the location of spidev_test.c changes from v4.5 onwards.
>  
> -ifeq ($(BR2_TOOLCHAIN_HEADERS_AT_LEAST_5_0),y)
> +ifeq ($(BR2_TOOLCHAIN_HEADERS_AT_LEAST_5_8),y)
>  SPIDEV_TEST_VERSION = 5.8
>  SPIDEV_TEST_PATH = tools/spi
>  else ifeq ($(BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_15),y)
> -- 
> 2.35.1
> 
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

      reply	other threads:[~2022-04-05 21:20 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-05 20:42 [Buildroot] [PATCH v1] package/spidev_test: fix version determination (SPI_TX_OCTAL support needs linux headers >= 5.8) Peter Seiderer
2022-04-05 21:20 ` Yann E. MORIN [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220405212019.GK2354230@scaer \
    --to=yann.morin.1998@free.fr \
    --cc=buildroot@buildroot.org \
    --cc=ps.report@gmx.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.