All of
 help / color / mirror / Atom feed
From: Frederic Weisbecker <>
To: Anna-Maria Behnsen <>
	Thomas Gleixner <>,
	Peter Zijlstra <>,
	Johannes Berg <>
Subject: Re: [PATCH 2/2] timers: Fix warning in __run_timers()
Date: Tue, 5 Apr 2022 23:43:19 +0200	[thread overview]
Message-ID: <20220405214319.GA1359137@lothringen> (raw)
In-Reply-To: <>

On Tue, Apr 05, 2022 at 09:17:32PM +0200, Anna-Maria Behnsen wrote:
> When the timer base is empty, base::next_expiry is set to base::clk +
> NEXT_TIMER_MAX_DELTA and base::next_expiry_recalc is false. When no timer
> is queued until jiffies reaches base::next_expiry value, the warning for
> not finding any expired timer and base::next_expiry_recalc is false in
> __run_timers() triggers.
> To prevent triggering the warning in this valid scenario
> base::timers_pending needs to be added to the warning condition.
> Fixes: 31cd0e119d50 ("timers: Recalculate next timer interrupt only when necessary")
> Reported-by: Johannes Berg <>
> Signed-off-by: Anna-Maria Behnsen <>

Reviewed-by: Frederic Weisbecker <>


  reply	other threads:[~2022-04-06  2:40 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-05 19:17 [PATCH 0/2] timers: Small fixes Anna-Maria Behnsen
2022-04-05 19:17 ` [PATCH 1/2] timers: Initialize base::next_expiry_recalc during prepare cpu Anna-Maria Behnsen
2022-04-05 21:51   ` Frederic Weisbecker
2022-04-09 20:22   ` [tip: timers/core] timers: Initialize base::next_expiry_recalc in timers_prepare_cpu() tip-bot2 for Anna-Maria Behnsen
2022-04-05 19:17 ` [PATCH 2/2] timers: Fix warning in __run_timers() Anna-Maria Behnsen
2022-04-05 21:43   ` Frederic Weisbecker [this message]
2022-04-09 20:22   ` [tip: timers/core] timers: Fix warning condition " tip-bot2 for Anna-Maria Behnsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220405214319.GA1359137@lothringen \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.