All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: Jens Axboe <axboe@kernel.dk>
Cc: dm-devel@redhat.com, linux-xfs@vger.kernel.org,
	linux-fsdevel@vger.kernel.org, linux-um@lists.infradead.org,
	linux-block@vger.kernel.org, drbd-dev@lists.linbit.com,
	nbd@other.debian.org, ceph-devel@vger.kernel.org,
	virtualization@lists.linux-foundation.org,
	xen-devel@lists.xenproject.org, linux-bcache@vger.kernel.org,
	linux-raid@vger.kernel.org, linux-mmc@vger.kernel.org,
	linux-mtd@lists.infradead.org, linux-nvme@lists.infradead.org,
	linux-s390@vger.kernel.org, linux-scsi@vger.kernel.org,
	target-devel@vger.kernel.org, linux-btrfs@vger.kernel.org,
	linux-ext4@vger.kernel.org,
	linux-f2fs-devel@lists.sourceforge.net, cluster-devel@redhat.com,
	jfs-discussion@lists.sourceforge.net,
	linux-nilfs@vger.kernel.org, ntfs3@lists.linux.dev,
	ocfs2-devel@oss.oracle.com, linux-mm@kvack.org
Subject: [PATCH 22/27] block: refactor discard bio size limiting
Date: Wed,  6 Apr 2022 08:05:11 +0200	[thread overview]
Message-ID: <20220406060516.409838-23-hch@lst.de> (raw)
In-Reply-To: <20220406060516.409838-1-hch@lst.de>

Move all the logic to limit the discard bio size into a common helper
so that it is better documented.

Signed-off-by: Christoph Hellwig <hch@lst.de>
---
 block/blk-lib.c | 59 ++++++++++++++++++++++++-------------------------
 block/blk.h     | 14 ------------
 2 files changed, 29 insertions(+), 44 deletions(-)

diff --git a/block/blk-lib.c b/block/blk-lib.c
index 237d60d8b5857..2ae32a722851c 100644
--- a/block/blk-lib.c
+++ b/block/blk-lib.c
@@ -10,6 +10,32 @@
 
 #include "blk.h"
 
+static sector_t bio_discard_limit(struct block_device *bdev, sector_t sector)
+{
+	unsigned int discard_granularity =
+		bdev_get_queue(bdev)->limits.discard_granularity;
+	sector_t granularity_aligned_sector;
+
+	if (bdev_is_partition(bdev))
+		sector += bdev->bd_start_sect;
+
+	granularity_aligned_sector =
+		round_up(sector, discard_granularity >> SECTOR_SHIFT);
+
+	/*
+	 * Make sure subsequent bios start aligned to the discard granularity if
+	 * it needs to be split.
+	 */
+	if (granularity_aligned_sector != sector)
+		return granularity_aligned_sector - sector;
+
+	/*
+	 * Align the bio size to the discard granularity to make splitting the bio
+	 * at discard granularity boundaries easier in the driver if needed.
+	 */
+	return round_down(UINT_MAX, discard_granularity) >> SECTOR_SHIFT;
+}
+
 int __blkdev_issue_discard(struct block_device *bdev, sector_t sector,
 		sector_t nr_sects, gfp_t gfp_mask, int flags,
 		struct bio **biop)
@@ -17,7 +43,7 @@ int __blkdev_issue_discard(struct block_device *bdev, sector_t sector,
 	struct request_queue *q = bdev_get_queue(bdev);
 	struct bio *bio = *biop;
 	unsigned int op;
-	sector_t bs_mask, part_offset = 0;
+	sector_t bs_mask;
 
 	if (bdev_read_only(bdev))
 		return -EPERM;
@@ -48,36 +74,9 @@ int __blkdev_issue_discard(struct block_device *bdev, sector_t sector,
 	if (!nr_sects)
 		return -EINVAL;
 
-	/* In case the discard request is in a partition */
-	if (bdev_is_partition(bdev))
-		part_offset = bdev->bd_start_sect;
-
 	while (nr_sects) {
-		sector_t granularity_aligned_lba, req_sects;
-		sector_t sector_mapped = sector + part_offset;
-
-		granularity_aligned_lba = round_up(sector_mapped,
-				q->limits.discard_granularity >> SECTOR_SHIFT);
-
-		/*
-		 * Check whether the discard bio starts at a discard_granularity
-		 * aligned LBA,
-		 * - If no: set (granularity_aligned_lba - sector_mapped) to
-		 *   bi_size of the first split bio, then the second bio will
-		 *   start at a discard_granularity aligned LBA on the device.
-		 * - If yes: use bio_aligned_discard_max_sectors() as the max
-		 *   possible bi_size of the first split bio. Then when this bio
-		 *   is split in device drive, the split ones are very probably
-		 *   to be aligned to discard_granularity of the device's queue.
-		 */
-		if (granularity_aligned_lba == sector_mapped)
-			req_sects = min_t(sector_t, nr_sects,
-					  bio_aligned_discard_max_sectors(q));
-		else
-			req_sects = min_t(sector_t, nr_sects,
-					  granularity_aligned_lba - sector_mapped);
-
-		WARN_ON_ONCE((req_sects << 9) > UINT_MAX);
+		sector_t req_sects =
+			min(nr_sects, bio_discard_limit(bdev, sector));
 
 		bio = blk_next_bio(bio, bdev, 0, op, gfp_mask);
 		bio->bi_iter.bi_sector = sector;
diff --git a/block/blk.h b/block/blk.h
index 8ccbc6e076369..1fdc1d28e6d60 100644
--- a/block/blk.h
+++ b/block/blk.h
@@ -346,20 +346,6 @@ static inline unsigned int bio_allowed_max_sectors(struct request_queue *q)
 	return round_down(UINT_MAX, queue_logical_block_size(q)) >> 9;
 }
 
-/*
- * The max bio size which is aligned to q->limits.discard_granularity. This
- * is a hint to split large discard bio in generic block layer, then if device
- * driver needs to split the discard bio into smaller ones, their bi_size can
- * be very probably and easily aligned to discard_granularity of the device's
- * queue.
- */
-static inline unsigned int bio_aligned_discard_max_sectors(
-					struct request_queue *q)
-{
-	return round_down(UINT_MAX, q->limits.discard_granularity) >>
-			SECTOR_SHIFT;
-}
-
 /*
  * Internal io_context interface
  */
-- 
2.30.2


WARNING: multiple messages have this Message-ID
From: Christoph Hellwig <hch@lst.de>
To: Jens Axboe <axboe@kernel.dk>
Cc: jfs-discussion@lists.sourceforge.net,
	linux-nvme@lists.infradead.org,
	virtualization@lists.linux-foundation.org, linux-mm@kvack.org,
	dm-devel@redhat.com, target-devel@vger.kernel.org,
	linux-mtd@lists.infradead.org, drbd-dev@lists.linbit.com,
	linux-s390@vger.kernel.org, linux-nilfs@vger.kernel.org,
	linux-scsi@vger.kernel.org, cluster-devel@redhat.com,
	xen-devel@lists.xenproject.org, linux-ext4@vger.kernel.org,
	linux-um@lists.infradead.org, nbd@other.debian.org,
	linux-block@vger.kernel.org, linux-bcache@vger.kernel.org,
	ceph-devel@vger.kernel.org, linux-raid@vger.kernel.org,
	linux-mmc@vger.kernel.org,
	linux-f2fs-devel@lists.sourceforge.net,
	linux-xfs@vger.kernel.org, ocfs2-devel@oss.oracle.com,
	linux-fsdevel@vger.kernel.org, ntfs3@lists.linux.dev,
	linux-btrfs@vger.kernel.org
Subject: [PATCH 22/27] block: refactor discard bio size limiting
Date: Wed,  6 Apr 2022 08:05:11 +0200	[thread overview]
Message-ID: <20220406060516.409838-23-hch@lst.de> (raw)
In-Reply-To: <20220406060516.409838-1-hch@lst.de>

Move all the logic to limit the discard bio size into a common helper
so that it is better documented.

Signed-off-by: Christoph Hellwig <hch@lst.de>
---
 block/blk-lib.c | 59 ++++++++++++++++++++++++-------------------------
 block/blk.h     | 14 ------------
 2 files changed, 29 insertions(+), 44 deletions(-)

diff --git a/block/blk-lib.c b/block/blk-lib.c
index 237d60d8b5857..2ae32a722851c 100644
--- a/block/blk-lib.c
+++ b/block/blk-lib.c
@@ -10,6 +10,32 @@
 
 #include "blk.h"
 
+static sector_t bio_discard_limit(struct block_device *bdev, sector_t sector)
+{
+	unsigned int discard_granularity =
+		bdev_get_queue(bdev)->limits.discard_granularity;
+	sector_t granularity_aligned_sector;
+
+	if (bdev_is_partition(bdev))
+		sector += bdev->bd_start_sect;
+
+	granularity_aligned_sector =
+		round_up(sector, discard_granularity >> SECTOR_SHIFT);
+
+	/*
+	 * Make sure subsequent bios start aligned to the discard granularity if
+	 * it needs to be split.
+	 */
+	if (granularity_aligned_sector != sector)
+		return granularity_aligned_sector - sector;
+
+	/*
+	 * Align the bio size to the discard granularity to make splitting the bio
+	 * at discard granularity boundaries easier in the driver if needed.
+	 */
+	return round_down(UINT_MAX, discard_granularity) >> SECTOR_SHIFT;
+}
+
 int __blkdev_issue_discard(struct block_device *bdev, sector_t sector,
 		sector_t nr_sects, gfp_t gfp_mask, int flags,
 		struct bio **biop)
@@ -17,7 +43,7 @@ int __blkdev_issue_discard(struct block_device *bdev, sector_t sector,
 	struct request_queue *q = bdev_get_queue(bdev);
 	struct bio *bio = *biop;
 	unsigned int op;
-	sector_t bs_mask, part_offset = 0;
+	sector_t bs_mask;
 
 	if (bdev_read_only(bdev))
 		return -EPERM;
@@ -48,36 +74,9 @@ int __blkdev_issue_discard(struct block_device *bdev, sector_t sector,
 	if (!nr_sects)
 		return -EINVAL;
 
-	/* In case the discard request is in a partition */
-	if (bdev_is_partition(bdev))
-		part_offset = bdev->bd_start_sect;
-
 	while (nr_sects) {
-		sector_t granularity_aligned_lba, req_sects;
-		sector_t sector_mapped = sector + part_offset;
-
-		granularity_aligned_lba = round_up(sector_mapped,
-				q->limits.discard_granularity >> SECTOR_SHIFT);
-
-		/*
-		 * Check whether the discard bio starts at a discard_granularity
-		 * aligned LBA,
-		 * - If no: set (granularity_aligned_lba - sector_mapped) to
-		 *   bi_size of the first split bio, then the second bio will
-		 *   start at a discard_granularity aligned LBA on the device.
-		 * - If yes: use bio_aligned_discard_max_sectors() as the max
-		 *   possible bi_size of the first split bio. Then when this bio
-		 *   is split in device drive, the split ones are very probably
-		 *   to be aligned to discard_granularity of the device's queue.
-		 */
-		if (granularity_aligned_lba == sector_mapped)
-			req_sects = min_t(sector_t, nr_sects,
-					  bio_aligned_discard_max_sectors(q));
-		else
-			req_sects = min_t(sector_t, nr_sects,
-					  granularity_aligned_lba - sector_mapped);
-
-		WARN_ON_ONCE((req_sects << 9) > UINT_MAX);
+		sector_t req_sects =
+			min(nr_sects, bio_discard_limit(bdev, sector));
 
 		bio = blk_next_bio(bio, bdev, 0, op, gfp_mask);
 		bio->bi_iter.bi_sector = sector;
diff --git a/block/blk.h b/block/blk.h
index 8ccbc6e076369..1fdc1d28e6d60 100644
--- a/block/blk.h
+++ b/block/blk.h
@@ -346,20 +346,6 @@ static inline unsigned int bio_allowed_max_sectors(struct request_queue *q)
 	return round_down(UINT_MAX, queue_logical_block_size(q)) >> 9;
 }
 
-/*
- * The max bio size which is aligned to q->limits.discard_granularity. This
- * is a hint to split large discard bio in generic block layer, then if device
- * driver needs to split the discard bio into smaller ones, their bi_size can
- * be very probably and easily aligned to discard_granularity of the device's
- * queue.
- */
-static inline unsigned int bio_aligned_discard_max_sectors(
-					struct request_queue *q)
-{
-	return round_down(UINT_MAX, q->limits.discard_granularity) >>
-			SECTOR_SHIFT;
-}
-
 /*
  * Internal io_context interface
  */
-- 
2.30.2

_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization

WARNING: multiple messages have this Message-ID
From: Christoph Hellwig via Ocfs2-devel <ocfs2-devel@oss.oracle.com>
To: Jens Axboe <axboe@kernel.dk>
Cc: jfs-discussion@lists.sourceforge.net,
	linux-nvme@lists.infradead.org,
	virtualization@lists.linux-foundation.org, linux-mm@kvack.org,
	dm-devel@redhat.com, target-devel@vger.kernel.org,
	linux-mtd@lists.infradead.org, drbd-dev@lists.linbit.com,
	linux-s390@vger.kernel.org, linux-nilfs@vger.kernel.org,
	linux-scsi@vger.kernel.org, cluster-devel@redhat.com,
	xen-devel@lists.xenproject.org, linux-ext4@vger.kernel.org,
	linux-um@lists.infradead.org, nbd@other.debian.org,
	linux-block@vger.kernel.org, linux-bcache@vger.kernel.org,
	ceph-devel@vger.kernel.org, linux-raid@vger.kernel.org,
	linux-mmc@vger.kernel.org,
	linux-f2fs-devel@lists.sourceforge.net,
	linux-xfs@vger.kernel.org, ocfs2-devel@oss.oracle.com,
	linux-fsdevel@vger.kernel.org, ntfs3@lists.linux.dev,
	linux-btrfs@vger.kernel.org
Subject: [Ocfs2-devel] [PATCH 22/27] block: refactor discard bio size	limiting
Date: Wed,  6 Apr 2022 08:05:11 +0200	[thread overview]
Message-ID: <20220406060516.409838-23-hch@lst.de> (raw)
In-Reply-To: <20220406060516.409838-1-hch@lst.de>

Move all the logic to limit the discard bio size into a common helper
so that it is better documented.

Signed-off-by: Christoph Hellwig <hch@lst.de>
---
 block/blk-lib.c | 59 ++++++++++++++++++++++++-------------------------
 block/blk.h     | 14 ------------
 2 files changed, 29 insertions(+), 44 deletions(-)

diff --git a/block/blk-lib.c b/block/blk-lib.c
index 237d60d8b5857..2ae32a722851c 100644
--- a/block/blk-lib.c
+++ b/block/blk-lib.c
@@ -10,6 +10,32 @@
 
 #include "blk.h"
 
+static sector_t bio_discard_limit(struct block_device *bdev, sector_t sector)
+{
+	unsigned int discard_granularity =
+		bdev_get_queue(bdev)->limits.discard_granularity;
+	sector_t granularity_aligned_sector;
+
+	if (bdev_is_partition(bdev))
+		sector += bdev->bd_start_sect;
+
+	granularity_aligned_sector =
+		round_up(sector, discard_granularity >> SECTOR_SHIFT);
+
+	/*
+	 * Make sure subsequent bios start aligned to the discard granularity if
+	 * it needs to be split.
+	 */
+	if (granularity_aligned_sector != sector)
+		return granularity_aligned_sector - sector;
+
+	/*
+	 * Align the bio size to the discard granularity to make splitting the bio
+	 * at discard granularity boundaries easier in the driver if needed.
+	 */
+	return round_down(UINT_MAX, discard_granularity) >> SECTOR_SHIFT;
+}
+
 int __blkdev_issue_discard(struct block_device *bdev, sector_t sector,
 		sector_t nr_sects, gfp_t gfp_mask, int flags,
 		struct bio **biop)
@@ -17,7 +43,7 @@ int __blkdev_issue_discard(struct block_device *bdev, sector_t sector,
 	struct request_queue *q = bdev_get_queue(bdev);
 	struct bio *bio = *biop;
 	unsigned int op;
-	sector_t bs_mask, part_offset = 0;
+	sector_t bs_mask;
 
 	if (bdev_read_only(bdev))
 		return -EPERM;
@@ -48,36 +74,9 @@ int __blkdev_issue_discard(struct block_device *bdev, sector_t sector,
 	if (!nr_sects)
 		return -EINVAL;
 
-	/* In case the discard request is in a partition */
-	if (bdev_is_partition(bdev))
-		part_offset = bdev->bd_start_sect;
-
 	while (nr_sects) {
-		sector_t granularity_aligned_lba, req_sects;
-		sector_t sector_mapped = sector + part_offset;
-
-		granularity_aligned_lba = round_up(sector_mapped,
-				q->limits.discard_granularity >> SECTOR_SHIFT);
-
-		/*
-		 * Check whether the discard bio starts at a discard_granularity
-		 * aligned LBA,
-		 * - If no: set (granularity_aligned_lba - sector_mapped) to
-		 *   bi_size of the first split bio, then the second bio will
-		 *   start at a discard_granularity aligned LBA on the device.
-		 * - If yes: use bio_aligned_discard_max_sectors() as the max
-		 *   possible bi_size of the first split bio. Then when this bio
-		 *   is split in device drive, the split ones are very probably
-		 *   to be aligned to discard_granularity of the device's queue.
-		 */
-		if (granularity_aligned_lba == sector_mapped)
-			req_sects = min_t(sector_t, nr_sects,
-					  bio_aligned_discard_max_sectors(q));
-		else
-			req_sects = min_t(sector_t, nr_sects,
-					  granularity_aligned_lba - sector_mapped);
-
-		WARN_ON_ONCE((req_sects << 9) > UINT_MAX);
+		sector_t req_sects =
+			min(nr_sects, bio_discard_limit(bdev, sector));
 
 		bio = blk_next_bio(bio, bdev, 0, op, gfp_mask);
 		bio->bi_iter.bi_sector = sector;
diff --git a/block/blk.h b/block/blk.h
index 8ccbc6e076369..1fdc1d28e6d60 100644
--- a/block/blk.h
+++ b/block/blk.h
@@ -346,20 +346,6 @@ static inline unsigned int bio_allowed_max_sectors(struct request_queue *q)
 	return round_down(UINT_MAX, queue_logical_block_size(q)) >> 9;
 }
 
-/*
- * The max bio size which is aligned to q->limits.discard_granularity. This
- * is a hint to split large discard bio in generic block layer, then if device
- * driver needs to split the discard bio into smaller ones, their bi_size can
- * be very probably and easily aligned to discard_granularity of the device's
- * queue.
- */
-static inline unsigned int bio_aligned_discard_max_sectors(
-					struct request_queue *q)
-{
-	return round_down(UINT_MAX, q->limits.discard_granularity) >>
-			SECTOR_SHIFT;
-}
-
 /*
  * Internal io_context interface
  */
-- 
2.30.2


_______________________________________________
Ocfs2-devel mailing list
Ocfs2-devel@oss.oracle.com
https://oss.oracle.com/mailman/listinfo/ocfs2-devel

WARNING: multiple messages have this Message-ID
From: Christoph Hellwig <hch@lst.de>
To: Jens Axboe <axboe@kernel.dk>
Cc: jfs-discussion@lists.sourceforge.net,
	linux-nvme@lists.infradead.org,
	virtualization@lists.linux-foundation.org, linux-mm@kvack.org,
	dm-devel@redhat.com, target-devel@vger.kernel.org,
	linux-mtd@lists.infradead.org, drbd-dev@lists.linbit.com,
	linux-s390@vger.kernel.org, linux-nilfs@vger.kernel.org,
	linux-scsi@vger.kernel.org, cluster-devel@redhat.com,
	xen-devel@lists.xenproject.org, linux-ext4@vger.kernel.org,
	linux-um@lists.infradead.org, nbd@other.debian.org,
	linux-block@vger.kernel.org, linux-bcache@vger.kernel.org,
	ceph-devel@vger.kernel.org, linux-raid@vger.kernel.org,
	linux-mmc@vger.kernel.org,
	linux-f2fs-devel@lists.sourceforge.net,
	linux-xfs@vger.kernel.org, ocfs2-devel@oss.oracle.com,
	linux-fsdevel@vger.kernel.org, ntfs3@lists.linux.dev,
	linux-btrfs@vger.kernel.org
Subject: [f2fs-dev] [PATCH 22/27] block: refactor discard bio size limiting
Date: Wed,  6 Apr 2022 08:05:11 +0200	[thread overview]
Message-ID: <20220406060516.409838-23-hch@lst.de> (raw)
In-Reply-To: <20220406060516.409838-1-hch@lst.de>

Move all the logic to limit the discard bio size into a common helper
so that it is better documented.

Signed-off-by: Christoph Hellwig <hch@lst.de>
---
 block/blk-lib.c | 59 ++++++++++++++++++++++++-------------------------
 block/blk.h     | 14 ------------
 2 files changed, 29 insertions(+), 44 deletions(-)

diff --git a/block/blk-lib.c b/block/blk-lib.c
index 237d60d8b5857..2ae32a722851c 100644
--- a/block/blk-lib.c
+++ b/block/blk-lib.c
@@ -10,6 +10,32 @@
 
 #include "blk.h"
 
+static sector_t bio_discard_limit(struct block_device *bdev, sector_t sector)
+{
+	unsigned int discard_granularity =
+		bdev_get_queue(bdev)->limits.discard_granularity;
+	sector_t granularity_aligned_sector;
+
+	if (bdev_is_partition(bdev))
+		sector += bdev->bd_start_sect;
+
+	granularity_aligned_sector =
+		round_up(sector, discard_granularity >> SECTOR_SHIFT);
+
+	/*
+	 * Make sure subsequent bios start aligned to the discard granularity if
+	 * it needs to be split.
+	 */
+	if (granularity_aligned_sector != sector)
+		return granularity_aligned_sector - sector;
+
+	/*
+	 * Align the bio size to the discard granularity to make splitting the bio
+	 * at discard granularity boundaries easier in the driver if needed.
+	 */
+	return round_down(UINT_MAX, discard_granularity) >> SECTOR_SHIFT;
+}
+
 int __blkdev_issue_discard(struct block_device *bdev, sector_t sector,
 		sector_t nr_sects, gfp_t gfp_mask, int flags,
 		struct bio **biop)
@@ -17,7 +43,7 @@ int __blkdev_issue_discard(struct block_device *bdev, sector_t sector,
 	struct request_queue *q = bdev_get_queue(bdev);
 	struct bio *bio = *biop;
 	unsigned int op;
-	sector_t bs_mask, part_offset = 0;
+	sector_t bs_mask;
 
 	if (bdev_read_only(bdev))
 		return -EPERM;
@@ -48,36 +74,9 @@ int __blkdev_issue_discard(struct block_device *bdev, sector_t sector,
 	if (!nr_sects)
 		return -EINVAL;
 
-	/* In case the discard request is in a partition */
-	if (bdev_is_partition(bdev))
-		part_offset = bdev->bd_start_sect;
-
 	while (nr_sects) {
-		sector_t granularity_aligned_lba, req_sects;
-		sector_t sector_mapped = sector + part_offset;
-
-		granularity_aligned_lba = round_up(sector_mapped,
-				q->limits.discard_granularity >> SECTOR_SHIFT);
-
-		/*
-		 * Check whether the discard bio starts at a discard_granularity
-		 * aligned LBA,
-		 * - If no: set (granularity_aligned_lba - sector_mapped) to
-		 *   bi_size of the first split bio, then the second bio will
-		 *   start at a discard_granularity aligned LBA on the device.
-		 * - If yes: use bio_aligned_discard_max_sectors() as the max
-		 *   possible bi_size of the first split bio. Then when this bio
-		 *   is split in device drive, the split ones are very probably
-		 *   to be aligned to discard_granularity of the device's queue.
-		 */
-		if (granularity_aligned_lba == sector_mapped)
-			req_sects = min_t(sector_t, nr_sects,
-					  bio_aligned_discard_max_sectors(q));
-		else
-			req_sects = min_t(sector_t, nr_sects,
-					  granularity_aligned_lba - sector_mapped);
-
-		WARN_ON_ONCE((req_sects << 9) > UINT_MAX);
+		sector_t req_sects =
+			min(nr_sects, bio_discard_limit(bdev, sector));
 
 		bio = blk_next_bio(bio, bdev, 0, op, gfp_mask);
 		bio->bi_iter.bi_sector = sector;
diff --git a/block/blk.h b/block/blk.h
index 8ccbc6e076369..1fdc1d28e6d60 100644
--- a/block/blk.h
+++ b/block/blk.h
@@ -346,20 +346,6 @@ static inline unsigned int bio_allowed_max_sectors(struct request_queue *q)
 	return round_down(UINT_MAX, queue_logical_block_size(q)) >> 9;
 }
 
-/*
- * The max bio size which is aligned to q->limits.discard_granularity. This
- * is a hint to split large discard bio in generic block layer, then if device
- * driver needs to split the discard bio into smaller ones, their bi_size can
- * be very probably and easily aligned to discard_granularity of the device's
- * queue.
- */
-static inline unsigned int bio_aligned_discard_max_sectors(
-					struct request_queue *q)
-{
-	return round_down(UINT_MAX, q->limits.discard_granularity) >>
-			SECTOR_SHIFT;
-}
-
 /*
  * Internal io_context interface
  */
-- 
2.30.2



_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel

WARNING: multiple messages have this Message-ID
From: Christoph Hellwig <hch@lst.de>
To: Jens Axboe <axboe@kernel.dk>
Cc: jfs-discussion@lists.sourceforge.net,
	linux-nvme@lists.infradead.org,
	virtualization@lists.linux-foundation.org, linux-mm@kvack.org,
	dm-devel@redhat.com, target-devel@vger.kernel.org,
	linux-mtd@lists.infradead.org, drbd-dev@lists.linbit.com,
	linux-s390@vger.kernel.org, linux-nilfs@vger.kernel.org,
	linux-scsi@vger.kernel.org, cluster-devel@redhat.com,
	xen-devel@lists.xenproject.org, linux-ext4@vger.kernel.org,
	linux-um@lists.infradead.org, nbd@other.debian.org,
	linux-block@vger.kernel.org, linux-bcache@vger.kernel.org,
	ceph-devel@vger.kernel.org, linux-raid@vger.kernel.org,
	linux-mmc@vger.kernel.org,
	linux-f2fs-devel@lists.sourceforge.net,
	linux-xfs@vger.kernel.org, ocfs2-devel@oss.oracle.com,
	linux-fsdevel@vger.kernel.org, ntfs3@lists.linux.dev,
	linux-btrfs@vger.kernel.org
Subject: [dm-devel] [PATCH 22/27] block: refactor discard bio size limiting
Date: Wed,  6 Apr 2022 08:05:11 +0200	[thread overview]
Message-ID: <20220406060516.409838-23-hch@lst.de> (raw)
In-Reply-To: <20220406060516.409838-1-hch@lst.de>

Move all the logic to limit the discard bio size into a common helper
so that it is better documented.

Signed-off-by: Christoph Hellwig <hch@lst.de>
---
 block/blk-lib.c | 59 ++++++++++++++++++++++++-------------------------
 block/blk.h     | 14 ------------
 2 files changed, 29 insertions(+), 44 deletions(-)

diff --git a/block/blk-lib.c b/block/blk-lib.c
index 237d60d8b5857..2ae32a722851c 100644
--- a/block/blk-lib.c
+++ b/block/blk-lib.c
@@ -10,6 +10,32 @@
 
 #include "blk.h"
 
+static sector_t bio_discard_limit(struct block_device *bdev, sector_t sector)
+{
+	unsigned int discard_granularity =
+		bdev_get_queue(bdev)->limits.discard_granularity;
+	sector_t granularity_aligned_sector;
+
+	if (bdev_is_partition(bdev))
+		sector += bdev->bd_start_sect;
+
+	granularity_aligned_sector =
+		round_up(sector, discard_granularity >> SECTOR_SHIFT);
+
+	/*
+	 * Make sure subsequent bios start aligned to the discard granularity if
+	 * it needs to be split.
+	 */
+	if (granularity_aligned_sector != sector)
+		return granularity_aligned_sector - sector;
+
+	/*
+	 * Align the bio size to the discard granularity to make splitting the bio
+	 * at discard granularity boundaries easier in the driver if needed.
+	 */
+	return round_down(UINT_MAX, discard_granularity) >> SECTOR_SHIFT;
+}
+
 int __blkdev_issue_discard(struct block_device *bdev, sector_t sector,
 		sector_t nr_sects, gfp_t gfp_mask, int flags,
 		struct bio **biop)
@@ -17,7 +43,7 @@ int __blkdev_issue_discard(struct block_device *bdev, sector_t sector,
 	struct request_queue *q = bdev_get_queue(bdev);
 	struct bio *bio = *biop;
 	unsigned int op;
-	sector_t bs_mask, part_offset = 0;
+	sector_t bs_mask;
 
 	if (bdev_read_only(bdev))
 		return -EPERM;
@@ -48,36 +74,9 @@ int __blkdev_issue_discard(struct block_device *bdev, sector_t sector,
 	if (!nr_sects)
 		return -EINVAL;
 
-	/* In case the discard request is in a partition */
-	if (bdev_is_partition(bdev))
-		part_offset = bdev->bd_start_sect;
-
 	while (nr_sects) {
-		sector_t granularity_aligned_lba, req_sects;
-		sector_t sector_mapped = sector + part_offset;
-
-		granularity_aligned_lba = round_up(sector_mapped,
-				q->limits.discard_granularity >> SECTOR_SHIFT);
-
-		/*
-		 * Check whether the discard bio starts at a discard_granularity
-		 * aligned LBA,
-		 * - If no: set (granularity_aligned_lba - sector_mapped) to
-		 *   bi_size of the first split bio, then the second bio will
-		 *   start at a discard_granularity aligned LBA on the device.
-		 * - If yes: use bio_aligned_discard_max_sectors() as the max
-		 *   possible bi_size of the first split bio. Then when this bio
-		 *   is split in device drive, the split ones are very probably
-		 *   to be aligned to discard_granularity of the device's queue.
-		 */
-		if (granularity_aligned_lba == sector_mapped)
-			req_sects = min_t(sector_t, nr_sects,
-					  bio_aligned_discard_max_sectors(q));
-		else
-			req_sects = min_t(sector_t, nr_sects,
-					  granularity_aligned_lba - sector_mapped);
-
-		WARN_ON_ONCE((req_sects << 9) > UINT_MAX);
+		sector_t req_sects =
+			min(nr_sects, bio_discard_limit(bdev, sector));
 
 		bio = blk_next_bio(bio, bdev, 0, op, gfp_mask);
 		bio->bi_iter.bi_sector = sector;
diff --git a/block/blk.h b/block/blk.h
index 8ccbc6e076369..1fdc1d28e6d60 100644
--- a/block/blk.h
+++ b/block/blk.h
@@ -346,20 +346,6 @@ static inline unsigned int bio_allowed_max_sectors(struct request_queue *q)
 	return round_down(UINT_MAX, queue_logical_block_size(q)) >> 9;
 }
 
-/*
- * The max bio size which is aligned to q->limits.discard_granularity. This
- * is a hint to split large discard bio in generic block layer, then if device
- * driver needs to split the discard bio into smaller ones, their bi_size can
- * be very probably and easily aligned to discard_granularity of the device's
- * queue.
- */
-static inline unsigned int bio_aligned_discard_max_sectors(
-					struct request_queue *q)
-{
-	return round_down(UINT_MAX, q->limits.discard_granularity) >>
-			SECTOR_SHIFT;
-}
-
 /*
  * Internal io_context interface
  */
-- 
2.30.2

--
dm-devel mailing list
dm-devel@redhat.com
https://listman.redhat.com/mailman/listinfo/dm-devel


WARNING: multiple messages have this Message-ID
From: Christoph Hellwig <hch@lst.de>
To: Jens Axboe <axboe@kernel.dk>
Cc: dm-devel@redhat.com, linux-xfs@vger.kernel.org,
	linux-fsdevel@vger.kernel.org, linux-um@lists.infradead.org,
	linux-block@vger.kernel.org, drbd-dev@lists.linbit.com,
	nbd@other.debian.org, ceph-devel@vger.kernel.org,
	virtualization@lists.linux-foundation.org,
	xen-devel@lists.xenproject.org, linux-bcache@vger.kernel.org,
	linux-raid@vger.kernel.org, linux-mmc@vger.kernel.org,
	linux-mtd@lists.infradead.org, linux-nvme@lists.infradead.org,
	linux-s390@vger.kernel.org, linux-scsi@vger.kernel.org,
	target-devel@vger.kernel.org, linux-btrfs@vger.kernel.org,
	linux-ext4@vger.kernel.org,
	linux-f2fs-devel@lists.sourceforge.net, cluster-devel@redhat.com,
	jfs-discussion@lists.sourceforge.net,
	linux-nilfs@vger.kernel.org, ntfs3@lists.linux.dev,
	ocfs2-devel@oss.oracle.com, linux-mm@kvack.org
Subject: [PATCH 22/27] block: refactor discard bio size limiting
Date: Wed,  6 Apr 2022 08:05:11 +0200	[thread overview]
Message-ID: <20220406060516.409838-23-hch@lst.de> (raw)
In-Reply-To: <20220406060516.409838-1-hch@lst.de>

Move all the logic to limit the discard bio size into a common helper
so that it is better documented.

Signed-off-by: Christoph Hellwig <hch@lst.de>
---
 block/blk-lib.c | 59 ++++++++++++++++++++++++-------------------------
 block/blk.h     | 14 ------------
 2 files changed, 29 insertions(+), 44 deletions(-)

diff --git a/block/blk-lib.c b/block/blk-lib.c
index 237d60d8b5857..2ae32a722851c 100644
--- a/block/blk-lib.c
+++ b/block/blk-lib.c
@@ -10,6 +10,32 @@
 
 #include "blk.h"
 
+static sector_t bio_discard_limit(struct block_device *bdev, sector_t sector)
+{
+	unsigned int discard_granularity =
+		bdev_get_queue(bdev)->limits.discard_granularity;
+	sector_t granularity_aligned_sector;
+
+	if (bdev_is_partition(bdev))
+		sector += bdev->bd_start_sect;
+
+	granularity_aligned_sector =
+		round_up(sector, discard_granularity >> SECTOR_SHIFT);
+
+	/*
+	 * Make sure subsequent bios start aligned to the discard granularity if
+	 * it needs to be split.
+	 */
+	if (granularity_aligned_sector != sector)
+		return granularity_aligned_sector - sector;
+
+	/*
+	 * Align the bio size to the discard granularity to make splitting the bio
+	 * at discard granularity boundaries easier in the driver if needed.
+	 */
+	return round_down(UINT_MAX, discard_granularity) >> SECTOR_SHIFT;
+}
+
 int __blkdev_issue_discard(struct block_device *bdev, sector_t sector,
 		sector_t nr_sects, gfp_t gfp_mask, int flags,
 		struct bio **biop)
@@ -17,7 +43,7 @@ int __blkdev_issue_discard(struct block_device *bdev, sector_t sector,
 	struct request_queue *q = bdev_get_queue(bdev);
 	struct bio *bio = *biop;
 	unsigned int op;
-	sector_t bs_mask, part_offset = 0;
+	sector_t bs_mask;
 
 	if (bdev_read_only(bdev))
 		return -EPERM;
@@ -48,36 +74,9 @@ int __blkdev_issue_discard(struct block_device *bdev, sector_t sector,
 	if (!nr_sects)
 		return -EINVAL;
 
-	/* In case the discard request is in a partition */
-	if (bdev_is_partition(bdev))
-		part_offset = bdev->bd_start_sect;
-
 	while (nr_sects) {
-		sector_t granularity_aligned_lba, req_sects;
-		sector_t sector_mapped = sector + part_offset;
-
-		granularity_aligned_lba = round_up(sector_mapped,
-				q->limits.discard_granularity >> SECTOR_SHIFT);
-
-		/*
-		 * Check whether the discard bio starts at a discard_granularity
-		 * aligned LBA,
-		 * - If no: set (granularity_aligned_lba - sector_mapped) to
-		 *   bi_size of the first split bio, then the second bio will
-		 *   start at a discard_granularity aligned LBA on the device.
-		 * - If yes: use bio_aligned_discard_max_sectors() as the max
-		 *   possible bi_size of the first split bio. Then when this bio
-		 *   is split in device drive, the split ones are very probably
-		 *   to be aligned to discard_granularity of the device's queue.
-		 */
-		if (granularity_aligned_lba == sector_mapped)
-			req_sects = min_t(sector_t, nr_sects,
-					  bio_aligned_discard_max_sectors(q));
-		else
-			req_sects = min_t(sector_t, nr_sects,
-					  granularity_aligned_lba - sector_mapped);
-
-		WARN_ON_ONCE((req_sects << 9) > UINT_MAX);
+		sector_t req_sects =
+			min(nr_sects, bio_discard_limit(bdev, sector));
 
 		bio = blk_next_bio(bio, bdev, 0, op, gfp_mask);
 		bio->bi_iter.bi_sector = sector;
diff --git a/block/blk.h b/block/blk.h
index 8ccbc6e076369..1fdc1d28e6d60 100644
--- a/block/blk.h
+++ b/block/blk.h
@@ -346,20 +346,6 @@ static inline unsigned int bio_allowed_max_sectors(struct request_queue *q)
 	return round_down(UINT_MAX, queue_logical_block_size(q)) >> 9;
 }
 
-/*
- * The max bio size which is aligned to q->limits.discard_granularity. This
- * is a hint to split large discard bio in generic block layer, then if device
- * driver needs to split the discard bio into smaller ones, their bi_size can
- * be very probably and easily aligned to discard_granularity of the device's
- * queue.
- */
-static inline unsigned int bio_aligned_discard_max_sectors(
-					struct request_queue *q)
-{
-	return round_down(UINT_MAX, q->limits.discard_granularity) >>
-			SECTOR_SHIFT;
-}
-
 /*
  * Internal io_context interface
  */
-- 
2.30.2


______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

  parent reply	other threads:[~2022-04-06  6:07 UTC|newest]

Thread overview: 403+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-06  6:04 use block_device based APIs in block layer consumers Christoph Hellwig
2022-04-06  6:04 ` [Ocfs2-devel] " Christoph Hellwig via Ocfs2-devel
2022-04-06  6:04 ` [dm-devel] " Christoph Hellwig
2022-04-06  6:04 ` Christoph Hellwig
2022-04-06  6:04 ` Christoph Hellwig
2022-04-06  6:04 ` [f2fs-dev] " Christoph Hellwig
2022-04-06  6:04 ` [PATCH 01/27] target: remove an incorrect unmap zeroes data deduction Christoph Hellwig
2022-04-06  6:04   ` [Ocfs2-devel] " Christoph Hellwig via Ocfs2-devel
2022-04-06  6:04   ` [dm-devel] " Christoph Hellwig
2022-04-06  6:04   ` Christoph Hellwig
2022-04-06  6:04   ` Christoph Hellwig
2022-04-06  6:04   ` [f2fs-dev] " Christoph Hellwig
2022-04-07  3:05   ` [dm-devel] " Martin K. Petersen
2022-04-07  3:05     ` Martin K. Petersen
2022-04-07  3:05     ` [f2fs-dev] " Martin K. Petersen
2022-04-07  3:05     ` Martin K. Petersen
2022-04-07  3:05     ` Martin K. Petersen
2022-04-07  3:05     ` [Ocfs2-devel] " Martin K. Petersen via Ocfs2-devel
2022-04-07  3:06   ` Martin K. Petersen
2022-04-07  3:06     ` Martin K. Petersen
2022-04-07  3:06     ` Martin K. Petersen
2022-04-07  3:06     ` Martin K. Petersen
2022-04-07  3:06     ` [f2fs-dev] " Martin K. Petersen
2022-04-07  3:06     ` [Ocfs2-devel] " Martin K. Petersen via Ocfs2-devel
2022-04-06  6:04 ` [f2fs-dev] [PATCH 02/27] target: pass a block_device to target_configure_unmap_from_queue Christoph Hellwig
2022-04-06  6:04   ` Christoph Hellwig
2022-04-06  6:04   ` [Ocfs2-devel] " Christoph Hellwig via Ocfs2-devel
2022-04-06  6:04   ` Christoph Hellwig
2022-04-06  6:04   ` [dm-devel] " Christoph Hellwig
2022-04-06  6:04   ` Christoph Hellwig
2022-04-07  3:07   ` Martin K. Petersen
2022-04-07  3:07     ` [dm-devel] " Martin K. Petersen
2022-04-07  3:07     ` Martin K. Petersen
2022-04-07  3:07     ` Martin K. Petersen
2022-04-07  3:07     ` [f2fs-dev] " Martin K. Petersen
2022-04-07  3:07     ` [Ocfs2-devel] " Martin K. Petersen via Ocfs2-devel
2022-04-06  6:04 ` [f2fs-dev] [PATCH 03/27] target: fix discard alignment on partitions Christoph Hellwig
2022-04-06  6:04   ` Christoph Hellwig
2022-04-06  6:04   ` [Ocfs2-devel] " Christoph Hellwig via Ocfs2-devel
2022-04-06  6:04   ` Christoph Hellwig
2022-04-06  6:04   ` [dm-devel] " Christoph Hellwig
2022-04-06  6:04   ` Christoph Hellwig
2022-04-07  3:14   ` [Ocfs2-devel] [dm-devel] " Martin K. Petersen via Ocfs2-devel
2022-04-07  3:14     ` Martin K. Petersen
2022-04-07  3:14     ` Martin K. Petersen
2022-04-07  3:14     ` [f2fs-dev] " Martin K. Petersen
2022-04-07  3:14     ` Martin K. Petersen
2022-04-07  3:14     ` Martin K. Petersen
2022-04-06  6:04 ` [f2fs-dev] [PATCH 04/27] drbd: remove assign_p_sizes_qlim Christoph Hellwig
2022-04-06  6:04   ` Christoph Hellwig
2022-04-06  6:04   ` [Ocfs2-devel] " Christoph Hellwig via Ocfs2-devel
2022-04-06  6:04   ` Christoph Hellwig
2022-04-06  6:04   ` [dm-devel] " Christoph Hellwig
2022-04-06  6:04   ` Christoph Hellwig
2022-04-06  9:09   ` [Drbd-dev] " Christoph Böhmwalder
2022-04-06  6:04 ` [f2fs-dev] [PATCH 05/27] drbd: use bdev based limit helpers in drbd_send_sizes Christoph Hellwig
2022-04-06  6:04   ` Christoph Hellwig
2022-04-06  6:04   ` [Ocfs2-devel] " Christoph Hellwig via Ocfs2-devel
2022-04-06  6:04   ` Christoph Hellwig
2022-04-06  6:04   ` [dm-devel] " Christoph Hellwig
2022-04-06  6:04   ` Christoph Hellwig
2022-04-06  9:20   ` [Drbd-dev] " Christoph Böhmwalder
2022-04-06  6:04 ` [f2fs-dev] [PATCH 06/27] drbd: cleanup decide_on_discard_support Christoph Hellwig
2022-04-06  6:04   ` Christoph Hellwig
2022-04-06  6:04   ` [dm-devel] " Christoph Hellwig
2022-04-06  6:04   ` [Ocfs2-devel] " Christoph Hellwig via Ocfs2-devel
2022-04-06  6:04   ` Christoph Hellwig
2022-04-06  6:04   ` Christoph Hellwig
2022-04-06  9:28   ` [Drbd-dev] " Christoph Böhmwalder
2022-04-06  6:04 ` [f2fs-dev] [PATCH 07/27] btrfs: use bdev_max_active_zones instead of open coding it Christoph Hellwig
2022-04-06  6:04   ` Christoph Hellwig
2022-04-06  6:04   ` [Ocfs2-devel] " Christoph Hellwig via Ocfs2-devel
2022-04-06  6:04   ` Christoph Hellwig
2022-04-06  6:04   ` [dm-devel] " Christoph Hellwig
2022-04-06  6:04   ` Christoph Hellwig
2022-04-06  9:56   ` [Ocfs2-devel] " Johannes Thumshirn via Ocfs2-devel
2022-04-06  9:56     ` [f2fs-dev] " Johannes Thumshirn via Linux-f2fs-devel
2022-04-06  9:56     ` Johannes Thumshirn
2022-04-06  9:56     ` [dm-devel] " Johannes Thumshirn
2022-04-06  9:56     ` Johannes Thumshirn
2022-04-07 15:20   ` David Sterba
2022-04-07 15:20     ` [dm-devel] " David Sterba
2022-04-07 15:20     ` [f2fs-dev] " David Sterba
2022-04-07 15:20     ` David Sterba
2022-04-07 15:20     ` David Sterba
2022-04-07 15:20     ` [Ocfs2-devel] " David Sterba via Ocfs2-devel
2022-04-07 15:26     ` Christoph Hellwig
2022-04-07 15:26       ` Christoph Hellwig
2022-04-07 15:26       ` [dm-devel] " Christoph Hellwig
2022-04-07 15:26       ` [f2fs-dev] " Christoph Hellwig
2022-04-07 15:26       ` Christoph Hellwig
2022-04-06  6:04 ` [PATCH 08/27] ntfs3: use bdev_logical_block_size " Christoph Hellwig
2022-04-06  6:04   ` Christoph Hellwig
2022-04-06  6:04   ` [dm-devel] " Christoph Hellwig
2022-04-06  6:04   ` [f2fs-dev] " Christoph Hellwig
2022-04-06  6:04   ` [Ocfs2-devel] " Christoph Hellwig via Ocfs2-devel
2022-04-06  6:04   ` Christoph Hellwig
2022-04-06  6:04 ` [PATCH 09/27] mm: use bdev_is_zoned in claim_swapfile Christoph Hellwig
2022-04-06  6:04   ` Christoph Hellwig
2022-04-06  6:04   ` [dm-devel] " Christoph Hellwig
2022-04-06  6:04   ` [f2fs-dev] " Christoph Hellwig
2022-04-06  6:04   ` [Ocfs2-devel] " Christoph Hellwig via Ocfs2-devel
2022-04-06  6:04   ` Christoph Hellwig
2022-04-06  6:04 ` [PATCH 10/27] block: add a bdev_nonrot helper Christoph Hellwig
2022-04-06  6:04   ` Christoph Hellwig
2022-04-06  6:04   ` [dm-devel] " Christoph Hellwig
2022-04-06  6:04   ` Christoph Hellwig
2022-04-06  6:04   ` [f2fs-dev] " Christoph Hellwig
2022-04-06  6:04   ` [Ocfs2-devel] " Christoph Hellwig via Ocfs2-devel
2022-04-07  3:16   ` Martin K. Petersen via Ocfs2-devel
2022-04-07  3:16     ` Martin K. Petersen
2022-04-07  3:16     ` [dm-devel] " Martin K. Petersen
2022-04-07  3:16     ` [f2fs-dev] " Martin K. Petersen
2022-04-07  3:16     ` Martin K. Petersen
2022-04-07  3:16     ` Martin K. Petersen
2022-04-07 15:21   ` David Sterba
2022-04-07 15:21     ` [dm-devel] " David Sterba
2022-04-07 15:21     ` [f2fs-dev] " David Sterba
2022-04-07 15:21     ` David Sterba
2022-04-07 15:21     ` David Sterba
2022-04-07 15:21     ` [Ocfs2-devel] " David Sterba via Ocfs2-devel
2022-04-06  6:05 ` [PATCH 11/27] block: add a bdev_write_cache helper Christoph Hellwig
2022-04-06  6:05   ` Christoph Hellwig
2022-04-06  6:05   ` [dm-devel] " Christoph Hellwig
2022-04-06  6:05   ` Christoph Hellwig
2022-04-06  6:05   ` [f2fs-dev] " Christoph Hellwig
2022-04-06  6:05   ` [Ocfs2-devel] " Christoph Hellwig via Ocfs2-devel
2022-04-07  3:17   ` Martin K. Petersen via Ocfs2-devel
2022-04-07  3:17     ` Martin K. Petersen
2022-04-07  3:17     ` [dm-devel] " Martin K. Petersen
2022-04-07  3:17     ` Martin K. Petersen
2022-04-07  3:17     ` Martin K. Petersen
2022-04-07  3:17     ` [f2fs-dev] " Martin K. Petersen
2022-04-07 15:21   ` David Sterba
2022-04-07 15:21     ` [dm-devel] " David Sterba
2022-04-07 15:21     ` [f2fs-dev] " David Sterba
2022-04-07 15:21     ` David Sterba
2022-04-07 15:21     ` David Sterba
2022-04-07 15:21     ` [Ocfs2-devel] " David Sterba via Ocfs2-devel
2022-04-06  6:05 ` [PATCH 12/27] block: add a bdev_fua helper Christoph Hellwig
2022-04-06  6:05   ` Christoph Hellwig
2022-04-06  6:05   ` [dm-devel] " Christoph Hellwig
2022-04-06  6:05   ` Christoph Hellwig
2022-04-06  6:05   ` [f2fs-dev] " Christoph Hellwig
2022-04-06  6:05   ` [Ocfs2-devel] " Christoph Hellwig via Ocfs2-devel
2022-04-07  3:17   ` Martin K. Petersen via Ocfs2-devel
2022-04-07  3:17     ` Martin K. Petersen
2022-04-07  3:17     ` [dm-devel] " Martin K. Petersen
2022-04-07  3:17     ` [f2fs-dev] " Martin K. Petersen
2022-04-07  3:17     ` Martin K. Petersen
2022-04-07  3:17     ` Martin K. Petersen
2022-04-06  6:05 ` [PATCH 13/27] block: add a bdev_stable_writes helper Christoph Hellwig
2022-04-06  6:05   ` Christoph Hellwig
2022-04-06  6:05   ` [dm-devel] " Christoph Hellwig
2022-04-06  6:05   ` Christoph Hellwig
2022-04-06  6:05   ` [f2fs-dev] " Christoph Hellwig
2022-04-06  6:05   ` [Ocfs2-devel] " Christoph Hellwig via Ocfs2-devel
2022-04-07  3:18   ` Martin K. Petersen
2022-04-07  3:18     ` Martin K. Petersen
2022-04-07  3:18     ` [dm-devel] " Martin K. Petersen
2022-04-07  3:18     ` Martin K. Petersen
2022-04-07  3:18     ` [f2fs-dev] " Martin K. Petersen
2022-04-07  3:18     ` Martin K. Petersen via Ocfs2-devel
2022-04-06  6:05 ` [PATCH 14/27] block: add a bdev_max_zone_append_sectors helper Christoph Hellwig
2022-04-06  6:05   ` Christoph Hellwig
2022-04-06  6:05   ` [dm-devel] " Christoph Hellwig
2022-04-06  6:05   ` Christoph Hellwig
2022-04-06  6:05   ` [f2fs-dev] " Christoph Hellwig
2022-04-06  6:05   ` [Ocfs2-devel] " Christoph Hellwig via Ocfs2-devel
2022-04-06  8:52   ` Damien Le Moal
2022-04-06  8:52     ` [f2fs-dev] " Damien Le Moal via Linux-f2fs-devel
2022-04-06  8:52     ` [dm-devel] " Damien Le Moal
2022-04-06  8:52     ` Damien Le Moal
2022-04-06  9:58   ` [Ocfs2-devel] " Johannes Thumshirn via Ocfs2-devel
2022-04-06  9:58     ` [f2fs-dev] " Johannes Thumshirn via Linux-f2fs-devel
2022-04-06  9:58     ` Johannes Thumshirn
2022-04-06  9:58     ` [dm-devel] " Johannes Thumshirn
2022-04-06  9:58     ` Johannes Thumshirn
2022-04-07  3:15   ` [Ocfs2-devel] [dm-devel] " Martin K. Petersen via Ocfs2-devel
2022-04-07  3:15     ` Martin K. Petersen
2022-04-07  3:15     ` Martin K. Petersen
2022-04-07  3:15     ` Martin K. Petersen
2022-04-07  3:15     ` [f2fs-dev] " Martin K. Petersen
2022-04-07  3:15     ` Martin K. Petersen
2022-04-06  6:05 ` [PATCH 15/27] block: use bdev_alignment_offset in part_alignment_offset_show Christoph Hellwig
2022-04-06  6:05   ` Christoph Hellwig
2022-04-06  6:05   ` [dm-devel] " Christoph Hellwig
2022-04-06  6:05   ` Christoph Hellwig
2022-04-06  6:05   ` [f2fs-dev] " Christoph Hellwig
2022-04-06  6:05   ` [Ocfs2-devel] " Christoph Hellwig via Ocfs2-devel
2022-04-07  3:19   ` Martin K. Petersen via Ocfs2-devel
2022-04-07  3:19     ` Martin K. Petersen
2022-04-07  3:19     ` [dm-devel] " Martin K. Petersen
2022-04-07  3:19     ` [f2fs-dev] " Martin K. Petersen
2022-04-07  3:19     ` Martin K. Petersen
2022-04-07  3:19     ` Martin K. Petersen
2022-04-06  6:05 ` [PATCH 16/27] drbd: use bdev_alignment_offset instead of queue_alignment_offset Christoph Hellwig
2022-04-06  6:05   ` Christoph Hellwig
2022-04-06  6:05   ` [dm-devel] " Christoph Hellwig
2022-04-06  6:05   ` Christoph Hellwig
2022-04-06  6:05   ` [f2fs-dev] " Christoph Hellwig
2022-04-06  6:05   ` [Ocfs2-devel] " Christoph Hellwig via Ocfs2-devel
2022-04-06  9:32   ` [Drbd-dev] " Christoph Böhmwalder
2022-04-06  6:05 ` [PATCH 17/27] block: use bdev_alignment_offset in disk_alignment_offset_show Christoph Hellwig
2022-04-06  6:05   ` Christoph Hellwig
2022-04-06  6:05   ` [dm-devel] " Christoph Hellwig
2022-04-06  6:05   ` Christoph Hellwig
2022-04-06  6:05   ` [f2fs-dev] " Christoph Hellwig
2022-04-06  6:05   ` [Ocfs2-devel] " Christoph Hellwig via Ocfs2-devel
2022-04-07  3:20   ` Martin K. Petersen via Ocfs2-devel
2022-04-07  3:20     ` Martin K. Petersen
2022-04-07  3:20     ` [dm-devel] " Martin K. Petersen
2022-04-07  3:20     ` Martin K. Petersen
2022-04-07  3:20     ` [f2fs-dev] " Martin K. Petersen
2022-04-07  3:20     ` Martin K. Petersen
2022-04-06  6:05 ` [PATCH 18/27] block: move bdev_alignment_offset and queue_limit_alignment_offset out of line Christoph Hellwig
2022-04-06  6:05   ` Christoph Hellwig
2022-04-06  6:05   ` [dm-devel] " Christoph Hellwig
2022-04-06  6:05   ` Christoph Hellwig
2022-04-06  6:05   ` [f2fs-dev] " Christoph Hellwig
2022-04-06  6:05   ` [Ocfs2-devel] " Christoph Hellwig via Ocfs2-devel
2022-04-07  3:21   ` Martin K. Petersen via Ocfs2-devel
2022-04-07  3:21     ` Martin K. Petersen
2022-04-07  3:21     ` [dm-devel] " Martin K. Petersen
2022-04-07  3:21     ` Martin K. Petersen
2022-04-07  3:21     ` [f2fs-dev] " Martin K. Petersen
2022-04-07  3:21     ` Martin K. Petersen
2022-04-06  6:05 ` [PATCH 19/27] block: remove queue_discard_alignment Christoph Hellwig
2022-04-06  6:05   ` Christoph Hellwig
2022-04-06  6:05   ` [dm-devel] " Christoph Hellwig
2022-04-06  6:05   ` Christoph Hellwig
2022-04-06  6:05   ` [f2fs-dev] " Christoph Hellwig
2022-04-06  6:05   ` [Ocfs2-devel] " Christoph Hellwig via Ocfs2-devel
2022-04-07  3:21   ` Martin K. Petersen via Ocfs2-devel
2022-04-07  3:21     ` Martin K. Petersen
2022-04-07  3:21     ` [dm-devel] " Martin K. Petersen
2022-04-07  3:21     ` [f2fs-dev] " Martin K. Petersen
2022-04-07  3:21     ` Martin K. Petersen
2022-04-07  3:21     ` Martin K. Petersen
2022-04-06  6:05 ` [PATCH 20/27] block: use bdev_discard_alignment in part_discard_alignment_show Christoph Hellwig
2022-04-06  6:05   ` Christoph Hellwig
2022-04-06  6:05   ` [dm-devel] " Christoph Hellwig
2022-04-06  6:05   ` [Ocfs2-devel] " Christoph Hellwig via Ocfs2-devel
2022-04-06  6:05   ` Christoph Hellwig
2022-04-06  6:05   ` [f2fs-dev] " Christoph Hellwig
2022-04-07  3:22   ` [Ocfs2-devel] " Martin K. Petersen via Ocfs2-devel
2022-04-07  3:22     ` Martin K. Petersen
2022-04-07  3:22     ` [dm-devel] " Martin K. Petersen
2022-04-07  3:22     ` Martin K. Petersen
2022-04-07  3:22     ` [f2fs-dev] " Martin K. Petersen
2022-04-07  3:22     ` Martin K. Petersen
2022-04-06  6:05 ` [PATCH 21/27] block: move {bdev,queue_limit}_discard_alignment out of line Christoph Hellwig
2022-04-06  6:05   ` [PATCH 21/27] block: move {bdev, queue_limit}_discard_alignment " Christoph Hellwig
2022-04-06  6:05   ` Christoph Hellwig
2022-04-06  6:05   ` [dm-devel] " Christoph Hellwig
2022-04-06  6:05   ` Christoph Hellwig
2022-04-06  6:05   ` [f2fs-dev] " Christoph Hellwig
2022-04-06  6:05   ` [Ocfs2-devel] " Christoph Hellwig via Ocfs2-devel
2022-04-07  3:27   ` Martin K. Petersen
2022-04-07  3:27     ` Martin K. Petersen
2022-04-07  3:27     ` [dm-devel] " Martin K. Petersen
2022-04-07  3:27     ` Martin K. Petersen via Ocfs2-devel
2022-04-07  3:27     ` Martin K. Petersen
2022-04-07  3:27     ` [f2fs-dev] " Martin K. Petersen
2022-04-06  6:05 ` Christoph Hellwig [this message]
2022-04-06  6:05   ` [PATCH 22/27] block: refactor discard bio size limiting Christoph Hellwig
2022-04-06  6:05   ` [dm-devel] " Christoph Hellwig
2022-04-06  6:05   ` [f2fs-dev] " Christoph Hellwig
2022-04-06  6:05   ` [Ocfs2-devel] " Christoph Hellwig via Ocfs2-devel
2022-04-06  6:05   ` Christoph Hellwig
2022-04-07  3:29   ` [Ocfs2-devel] " Martin K. Petersen
2022-04-07  3:29     ` Martin K. Petersen
2022-04-07  3:29     ` [dm-devel] " Martin K. Petersen
2022-04-07  3:29     ` Martin K. Petersen
2022-04-07  3:29     ` [f2fs-dev] " Martin K. Petersen
2022-04-07  3:29     ` Martin K. Petersen via Ocfs2-devel
2022-04-07  8:03   ` Coly Li
2022-04-07  8:03     ` Coly Li
2022-04-07  8:03     ` [dm-devel] " Coly Li
2022-04-07  8:03     ` [f2fs-dev] " Coly Li
2022-04-06  6:05 ` [Ocfs2-devel] [PATCH 23/27] block: add a bdev_max_discard_sectors helper Christoph Hellwig via Ocfs2-devel
2022-04-06  6:05   ` Christoph Hellwig
2022-04-06  6:05   ` [dm-devel] " Christoph Hellwig
2022-04-06  6:05   ` Christoph Hellwig
2022-04-06  6:05   ` Christoph Hellwig
2022-04-06  6:05   ` [f2fs-dev] " Christoph Hellwig
2022-04-06  9:36   ` [Drbd-dev] " Christoph Böhmwalder
2022-04-06  9:53   ` [Cluster-devel] " Andreas Gruenbacher
2022-04-06  9:53     ` [dm-devel] " Andreas Gruenbacher
2022-04-06  9:53     ` Andreas Gruenbacher
2022-04-06  9:53     ` [f2fs-dev] " Andreas Gruenbacher
2022-04-06  9:53     ` [Ocfs2-devel] " Andreas Gruenbacher via Ocfs2-devel
2022-04-06 17:28   ` Ryusuke Konishi
2022-04-06 17:28     ` [dm-devel] " Ryusuke Konishi
2022-04-06 17:28     ` Ryusuke Konishi
2022-04-06 17:28     ` [f2fs-dev] " Ryusuke Konishi
2022-04-07  3:30   ` [Ocfs2-devel] " Martin K. Petersen via Ocfs2-devel
2022-04-07  3:30     ` Martin K. Petersen
2022-04-07  3:30     ` [dm-devel] " Martin K. Petersen
2022-04-07  3:30     ` Martin K. Petersen
2022-04-07  3:30     ` [f2fs-dev] " Martin K. Petersen
2022-04-07  3:30     ` Martin K. Petersen
2022-04-07  5:16   ` Coly Li
2022-04-07  5:16     ` [dm-devel] " Coly Li
2022-04-07  5:16     ` Coly Li
2022-04-07  5:16     ` [f2fs-dev] " Coly Li
2022-04-07 15:22   ` David Sterba
2022-04-07 15:22     ` [dm-devel] " David Sterba
2022-04-07 15:22     ` [f2fs-dev] " David Sterba
2022-04-07 15:22     ` David Sterba
2022-04-07 15:22     ` [Ocfs2-devel] " David Sterba via Ocfs2-devel
2022-04-07 15:22     ` David Sterba
2022-04-06  6:05 ` [PATCH 24/27] block: add a bdev_discard_granularity helper Christoph Hellwig
2022-04-06  6:05   ` Christoph Hellwig
2022-04-06  6:05   ` [dm-devel] " Christoph Hellwig
2022-04-06  6:05   ` Christoph Hellwig
2022-04-06  6:05   ` [f2fs-dev] " Christoph Hellwig
2022-04-06  6:05   ` [Ocfs2-devel] " Christoph Hellwig via Ocfs2-devel
2022-04-06  9:40   ` [Drbd-dev] " Christoph Böhmwalder
2022-04-06 18:26   ` Ryusuke Konishi
2022-04-06 18:26     ` [dm-devel] " Ryusuke Konishi
2022-04-06 18:26     ` Ryusuke Konishi
2022-04-06 18:26     ` [f2fs-dev] " Ryusuke Konishi
2022-04-07  3:32   ` [Ocfs2-devel] " Martin K. Petersen via Ocfs2-devel
2022-04-07  3:32     ` Martin K. Petersen
2022-04-07  3:32     ` [dm-devel] " Martin K. Petersen
2022-04-07  3:32     ` Martin K. Petersen
2022-04-07  3:32     ` Martin K. Petersen
2022-04-07  3:32     ` [f2fs-dev] " Martin K. Petersen
2022-04-07 15:26   ` David Sterba via Ocfs2-devel
2022-04-07 15:26     ` [dm-devel] " David Sterba
2022-04-07 15:26     ` David Sterba
2022-04-07 15:26     ` [f2fs-dev] " David Sterba
2022-04-07 15:26     ` David Sterba
2022-04-07 15:26     ` David Sterba
2022-04-06  6:05 ` [Ocfs2-devel] [PATCH 25/27] block: remove QUEUE_FLAG_DISCARD Christoph Hellwig via Ocfs2-devel
2022-04-06  6:05   ` Christoph Hellwig
2022-04-06  6:05   ` [dm-devel] " Christoph Hellwig
2022-04-06  6:05   ` Christoph Hellwig
2022-04-06  6:05   ` Christoph Hellwig
2022-04-06  6:05   ` [f2fs-dev] " Christoph Hellwig
2022-04-06  9:43   ` [Drbd-dev] " Christoph Böhmwalder
2022-04-07  3:34   ` [Ocfs2-devel] " Martin K. Petersen via Ocfs2-devel
2022-04-07  3:34     ` Martin K. Petersen
2022-04-07  3:34     ` [dm-devel] " Martin K. Petersen
2022-04-07  3:34     ` [f2fs-dev] " Martin K. Petersen
2022-04-07  3:34     ` Martin K. Petersen
2022-04-07  3:34     ` Martin K. Petersen
2022-04-07  5:18   ` Coly Li
2022-04-07  5:18     ` [dm-devel] " Coly Li
2022-04-07  5:18     ` Coly Li
2022-04-07  5:18     ` [f2fs-dev] " Coly Li
2022-04-06  6:05 ` [Ocfs2-devel] [PATCH 26/27] block: uncouple REQ_OP_SECURE_ERASE from REQ_OP_DISCARD Christoph Hellwig via Ocfs2-devel
2022-04-06  6:05   ` Christoph Hellwig
2022-04-06  6:05   ` [dm-devel] " Christoph Hellwig
2022-04-06  6:05   ` Christoph Hellwig
2022-04-06  6:05   ` Christoph Hellwig
2022-04-06  6:05   ` [f2fs-dev] " Christoph Hellwig
2022-04-06  9:45   ` [Drbd-dev] " Christoph Böhmwalder
2022-04-07  3:36   ` [Ocfs2-devel] " Martin K. Petersen via Ocfs2-devel
2022-04-07  3:36     ` Martin K. Petersen
2022-04-07  3:36     ` [dm-devel] " Martin K. Petersen
2022-04-07  3:36     ` Martin K. Petersen
2022-04-07  3:36     ` [f2fs-dev] " Martin K. Petersen
2022-04-07  3:36     ` Martin K. Petersen
2022-04-07  6:09   ` Coly Li
2022-04-07  6:09     ` [dm-devel] " Coly Li
2022-04-07  6:09     ` Coly Li
2022-04-07  6:09     ` [f2fs-dev] " Coly Li
2022-04-07  7:01   ` Ryusuke Konishi
2022-04-07  7:01     ` [dm-devel] " Ryusuke Konishi
2022-04-07  7:01     ` Ryusuke Konishi
2022-04-07  7:01     ` [f2fs-dev] " Ryusuke Konishi
2022-04-07 15:26   ` [Ocfs2-devel] " David Sterba via Ocfs2-devel
2022-04-07 15:26     ` [dm-devel] " David Sterba
2022-04-07 15:26     ` David Sterba
2022-04-07 15:26     ` [f2fs-dev] " David Sterba
2022-04-07 15:26     ` David Sterba
2022-04-07 15:26     ` David Sterba
2022-04-11 18:24   ` [f2fs-dev] " Jaegeuk Kim
2022-04-11 18:24     ` [dm-devel] " Jaegeuk Kim
2022-04-11 18:24     ` Jaegeuk Kim
2022-04-11 18:24     ` Jaegeuk Kim
2022-04-11 18:24     ` [Ocfs2-devel] " Jaegeuk Kim via Ocfs2-devel
2022-04-06  6:05 ` [Ocfs2-devel] [PATCH 27/27] direct-io: remove random prefetches Christoph Hellwig via Ocfs2-devel
2022-04-06  6:05   ` Christoph Hellwig
2022-04-06  6:05   ` [dm-devel] " Christoph Hellwig
2022-04-06  6:05   ` Christoph Hellwig
2022-04-06  6:05   ` Christoph Hellwig
2022-04-06  6:05   ` [f2fs-dev] " Christoph Hellwig
     [not found] ` <0b7ae3df301c4fdd8d37f773d8d1eb93@FR3P281MB0843.DEUP281.PROD.OUTLOOK.COM>
2022-04-06  7:04   ` [PATCH 15/27] block: use bdev_alignment_offset in part_alignment_offset_show Alan Robinson
2022-04-06  7:04     ` [dm-devel] " Alan Robinson
2022-04-06  7:04     ` Alan Robinson
2022-04-06  7:04     ` [f2fs-dev] " Alan Robinson
2022-04-06  7:04     ` Alan Robinson
2022-04-09  4:50 use block_device based APIs in block layer consumers v2 Christoph Hellwig
2022-04-09  4:50 ` [PATCH 22/27] block: refactor discard bio size limiting Christoph Hellwig
2022-04-09  4:50   ` Christoph Hellwig
2022-04-09  4:50   ` Christoph Hellwig
2022-04-15  4:52 use block_device based APIs in block layer consumers v3 Christoph Hellwig
2022-04-15  4:52 ` [PATCH 22/27] block: refactor discard bio size limiting Christoph Hellwig
2022-04-15  4:52   ` Christoph Hellwig
2022-04-15  4:52   ` Christoph Hellwig
2022-04-15  5:46   ` Chaitanya Kulkarni
2022-04-15  5:46     ` Chaitanya Kulkarni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220406060516.409838-23-hch@lst.de \
    --to=hch@lst.de \
    --cc=axboe@kernel.dk \
    --cc=ceph-devel@vger.kernel.org \
    --cc=cluster-devel@redhat.com \
    --cc=dm-devel@redhat.com \
    --cc=drbd-dev@lists.linbit.com \
    --cc=jfs-discussion@lists.sourceforge.net \
    --cc=linux-bcache@vger.kernel.org \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-btrfs@vger.kernel.org \
    --cc=linux-ext4@vger.kernel.org \
    --cc=linux-f2fs-devel@lists.sourceforge.net \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=linux-mmc@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=linux-nilfs@vger.kernel.org \
    --cc=linux-nvme@lists.infradead.org \
    --cc=linux-raid@vger.kernel.org \
    --cc=linux-s390@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=linux-um@lists.infradead.org \
    --cc=linux-xfs@vger.kernel.org \
    --cc=nbd@other.debian.org \
    --cc=ntfs3@lists.linux.dev \
    --cc=ocfs2-devel@oss.oracle.com \
    --cc=target-devel@vger.kernel.org \
    --cc=virtualization@lists.linux-foundation.org \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.