From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 87E07C433F5 for ; Wed, 6 Apr 2022 11:01:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240672AbiDFLDQ (ORCPT ); Wed, 6 Apr 2022 07:03:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44482 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1354322AbiDFLCi (ORCPT ); Wed, 6 Apr 2022 07:02:38 -0400 Received: from desiato.infradead.org (desiato.infradead.org [IPv6:2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 69C3C528D3C for ; Wed, 6 Apr 2022 00:29:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=3JjTLPdPSJ39pHGd48spiEl6+cFumvV5r8fxCWUxCn8=; b=iMWpYPXE1d5UMEh0IGNfqV2tw2 zwxa7xHlEXejRaAzN8IGTYL6QpUh1jyBQJ2Fz7YuuyPy22PFi3t/uNFdfRDjI6UBsEY9hgxbu8L0T Np2bfr3DZJbZ4VhJbgF6s9qfBWz7F12mW9CqsdOk7bOro0UjKZ3UHc3qUacQlg/ukLr8qM72eKSBb sPD7f8/zGyC9Ne7uag23Tsb/sm7s3U1Uti0ysQf+Ux6JZCXMRVOX5JBKiNem2JmcPauflWA51+iRW UoKoei2rx3gtJvFaTC6luDjg2O0jVMg5cMLz5mpfN43IFaEXynVWeI7lZxNC5OUrl1nRFNzDgWQ0P kWruCcKg==; Received: from j217100.upc-j.chello.nl ([24.132.217.100] helo=worktop.programming.kicks-ass.net) by desiato.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1nc06N-0026Gw-GH; Wed, 06 Apr 2022 07:29:16 +0000 Received: by worktop.programming.kicks-ass.net (Postfix, from userid 1000) id 46E959861A5; Wed, 6 Apr 2022 09:29:13 +0200 (CEST) Date: Wed, 6 Apr 2022 09:29:13 +0200 From: Peter Zijlstra To: Josh Poimboeuf Cc: Thomas Gleixner , kernel test robot , kbuild-all@lists.01.org, linux-kernel@vger.kernel.org, mbenes@suse.cz, x86@kernel.org, Steven Rostedt Subject: Re: drivers/gpu/drm/i915/i915.prelink.o: warning: objtool: __intel_wait_for_register_fw.cold()+0xce: relocation to !ENDBR: vlv_allow_gt_wake.cold+0x0 Message-ID: <20220406072913.GC34954@worktop.programming.kicks-ass.net> References: <202204041241.Hw855BWm-lkp@intel.com> <20220406000500.5hlaqy5zrdqsg5mg@treble> <87czhv11k1.ffs@tglx> <20220406053251.6dyfxrjmmgdwocfc@treble> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220406053251.6dyfxrjmmgdwocfc@treble> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Apr 05, 2022 at 10:32:51PM -0700, Josh Poimboeuf wrote: > On Wed, Apr 06, 2022 at 02:46:22AM +0200, Thomas Gleixner wrote: > > On Tue, Apr 05 2022 at 17:05, Josh Poimboeuf wrote: > > > On Tue, Apr 05, 2022 at 04:01:15PM +0200, Peter Zijlstra wrote: > > > > > > But objtool is complaining about a real problem (albeit with a cryptic > > > warning). I don't think we want to paper over that. See patch. > > > > > > Also, are in-tree users of trace_printk() even allowed?? > > > > See the comment in the header file you are patching: > > > > * This is intended as a debugging tool for the developer only. > > * Please refrain from leaving trace_printks scattered around in > > * your code. (Extra memory is used for special buffers that are > > * allocated when trace_printk() is used.) > > So what do we do ... send a nastygram? Best would be for Steve to send a patch removing them all: arch/powerpc/kvm/book3s_xics.c:#define XICS_DBG(fmt...) trace_printk(fmt) drivers/gpu/drm/i915/gt/intel_gtt.h:#define DBG(...) trace_printk(__VA_ARGS__) drivers/gpu/drm/i915/i915_gem.h:#define GEM_TRACE(...) trace_printk(__VA_ARGS__) drivers/gpu/drm/i915/i915_gem.h: trace_printk(__VA_ARGS__); \ drivers/hwtracing/stm/dummy_stm.c: trace_printk("[%u:%u] [pkt: %x/%x] (%llx)\n", master, channel, drivers/infiniband/hw/hfi1/trace_dbg.h: trace_printk(fmt, ##__VA_ARGS__) drivers/tty/n_tty.c:# define n_tty_trace(f, args...) trace_printk(f, ##args) drivers/usb/early/xhci-dbc.c:#define xdbc_trace trace_printk fs/ext4/inline.c: trace_printk("inode %lu\n", dir->i_ino); fs/ext4/inline.c: trace_printk("de: off %u rlen %u name %.*s nlen %u ino %u\n", All except i915 use CPP tokens that don't exist, local developer really has to take effort to enable it. i915 crud depends on a CONFIG_ symbols that all{yes,mod}config will happily set for you, From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: multipart/mixed; boundary="===============4198107411156249123==" MIME-Version: 1.0 From: Peter Zijlstra To: kbuild-all@lists.01.org Subject: Re: drivers/gpu/drm/i915/i915.prelink.o: warning: objtool: __intel_wait_for_register_fw.cold()+0xce: relocation to !ENDBR: vlv_allow_gt_wake.cold+0x0 Date: Wed, 06 Apr 2022 09:29:13 +0200 Message-ID: <20220406072913.GC34954@worktop.programming.kicks-ass.net> In-Reply-To: <20220406053251.6dyfxrjmmgdwocfc@treble> List-Id: --===============4198107411156249123== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable On Tue, Apr 05, 2022 at 10:32:51PM -0700, Josh Poimboeuf wrote: > On Wed, Apr 06, 2022 at 02:46:22AM +0200, Thomas Gleixner wrote: > > On Tue, Apr 05 2022 at 17:05, Josh Poimboeuf wrote: > > > On Tue, Apr 05, 2022 at 04:01:15PM +0200, Peter Zijlstra wrote: > > > > > > But objtool is complaining about a real problem (albeit with a cryptic > > > warning). I don't think we want to paper over that. See patch. > > > > > > Also, are in-tree users of trace_printk() even allowed?? > > = > > See the comment in the header file you are patching: > > = > > * This is intended as a debugging tool for the developer only. > > * Please refrain from leaving trace_printks scattered around in > > * your code. (Extra memory is used for special buffers that are > > * allocated when trace_printk() is used.) > = > So what do we do ... send a nastygram? = Best would be for Steve to send a patch removing them all: arch/powerpc/kvm/book3s_xics.c:#define XICS_DBG(fmt...) trace_printk(fmt) drivers/gpu/drm/i915/gt/intel_gtt.h:#define DBG(...) trace_printk(__VA_ARGS= __) drivers/gpu/drm/i915/i915_gem.h:#define GEM_TRACE(...) trace_printk(__VA_AR= GS__) drivers/gpu/drm/i915/i915_gem.h: trace_printk(__VA_ARGS__); = \ drivers/hwtracing/stm/dummy_stm.c: trace_printk("[%u:%u] [pkt: %x/%x] = (%llx)\n", master, channel, drivers/infiniband/hw/hfi1/trace_dbg.h: trace_printk(fmt, ##__VA_ARGS__) drivers/tty/n_tty.c:# define n_tty_trace(f, args...) trace_printk(f, ##a= rgs) drivers/usb/early/xhci-dbc.c:#define xdbc_trace trace_printk fs/ext4/inline.c: trace_printk("inode %lu\n", dir->i_ino); fs/ext4/inline.c: trace_printk("de: off %u rlen %u name %.*s = nlen %u ino %u\n", All except i915 use CPP tokens that don't exist, local developer really has to take effort to enable it. i915 crud depends on a CONFIG_ symbols that all{yes,mod}config will happily set for you, --===============4198107411156249123==--