All of lore.kernel.org
 help / color / mirror / Atom feed
From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Magnus Damm <magnus.damm@gmail.com>,
	Gareth Williams <gareth.williams.jx@renesas.com>,
	Phil Edworthy <phil.edworthy@renesas.com>,
	Geert Uytterhoeven <geert@linux-m68k.org>,
	Vinod Koul <vkoul@kernel.org>,
	linux-renesas-soc@vger.kernel.org, dmaengine@vger.kernel.org,
	Milan Stevanovic <milan.stevanovic@se.com>,
	Jimmy Lalande <jimmy.lalande@se.com>,
	Pascal Eberhard <pascal.eberhard@se.com>,
	Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
	Herve Codina <herve.codina@bootlin.com>,
	Clement Leger <clement.leger@bootlin.com>,
	Stephen Boyd <sboyd@kernel.org>,
	Michael Turquette <mturquette@baylibre.com>,
	linux-clk@vger.kernel.org, Viresh Kumar <vireshk@kernel.org>,
	Ilpo Jarvinen <ilpo.jarvinen@linux.intel.com>
Subject: Re: [PATCH v7 5/9] dmaengine: dw: dmamux: Introduce RZN1 DMA router support
Date: Wed, 6 Apr 2022 14:13:46 +0200	[thread overview]
Message-ID: <20220406141346.5caf746c@xps13> (raw)
In-Reply-To: <Yk1WWaJ9IJsU5HXV@smile.fi.intel.com>

Hi Andy,

andriy.shevchenko@linux.intel.com wrote on Wed, 6 Apr 2022 11:59:05
+0300:

> On Wed, Apr 06, 2022 at 09:49:08AM +0200, Miquel Raynal wrote:
> > andriy.shevchenko@linux.intel.com wrote on Tue, 5 Apr 2022 17:50:57
> > +0300:  
> > > On Tue, Apr 05, 2022 at 10:19:07AM +0200, Miquel Raynal wrote:  
> 
> ...
> 
> > > > +#define RZN1_DMAMUX_SPLIT 16  
> > >
> > > I would name it more explicitly:
> > > 
> > > #define RZN1_DMAMUX_SPLIT_1_0	 16  
> > 
> > I am sorry but I don't understand this suffix, which probably means
> > that it is not as clear as we wish. Do you mind if I stick to
> > RZN1_DMAMUX_SPLIT?  
> 
> The suffix to show that this is the value between part 0 (indexed by 0) and
> part 1 (indexed by 1) as far as I can see they are different by size. Since
> they are not equal, the original name without suffix is confusing (I would
> expect indexing up to 4 in such case).

They are equivalent in size (0-15/16-31), or aren't we talking about the
same thing?

Thanks,
Miquèl

  reply	other threads:[~2022-04-06 15:12 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-05  8:19 [PATCH v7 0/9] RZN1 DMA support Miquel Raynal
2022-04-05  8:19 ` [PATCH v7 1/9] dt-bindings: dmaengine: Introduce RZN1 dmamux bindings Miquel Raynal
2022-04-05 18:12   ` Rob Herring
2022-04-06  7:31     ` Miquel Raynal
2022-04-05  8:19 ` [PATCH v7 2/9] dt-bindings: clock: r9a06g032-sysctrl: Reference the DMAMUX subnode Miquel Raynal
2022-04-05  8:19 ` [PATCH v7 3/9] dt-bindings: dmaengine: Introduce RZN1 DMA compatible Miquel Raynal
2022-04-05  8:19 ` [PATCH v7 4/9] soc: renesas: rzn1-sysc: Export function to set dmamux Miquel Raynal
2022-04-05  8:19 ` [PATCH v7 5/9] dmaengine: dw: dmamux: Introduce RZN1 DMA router support Miquel Raynal
2022-04-05 14:50   ` Andy Shevchenko
2022-04-06  7:49     ` Miquel Raynal
2022-04-06  8:59       ` Andy Shevchenko
2022-04-06 12:13         ` Miquel Raynal [this message]
2022-04-06 12:47           ` Andy Shevchenko
2022-04-05  8:19 ` [PATCH v7 6/9] clk: renesas: r9a06g032: Probe possible children Miquel Raynal
2022-04-05  8:19 ` [PATCH v7 7/9] dmaengine: dw: Add RZN1 compatible Miquel Raynal
2022-04-05 14:51   ` Andy Shevchenko
2022-04-05  8:19 ` [PATCH v7 8/9] ARM: dts: r9a06g032: Add the two DMA nodes Miquel Raynal
2022-04-05  8:19 ` [PATCH v7 9/9] ARM: dts: r9a06g032: Describe the DMA router Miquel Raynal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220406141346.5caf746c@xps13 \
    --to=miquel.raynal@bootlin.com \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=clement.leger@bootlin.com \
    --cc=dmaengine@vger.kernel.org \
    --cc=gareth.williams.jx@renesas.com \
    --cc=geert@linux-m68k.org \
    --cc=herve.codina@bootlin.com \
    --cc=ilpo.jarvinen@linux.intel.com \
    --cc=jimmy.lalande@se.com \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=magnus.damm@gmail.com \
    --cc=milan.stevanovic@se.com \
    --cc=mturquette@baylibre.com \
    --cc=pascal.eberhard@se.com \
    --cc=phil.edworthy@renesas.com \
    --cc=sboyd@kernel.org \
    --cc=thomas.petazzoni@bootlin.com \
    --cc=vireshk@kernel.org \
    --cc=vkoul@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.