From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 69353C433EF for ; Wed, 6 Apr 2022 20:01:10 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 2CD221703; Wed, 6 Apr 2022 22:00:18 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 2CD221703 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1649275268; bh=DJzkIrSAHCA6cRSISS+QV1y58Ivj2Wq3yloyBt2Huuc=; h=Date:From:To:Subject:References:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=DpHXvQZUeaORMnqTcO9tQq0mbv1+cuG5mlZmPhLyrEpTGR0XlU7MQcScjHbkMu3Y5 brzns9bFjhnB8gPA9hdkWA9hjPrsg6CwuAX3XqvX3hrybr9G2lsRID9+x6neX6BWiN mCUT79ER1Cw1n9LLMoT/5ePGI/p6ElLw9pBFUaoE= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id BF1B7F800D1; Wed, 6 Apr 2022 22:00:17 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 2D6ABF80054; Wed, 6 Apr 2022 22:00:16 +0200 (CEST) Received: from lahtoruutu.iki.fi (lahtoruutu.iki.fi [185.185.170.37]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id A770EF80054 for ; Wed, 6 Apr 2022 22:00:13 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz A770EF80054 Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key) header.d=iki.fi header.i=@iki.fi header.b="Nn4RAbFb" Received: from darkstar.musicnaut.iki.fi (85-76-76-218-nat.elisa-mobile.fi [85.76.76.218]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: aaro.koskinen) by lahtoruutu.iki.fi (Postfix) with ESMTPSA id C3DA61B000E0; Wed, 6 Apr 2022 23:00:11 +0300 (EEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=iki.fi; s=lahtoruutu; t=1649275212; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=HF/OS3JAtoNKv3AksoUVmxtqiwmaGXqNkeVyB7AYT2k=; b=Nn4RAbFbzK4bwfg86ykyMmwZil9SKibzGCF6IqPtA9woskWkPm0Qpo8xHB6DmiuFZCDabl hKhYB7cTF1pnQmfdEueduNI+Bie9rxrrlv4+Ae9YdogxoZPaT+AnKd36njOcJfii/ZG9el NXeQ9cJa9eyyADZvMify5l3g3e6/9P6d54WrG6RxGfxgsqDX4gklm2g60np78Z2iAK4H5W MYGDa3g/ettQmzEK/GGe/dgnxSa0+JfQVzn6IDHYnDPuqAhZ29ChrVGrIXEk6e+gIQp/ZO YsKxpOTuJMbZKTk6UgFqwopmBrXCz1Q8WLvlxfzJ2EFoML4ykS+CJaqZAs9ITA== Date: Wed, 6 Apr 2022 23:00:10 +0300 From: Aaro Koskinen To: Janusz Krzysztofik Subject: Re: [PATCH v2] ARM: OMAP1: Prepare for conversion of OMAP1 clocks to CCF Message-ID: <20220406200010.GE594699@darkstar.musicnaut.iki.fi> References: <20220310233307.99220-3-jmkrzyszt@gmail.com> <1810824.tdWV9SEqCh@dell> <20220406132149.GC594699@darkstar.musicnaut.iki.fi> <1888452.PYKUYFuaPT@dell> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1888452.PYKUYFuaPT@dell> ARC-Seal: i=1; s=lahtoruutu; d=iki.fi; t=1649275212; a=rsa-sha256; cv=none; b=Ol1GS9eE8NlyDUV0WcHY2VWATp+nj58s0051qvEeumo7NtBnjXas42R78yzG70ifyC61w1 uNejgjj5y2u/lipXR8kWDr6uohk/Qlt2RTi7GBtSFq/B72+3ebibY0TmKGFTacwnLE/Q0Q tPyBaa+IGUVAVry4W3pdajUy4YfXuZPAbe7qOV2W6PWhvFy5/u1KlaqNZJsnjYrRO5D9dj xoCq4TSeoGt+wWudWLGQwD7h83OmvjLmmnHe1ciL+J2iNX7wi6z6XTcYeQ2dMUgmsEzE7h UOG82BaXJw2nJuLhTmns2woVednPtANIIzueIdMPzqje3Y1nqQ/oFewmJr60ng== ARC-Authentication-Results: i=1; ORIGINATING; auth=pass smtp.auth=aaro.koskinen smtp.mailfrom=aaro.koskinen@iki.fi ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=iki.fi; s=lahtoruutu; t=1649275212; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=HF/OS3JAtoNKv3AksoUVmxtqiwmaGXqNkeVyB7AYT2k=; b=amTI0JvrXmyzyX8Uf2XnSz1hRH/n+rrTw1Nz41uGo9Db4A+x3UljqHgdkWZ+xZMSMFXmqF NpqoT7DqPS10usMauUwiurnKUVrlRou9YOW5adeY4I5ejE8YptoMDaRUt5BlI5ya6Tsir4 ZQ9EwOXwkara1rof7KYZYYBUaJHXP873LqWCguWgum+N5SNiM6cE8BjG6+lCLdr+Og6l7/ 02uNTNywsqyZ7r97elJ/MoCN+w2VWTRKFSv18b2pTuPihEhiQNuhWhqeAlpXg+nqf5Nq92 42iC+aDWXKVc7nuF531otS5HSwey0rL0Z+4eYJWSaqI9TJ0RCC9yORLMK37McA== Cc: alsa-devel@alsa-project.org, Felipe Balbi , Paul Walmsley , Arnd Bergmann , Liam Girdwood , Tony Lindgren , Greg Kroah-Hartman , Helge Deller , linux-usb@vger.kernel.org, linux-mmc@vger.kernel.org, linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org, Mark Brown , Alan Stern , Ulf Hansson , linux-omap@vger.kernel.org, Peter Ujfalusi , linux-arm-kernel@lists.infradead.org X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" Hi, On Wed, Apr 06, 2022 at 08:48:14PM +0200, Janusz Krzysztofik wrote: > Dnia środa, 6 kwietnia 2022 15:21:49 CEST Aaro Koskinen pisze: > > On Sat, Mar 26, 2022 at 10:17:49PM +0100, Janusz Krzysztofik wrote: > > > Dnia wtorek, 22 marca 2022 20:07:53 CET Aaro Koskinen pisze: > > > > On Tue, Mar 22, 2022 at 06:36:48PM +0200, Aaro Koskinen wrote: > > > > > Something is still broken. When doing kexec (using CCF kernel), the > > > > > kexec'ed kernel now hangs early (on 770): > > > > [...] > > > > > [ 0.928863] calling omap1_init_devices+0x0/0x2c @ 1 > > > > > > > > It hangs in omap_sram_reprogram_clock() (<- omap1_select_table_rate() > > > > <- omap1_clk_late_init()). > > > > > > I've reviewed my changes but haven't found anything suspicious. > > > > The below change is fixing the kexec boot. Based on the comment in the > > code, it seems this clock is needed for the SRAM to work. > > > > diff --git a/arch/arm/mach-omap1/clock_data.c b/arch/arm/mach-omap1/clock_data.c > > index e33e11f826af..b8b4876ff935 100644 > > --- a/arch/arm/mach-omap1/clock_data.c > > +++ b/arch/arm/mach-omap1/clock_data.c > > @@ -285,7 +285,7 @@ static struct omap1_clk tc1_ck = { > > */ > > > > static struct omap1_clk tc2_ck = { > > - .hw.init = CLK_HW_INIT("tc2_ck", "tc_ck", &omap1_clk_gate_ops, 0), > > + .hw.init = CLK_HW_INIT("tc2_ck", "tc_ck", &omap1_clk_gate_ops, CLK_IS_CRITICAL), > > .ops = &clkops_generic, > > .enable_reg = OMAP1_IO_ADDRESS(ARM_IDLECT3), > > .enable_bit = EN_TC2_CK, > > > > A. > > > > Thank you Aaro. Will you submit this as a separate fix, or should I submit > v2 of my patch 4/4 with your fix included? Please send a new version with the fix included. A. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 96EACC433EF for ; Wed, 6 Apr 2022 20:01:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=zjDmCaHUN6UXan/W9uIy7N0gT1QoB0rcUkC9VZXFWws=; b=tNzu1HrqlVPbpJ ZQPL3spscHVJtGqfbcW19Ps4AiRtytXUfWEvkdbBmsPV56QS9U7bIxLkS94c8gDihwckv3zftDpa8 MtqSAP9JrISZ16DTslXgJ2cbpXyWzAbEe15KHpYQyNN05VxvMI2Rcw8Kc1AoDqGvEUo3ImwWcE0Ux 6BGqP9YUPf/2N6rhJs8HdU0pyUxSLiLI3Ysqn1vy9B9l8GTa1E7i+wAycqmMoi5XjdbqWHB4EI0u+ fnAy+KK7hXwRHLVH/KORme4JTR65eR93AqckT9nZtmuN4uyRsuoIpp1FsspesK2WWr2CqkbjVOHQA 5Rh0QpeH1rNsvTWnfyRg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ncBpM-007mk8-SY; Wed, 06 Apr 2022 20:00:29 +0000 Received: from lahtoruutu.iki.fi ([185.185.170.37]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ncBpC-007mhD-8k for linux-arm-kernel@lists.infradead.org; Wed, 06 Apr 2022 20:00:19 +0000 Received: from darkstar.musicnaut.iki.fi (85-76-76-218-nat.elisa-mobile.fi [85.76.76.218]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: aaro.koskinen) by lahtoruutu.iki.fi (Postfix) with ESMTPSA id C3DA61B000E0; Wed, 6 Apr 2022 23:00:11 +0300 (EEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=iki.fi; s=lahtoruutu; t=1649275212; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=HF/OS3JAtoNKv3AksoUVmxtqiwmaGXqNkeVyB7AYT2k=; b=Nn4RAbFbzK4bwfg86ykyMmwZil9SKibzGCF6IqPtA9woskWkPm0Qpo8xHB6DmiuFZCDabl hKhYB7cTF1pnQmfdEueduNI+Bie9rxrrlv4+Ae9YdogxoZPaT+AnKd36njOcJfii/ZG9el NXeQ9cJa9eyyADZvMify5l3g3e6/9P6d54WrG6RxGfxgsqDX4gklm2g60np78Z2iAK4H5W MYGDa3g/ettQmzEK/GGe/dgnxSa0+JfQVzn6IDHYnDPuqAhZ29ChrVGrIXEk6e+gIQp/ZO YsKxpOTuJMbZKTk6UgFqwopmBrXCz1Q8WLvlxfzJ2EFoML4ykS+CJaqZAs9ITA== Date: Wed, 6 Apr 2022 23:00:10 +0300 From: Aaro Koskinen To: Janusz Krzysztofik Cc: Tony Lindgren , Paul Walmsley , Alan Stern , Greg Kroah-Hartman , Helge Deller , linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-usb@vger.kernel.org, linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org, Ulf Hansson , Arnd Bergmann , Felipe Balbi , Peter Ujfalusi , Liam Girdwood , Mark Brown , linux-mmc@vger.kernel.org, alsa-devel@alsa-project.org Subject: Re: [PATCH v2] ARM: OMAP1: Prepare for conversion of OMAP1 clocks to CCF Message-ID: <20220406200010.GE594699@darkstar.musicnaut.iki.fi> References: <20220310233307.99220-3-jmkrzyszt@gmail.com> <1810824.tdWV9SEqCh@dell> <20220406132149.GC594699@darkstar.musicnaut.iki.fi> <1888452.PYKUYFuaPT@dell> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1888452.PYKUYFuaPT@dell> ARC-Seal: i=1; s=lahtoruutu; d=iki.fi; t=1649275212; a=rsa-sha256; cv=none; b=Ol1GS9eE8NlyDUV0WcHY2VWATp+nj58s0051qvEeumo7NtBnjXas42R78yzG70ifyC61w1 uNejgjj5y2u/lipXR8kWDr6uohk/Qlt2RTi7GBtSFq/B72+3ebibY0TmKGFTacwnLE/Q0Q tPyBaa+IGUVAVry4W3pdajUy4YfXuZPAbe7qOV2W6PWhvFy5/u1KlaqNZJsnjYrRO5D9dj xoCq4TSeoGt+wWudWLGQwD7h83OmvjLmmnHe1ciL+J2iNX7wi6z6XTcYeQ2dMUgmsEzE7h UOG82BaXJw2nJuLhTmns2woVednPtANIIzueIdMPzqje3Y1nqQ/oFewmJr60ng== ARC-Authentication-Results: i=1; ORIGINATING; auth=pass smtp.auth=aaro.koskinen smtp.mailfrom=aaro.koskinen@iki.fi ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=iki.fi; s=lahtoruutu; t=1649275212; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=HF/OS3JAtoNKv3AksoUVmxtqiwmaGXqNkeVyB7AYT2k=; b=amTI0JvrXmyzyX8Uf2XnSz1hRH/n+rrTw1Nz41uGo9Db4A+x3UljqHgdkWZ+xZMSMFXmqF NpqoT7DqPS10usMauUwiurnKUVrlRou9YOW5adeY4I5ejE8YptoMDaRUt5BlI5ya6Tsir4 ZQ9EwOXwkara1rof7KYZYYBUaJHXP873LqWCguWgum+N5SNiM6cE8BjG6+lCLdr+Og6l7/ 02uNTNywsqyZ7r97elJ/MoCN+w2VWTRKFSv18b2pTuPihEhiQNuhWhqeAlpXg+nqf5Nq92 42iC+aDWXKVc7nuF531otS5HSwey0rL0Z+4eYJWSaqI9TJ0RCC9yORLMK37McA== X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220406_130018_529488_9CCDB597 X-CRM114-Status: GOOD ( 21.85 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org SGksCgpPbiBXZWQsIEFwciAwNiwgMjAyMiBhdCAwODo0ODoxNFBNICswMjAwLCBKYW51c3ogS3J6 eXN6dG9maWsgd3JvdGU6Cj4gRG5pYSDFm3JvZGEsIDYga3dpZXRuaWEgMjAyMiAxNToyMTo0OSBD RVNUIEFhcm8gS29za2luZW4gcGlzemU6Cj4gPiBPbiBTYXQsIE1hciAyNiwgMjAyMiBhdCAxMDox Nzo0OVBNICswMTAwLCBKYW51c3ogS3J6eXN6dG9maWsgd3JvdGU6Cj4gPiA+IERuaWEgd3RvcmVr LCAyMiBtYXJjYSAyMDIyIDIwOjA3OjUzIENFVCBBYXJvIEtvc2tpbmVuIHBpc3plOgo+ID4gPiA+ IE9uIFR1ZSwgTWFyIDIyLCAyMDIyIGF0IDA2OjM2OjQ4UE0gKzAyMDAsIEFhcm8gS29za2luZW4g d3JvdGU6Cj4gPiA+ID4gPiBTb21ldGhpbmcgaXMgc3RpbGwgYnJva2VuLiBXaGVuIGRvaW5nIGtl eGVjICh1c2luZyBDQ0Yga2VybmVsKSwgdGhlCj4gPiA+ID4gPiBrZXhlYydlZCBrZXJuZWwgbm93 IGhhbmdzIGVhcmx5IChvbiA3NzApOgo+ID4gPiA+IFsuLi5dCj4gPiA+ID4gPiBbICAgIDAuOTI4 ODYzXSBjYWxsaW5nICBvbWFwMV9pbml0X2RldmljZXMrMHgwLzB4MmMgQCAxCj4gPiA+ID4gCj4g PiA+ID4gSXQgaGFuZ3MgaW4gb21hcF9zcmFtX3JlcHJvZ3JhbV9jbG9jaygpICg8LSBvbWFwMV9z ZWxlY3RfdGFibGVfcmF0ZSgpCj4gPiA+ID4gPC0gb21hcDFfY2xrX2xhdGVfaW5pdCgpKS4KPiA+ ID4gCj4gPiA+IEkndmUgcmV2aWV3ZWQgbXkgY2hhbmdlcyBidXQgaGF2ZW4ndCBmb3VuZCBhbnl0 aGluZyBzdXNwaWNpb3VzLgo+ID4gCj4gPiBUaGUgYmVsb3cgY2hhbmdlIGlzIGZpeGluZyB0aGUg a2V4ZWMgYm9vdC4gQmFzZWQgb24gdGhlIGNvbW1lbnQgaW4gdGhlCj4gPiBjb2RlLCBpdCBzZWVt cyB0aGlzIGNsb2NrIGlzIG5lZWRlZCBmb3IgdGhlIFNSQU0gdG8gd29yay4KPiA+IAo+ID4gZGlm ZiAtLWdpdCBhL2FyY2gvYXJtL21hY2gtb21hcDEvY2xvY2tfZGF0YS5jIGIvYXJjaC9hcm0vbWFj aC1vbWFwMS9jbG9ja19kYXRhLmMKPiA+IGluZGV4IGUzM2UxMWY4MjZhZi4uYjhiNDg3NmZmOTM1 IDEwMDY0NAo+ID4gLS0tIGEvYXJjaC9hcm0vbWFjaC1vbWFwMS9jbG9ja19kYXRhLmMKPiA+ICsr KyBiL2FyY2gvYXJtL21hY2gtb21hcDEvY2xvY2tfZGF0YS5jCj4gPiBAQCAtMjg1LDcgKzI4NSw3 IEBAIHN0YXRpYyBzdHJ1Y3Qgb21hcDFfY2xrIHRjMV9jayA9IHsKPiA+ICAgKi8KPiA+ICAKPiA+ ICBzdGF0aWMgc3RydWN0IG9tYXAxX2NsayB0YzJfY2sgPSB7Cj4gPiAtCS5ody5pbml0CT0gQ0xL X0hXX0lOSVQoInRjMl9jayIsICJ0Y19jayIsICZvbWFwMV9jbGtfZ2F0ZV9vcHMsIDApLAo+ID4g KwkuaHcuaW5pdAk9IENMS19IV19JTklUKCJ0YzJfY2siLCAidGNfY2siLCAmb21hcDFfY2xrX2dh dGVfb3BzLCBDTEtfSVNfQ1JJVElDQUwpLAo+ID4gIAkub3BzCQk9ICZjbGtvcHNfZ2VuZXJpYywK PiA+ICAJLmVuYWJsZV9yZWcJPSBPTUFQMV9JT19BRERSRVNTKEFSTV9JRExFQ1QzKSwKPiA+ICAJ LmVuYWJsZV9iaXQJPSBFTl9UQzJfQ0ssCj4gPiAKPiA+IEEuCj4gPiAKPiAKPiBUaGFuayB5b3Ug QWFyby4gIFdpbGwgeW91IHN1Ym1pdCB0aGlzIGFzIGEgc2VwYXJhdGUgZml4LCBvciBzaG91bGQg SSBzdWJtaXQgCj4gdjIgb2YgbXkgcGF0Y2ggNC80IHdpdGggeW91ciBmaXggaW5jbHVkZWQ/CgpQ bGVhc2Ugc2VuZCBhIG5ldyB2ZXJzaW9uIHdpdGggdGhlIGZpeCBpbmNsdWRlZC4KCkEuCgpfX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpsaW51eC1hcm0ta2Vy bmVsIG1haWxpbmcgbGlzdApsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0 cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1hcm0ta2VybmVs Cg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3C801C433EF for ; Wed, 6 Apr 2022 21:14:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234952AbiDFVQZ (ORCPT ); Wed, 6 Apr 2022 17:16:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34198 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235518AbiDFVP4 (ORCPT ); Wed, 6 Apr 2022 17:15:56 -0400 X-Greylist: delayed 23900 seconds by postgrey-1.37 at lindbergh.monkeyblade.net; Wed, 06 Apr 2022 13:00:15 PDT Received: from lahtoruutu.iki.fi (lahtoruutu.iki.fi [185.185.170.37]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 633192467DF; Wed, 6 Apr 2022 13:00:14 -0700 (PDT) Received: from darkstar.musicnaut.iki.fi (85-76-76-218-nat.elisa-mobile.fi [85.76.76.218]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: aaro.koskinen) by lahtoruutu.iki.fi (Postfix) with ESMTPSA id C3DA61B000E0; Wed, 6 Apr 2022 23:00:11 +0300 (EEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=iki.fi; s=lahtoruutu; t=1649275212; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=HF/OS3JAtoNKv3AksoUVmxtqiwmaGXqNkeVyB7AYT2k=; b=Nn4RAbFbzK4bwfg86ykyMmwZil9SKibzGCF6IqPtA9woskWkPm0Qpo8xHB6DmiuFZCDabl hKhYB7cTF1pnQmfdEueduNI+Bie9rxrrlv4+Ae9YdogxoZPaT+AnKd36njOcJfii/ZG9el NXeQ9cJa9eyyADZvMify5l3g3e6/9P6d54WrG6RxGfxgsqDX4gklm2g60np78Z2iAK4H5W MYGDa3g/ettQmzEK/GGe/dgnxSa0+JfQVzn6IDHYnDPuqAhZ29ChrVGrIXEk6e+gIQp/ZO YsKxpOTuJMbZKTk6UgFqwopmBrXCz1Q8WLvlxfzJ2EFoML4ykS+CJaqZAs9ITA== Date: Wed, 6 Apr 2022 23:00:10 +0300 From: Aaro Koskinen To: Janusz Krzysztofik Cc: Tony Lindgren , Paul Walmsley , Alan Stern , Greg Kroah-Hartman , Helge Deller , linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-usb@vger.kernel.org, linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org, Ulf Hansson , Arnd Bergmann , Felipe Balbi , Peter Ujfalusi , Liam Girdwood , Mark Brown , linux-mmc@vger.kernel.org, alsa-devel@alsa-project.org Subject: Re: [PATCH v2] ARM: OMAP1: Prepare for conversion of OMAP1 clocks to CCF Message-ID: <20220406200010.GE594699@darkstar.musicnaut.iki.fi> References: <20220310233307.99220-3-jmkrzyszt@gmail.com> <1810824.tdWV9SEqCh@dell> <20220406132149.GC594699@darkstar.musicnaut.iki.fi> <1888452.PYKUYFuaPT@dell> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1888452.PYKUYFuaPT@dell> ARC-Seal: i=1; s=lahtoruutu; d=iki.fi; t=1649275212; a=rsa-sha256; cv=none; b=Ol1GS9eE8NlyDUV0WcHY2VWATp+nj58s0051qvEeumo7NtBnjXas42R78yzG70ifyC61w1 uNejgjj5y2u/lipXR8kWDr6uohk/Qlt2RTi7GBtSFq/B72+3ebibY0TmKGFTacwnLE/Q0Q tPyBaa+IGUVAVry4W3pdajUy4YfXuZPAbe7qOV2W6PWhvFy5/u1KlaqNZJsnjYrRO5D9dj xoCq4TSeoGt+wWudWLGQwD7h83OmvjLmmnHe1ciL+J2iNX7wi6z6XTcYeQ2dMUgmsEzE7h UOG82BaXJw2nJuLhTmns2woVednPtANIIzueIdMPzqje3Y1nqQ/oFewmJr60ng== ARC-Authentication-Results: i=1; ORIGINATING; auth=pass smtp.auth=aaro.koskinen smtp.mailfrom=aaro.koskinen@iki.fi ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=iki.fi; s=lahtoruutu; t=1649275212; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=HF/OS3JAtoNKv3AksoUVmxtqiwmaGXqNkeVyB7AYT2k=; b=amTI0JvrXmyzyX8Uf2XnSz1hRH/n+rrTw1Nz41uGo9Db4A+x3UljqHgdkWZ+xZMSMFXmqF NpqoT7DqPS10usMauUwiurnKUVrlRou9YOW5adeY4I5ejE8YptoMDaRUt5BlI5ya6Tsir4 ZQ9EwOXwkara1rof7KYZYYBUaJHXP873LqWCguWgum+N5SNiM6cE8BjG6+lCLdr+Og6l7/ 02uNTNywsqyZ7r97elJ/MoCN+w2VWTRKFSv18b2pTuPihEhiQNuhWhqeAlpXg+nqf5Nq92 42iC+aDWXKVc7nuF531otS5HSwey0rL0Z+4eYJWSaqI9TJ0RCC9yORLMK37McA== Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On Wed, Apr 06, 2022 at 08:48:14PM +0200, Janusz Krzysztofik wrote: > Dnia środa, 6 kwietnia 2022 15:21:49 CEST Aaro Koskinen pisze: > > On Sat, Mar 26, 2022 at 10:17:49PM +0100, Janusz Krzysztofik wrote: > > > Dnia wtorek, 22 marca 2022 20:07:53 CET Aaro Koskinen pisze: > > > > On Tue, Mar 22, 2022 at 06:36:48PM +0200, Aaro Koskinen wrote: > > > > > Something is still broken. When doing kexec (using CCF kernel), the > > > > > kexec'ed kernel now hangs early (on 770): > > > > [...] > > > > > [ 0.928863] calling omap1_init_devices+0x0/0x2c @ 1 > > > > > > > > It hangs in omap_sram_reprogram_clock() (<- omap1_select_table_rate() > > > > <- omap1_clk_late_init()). > > > > > > I've reviewed my changes but haven't found anything suspicious. > > > > The below change is fixing the kexec boot. Based on the comment in the > > code, it seems this clock is needed for the SRAM to work. > > > > diff --git a/arch/arm/mach-omap1/clock_data.c b/arch/arm/mach-omap1/clock_data.c > > index e33e11f826af..b8b4876ff935 100644 > > --- a/arch/arm/mach-omap1/clock_data.c > > +++ b/arch/arm/mach-omap1/clock_data.c > > @@ -285,7 +285,7 @@ static struct omap1_clk tc1_ck = { > > */ > > > > static struct omap1_clk tc2_ck = { > > - .hw.init = CLK_HW_INIT("tc2_ck", "tc_ck", &omap1_clk_gate_ops, 0), > > + .hw.init = CLK_HW_INIT("tc2_ck", "tc_ck", &omap1_clk_gate_ops, CLK_IS_CRITICAL), > > .ops = &clkops_generic, > > .enable_reg = OMAP1_IO_ADDRESS(ARM_IDLECT3), > > .enable_bit = EN_TC2_CK, > > > > A. > > > > Thank you Aaro. Will you submit this as a separate fix, or should I submit > v2 of my patch 4/4 with your fix included? Please send a new version with the fix included. A.