From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id AEA66C4332F for ; Wed, 6 Apr 2022 20:23:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233626AbiDFUY7 (ORCPT ); Wed, 6 Apr 2022 16:24:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60054 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234486AbiDFUWh (ORCPT ); Wed, 6 Apr 2022 16:22:37 -0400 Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 795101CEA59; Wed, 6 Apr 2022 10:52:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1649267537; x=1680803537; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=NKYqSDBSi2gK7jq1hDnM4aEW04YtFUxd7nZHJ7bseh0=; b=Bm9t/h+TXBGewdWnTVzUKQLc64XIY77jTMjvZAnLclF5viOu/od46bF6 K5eHIDOvzcJS3WQV+9O3OHBzIe912CVX/W/ZRBg0Gu80bdQIdZF81YyVM /y8G5MZMvF2tQFN9V4t9ull4sh6+3nqvG7Rviejb7u4AQtF411/8v3qmv 9uTEcB8Zi+/2xYrXVoVorgluyQu1k2Xh2hEvzGi046KBCz9MI/WjV/Jah 4hGiNwb6e8h+2OYIlmJ29hMWcJYX2LN2xN2i0yxgYFntZB9fF/BySP6OA iRtZaVAPoih7ACpJI15t+Al3RDjxnfdiVC43tgDjdx6Y7qsxe5rwcrvHU g==; X-IronPort-AV: E=McAfee;i="6200,9189,10309"; a="241706443" X-IronPort-AV: E=Sophos;i="5.90,240,1643702400"; d="scan'208";a="241706443" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Apr 2022 10:52:16 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.90,240,1643702400"; d="scan'208";a="658629123" Received: from lkp-server02.sh.intel.com (HELO a44fdfb70b94) ([10.239.97.151]) by orsmga004.jf.intel.com with ESMTP; 06 Apr 2022 10:52:13 -0700 Received: from kbuild by a44fdfb70b94 with local (Exim 4.95) (envelope-from ) id 1nc9pE-0004dP-QV; Wed, 06 Apr 2022 17:52:12 +0000 Date: Thu, 7 Apr 2022 01:51:43 +0800 From: kernel test robot To: Andy Shevchenko , linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org Cc: kbuild-all@lists.01.org, Daniel Scally , Heikki Krogerus , Sakari Ailus , Greg Kroah-Hartman , "Rafael J. Wysocki" , Len Brown , Michael Walle Subject: Re: [PATCH v5 4/4] device property: Constify fwnode APIs that uses fwnode_get_next_parent() Message-ID: <202204070123.UdpbjnDH-lkp@intel.com> References: <20220406130552.30930-4-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220406130552.30930-4-andriy.shevchenko@linux.intel.com> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org Hi Andy, I love your patch! Perhaps something to improve: [auto build test WARNING on driver-core/driver-core-testing] [also build test WARNING on rafael-pm/linux-next linus/master linux/master v5.18-rc1 next-20220406] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/intel-lab-lkp/linux/commits/Andy-Shevchenko/device-property-Allow-error-pointer-to-be-passed-to-fwnode-APIs/20220407-002511 base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/driver-core.git 3123109284176b1532874591f7c81f3837bbdc17 config: powerpc-allnoconfig (https://download.01.org/0day-ci/archive/20220407/202204070123.UdpbjnDH-lkp@intel.com/config) compiler: powerpc-linux-gcc (GCC) 11.2.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/intel-lab-lkp/linux/commit/d9d353ada8d8c3b1b7f3965ad7fe191bd7dea930 git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review Andy-Shevchenko/device-property-Allow-error-pointer-to-be-passed-to-fwnode-APIs/20220407-002511 git checkout d9d353ada8d8c3b1b7f3965ad7fe191bd7dea930 # save the config file to linux build tree mkdir build_dir COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=powerpc SHELL=/bin/bash drivers/base/ If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot All warnings (new ones prefixed by >>): drivers/base/property.c: In function 'fwnode_get_nth_parent': >> drivers/base/property.c:647:42: warning: passing argument 1 of 'fwnode_handle_get' discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers] 647 | return fwnode_handle_get(fwnode); | ^~~~~~ In file included from include/linux/of.h:22, from include/linux/irqdomain.h:35, from include/linux/acpi.h:13, from drivers/base/property.c:10: include/linux/property.h:123:63: note: expected 'struct fwnode_handle *' but argument is of type 'const struct fwnode_handle *' 123 | struct fwnode_handle *fwnode_handle_get(struct fwnode_handle *fwnode); | ~~~~~~~~~~~~~~~~~~~~~~^~~~~~ vim +647 drivers/base/property.c 87e5e95db31a27 Sakari Ailus 2019-10-03 629 87e5e95db31a27 Sakari Ailus 2019-10-03 630 /** 87e5e95db31a27 Sakari Ailus 2019-10-03 631 * fwnode_get_nth_parent - Return an nth parent of a node 87e5e95db31a27 Sakari Ailus 2019-10-03 632 * @fwnode: The node the parent of which is requested 87e5e95db31a27 Sakari Ailus 2019-10-03 633 * @depth: Distance of the parent from the node 87e5e95db31a27 Sakari Ailus 2019-10-03 634 * 87e5e95db31a27 Sakari Ailus 2019-10-03 635 * Returns the nth parent of a node. If there is no parent at the requested 87e5e95db31a27 Sakari Ailus 2019-10-03 636 * @depth, %NULL is returned. If @depth is 0, the functionality is equivalent to 87e5e95db31a27 Sakari Ailus 2019-10-03 637 * fwnode_handle_get(). For @depth == 1, it is fwnode_get_parent() and so on. 87e5e95db31a27 Sakari Ailus 2019-10-03 638 * 87e5e95db31a27 Sakari Ailus 2019-10-03 639 * The caller is responsible for calling fwnode_handle_put() for the returned 87e5e95db31a27 Sakari Ailus 2019-10-03 640 * node. 87e5e95db31a27 Sakari Ailus 2019-10-03 641 */ d9d353ada8d8c3 Andy Shevchenko 2022-04-06 642 struct fwnode_handle *fwnode_get_nth_parent(const struct fwnode_handle *fwnode, unsigned int depth) 87e5e95db31a27 Sakari Ailus 2019-10-03 643 { 040f806ecab6cd Andy Shevchenko 2022-04-06 644 struct fwnode_handle *parent; 87e5e95db31a27 Sakari Ailus 2019-10-03 645 040f806ecab6cd Andy Shevchenko 2022-04-06 646 if (depth == 0) 040f806ecab6cd Andy Shevchenko 2022-04-06 @647 return fwnode_handle_get(fwnode); 87e5e95db31a27 Sakari Ailus 2019-10-03 648 040f806ecab6cd Andy Shevchenko 2022-04-06 649 fwnode_for_each_parent_node(fwnode, parent) { 040f806ecab6cd Andy Shevchenko 2022-04-06 650 if (--depth == 0) 040f806ecab6cd Andy Shevchenko 2022-04-06 651 return parent; 040f806ecab6cd Andy Shevchenko 2022-04-06 652 } 040f806ecab6cd Andy Shevchenko 2022-04-06 653 return NULL; 87e5e95db31a27 Sakari Ailus 2019-10-03 654 } 87e5e95db31a27 Sakari Ailus 2019-10-03 655 EXPORT_SYMBOL_GPL(fwnode_get_nth_parent); 87e5e95db31a27 Sakari Ailus 2019-10-03 656 -- 0-DAY CI Kernel Test Service https://01.org/lkp