All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christian Brauner <brauner@kernel.org>
To: Amir Goldstein <amir73il@gmail.com>,
	Miklos Szeredi <mszeredi@redhat.com>
Cc: "Christian Brauner" <brauner@kernel.org>,
	"Christoph Hellwig" <hch@lst.de>,
	linux-unionfs@vger.kernel.org, "Aleksa Sarai" <cyphar@cyphar.com>,
	"Giuseppe Scrivano" <gscrivan@redhat.com>,
	"Rodrigo Campos Catelin" <rodrigo@sdfg.com.ar>,
	"Seth Forshee" <sforshee@digitalocean.com>,
	"Luca Bocassi" <luca.boccassi@microsoft.com>,
	"Lennart Poettering" <mzxreary@0pointer.de>,
	"Stéphane Graber" <stgraber@ubuntu.com>
Subject: [PATCH v5 19/19] ovl: support idmapped layers
Date: Thu,  7 Apr 2022 13:21:56 +0200	[thread overview]
Message-ID: <20220407112157.1775081-20-brauner@kernel.org> (raw)
In-Reply-To: <20220407112157.1775081-1-brauner@kernel.org>

Now that overlay is able to take a layers idmapping into account allow
overlay mounts to be created on top of idmapped mounts.

Cc: <linux-unionfs@vger.kernel.org>
Tested-by: Giuseppe Scrivano <gscrivan@redhat.com>
Reviewed-by: Amir Goldstein <amir73il@gmail.com>
Signed-off-by: Christian Brauner (Microsoft) <brauner@kernel.org>
---
/* v2 */
- Turn on support for idmapped mounts in ovl_upper_idmap() helper here
  after we've introduced it earlier in the series and made it return the
  initial idmapping.

/* v3 */
unchanged

/* v4 */
unchanged

/* v5 */
unchanged
---
 fs/overlayfs/ovl_entry.h | 2 +-
 fs/overlayfs/super.c     | 4 ----
 2 files changed, 1 insertion(+), 5 deletions(-)

diff --git a/fs/overlayfs/ovl_entry.h b/fs/overlayfs/ovl_entry.h
index 8630fd93238a..e1af8f660698 100644
--- a/fs/overlayfs/ovl_entry.h
+++ b/fs/overlayfs/ovl_entry.h
@@ -92,7 +92,7 @@ static inline struct vfsmount *ovl_upper_mnt(struct ovl_fs *ofs)
 
 static inline struct user_namespace *ovl_upper_mnt_userns(struct ovl_fs *ofs)
 {
-       return &init_user_ns;
+	return mnt_user_ns(ovl_upper_mnt(ofs));
 }
 
 static inline struct ovl_fs *OVL_FS(struct super_block *sb)
diff --git a/fs/overlayfs/super.c b/fs/overlayfs/super.c
index 0123c8086ee9..e0a2e0468ee7 100644
--- a/fs/overlayfs/super.c
+++ b/fs/overlayfs/super.c
@@ -874,10 +874,6 @@ static int ovl_mount_dir_noesc(const char *name, struct path *path)
 		pr_err("filesystem on '%s' not supported\n", name);
 		goto out_put;
 	}
-	if (is_idmapped_mnt(path->mnt)) {
-		pr_err("idmapped layers are currently not supported\n");
-		goto out_put;
-	}
 	if (!d_is_dir(path->dentry)) {
 		pr_err("'%s' not a directory\n", name);
 		goto out_put;
-- 
2.32.0


  parent reply	other threads:[~2022-04-07 11:23 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-07 11:21 [PATCH v5 00/19] overlay: support idmapped layers Christian Brauner
2022-04-07 11:21 ` [PATCH v5 01/19] fs: add two trivial lookup helpers Christian Brauner
2022-04-07 11:21 ` [PATCH v5 02/19] exportfs: support idmapped mounts Christian Brauner
2022-04-07 11:21 ` [PATCH v5 03/19] ovl: use wrappers to all vfs_*xattr() calls Christian Brauner
2022-04-07 11:21 ` [PATCH v5 04/19] ovl: pass ofs to creation operations Christian Brauner
2022-04-07 11:21 ` [PATCH v5 05/19] ovl: add ovl_upper_mnt_userns() wrapper Christian Brauner
2022-04-07 11:21 ` [PATCH v5 06/19] ovl: handle idmappings in creation operations Christian Brauner
2022-04-07 11:21 ` [PATCH v5 07/19] ovl: pass ofs to setattr operations Christian Brauner
2022-04-07 11:21 ` [PATCH v5 08/19] ovl: pass layer mnt to ovl_open_realfile() Christian Brauner
2022-04-07 11:21 ` [PATCH v5 09/19] ovl: use ovl_do_notify_change() wrapper Christian Brauner
2022-04-07 11:21 ` [PATCH v5 10/19] ovl: use ovl_lookup_upper() wrapper Christian Brauner
2022-04-07 11:21 ` [PATCH v5 11/19] ovl: use ovl_path_getxattr() wrapper Christian Brauner
2022-04-07 11:21 ` [PATCH v5 12/19] ovl: handle idmappings for layer fileattrs Christian Brauner
2022-04-07 11:21 ` [PATCH v5 13/19] ovl: handle idmappings for layer lookup Christian Brauner
2022-04-28 10:10   ` Miklos Szeredi
2022-04-28 10:30     ` Christian Brauner
2022-04-28 10:57       ` Amir Goldstein
2022-04-28 11:43         ` Miklos Szeredi
2022-04-28 11:30       ` Miklos Szeredi
2022-04-28 11:35         ` Miklos Szeredi
2022-04-28 11:50           ` Christian Brauner
2022-04-07 11:21 ` [PATCH v5 14/19] ovl: store lower path in ovl_inode Christian Brauner
2022-04-07 11:21 ` [PATCH v5 15/19] ovl: use ovl_copy_{real,upper}attr() wrappers Christian Brauner
2022-04-07 11:21 ` [PATCH v5 16/19] ovl: handle idmappings in ovl_permission() Christian Brauner
2022-04-07 11:21 ` [PATCH v5 17/19] ovl: handle idmappings in layer open helpers Christian Brauner
2022-04-07 11:21 ` [PATCH v5 18/19] ovl: handle idmappings in ovl_xattr_{g,s}et() Christian Brauner
2022-04-07 11:21 ` Christian Brauner [this message]
2022-04-07 11:21 ` [PATCH v5] common: allow to run all tests on idmapped mounts Christian Brauner
2022-04-13  7:49   ` Christian Brauner
2022-04-28 14:39 ` [PATCH v5 00/19] overlay: support idmapped layers Miklos Szeredi
2022-04-28 14:47   ` Christian Brauner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220407112157.1775081-20-brauner@kernel.org \
    --to=brauner@kernel.org \
    --cc=amir73il@gmail.com \
    --cc=cyphar@cyphar.com \
    --cc=gscrivan@redhat.com \
    --cc=hch@lst.de \
    --cc=linux-unionfs@vger.kernel.org \
    --cc=luca.boccassi@microsoft.com \
    --cc=mszeredi@redhat.com \
    --cc=mzxreary@0pointer.de \
    --cc=rodrigo@sdfg.com.ar \
    --cc=sforshee@digitalocean.com \
    --cc=stgraber@ubuntu.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.