From: Dan Carpenter <dan.carpenter@oracle.com>
To: Kate Hsuan <hpa@redhat.com>
Cc: Sakari Ailus <sakari.ailus@linux.intel.com>,
Bingbu Cao <bingbu.cao@intel.com>,
Tianshu Qiu <tian.shu.qiu@intel.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jean-Michel Hautbois <jeanmichel.hautbois@ideasonboard.com>,
linux-media@vger.kernel.org, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org, hdegoede@redhat.com
Subject: Re: [PATCH v2] staging: media: ipu3: Fix AWB x_start position when rightmost stripe is used
Date: Thu, 7 Apr 2022 14:51:33 +0300 [thread overview]
Message-ID: <20220407115133.GL3293@kadam> (raw)
In-Reply-To: <20220407105724.308930-1-hpa@redhat.com>
On Thu, Apr 07, 2022 at 06:57:24PM +0800, Kate Hsuan wrote:
> A not calibrated x_start setting would result in an incorrect AWB location
> configuration on a sensor when only the rightmost stripe is used. x_start
> should be calibrated by subtracting the stripe offset to set the coordinate
> to the correct position on the second stripe.
>
I wish the commit description said more about what the bug looks like to
the user. This is the front facing camera, right? Is part of the video
blank or what's the deal?
> Signed-off-by: Kate Hsuan <hpa@redhat.com>
> ---
> Correct the patch. The correction should be awb, not awb_fr.
I tried to review the original patch and it was impossible. I saw
you're from an @redhat.com email address so I decided it must be right.
I kind of get that you need to be a domain expert to review these
patches but this function is such a mess...
regards,
dan carpenter
next prev parent reply other threads:[~2022-04-07 11:52 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-07 10:57 [PATCH v2] staging: media: ipu3: Fix AWB x_start position when rightmost stripe is used Kate Hsuan
2022-04-07 11:51 ` Dan Carpenter [this message]
2022-04-07 13:17 ` Kate Hsuan
2022-04-07 13:26 ` Dan Carpenter
2022-04-08 3:07 ` Kate Hsuan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220407115133.GL3293@kadam \
--to=dan.carpenter@oracle.com \
--cc=bingbu.cao@intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=hdegoede@redhat.com \
--cc=hpa@redhat.com \
--cc=jeanmichel.hautbois@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=mchehab@kernel.org \
--cc=sakari.ailus@linux.intel.com \
--cc=tian.shu.qiu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.