All of lore.kernel.org
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: Lino Sanfilippo <l.sanfilippo@kunbus.com>
Cc: kbuild-all@lists.01.org, linux-kernel@vger.kernel.org,
	Lukas Wunner <lukas@wunner.de>
Subject: [l1k:smsc95xx_5.17 191/199] drivers/char/tpm/tpm_tis_spi_slb9670.c:24:5: warning: no previous prototype for 'slb9670_spi_unset_reset'
Date: Fri, 8 Apr 2022 13:25:38 +0800	[thread overview]
Message-ID: <202204081357.8SfjQosI-lkp@intel.com> (raw)

tree:   https://github.com/l1k/linux smsc95xx_5.17
head:   b194077da9627d066b5fa96b0aa1515b3b982d15
commit: 0c5db7c8f524b10886d73cf60256665e5f6df603 [191/199] tpm: tpm_tis_spi_slb_9670: implement set_reset and unset_reset functions
config: h8300-randconfig-r035-20220408 (https://download.01.org/0day-ci/archive/20220408/202204081357.8SfjQosI-lkp@intel.com/config)
compiler: h8300-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/l1k/linux/commit/0c5db7c8f524b10886d73cf60256665e5f6df603
        git remote add l1k https://github.com/l1k/linux
        git fetch --no-tags l1k smsc95xx_5.17
        git checkout 0c5db7c8f524b10886d73cf60256665e5f6df603
        # save the config file to linux build tree
        mkdir build_dir
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=h8300 SHELL=/bin/bash drivers/char/tpm/

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

>> drivers/char/tpm/tpm_tis_spi_slb9670.c:24:5: warning: no previous prototype for 'slb9670_spi_unset_reset' [-Wmissing-prototypes]
      24 | int slb9670_spi_unset_reset(struct tpm_tis_data *data)
         |     ^~~~~~~~~~~~~~~~~~~~~~~
>> drivers/char/tpm/tpm_tis_spi_slb9670.c:46:5: warning: no previous prototype for 'slb9670_spi_set_reset' [-Wmissing-prototypes]
      46 | int slb9670_spi_set_reset(struct tpm_tis_data *data)
         |     ^~~~~~~~~~~~~~~~~~~~~


vim +/slb9670_spi_unset_reset +24 drivers/char/tpm/tpm_tis_spi_slb9670.c

    23	
  > 24	int slb9670_spi_unset_reset(struct tpm_tis_data *data)
    25	{
    26		/*
    27		 * Perform the reset sequence: we have to deassert and assert the reset
    28		 * line two times and wait the respective time intervals.
    29		 * After a last wait interval of RSTIN the chip is ready to receive the
    30		 * first command.
    31		 */
    32		gpiod_set_value(data->reset_gpio, 0);
    33		msleep(SLB9670_TIME_RSTIN);
    34		gpiod_set_value(data->reset_gpio, 1);
    35		udelay(SLB9670_TIME_WRST);
    36		gpiod_set_value(data->reset_gpio, 0);
    37		msleep(SLB9670_TIME_RSTIN);
    38		gpiod_set_value(data->reset_gpio, 1);
    39		udelay(SLB9670_TIME_WRST);
    40		gpiod_set_value(data->reset_gpio, 0);
    41		msleep(SLB9670_TIME_RSTIN);
    42	
    43		return 0;
    44	}
    45	
  > 46	int slb9670_spi_set_reset(struct tpm_tis_data *data)
    47	{
    48		gpiod_set_value(data->reset_gpio, 1);
    49		return 0;
    50	}
    51	

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp

                 reply	other threads:[~2022-04-08  5:26 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202204081357.8SfjQosI-lkp@intel.com \
    --to=lkp@intel.com \
    --cc=kbuild-all@lists.01.org \
    --cc=l.sanfilippo@kunbus.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lukas@wunner.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.