From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 66792C433F5 for ; Mon, 11 Apr 2022 02:56:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243831AbiDKC6V (ORCPT ); Sun, 10 Apr 2022 22:58:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43636 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232344AbiDKC6V (ORCPT ); Sun, 10 Apr 2022 22:58:21 -0400 Received: from mail104.syd.optusnet.com.au (mail104.syd.optusnet.com.au [211.29.132.246]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 6DBB31837A for ; Sun, 10 Apr 2022 19:56:06 -0700 (PDT) Received: from dread.disaster.area (pa49-186-233-190.pa.vic.optusnet.com.au [49.186.233.190]) by mail104.syd.optusnet.com.au (Postfix) with ESMTPS id 594E153C7F6; Mon, 11 Apr 2022 12:56:05 +1000 (AEST) Received: from dave by dread.disaster.area with local (Exim 4.92.3) (envelope-from ) id 1ndkDj-00GGyD-1u; Mon, 11 Apr 2022 12:56:03 +1000 Date: Mon, 11 Apr 2022 12:56:03 +1000 From: Dave Chinner To: Chandan Babu R Cc: linux-xfs@vger.kernel.org, djwong@kernel.org Subject: Re: [PATCH V9.1] xfs: Enable bulkstat ioctl to support 64-bit per-inode extent counters Message-ID: <20220411025603.GY1544202@dread.disaster.area> References: <20220406061904.595597-19-chandan.babu@oracle.com> <20220409135709.495356-1-chandan.babu@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220409135709.495356-1-chandan.babu@oracle.com> X-Optus-CM-Score: 0 X-Optus-CM-Analysis: v=2.4 cv=VuxAv86n c=1 sm=1 tr=0 ts=625398c5 a=bHAvQTfMiaNt/bo4vVGwyA==:117 a=bHAvQTfMiaNt/bo4vVGwyA==:17 a=kj9zAlcOel0A:10 a=z0gMJWrwH1QA:10 a=20KFwNOVAAAA:8 a=VwQbUJbxAAAA:8 a=yPCof4ZbAAAA:8 a=7-415B0cAAAA:8 a=nb6c5JsIZB3-lfREE2IA:9 a=CjuIK1q_8ugA:10 a=AjGcO6oz07-iQ99wixmX:22 a=biEYGPWJfzWAr4FL6Ov7:22 Precedence: bulk List-ID: X-Mailing-List: linux-xfs@vger.kernel.org On Sat, Apr 09, 2022 at 07:27:09PM +0530, Chandan Babu R wrote: > The following changes are made to enable userspace to obtain 64-bit extent > counters, > 1. Carve out a new 64-bit field xfs_bulkstat->bs_extents64 from > xfs_bulkstat->bs_pad[] to hold 64-bit extent counter. > 2. Define the new flag XFS_BULK_IREQ_BULKSTAT for userspace to indicate that > it is capable of receiving 64-bit extent counters. > > Reviewed-by: Dave Chinner > Suggested-by: Darrick J. Wong > Signed-off-by: Chandan Babu R .... > diff --git a/fs/xfs/xfs_itable.h b/fs/xfs/xfs_itable.h > index 5ee1d3f44ce9..e2d0eba43f35 100644 > --- a/fs/xfs/xfs_itable.h > +++ b/fs/xfs/xfs_itable.h > @@ -19,6 +19,9 @@ struct xfs_ibulk { > /* Only iterate within the same AG as startino */ > #define XFS_IBULK_SAME_AG (1U << 0) This doesn't apply - I guess you modified patch 17 to make this 1U instead of 1 and then didn't resend it. I'll clean it up.... -Dave. -- Dave Chinner david@fromorbit.com