From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E1941C433EF for ; Mon, 11 Apr 2022 13:39:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1346589AbiDKNlM (ORCPT ); Mon, 11 Apr 2022 09:41:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36058 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1343774AbiDKNlK (ORCPT ); Mon, 11 Apr 2022 09:41:10 -0400 Received: from mail-lj1-x234.google.com (mail-lj1-x234.google.com [IPv6:2a00:1450:4864:20::234]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DD777222B0 for ; Mon, 11 Apr 2022 06:38:55 -0700 (PDT) Received: by mail-lj1-x234.google.com with SMTP id o16so14261582ljp.3 for ; Mon, 11 Apr 2022 06:38:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:organization:content-transfer-encoding; bh=c2Hxf+Qd4VDlf3RyTcZ7u6PSE6ckvu4bfuQ6dUJjbnI=; b=dUNS3ltsPrnQGHh8Qf2VDr2VwLlBywJMd8CzsUSUVQtAzwupM2mqlPeuT3AWAGOMSj yvg0DBq5zwVVyWyOADLHtTHJQobKUiLz5Pxo6H1gdQ7epVI1VvvIlFQo48J9lixiWTSQ NjxX1hEeC6LHMkfcXHvnVCsE7+5Fwjm/sS7NbNINMiRUXkID17v7gAceggPr0Ig5LHmV IPPbGJ8SCmjY3ful/7pM26xjH3WSg5VpxABl+sGKdRRAf8GR56yDXdjTYAGo0rKtTfdK hw9F65Lc3XDw6Lpc+k3/MzH+Xh14LtESEtAlX6rO8pHaZaS+/sRITde0PYRfmlEIyHDk VV6Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:organization:content-transfer-encoding; bh=c2Hxf+Qd4VDlf3RyTcZ7u6PSE6ckvu4bfuQ6dUJjbnI=; b=C2IpASw2ac0V1JhG/Jd0g/y/3f0R4sesH1/BRQSGuSTVtwUDwJGTyMZaNJtxRigoRo 0+8imgCTDxLEXChrgXGVMKcvhIf+6t1XDjUvWDU71lIthubTkvSPmeHM/rPTYCSh/3/E ZTg5xjFlkQC9m2/hGzpciU5rzOVlcSbenvcHnWRnHkqkCnHoOzY0xCbmVRxSJ6Z4rB0p kwSOg9gaulj5Bc4UT50eSY/0Iwl+jfPtvfTfkmS2jnM8+co2Kq2VecwnFqo3rL3W4Tje SA93/RQgYd4EZpW80tWdDMwunyvmAeaXBqIbOe+p33rlY//POdiARrCKuyKfUAcQPQy6 x+yg== X-Gm-Message-State: AOAM533Q/BWkMFpZcaORvvQtwRpKdEYOCoBorOPWKrQPWLV8ClDATfOo b32tjSCDD5Df9Q+sId63jkvvK6JboCqbRTkE X-Google-Smtp-Source: ABdhPJxN2mL7iTx2J06MCeT8oLkZN2Gf/0grFXW54mHhvTegORZPIn9cHNTNg8NPU/m7q+cCFGoxKA== X-Received: by 2002:a05:651c:1203:b0:24b:58c9:e1e3 with SMTP id i3-20020a05651c120300b0024b58c9e1e3mr7135103lja.127.1649684334132; Mon, 11 Apr 2022 06:38:54 -0700 (PDT) Received: from wbg.labs.westermo.se (h-158-174-22-128.NA.cust.bahnhof.se. [158.174.22.128]) by smtp.gmail.com with ESMTPSA id p12-20020a056512138c00b0044833f1cd85sm3336847lfa.62.2022.04.11.06.38.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 11 Apr 2022 06:38:53 -0700 (PDT) From: Joachim Wiberg To: Roopa Prabhu , Nikolay Aleksandrov Cc: netdev@vger.kernel.org, bridge@lists.linux-foundation.org, "David S . Miller" , Jakub Kicinski , Joachim Wiberg , Tobias Waldekranz , Vladimir Oltean Subject: [PATCH RFC net-next 02/13] net: bridge: rename br_switchdev_set_port_flag() to .._dev_flag() Date: Mon, 11 Apr 2022 15:38:26 +0200 Message-Id: <20220411133837.318876-3-troglobit@gmail.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220411133837.318876-1-troglobit@gmail.com> References: <20220411133837.318876-1-troglobit@gmail.com> MIME-Version: 1.0 Organization: Westermo Network Technologies AB Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org The br_switchdev_set_port_flag() function only uses the `p->dev` member of the port, and we also want to reuse it for the bridge itself. Change the first argument and the name of the function to match. Signed-off-by: Joachim Wiberg --- net/bridge/br_netlink.c | 2 +- net/bridge/br_private.h | 4 ++-- net/bridge/br_switchdev.c | 8 ++++---- net/bridge/br_sysfs_if.c | 2 +- 4 files changed, 8 insertions(+), 8 deletions(-) diff --git a/net/bridge/br_netlink.c b/net/bridge/br_netlink.c index 200ad05b296f..7fca8ff13ec7 100644 --- a/net/bridge/br_netlink.c +++ b/net/bridge/br_netlink.c @@ -942,7 +942,7 @@ static int br_setport(struct net_bridge_port *p, struct nlattr *tb[], changed_mask = old_flags ^ p->flags; - err = br_switchdev_set_port_flag(p, p->flags, changed_mask, extack); + err = br_switchdev_set_dev_flag(p->dev, p->flags, changed_mask, extack); if (err) { p->flags = old_flags; return err; diff --git a/net/bridge/br_private.h b/net/bridge/br_private.h index 683bd0ee4c64..6c230be6fbf5 100644 --- a/net/bridge/br_private.h +++ b/net/bridge/br_private.h @@ -2038,7 +2038,7 @@ void nbp_switchdev_frame_mark(const struct net_bridge_port *p, struct sk_buff *skb); bool nbp_switchdev_allowed_egress(const struct net_bridge_port *p, const struct sk_buff *skb); -int br_switchdev_set_port_flag(struct net_bridge_port *p, +int br_switchdev_set_dev_flag(struct net_device *dev, unsigned long flags, unsigned long mask, struct netlink_ext_ack *extack); @@ -2108,7 +2108,7 @@ static inline bool nbp_switchdev_allowed_egress(const struct net_bridge_port *p, return true; } -static inline int br_switchdev_set_port_flag(struct net_bridge_port *p, +static inline int br_switchdev_set_dev_flag(struct net_device *dev, unsigned long flags, unsigned long mask, struct netlink_ext_ack *extack) diff --git a/net/bridge/br_switchdev.c b/net/bridge/br_switchdev.c index 8cc44c367231..3b4df63e96a6 100644 --- a/net/bridge/br_switchdev.c +++ b/net/bridge/br_switchdev.c @@ -74,13 +74,13 @@ bool nbp_switchdev_allowed_egress(const struct net_bridge_port *p, #define BR_PORT_FLAGS_HW_OFFLOAD (BR_LEARNING | BR_FLOOD | \ BR_MCAST_FLOOD | BR_BCAST_FLOOD | BR_PORT_LOCKED) -int br_switchdev_set_port_flag(struct net_bridge_port *p, +int br_switchdev_set_dev_flag(struct net_device *dev, unsigned long flags, unsigned long mask, struct netlink_ext_ack *extack) { struct switchdev_attr attr = { - .orig_dev = p->dev, + .orig_dev = dev, }; struct switchdev_notifier_port_attr_info info = { .attr = &attr, @@ -96,7 +96,7 @@ int br_switchdev_set_port_flag(struct net_bridge_port *p, attr.u.brport_flags.mask = mask; /* We run from atomic context here */ - err = call_switchdev_notifiers(SWITCHDEV_PORT_ATTR_SET, p->dev, + err = call_switchdev_notifiers(SWITCHDEV_PORT_ATTR_SET, dev, &info.info, extack); err = notifier_to_errno(err); if (err == -EOPNOTSUPP) @@ -112,7 +112,7 @@ int br_switchdev_set_port_flag(struct net_bridge_port *p, attr.id = SWITCHDEV_ATTR_ID_PORT_BRIDGE_FLAGS; attr.flags = SWITCHDEV_F_DEFER; - err = switchdev_port_attr_set(p->dev, &attr, extack); + err = switchdev_port_attr_set(dev, &attr, extack); if (err) { if (extack && !extack->_msg) NL_SET_ERR_MSG_MOD(extack, diff --git a/net/bridge/br_sysfs_if.c b/net/bridge/br_sysfs_if.c index 07fa76080512..c222c68105f1 100644 --- a/net/bridge/br_sysfs_if.c +++ b/net/bridge/br_sysfs_if.c @@ -69,7 +69,7 @@ static int store_flag(struct net_bridge_port *p, unsigned long v, flags &= ~mask; if (flags != p->flags) { - err = br_switchdev_set_port_flag(p, flags, mask, &extack); + err = br_switchdev_set_dev_flag(p->dev, flags, mask, &extack); if (err) { netdev_err(p->dev, "%s\n", extack._msg); return err; -- 2.25.1 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:organization:content-transfer-encoding; bh=c2Hxf+Qd4VDlf3RyTcZ7u6PSE6ckvu4bfuQ6dUJjbnI=; b=dUNS3ltsPrnQGHh8Qf2VDr2VwLlBywJMd8CzsUSUVQtAzwupM2mqlPeuT3AWAGOMSj yvg0DBq5zwVVyWyOADLHtTHJQobKUiLz5Pxo6H1gdQ7epVI1VvvIlFQo48J9lixiWTSQ NjxX1hEeC6LHMkfcXHvnVCsE7+5Fwjm/sS7NbNINMiRUXkID17v7gAceggPr0Ig5LHmV IPPbGJ8SCmjY3ful/7pM26xjH3WSg5VpxABl+sGKdRRAf8GR56yDXdjTYAGo0rKtTfdK hw9F65Lc3XDw6Lpc+k3/MzH+Xh14LtESEtAlX6rO8pHaZaS+/sRITde0PYRfmlEIyHDk VV6Q== From: Joachim Wiberg Date: Mon, 11 Apr 2022 15:38:26 +0200 Message-Id: <20220411133837.318876-3-troglobit@gmail.com> In-Reply-To: <20220411133837.318876-1-troglobit@gmail.com> References: <20220411133837.318876-1-troglobit@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [Bridge] [PATCH RFC net-next 02/13] net: bridge: rename br_switchdev_set_port_flag() to .._dev_flag() List-Id: Linux Ethernet Bridging List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Roopa Prabhu , Nikolay Aleksandrov Cc: netdev@vger.kernel.org, bridge@lists.linux-foundation.org, Vladimir Oltean , Joachim Wiberg , Jakub Kicinski , "David S . Miller" , Tobias Waldekranz The br_switchdev_set_port_flag() function only uses the `p->dev` member of the port, and we also want to reuse it for the bridge itself. Change the first argument and the name of the function to match. Signed-off-by: Joachim Wiberg --- net/bridge/br_netlink.c | 2 +- net/bridge/br_private.h | 4 ++-- net/bridge/br_switchdev.c | 8 ++++---- net/bridge/br_sysfs_if.c | 2 +- 4 files changed, 8 insertions(+), 8 deletions(-) diff --git a/net/bridge/br_netlink.c b/net/bridge/br_netlink.c index 200ad05b296f..7fca8ff13ec7 100644 --- a/net/bridge/br_netlink.c +++ b/net/bridge/br_netlink.c @@ -942,7 +942,7 @@ static int br_setport(struct net_bridge_port *p, struct nlattr *tb[], changed_mask = old_flags ^ p->flags; - err = br_switchdev_set_port_flag(p, p->flags, changed_mask, extack); + err = br_switchdev_set_dev_flag(p->dev, p->flags, changed_mask, extack); if (err) { p->flags = old_flags; return err; diff --git a/net/bridge/br_private.h b/net/bridge/br_private.h index 683bd0ee4c64..6c230be6fbf5 100644 --- a/net/bridge/br_private.h +++ b/net/bridge/br_private.h @@ -2038,7 +2038,7 @@ void nbp_switchdev_frame_mark(const struct net_bridge_port *p, struct sk_buff *skb); bool nbp_switchdev_allowed_egress(const struct net_bridge_port *p, const struct sk_buff *skb); -int br_switchdev_set_port_flag(struct net_bridge_port *p, +int br_switchdev_set_dev_flag(struct net_device *dev, unsigned long flags, unsigned long mask, struct netlink_ext_ack *extack); @@ -2108,7 +2108,7 @@ static inline bool nbp_switchdev_allowed_egress(const struct net_bridge_port *p, return true; } -static inline int br_switchdev_set_port_flag(struct net_bridge_port *p, +static inline int br_switchdev_set_dev_flag(struct net_device *dev, unsigned long flags, unsigned long mask, struct netlink_ext_ack *extack) diff --git a/net/bridge/br_switchdev.c b/net/bridge/br_switchdev.c index 8cc44c367231..3b4df63e96a6 100644 --- a/net/bridge/br_switchdev.c +++ b/net/bridge/br_switchdev.c @@ -74,13 +74,13 @@ bool nbp_switchdev_allowed_egress(const struct net_bridge_port *p, #define BR_PORT_FLAGS_HW_OFFLOAD (BR_LEARNING | BR_FLOOD | \ BR_MCAST_FLOOD | BR_BCAST_FLOOD | BR_PORT_LOCKED) -int br_switchdev_set_port_flag(struct net_bridge_port *p, +int br_switchdev_set_dev_flag(struct net_device *dev, unsigned long flags, unsigned long mask, struct netlink_ext_ack *extack) { struct switchdev_attr attr = { - .orig_dev = p->dev, + .orig_dev = dev, }; struct switchdev_notifier_port_attr_info info = { .attr = &attr, @@ -96,7 +96,7 @@ int br_switchdev_set_port_flag(struct net_bridge_port *p, attr.u.brport_flags.mask = mask; /* We run from atomic context here */ - err = call_switchdev_notifiers(SWITCHDEV_PORT_ATTR_SET, p->dev, + err = call_switchdev_notifiers(SWITCHDEV_PORT_ATTR_SET, dev, &info.info, extack); err = notifier_to_errno(err); if (err == -EOPNOTSUPP) @@ -112,7 +112,7 @@ int br_switchdev_set_port_flag(struct net_bridge_port *p, attr.id = SWITCHDEV_ATTR_ID_PORT_BRIDGE_FLAGS; attr.flags = SWITCHDEV_F_DEFER; - err = switchdev_port_attr_set(p->dev, &attr, extack); + err = switchdev_port_attr_set(dev, &attr, extack); if (err) { if (extack && !extack->_msg) NL_SET_ERR_MSG_MOD(extack, diff --git a/net/bridge/br_sysfs_if.c b/net/bridge/br_sysfs_if.c index 07fa76080512..c222c68105f1 100644 --- a/net/bridge/br_sysfs_if.c +++ b/net/bridge/br_sysfs_if.c @@ -69,7 +69,7 @@ static int store_flag(struct net_bridge_port *p, unsigned long v, flags &= ~mask; if (flags != p->flags) { - err = br_switchdev_set_port_flag(p, flags, mask, &extack); + err = br_switchdev_set_dev_flag(p->dev, flags, mask, &extack); if (err) { netdev_err(p->dev, "%s\n", extack._msg); return err; -- 2.25.1