From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 64432C433EF for ; Mon, 11 Apr 2022 15:31:40 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id A40ED83DD2; Mon, 11 Apr 2022 17:31:37 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="O9zioAFA"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 5922183C05; Mon, 11 Apr 2022 17:31:36 +0200 (CEST) Received: from mail-qk1-x734.google.com (mail-qk1-x734.google.com [IPv6:2607:f8b0:4864:20::734]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id CF8B083C05 for ; Mon, 11 Apr 2022 17:31:32 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qk1-x734.google.com with SMTP id j6so10909795qkp.9 for ; Mon, 11 Apr 2022 08:31:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=kxW/I751JkMVZZxeL6cFv95Z3j0EsGSzsU7jRwySD6g=; b=O9zioAFAiaoTo5nrlr5ETrKbVQIY8s8u73hWnUYYN/en9ivocKKut8TjBdOdMKF42b IMUzKI3IxB9hTF0FA+gDEXb/sRMWcP+7kKVTUQZ0mfYeSAZg1d62cnVup0tKxx8uT/Oi +MJYyU8DKEbUf4oDzm6jzCbNujdlyxlS9BwqQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=kxW/I751JkMVZZxeL6cFv95Z3j0EsGSzsU7jRwySD6g=; b=paDOprMOWxgYl50m1HKsUa07Kk2zvSMBojfMgkS/LvZD/M5RK+Tc+DiKaRLWjADsx0 HrwoxYbkrkLCSjhg2V1sFX3nz3rj/VtTYWiYrWNhOjQU3HM5lEQyHG/kidbKtEQBeOzE qW1llbvjbX0W7ZGUUnHP2cnMwgCsrG6BV/hSPm7sd3x/9wbuI0IabbLvx4ork6kVdOwN QxivxnMUYY5HxBfkMuU5NXstNQaWk8sEGdo3Ai/M4fT1nRdvSfZZiyQLVbIS/eFCJ7Vy ZOzglPMyPhV00/yZGuSU31s6i3sqRTjhlw368qngMoOcMMBm1AwEtjmmGh0Vf68VjjGe Yg5g== X-Gm-Message-State: AOAM530CBCQXK0IB57qfv0hpQmwBkVyKKTC1On5/oaJQtVbuRKYtwTKX GIe4pf1jK9HmoAQKU25WZcFbxvRNYVFdgQ== X-Google-Smtp-Source: ABdhPJzz1HYmXHbEc/yfU9fTi4GYQ6b2Z2SrUdURWVsSlumnaJSrPVIIv0pNtf+fvvV01NVMO8smYg== X-Received: by 2002:a05:620a:4691:b0:67e:c740:4a57 with SMTP id bq17-20020a05620a469100b0067ec7404a57mr22136679qkb.288.1649691090811; Mon, 11 Apr 2022 08:31:30 -0700 (PDT) Received: from bill-the-cat (2603-6081-7b01-cbda-2ef0-5dff-fedb-a8ba.res6.spectrum.com. [2603:6081:7b01:cbda:2ef0:5dff:fedb:a8ba]) by smtp.gmail.com with ESMTPSA id k20-20020a05622a03d400b002ec16d2694fsm10166181qtx.39.2022.04.11.08.31.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 11 Apr 2022 08:31:30 -0700 (PDT) Date: Mon, 11 Apr 2022 11:31:28 -0400 From: Tom Rini To: Nicolas Boulenguez Cc: u-boot@lists.denx.de Subject: Re: [PATCH] build: allow a downstream suffix in the version shown during boot Message-ID: <20220411153128.GA1167777@bill-the-cat> References: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="YiEDa0DAkWCtVeE4" Content-Disposition: inline In-Reply-To: X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean --YiEDa0DAkWCtVeE4 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Mar 13, 2022 at 11:42:45AM +0100, Nicolas Boulenguez wrote: > Hello. >=20 > https://lists.denx.de/pipermail/u-boot/2022-February/474887.html got > no answer, probably because it is trivial and has been lost among more > important topics, so I am submitting it again. >=20 > It is convenient for redistributors to add a build number to the > U-boot source version, which is displayed at boot and useful to know > if a device has been successfully updated, to triage bugs and so on. >=20 > For example, Debian adds '+dfsg-N' where N changes with each release > of a .deb package. >=20 > Author: Vagrant Cascadian > Author: Nicolas Boulenguez > Signed-By: Nicolas Boulenguez >=20 > --- a/Makefile > +++ b/Makefile > @@ -456,7 +456,7 @@ KBUILD_AFLAGS +=3D $(call cc-option,-fno-PIE) > =20 > # Read UBOOTRELEASE from include/config/uboot.release (if it exists) > UBOOTRELEASE =3D $(shell cat include/config/uboot.release 2> /dev/null) > -UBOOTVERSION =3D $(VERSION)$(if $(PATCHLEVEL),.$(PATCHLEVEL)$(if $(SUBLE= VEL),.$(SUBLEVEL)))$(EXTRAVERSION) > +UBOOTVERSION =3D $(VERSION)$(if $(PATCHLEVEL),.$(PATCHLEVEL)$(if $(SUBLE= VEL),.$(SUBLEVEL)))$(EXTRAVERSION)$(BUILD_VERSION) > =20 > export VERSION PATCHLEVEL SUBLEVEL UBOOTRELEASE UBOOTVERSION > export ARCH CPU BOARD VENDOR SOC CPUDIR BOARDDIR > --- a/doc/build/gcc.rst > +++ b/doc/build/gcc.rst > @@ -151,6 +151,11 @@ > Note that the :doc:`tools` are always built with the included version of= libfdt > so it is not possible to build U-Boot tools with a system libfdt, at pre= sent. > =20 > +If you are modifying the upstream sources, please make this visible > +at boot time by defining the BUILD_VERSION version suffix. > + > +* BUILD_VERSION=3D+<...> > + > Other build targets > ~~~~~~~~~~~~~~~~~~~ Why do you need this, instead of just using CONFIG_LOCALVERSION? What do you do for linux kernel builds, which are also Kbuild based? Thanks. --=20 Tom --YiEDa0DAkWCtVeE4 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmJUScYACgkQFHw5/5Y0 tyxzugv+LFNgVHcNu/0uIZlFoWCIEVTgYiTADV69zmyxEIhcBCaR5eImtn7HD2PT MpUXqrYVBXmbeDk1tBvFrNl5X06zBDXjFC+LGJ8wD314RXGoLl727kxFYqTNrsE8 +z3uHCVtgGgcPFjUQgqhbblxy6PL+Z/QEYpWKAhDQdbp/26/2+68UqRmMsfXwTAP 0gmC8tWJDUaobrskoCDj8LbTYog8WjIRXm6F8ssWounQyZJji2PYhWRTqwTtnp8a Tizb64+l7Z3SlhossrL5CLXlwvI2K6DDypi4rPtTYd0pUVUXmc4mUf1u7PAWeyBs ze4frWPGBEh4g24B6kuri8PwNH3FZUEl9pYqWrNQ8hlReIgAdUsqR8jBLbRofzpg g1e/xi5TjYshVn6b+GkZgK4qFk0SbZGyMiw7Ec6SRhIeyn4cvUykfQ/g3ScqS5bQ UYOKMTf6sfLASQ9yh3AM/dkfG6EeFOeeFi7vh2znugwwMzruLqHjjKe6oM4q4OnG ADHL+Ool =yzO/ -----END PGP SIGNATURE----- --YiEDa0DAkWCtVeE4--