Re: [PATCH v4 0/6] imx8mn-smm-s2/pro: Add iMX8MN BSH SMM S2 boards

From: Tom Rini <trini@konsulko.com>
To: Stefano Babic <sbabic@denx.de>
Cc: Ariel D'Alessandro <ariel.dalessandro@collabora.com>,
	festevam@gmail.com, u-boot@lists.denx.de, Peter.Hoyes@arm.com,
	aford173@gmail.com, alice.guo@nxp.com, andre.przywara@arm.com,
	andrey.zhizhikin@leica-geosystems.com, bmeng.cn@gmail.com,
	christian.gmeiner@gmail.com, christianshewitt@gmail.com,
	iliev@ronetix.at, jagan@amarulasolutions.com,
	jh80.chung@samsung.com, joe.hershberger@ni.com,
	kettenis@openbsd.org, kever.yang@rock-chips.com,
	kuldeep.singh@nxp.com, marcel.ziswiler@toradex.com,
	marex@denx.de, michael@amarulasolutions.com,
	michal.simek@xilinx.com, oliver.graute@kococonnector.com,
	pali@kernel.org, paul.liu@linaro.org, pbrobinson@gmail.com,
	peng.fan@nxp.com, philipp.tomsich@vrull.eu,
	priyanka.jain@nxp.com, radu-nicolae.pirea@oss.nxp.com,
	rath@ibv-augsburg.net, rfried.dev@gmail.com, samuel@sholland.org,
	simon.k.r.goldschmidt@gmail.com, sjg@chromium.org,
	stephan@gerhold.net, tharvey@gateworks.com,
	tien.fong.chee@intel.com, uboot-imx@nxp.com,
	vladimir.oltean@nxp.com, wd@denx.de, xypron.glpk@gmx.de,
	ye.li@nxp.com
Subject: Re: [PATCH v4 0/6] imx8mn-smm-s2/pro: Add iMX8MN BSH SMM S2 boards
Date: Mon, 11 Apr 2022 12:03:52 -0400	[thread overview]
Message-ID: <20220411160352.GI14282@bill-the-cat> (raw)
In-Reply-To: <7a34e2ee-b6c9-3f50-7b10-df95db462ea5@denx.de>

[-- Attachment #1: Type: text/plain, Size: 1579 bytes --]

On Mon, Apr 11, 2022 at 05:56:52PM +0200, Stefano Babic wrote:
> Hi Ariel,
> 
> On 11.04.22 13:56, Ariel D'Alessandro wrote:
> > Hi,
> > 
> > Gentle re-ping. What's blocking this?
> > This has been reviewed and queued for some time already. Please, be
> > clear on the status or what's the plan for this patchset.
> > 
> 
> After first run, build is blocked by CI due to CONFIG_ that should be se in
> configs/imx8mn_bsh_smm_s2_defconfig instead of
> include/configs/imx8mn_bsh_smm_s2_common.h. I can recognize at least
> CONFIG_SYS_MMCSD_RAW_MODE_U_BOOT_SECTOR (and family), but it looks like
> there are some more.
> 
> See error here:
> 
> 	https://source.denx.de/u-boot/custodians/u-boot-imx/-/jobs/420878

Since this is going to pop up a bit I suspect,
https://source.denx.de/u-boot/custodians/u-boot-imx/-/jobs/420878#L24
shows the shell command to run that gives "Unmigrated symbols found in
include/configs/imx8mn_bsh_smm_s2_common.h".  And if instead of:
NUM=`comm -123 --total --output-delimiter=, ${KSYMLST} ${KUSEDLST} | cut
-d , -f 3`; if [[ $NUM -ne 0 ]]; then echo "Unmigrated symbols found in
$CFG"; exit 1; fi

You do:
comm -12 ${KSYMLST} ${KUSEDLST}

You'll see the whole list of unmigrated symbols.  Many of which are easy
to migrate and it's just a matter of ./tools/moveconfig.py -y FOO and
then sanity checking the output.

And a currently failing patchset is also maybe motivation to expand the
CI check to note them too?  As I can certainly see how it would be good
to have the what failed more visible.

-- 
Tom

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]