From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 14E7EC433EF for ; Mon, 11 Apr 2022 16:53:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243308AbiDKQzY (ORCPT ); Mon, 11 Apr 2022 12:55:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60614 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241922AbiDKQzX (ORCPT ); Mon, 11 Apr 2022 12:55:23 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 46C8235264 for ; Mon, 11 Apr 2022 09:53:09 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id EAA7EB81716 for ; Mon, 11 Apr 2022 16:53:07 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 53B41C385A3; Mon, 11 Apr 2022 16:53:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1649695986; bh=JWgIvFStReKHFvazyQ+P5dMXzxxteokY9DZL2RDHylI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=LGrOxFQkUB9z4Vkadd1ZxqLpJmS8gacRwBVXUmTquXkHsdZV8y92PCw4kkFnHzm6D czEiRK7nKPCxzjHzs6kaIZ6lpPuqGvCrBuvo828ftSuk6aT1GNZ1R2Uz4K5q7QxvCZ /HeXoXC0ZGwPJBqtTQ9Tyg35ck0OYQrxu2QcXJ+26vmtNsMDl0OJMYU5o7y/uWg/aB gdyHnzVkEZlyWOi0pdzkmtHlSvULFQi7Yjept23GYmF0zGq+s2IQJID4yEkbCSY0H9 j6limE9Mu7ImEBusNzvrqYZmkY+zbEeKMyCJB3sLCLfhE66WG9XDUl/MSuUwgDdiSL +BGBte1zn3Saw== Received: by pali.im (Postfix) id 537D1947; Mon, 11 Apr 2022 18:53:03 +0200 (CEST) Date: Mon, 11 Apr 2022 18:53:03 +0200 From: Pali =?utf-8?B?Um9ow6Fy?= To: Lorenzo Pieralisi Cc: Marek =?utf-8?B?QmVow7pu?= , Bjorn Helgaas , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Marc Zyngier , linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Gregory CLEMENT Subject: Re: [PATCH 00/18] PCI: aardvark controller changes BATCH 5 Message-ID: <20220411165303.stupmwjszh3otlme@pali> References: <20220220193346.23789-1-kabel@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: NeoMutt/20180716 Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org On Monday 11 April 2022 16:36:43 Lorenzo Pieralisi wrote: > On Sun, Feb 20, 2022 at 08:33:28PM +0100, Marek Behún wrote: > > Hello Lorenzo, Krzysztof, > > > > here comes batch 5 of changes for Aardvark PCIe controller. > > > > This batch > > - adds support for AER > > - adds support for DLLSC and hotplug interrupt > > - adds support for sending slot power limit message > > - adds enabling/disabling PCIe clock > > - adds suspend support > > - optimizes link training by adding it into separate worker > > - optimizes GPIO resetting by asserting it only if it wasn't asserted > > already > > > > Marek > > Hi Marek, > > I noticed Pali posted patches [9,11] separately: > > https://lore.kernel.org/linux-pci/20220325093827.4983-1-pali@kernel.org Patches 9,10,11 from this patch series are also in above mvebu patch series as they are required for other patch in above patch series. Above patch series is v3 and I'm planning to send v4 to address all review issues. So basically patches 9,10,11 in this patch series should be replaced with new version. > I will review the rest of the series - when it comes to merging patches > we will handle how to apply them. > > Lorenzo > > > Marek Behún (1): > > arm64: dts: marvell: armada-37xx: Add clock to PCIe node > > > > Miquel Raynal (2): > > PCI: aardvark: Add clock support > > PCI: aardvark: Add suspend to RAM support > > > > Pali Rohár (13): > > PCI: aardvark: Add support for AER registers on emulated bridge > > PCI: Add PCI_EXP_SLTCAP_*_SHIFT macros > > PCI: aardvark: Fix reporting Slot capabilities on emulated bridge > > PCI: pciehp: Enable DLLSC interrupt only if supported > > PCI: pciehp: Enable Command Completed Interrupt only if supported > > PCI: aardvark: Add support for DLLSC and hotplug interrupt > > PCI: Add PCI_EXP_SLTCTL_ASPL_DISABLE macro > > PCI: Add function for parsing `slot-power-limit-milliwatt` DT property > > dt-bindings: PCI: aardvark: Describe slot-power-limit-milliwatt > > PCI: aardvark: Send Set_Slot_Power_Limit message > > arm64: dts: armada-3720-turris-mox: Define slot-power-limit-milliwatt > > for PCIe > > PCI: aardvark: Run link training in separate worker > > PCI: aardvark: Optimize PCIe card reset via GPIO > > > > Russell King (2): > > PCI: pci-bridge-emul: Re-arrange register tests > > PCI: pci-bridge-emul: Add support for PCIe extended capabilities > > > > .../devicetree/bindings/pci/aardvark-pci.txt | 2 + > > .../dts/marvell/armada-3720-turris-mox.dts | 1 + > > arch/arm64/boot/dts/marvell/armada-37xx.dtsi | 1 + > > drivers/pci/controller/pci-aardvark.c | 380 ++++++++++++++++-- > > drivers/pci/hotplug/pciehp_hpc.c | 34 +- > > drivers/pci/hotplug/pnv_php.c | 13 +- > > drivers/pci/of.c | 64 +++ > > drivers/pci/pci-bridge-emul.c | 130 +++--- > > drivers/pci/pci-bridge-emul.h | 15 + > > drivers/pci/pci.h | 15 + > > include/uapi/linux/pci_regs.h | 4 + > > 11 files changed, 565 insertions(+), 94 deletions(-) > > > > -- > > 2.34.1 > > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C68E1C433EF for ; Mon, 11 Apr 2022 16:54:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=2oLwAl7KYHwBzoRSpuPEjcs+Hq4TVzrR/J4v1YrUrKU=; b=PhxRKTnEw4QFqX fT9NyZoQF+72IaVWmPuVWPj7Cww7EyUiyS/VuZYy8ykgBstSsLgFzjlMVkvL5P/sJYfFuLwiLx4eY 699CaEhA2CTF0bXQSAdjJNRf5223bUN1IzCYPHoDzSCyP1jJvG/jKc4w1cRWDIrO7yyHDYi3TMiyd POEomvQ37xH1D+SS2X+ZCWeCBKp9bOhoItsdqhFnyQp2nxAAMttRhwaG9+rJhkW6ZBAa3hdR5miR8 13v05tncRtbBOOHeZ6aLpK8KhHWz1vEszT7Gwg2/0COa+5T08cStj4WhwpEDJOrgCQ0meZ8PKJHq8 G/H38U3iYpPhClMyYCwQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ndxHq-009oH9-QY; Mon, 11 Apr 2022 16:53:10 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ndxHo-009oGW-26 for linux-arm-kernel@lists.infradead.org; Mon, 11 Apr 2022 16:53:09 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 4D401616F3; Mon, 11 Apr 2022 16:53:07 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 53B41C385A3; Mon, 11 Apr 2022 16:53:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1649695986; bh=JWgIvFStReKHFvazyQ+P5dMXzxxteokY9DZL2RDHylI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=LGrOxFQkUB9z4Vkadd1ZxqLpJmS8gacRwBVXUmTquXkHsdZV8y92PCw4kkFnHzm6D czEiRK7nKPCxzjHzs6kaIZ6lpPuqGvCrBuvo828ftSuk6aT1GNZ1R2Uz4K5q7QxvCZ /HeXoXC0ZGwPJBqtTQ9Tyg35ck0OYQrxu2QcXJ+26vmtNsMDl0OJMYU5o7y/uWg/aB gdyHnzVkEZlyWOi0pdzkmtHlSvULFQi7Yjept23GYmF0zGq+s2IQJID4yEkbCSY0H9 j6limE9Mu7ImEBusNzvrqYZmkY+zbEeKMyCJB3sLCLfhE66WG9XDUl/MSuUwgDdiSL +BGBte1zn3Saw== Received: by pali.im (Postfix) id 537D1947; Mon, 11 Apr 2022 18:53:03 +0200 (CEST) Date: Mon, 11 Apr 2022 18:53:03 +0200 From: Pali =?utf-8?B?Um9ow6Fy?= To: Lorenzo Pieralisi Cc: Marek =?utf-8?B?QmVow7pu?= , Bjorn Helgaas , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Marc Zyngier , linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Gregory CLEMENT Subject: Re: [PATCH 00/18] PCI: aardvark controller changes BATCH 5 Message-ID: <20220411165303.stupmwjszh3otlme@pali> References: <20220220193346.23789-1-kabel@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20180716 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220411_095308_214165_605767B8 X-CRM114-Status: GOOD ( 22.64 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gTW9uZGF5IDExIEFwcmlsIDIwMjIgMTY6MzY6NDMgTG9yZW56byBQaWVyYWxpc2kgd3JvdGU6 Cj4gT24gU3VuLCBGZWIgMjAsIDIwMjIgYXQgMDg6MzM6MjhQTSArMDEwMCwgTWFyZWsgQmVow7pu IHdyb3RlOgo+ID4gSGVsbG8gTG9yZW56bywgS3J6eXN6dG9mLAo+ID4gCj4gPiBoZXJlIGNvbWVz IGJhdGNoIDUgb2YgY2hhbmdlcyBmb3IgQWFyZHZhcmsgUENJZSBjb250cm9sbGVyLgo+ID4gCj4g PiBUaGlzIGJhdGNoCj4gPiAtIGFkZHMgc3VwcG9ydCBmb3IgQUVSCj4gPiAtIGFkZHMgc3VwcG9y dCBmb3IgRExMU0MgYW5kIGhvdHBsdWcgaW50ZXJydXB0Cj4gPiAtIGFkZHMgc3VwcG9ydCBmb3Ig c2VuZGluZyBzbG90IHBvd2VyIGxpbWl0IG1lc3NhZ2UKPiA+IC0gYWRkcyBlbmFibGluZy9kaXNh YmxpbmcgUENJZSBjbG9jawo+ID4gLSBhZGRzIHN1c3BlbmQgc3VwcG9ydAo+ID4gLSBvcHRpbWl6 ZXMgbGluayB0cmFpbmluZyBieSBhZGRpbmcgaXQgaW50byBzZXBhcmF0ZSB3b3JrZXIKPiA+IC0g b3B0aW1pemVzIEdQSU8gcmVzZXR0aW5nIGJ5IGFzc2VydGluZyBpdCBvbmx5IGlmIGl0IHdhc24n dCBhc3NlcnRlZAo+ID4gICBhbHJlYWR5Cj4gPiAKPiA+IE1hcmVrCj4gCj4gSGkgTWFyZWssCj4g Cj4gSSBub3RpY2VkIFBhbGkgcG9zdGVkIHBhdGNoZXMgWzksMTFdIHNlcGFyYXRlbHk6Cj4gCj4g aHR0cHM6Ly9sb3JlLmtlcm5lbC5vcmcvbGludXgtcGNpLzIwMjIwMzI1MDkzODI3LjQ5ODMtMS1w YWxpQGtlcm5lbC5vcmcKClBhdGNoZXMgOSwxMCwxMSBmcm9tIHRoaXMgcGF0Y2ggc2VyaWVzIGFy ZSBhbHNvIGluIGFib3ZlIG12ZWJ1IHBhdGNoCnNlcmllcyBhcyB0aGV5IGFyZSByZXF1aXJlZCBm b3Igb3RoZXIgcGF0Y2ggaW4gYWJvdmUgcGF0Y2ggc2VyaWVzLgoKQWJvdmUgcGF0Y2ggc2VyaWVz IGlzIHYzIGFuZCBJJ20gcGxhbm5pbmcgdG8gc2VuZCB2NCB0byBhZGRyZXNzIGFsbApyZXZpZXcg aXNzdWVzLgoKU28gYmFzaWNhbGx5IHBhdGNoZXMgOSwxMCwxMSBpbiB0aGlzIHBhdGNoIHNlcmll cyBzaG91bGQgYmUgcmVwbGFjZWQKd2l0aCBuZXcgdmVyc2lvbi4KCj4gSSB3aWxsIHJldmlldyB0 aGUgcmVzdCBvZiB0aGUgc2VyaWVzIC0gd2hlbiBpdCBjb21lcyB0byBtZXJnaW5nIHBhdGNoZXMK PiB3ZSB3aWxsIGhhbmRsZSBob3cgdG8gYXBwbHkgdGhlbS4KPiAKPiBMb3JlbnpvCj4gCj4gPiBN YXJlayBCZWjDum4gKDEpOgo+ID4gICBhcm02NDogZHRzOiBtYXJ2ZWxsOiBhcm1hZGEtMzd4eDog QWRkIGNsb2NrIHRvIFBDSWUgbm9kZQo+ID4gCj4gPiBNaXF1ZWwgUmF5bmFsICgyKToKPiA+ICAg UENJOiBhYXJkdmFyazogQWRkIGNsb2NrIHN1cHBvcnQKPiA+ICAgUENJOiBhYXJkdmFyazogQWRk IHN1c3BlbmQgdG8gUkFNIHN1cHBvcnQKPiA+IAo+ID4gUGFsaSBSb2jDoXIgKDEzKToKPiA+ICAg UENJOiBhYXJkdmFyazogQWRkIHN1cHBvcnQgZm9yIEFFUiByZWdpc3RlcnMgb24gZW11bGF0ZWQg YnJpZGdlCj4gPiAgIFBDSTogQWRkIFBDSV9FWFBfU0xUQ0FQXypfU0hJRlQgbWFjcm9zCj4gPiAg IFBDSTogYWFyZHZhcms6IEZpeCByZXBvcnRpbmcgU2xvdCBjYXBhYmlsaXRpZXMgb24gZW11bGF0 ZWQgYnJpZGdlCj4gPiAgIFBDSTogcGNpZWhwOiBFbmFibGUgRExMU0MgaW50ZXJydXB0IG9ubHkg aWYgc3VwcG9ydGVkCj4gPiAgIFBDSTogcGNpZWhwOiBFbmFibGUgQ29tbWFuZCBDb21wbGV0ZWQg SW50ZXJydXB0IG9ubHkgaWYgc3VwcG9ydGVkCj4gPiAgIFBDSTogYWFyZHZhcms6IEFkZCBzdXBw b3J0IGZvciBETExTQyBhbmQgaG90cGx1ZyBpbnRlcnJ1cHQKPiA+ICAgUENJOiBBZGQgUENJX0VY UF9TTFRDVExfQVNQTF9ESVNBQkxFIG1hY3JvCj4gPiAgIFBDSTogQWRkIGZ1bmN0aW9uIGZvciBw YXJzaW5nIGBzbG90LXBvd2VyLWxpbWl0LW1pbGxpd2F0dGAgRFQgcHJvcGVydHkKPiA+ICAgZHQt YmluZGluZ3M6IFBDSTogYWFyZHZhcms6IERlc2NyaWJlIHNsb3QtcG93ZXItbGltaXQtbWlsbGl3 YXR0Cj4gPiAgIFBDSTogYWFyZHZhcms6IFNlbmQgU2V0X1Nsb3RfUG93ZXJfTGltaXQgbWVzc2Fn ZQo+ID4gICBhcm02NDogZHRzOiBhcm1hZGEtMzcyMC10dXJyaXMtbW94OiBEZWZpbmUgc2xvdC1w b3dlci1saW1pdC1taWxsaXdhdHQKPiA+ICAgICBmb3IgUENJZQo+ID4gICBQQ0k6IGFhcmR2YXJr OiBSdW4gbGluayB0cmFpbmluZyBpbiBzZXBhcmF0ZSB3b3JrZXIKPiA+ICAgUENJOiBhYXJkdmFy azogT3B0aW1pemUgUENJZSBjYXJkIHJlc2V0IHZpYSBHUElPCj4gPiAKPiA+IFJ1c3NlbGwgS2lu ZyAoMik6Cj4gPiAgIFBDSTogcGNpLWJyaWRnZS1lbXVsOiBSZS1hcnJhbmdlIHJlZ2lzdGVyIHRl c3RzCj4gPiAgIFBDSTogcGNpLWJyaWRnZS1lbXVsOiBBZGQgc3VwcG9ydCBmb3IgUENJZSBleHRl bmRlZCBjYXBhYmlsaXRpZXMKPiA+IAo+ID4gIC4uLi9kZXZpY2V0cmVlL2JpbmRpbmdzL3BjaS9h YXJkdmFyay1wY2kudHh0ICB8ICAgMiArCj4gPiAgLi4uL2R0cy9tYXJ2ZWxsL2FybWFkYS0zNzIw LXR1cnJpcy1tb3guZHRzICAgIHwgICAxICsKPiA+ICBhcmNoL2FybTY0L2Jvb3QvZHRzL21hcnZl bGwvYXJtYWRhLTM3eHguZHRzaSAgfCAgIDEgKwo+ID4gIGRyaXZlcnMvcGNpL2NvbnRyb2xsZXIv cGNpLWFhcmR2YXJrLmMgICAgICAgICB8IDM4MCArKysrKysrKysrKysrKysrLS0KPiA+ICBkcml2 ZXJzL3BjaS9ob3RwbHVnL3BjaWVocF9ocGMuYyAgICAgICAgICAgICAgfCAgMzQgKy0KPiA+ICBk cml2ZXJzL3BjaS9ob3RwbHVnL3Budl9waHAuYyAgICAgICAgICAgICAgICAgfCAgMTMgKy0KPiA+ ICBkcml2ZXJzL3BjaS9vZi5jICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgfCAgNjQgKysr Cj4gPiAgZHJpdmVycy9wY2kvcGNpLWJyaWRnZS1lbXVsLmMgICAgICAgICAgICAgICAgIHwgMTMw ICsrKy0tLQo+ID4gIGRyaXZlcnMvcGNpL3BjaS1icmlkZ2UtZW11bC5oICAgICAgICAgICAgICAg ICB8ICAxNSArCj4gPiAgZHJpdmVycy9wY2kvcGNpLmggICAgICAgICAgICAgICAgICAgICAgICAg ICAgIHwgIDE1ICsKPiA+ICBpbmNsdWRlL3VhcGkvbGludXgvcGNpX3JlZ3MuaCAgICAgICAgICAg ICAgICAgfCAgIDQgKwo+ID4gIDExIGZpbGVzIGNoYW5nZWQsIDU2NSBpbnNlcnRpb25zKCspLCA5 NCBkZWxldGlvbnMoLSkKPiA+IAo+ID4gLS0gCj4gPiAyLjM0LjEKPiA+IAoKX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGludXgtYXJtLWtlcm5lbCBtYWls aW5nIGxpc3QKbGludXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0 cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtYXJtLWtlcm5lbAo=