From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0AAADC433EF for ; Mon, 11 Apr 2022 17:23:35 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id BEDD683A1E; Mon, 11 Apr 2022 19:23:33 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="nQBQkEQm"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 01A0483B38; Mon, 11 Apr 2022 19:18:28 +0200 (CEST) Received: from mail-qk1-x72d.google.com (mail-qk1-x72d.google.com [IPv6:2607:f8b0:4864:20::72d]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id A88A483AEB for ; Mon, 11 Apr 2022 19:18:25 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qk1-x72d.google.com with SMTP id g11so10110748qke.1 for ; Mon, 11 Apr 2022 10:18:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=FFo+iefclaNTz7ZRDxSXWOJRZX1TXexN7E8oRFHdMAM=; b=nQBQkEQmbHHUmY0PfygAKf6bdmFCZJWB0YhqU5UzQlanyj14cxSZPB6ys6n4sY2ZCf h/psgCanXWb40e02hg8mNb0Y1F0FOm27mpfWlSRM1QX+vuaa4e/IG2UoIMrDtP1Qxbmk uRnTJHG9zDw/RjIeDEseozPiAI/XbhJexpFBw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=FFo+iefclaNTz7ZRDxSXWOJRZX1TXexN7E8oRFHdMAM=; b=06ScTu/qzjSk7dNQuyTpd1nhzttjcRz4plqM3F/QG3URFmET40lzybOS3jKNWTqud1 OvdTh9MDITbU8kmP8BRvfRU0Uox7SmdU1JMJKPTa8yBQ7SULx9q7zOJtOlnonHJA4p5o uIAgieQ4NGU8stTU711LtkiLJRe0ZFaaw2mdCTcqGVdYBrK6l7ZXji3EgqtpDkfykS1G gQjyVaaBAx68759wLWd52xJJWr9be/FVIXCntsrHmZ0d9zLOD2xZ38huQmBERRxBFSBU jk4XbfOd28ol29b2YGSC6Fj8xKEHSjwlaWCrlg1t7M8IQYzTNJ3mKr375F4CGkV1MZ1v /9rQ== X-Gm-Message-State: AOAM533k3x+R16A+h3xrbRMPqoKT9n2zVzE+oBEupI3RsPpLzU6BRjjP 5Tbo6iOSCns7seCwNThJF1bOQw== X-Google-Smtp-Source: ABdhPJybgvYTkwAfgIWbrtdEMT+WrDiwK1/PZdfWaxChsQeHoJcLHPRzaVohSjEt9tyRocs2Z31Klw== X-Received: by 2002:a37:9a57:0:b0:69b:fbce:8035 with SMTP id c84-20020a379a57000000b0069bfbce8035mr291104qke.187.1649697504304; Mon, 11 Apr 2022 10:18:24 -0700 (PDT) Received: from bill-the-cat (2603-6081-7b01-cbda-2ef0-5dff-fedb-a8ba.res6.spectrum.com. [2603:6081:7b01:cbda:2ef0:5dff:fedb:a8ba]) by smtp.gmail.com with ESMTPSA id d15-20020a05622a15cf00b002ef31d86837sm1535109qty.55.2022.04.11.10.18.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 11 Apr 2022 10:18:23 -0700 (PDT) Date: Mon, 11 Apr 2022 13:18:19 -0400 From: Tom Rini To: Stefano Babic Cc: Ariel D'Alessandro , festevam@gmail.com, u-boot@lists.denx.de, Peter.Hoyes@arm.com, aford173@gmail.com, alice.guo@nxp.com, andre.przywara@arm.com, andrey.zhizhikin@leica-geosystems.com, bmeng.cn@gmail.com, christian.gmeiner@gmail.com, christianshewitt@gmail.com, iliev@ronetix.at, jagan@amarulasolutions.com, jh80.chung@samsung.com, joe.hershberger@ni.com, kettenis@openbsd.org, kever.yang@rock-chips.com, kuldeep.singh@nxp.com, marcel.ziswiler@toradex.com, marex@denx.de, michael@amarulasolutions.com, michal.simek@xilinx.com, oliver.graute@kococonnector.com, pali@kernel.org, paul.liu@linaro.org, pbrobinson@gmail.com, peng.fan@nxp.com, philipp.tomsich@vrull.eu, priyanka.jain@nxp.com, radu-nicolae.pirea@oss.nxp.com, rath@ibv-augsburg.net, rfried.dev@gmail.com, samuel@sholland.org, simon.k.r.goldschmidt@gmail.com, sjg@chromium.org, stephan@gerhold.net, tharvey@gateworks.com, tien.fong.chee@intel.com, uboot-imx@nxp.com, vladimir.oltean@nxp.com, wd@denx.de, xypron.glpk@gmx.de, ye.li@nxp.com Subject: Re: [PATCH v4 0/6] imx8mn-smm-s2/pro: Add iMX8MN BSH SMM S2 boards Message-ID: <20220411171819.GK14282@bill-the-cat> References: <20220304122228.71412-1-ariel.dalessandro@collabora.com> <0ba4ebb3-afe5-95b2-47b8-cac6b381ba1e@collabora.com> <20220405224622.GX9042@bill-the-cat> <03fcfb51-a4ba-bd88-8bb0-883d1a0b7abe@collabora.com> <7a34e2ee-b6c9-3f50-7b10-df95db462ea5@denx.de> <20220411160352.GI14282@bill-the-cat> <62a3a093-3837-f7c8-39c0-f7565d509832@denx.de> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="H3QWGwNgsl3Q7pDd" Content-Disposition: inline In-Reply-To: <62a3a093-3837-f7c8-39c0-f7565d509832@denx.de> X-Clacks-Overhead: GNU Terry Pratchett X-Mailman-Approved-At: Mon, 11 Apr 2022 19:23:32 +0200 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean --H3QWGwNgsl3Q7pDd Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Apr 11, 2022 at 06:27:06PM +0200, Stefano Babic wrote: > On 11.04.22 18:03, Tom Rini wrote: > > On Mon, Apr 11, 2022 at 05:56:52PM +0200, Stefano Babic wrote: > > > Hi Ariel, > > >=20 > > > On 11.04.22 13:56, Ariel D'Alessandro wrote: > > > > Hi, > > > >=20 > > > > Gentle re-ping. What's blocking this? > > > > This has been reviewed and queued for some time already. Please, be > > > > clear on the status or what's the plan for this patchset. > > > >=20 > > >=20 > > > After first run, build is blocked by CI due to CONFIG_ that should be= se in > > > configs/imx8mn_bsh_smm_s2_defconfig instead of > > > include/configs/imx8mn_bsh_smm_s2_common.h. I can recognize at least > > > CONFIG_SYS_MMCSD_RAW_MODE_U_BOOT_SECTOR (and family), but it looks li= ke > > > there are some more. > > >=20 > > > See error here: > > >=20 > > > https://source.denx.de/u-boot/custodians/u-boot-imx/-/jobs/420878 > >=20 > > Since this is going to pop up a bit I suspect, > > https://source.denx.de/u-boot/custodians/u-boot-imx/-/jobs/420878#L24 > > shows the shell command to run that gives "Unmigrated symbols found in > > include/configs/imx8mn_bsh_smm_s2_common.h". And if instead of: > > NUM=3D`comm -123 --total --output-delimiter=3D, ${KSYMLST} ${KUSEDLST} = | cut > > -d , -f 3`; if [[ $NUM -ne 0 ]]; then echo "Unmigrated symbols found in > > $CFG"; exit 1; fi > >=20 > > You do: > > comm -12 ${KSYMLST} ${KUSEDLST} >=20 > It is much better because CI does not report which CONFIG_ were found. >=20 > >=20 > > You'll see the whole list of unmigrated symbols. Many of which are easy > > to migrate and it's just a matter of ./tools/moveconfig.py -y FOO and > > then sanity checking the output. > >=20 > > And a currently failing patchset is also maybe motivation to expand the > > CI check to note them too? As I can certainly see how it would be good > > to have the what failed more visible. >=20 > Sure, at least to get the whole list of CONFIG_ that clash. OK, I've got an updated test that gives more information: https://source.denx.de/u-boot/u-boot/-/jobs/421202 --=20 Tom --H3QWGwNgsl3Q7pDd Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmJUYtgACgkQFHw5/5Y0 tyzOnwv/TZg7+GKFHdCfApJuj1JVc+TJX4ipZJuiwNt2WE740WrfRQvSVyGEsf6a kqaWtVJWEPG3KaV2lofu4Rje8cqMZR4hZPphdzpU+qbkSZt3fyhcZepCxiHQgj+E SlkyCFpGKD+tXt2zQN+s0jy7mRArvvx5jj2Bt139Vfu+Tu6fExG+B1qybeusGn5i G/J6GCB/iyQ0+VInTsmCFNRQUGTkysHzOc28QEQxbKLh2lN1+UZFSVvJgzWIvZjD 9SmBGHxya27ZvpC05x+y0AfjF5guN0eq+ln/JDIPruuxjyEIsEb56C9byqOgnLFS o/Jbu/yKjtOq/JkH9SrjIr1W6men8odVWQJ+scWMfx/QhhhBre2Hsk1LXAz6N8yV pGTa2sXOeBcOh3lLHYn0yU/lh19tODcrRHkSRBFeW2HP9eg6PTdhquoN7sBzRQ9B fR95xvz0kC7fw+SnxGUCR24Kcf/1cghcwS5dyj2nRIWdWyThpzYYcj0TOZmXHfk4 S5gOjXUD =MAbH -----END PGP SIGNATURE----- --H3QWGwNgsl3Q7pDd--