All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jakub Kicinski <kuba@kernel.org>
To: <alexandru.tachici@analog.com>
Cc: <andrew@lunn.ch>, <o.rempel@pengutronix.de>,
	<davem@davemloft.net>, <devicetree@vger.kernel.org>,
	<hkallweit1@gmail.com>, <linux-kernel@vger.kernel.org>,
	<linux@armlinux.org.uk>, <netdev@vger.kernel.org>,
	<robh+dt@kernel.org>
Subject: Re: [PATCH v6 4/7] net: phy: Add 10BASE-T1L support in phy-c45
Date: Tue, 12 Apr 2022 09:45:24 -0700	[thread overview]
Message-ID: <20220412094524.178b8785@kernel.org> (raw)
In-Reply-To: <20220412130706.36767-5-alexandru.tachici@analog.com>

On Tue, 12 Apr 2022 16:07:03 +0300 alexandru.tachici@analog.com wrote:
> diff --git a/include/linux/phy.h b/include/linux/phy.h
> index 36ca2b5c2253..6c3048e2a3ce 100644
> --- a/include/linux/phy.h
> +++ b/include/linux/phy.h
> @@ -698,6 +698,8 @@ struct phy_device {
>  	u8 mdix;
>  	u8 mdix_ctrl;
>  
> +	int pma_extable;
> +
>  	void (*phy_link_change)(struct phy_device *phydev, bool up);
>  	void (*adjust_link)(struct net_device *dev);

kdoc warning here:

include/linux/phy.h:711: warning: Function parameter or member 'pma_extable' not described in 'phy_device'

Please allow at least 24h between postings to collect additional
feedback.

  reply	other threads:[~2022-04-12 16:45 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-12 13:06 [PATCH v6 0/7] net: phy: adin1100: Add initial support for ADIN1100 industrial PHY alexandru.tachici
2022-04-12 13:07 ` [PATCH v6 1/7] ethtool: Add 10base-T1L link mode entry alexandru.tachici
2022-04-13 14:03   ` Russell King (Oracle)
2022-04-22 12:27   ` Oleksij Rempel
2022-04-12 13:07 ` [PATCH v6 2/7] net: phy: Add 10-BaseT1L registers alexandru.tachici
2022-04-12 13:07 ` [PATCH v6 3/7] net: phy: Add BaseT1 auto-negotiation registers alexandru.tachici
2022-04-12 13:07 ` [PATCH v6 4/7] net: phy: Add 10BASE-T1L support in phy-c45 alexandru.tachici
2022-04-12 16:45   ` Jakub Kicinski [this message]
2022-04-12 13:07 ` [PATCH v6 5/7] net: phy: adin1100: Add initial support for ADIN1100 industrial PHY alexandru.tachici
2022-04-12 13:07 ` [PATCH v6 6/7] net: phy: adin1100: Add SQI support alexandru.tachici
2022-04-12 13:07 ` [PATCH v6 7/7] dt-bindings: net: phy: Add 10-baseT1L 2.4 Vpp alexandru.tachici

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220412094524.178b8785@kernel.org \
    --to=kuba@kernel.org \
    --cc=alexandru.tachici@analog.com \
    --cc=andrew@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=devicetree@vger.kernel.org \
    --cc=hkallweit1@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=netdev@vger.kernel.org \
    --cc=o.rempel@pengutronix.de \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.