From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8894EC433EF for ; Tue, 12 Apr 2022 11:48:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=zjMABNmOm91QDsvUngUHmJO7JMqvuJw9DVGAFwSwE8M=; b=oaBdmAVEJDaxW1 AGJ1+rf+gp/Mlor/7ggaYXpO9Ydt+R50RK15zxg6cEF5jlKtSvfv1czWoJuIE50KbFW3pictpAv81 KhujPEip1IdonnuFbqNIZOFosAByQ1vDBUUba6x+KFvhgyNcq1jmX37CVzHzG/50Z8hHf57LJJJvx 8XCOfkWT9lMA0l/stgtHZi9vntB/ZTpI5jt80Fb0dhMowLFpMwa/ZomHgEGMsS5Gsg8lHK3DuI1N9 /+PiIEiIrdT9ooiYRa3+ZyB/KPO3NtaMq7e3veX8LNtbtOJNZSMJfAosz3KLvAT9frAediRoRK4eH TMtU5Q0oJYOCspPi5UbA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1neEyt-00Don7-Hv; Tue, 12 Apr 2022 11:46:48 +0000 Received: from mail-lf1-x129.google.com ([2a00:1450:4864:20::129]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1neEq9-00DkuB-2e for linux-arm-kernel@lists.infradead.org; Tue, 12 Apr 2022 11:37:46 +0000 Received: by mail-lf1-x129.google.com with SMTP id t25so31657812lfg.7 for ; Tue, 12 Apr 2022 04:37:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=5aneK7Rl07kK1qGmCVmUb7811DnxlqneA9Z72R6PRJc=; b=HxQcMx486YxA3qXMLBqpak4qkZIVxLl/ycmPCLsPG+cpIO8n/09K/HAcK5/LPYhkxZ oq8z7qo/cw9fpuSHQikyXY7xnWM4u84DnBmJGaOOR7KYFNWv8vfHGrbYpMikl5RswyaF FnB+0zQGyFpE2J1RuTAE/CqtzQa5937jjDUwRhsSMwnrZl5EKqjUI5XrfoE+YqriPfr7 jVHKnK5k0q2pRgZXwIZBCTZYPizAB0a7OzPn1fLDety23eDV2k95zPfdJhgKn/WCdV+4 h7Y/xkdQLhKCwxLttf1slKfwUEnES7YAA5d3ogJH1/OIqgYCW/0Y+hHrg3v1MlpVN12l Gnbg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=5aneK7Rl07kK1qGmCVmUb7811DnxlqneA9Z72R6PRJc=; b=Cgx5t9VwimINrGFT8ctoHqZms5pyaGg+mTseYxk+XCHfaSALYmsZ3R4spstY4vtt0q 2zBUWkPwxOY8qatPP0itlfOuWaG85DvPWiMYOWUvljctmpta/Hp0S6IZBjydvIyOwYQ6 BsZToDB2Lulf91JK+CSR+6O9EKF/PYz172qF4TB8yya1e47NyntYxrUXM83o6RVJxJwq sMl44PRYx8qfHukcdguls1k5BRNmHfsF/RR3z2Kmf84qih4XsUGiKRc1RZEBXJ4LLpzQ rix1x0kAL24vDQ1mGTHyHxHxnHgw/gDWDApAwmDLej3DPiKADOJotxi63IPc7lkbXQkP cA+w== X-Gm-Message-State: AOAM533hJISHeCrKuSqE438bfeY6SYNTcJfhtImF+sXJK5QB93hyQWjD 7zmhbhYsYMEZk2lkZPyZ+tM= X-Google-Smtp-Source: ABdhPJxAmdxPltsou8uUUjeWnJuCK2JK93YfESll7d9K7ZQG+0dZuU+DhMEF1dNWNnaVHcgqlzdCPg== X-Received: by 2002:a05:6512:c18:b0:44a:9992:28bc with SMTP id z24-20020a0565120c1800b0044a999228bcmr25269448lfu.641.1649763461666; Tue, 12 Apr 2022 04:37:41 -0700 (PDT) Received: from mobilestation ([95.79.134.149]) by smtp.gmail.com with ESMTPSA id bq8-20020a056512150800b00448ab58bd53sm3618431lfb.40.2022.04.12.04.37.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Apr 2022 04:37:41 -0700 (PDT) Date: Tue, 12 Apr 2022 14:37:39 +0300 From: Serge Semin To: Brad Larson Cc: Serge Semin , linux-arm-kernel@lists.infradead.org, arnd@arndb.de, linus.walleij@linaro.org, bgolaszewski@baylibre.com, broonie@kernel.org, adrian.hunter@intel.com, ulf.hansson@linaro.org, olof@lixom.net, dac2@pensando.io, linux-gpio@vger.kernel.org, linux-spi@vger.kernel.org, linux-mmc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 04/11] dt-bindings: spi: Add compatible for Pensando Elba SoC Message-ID: <20220412113739.xczqscungojcitrm@mobilestation> References: <20220406233648.21644-1-brad@pensando.io> <20220406233648.21644-5-brad@pensando.io> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220406233648.21644-5-brad@pensando.io> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220412_043745_181202_73586DDE X-CRM114-Status: GOOD ( 18.58 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org > [PATCH 04/11] dt-bindings: spi: Add compatible for Pensando Elba SoC I think you need to be more specific in the patch title to what bindings you are adding the new compatible string. Something like this "dt-bindings: spi: cdns: ..." The same concerns the patch "[PATCH 03/11] dt-bindings: mmc: Add Pensando Elba SoC binding". Otherwise it isn't clear to what schema you are adding the Elba SoC support to. -Sergey On Wed, Apr 06, 2022 at 04:36:41PM -0700, Brad Larson wrote: > Document the cadence qspi controller compatible for Pensando Elba SoC > boards. The Elba qspi fifo size is 1024. > > Signed-off-by: Brad Larson > --- > Documentation/devicetree/bindings/spi/cdns,qspi-nor.yaml | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/spi/cdns,qspi-nor.yaml b/Documentation/devicetree/bindings/spi/cdns,qspi-nor.yaml > index 0a537fa3a641..bc298e413842 100644 > --- a/Documentation/devicetree/bindings/spi/cdns,qspi-nor.yaml > +++ b/Documentation/devicetree/bindings/spi/cdns,qspi-nor.yaml > @@ -30,6 +30,7 @@ properties: > - intel,lgm-qspi > - xlnx,versal-ospi-1.0 > - intel,socfpga-qspi > + - pensando,elba-qspi > - const: cdns,qspi-nor > - const: cdns,qspi-nor > > @@ -48,7 +49,7 @@ properties: > description: > Size of the data FIFO in words. > $ref: "/schemas/types.yaml#/definitions/uint32" > - enum: [ 128, 256 ] > + enum: [ 128, 256, 1024 ] > default: 128 > > cdns,fifo-width: > -- > 2.17.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C88AEC433EF for ; Tue, 12 Apr 2022 12:28:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1352666AbiDLMa3 (ORCPT ); Tue, 12 Apr 2022 08:30:29 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41950 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1353258AbiDLM16 (ORCPT ); Tue, 12 Apr 2022 08:27:58 -0400 Received: from mail-lf1-x136.google.com (mail-lf1-x136.google.com [IPv6:2a00:1450:4864:20::136]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7E073182; Tue, 12 Apr 2022 04:37:43 -0700 (PDT) Received: by mail-lf1-x136.google.com with SMTP id o2so10035784lfu.13; Tue, 12 Apr 2022 04:37:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=5aneK7Rl07kK1qGmCVmUb7811DnxlqneA9Z72R6PRJc=; b=HxQcMx486YxA3qXMLBqpak4qkZIVxLl/ycmPCLsPG+cpIO8n/09K/HAcK5/LPYhkxZ oq8z7qo/cw9fpuSHQikyXY7xnWM4u84DnBmJGaOOR7KYFNWv8vfHGrbYpMikl5RswyaF FnB+0zQGyFpE2J1RuTAE/CqtzQa5937jjDUwRhsSMwnrZl5EKqjUI5XrfoE+YqriPfr7 jVHKnK5k0q2pRgZXwIZBCTZYPizAB0a7OzPn1fLDety23eDV2k95zPfdJhgKn/WCdV+4 h7Y/xkdQLhKCwxLttf1slKfwUEnES7YAA5d3ogJH1/OIqgYCW/0Y+hHrg3v1MlpVN12l Gnbg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=5aneK7Rl07kK1qGmCVmUb7811DnxlqneA9Z72R6PRJc=; b=3JQ/rbJVZRVfBXDjqXKDZJzNb/ayFNkulKuEXznxKbbFwgJhjr0PERQcxIy/PrB18L w5pRc6rqvsi2Bvg0lCBkDfRr0fZDsMdGm4W0uBg+VKsKdeCwLHAVRHA4BBUe3KgtZiKM 7U0TEyTjdWe+qhFQcO9PeNip+pnbBTyafeEoQbd7bFhrmaEy5HDCFIqGaH2C5TSrcRCu 0amn3vviPOTqnsqq8j70jC/ss+UkDP3lKRfdDeSiNp2T2fRSUecn/BODJ0PP0Mk+gVt1 +henfqIGdoMyQMvDURG06MSh4QEeq3NE35Ntsb70sTpYvMzqacF515HOHUlUWLq6gAgC 6w5A== X-Gm-Message-State: AOAM5303864SCDCXUX+IzWJxiiv2mAb3qtNRubX30msJ1It4xiROltT/ 1pgMLxToyNdhq5AmhyHEBtg= X-Google-Smtp-Source: ABdhPJxAmdxPltsou8uUUjeWnJuCK2JK93YfESll7d9K7ZQG+0dZuU+DhMEF1dNWNnaVHcgqlzdCPg== X-Received: by 2002:a05:6512:c18:b0:44a:9992:28bc with SMTP id z24-20020a0565120c1800b0044a999228bcmr25269448lfu.641.1649763461666; Tue, 12 Apr 2022 04:37:41 -0700 (PDT) Received: from mobilestation ([95.79.134.149]) by smtp.gmail.com with ESMTPSA id bq8-20020a056512150800b00448ab58bd53sm3618431lfb.40.2022.04.12.04.37.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Apr 2022 04:37:41 -0700 (PDT) Date: Tue, 12 Apr 2022 14:37:39 +0300 From: Serge Semin To: Brad Larson Cc: Serge Semin , linux-arm-kernel@lists.infradead.org, arnd@arndb.de, linus.walleij@linaro.org, bgolaszewski@baylibre.com, broonie@kernel.org, adrian.hunter@intel.com, ulf.hansson@linaro.org, olof@lixom.net, dac2@pensando.io, linux-gpio@vger.kernel.org, linux-spi@vger.kernel.org, linux-mmc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 04/11] dt-bindings: spi: Add compatible for Pensando Elba SoC Message-ID: <20220412113739.xczqscungojcitrm@mobilestation> References: <20220406233648.21644-1-brad@pensando.io> <20220406233648.21644-5-brad@pensando.io> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220406233648.21644-5-brad@pensando.io> Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org > [PATCH 04/11] dt-bindings: spi: Add compatible for Pensando Elba SoC I think you need to be more specific in the patch title to what bindings you are adding the new compatible string. Something like this "dt-bindings: spi: cdns: ..." The same concerns the patch "[PATCH 03/11] dt-bindings: mmc: Add Pensando Elba SoC binding". Otherwise it isn't clear to what schema you are adding the Elba SoC support to. -Sergey On Wed, Apr 06, 2022 at 04:36:41PM -0700, Brad Larson wrote: > Document the cadence qspi controller compatible for Pensando Elba SoC > boards. The Elba qspi fifo size is 1024. > > Signed-off-by: Brad Larson > --- > Documentation/devicetree/bindings/spi/cdns,qspi-nor.yaml | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/spi/cdns,qspi-nor.yaml b/Documentation/devicetree/bindings/spi/cdns,qspi-nor.yaml > index 0a537fa3a641..bc298e413842 100644 > --- a/Documentation/devicetree/bindings/spi/cdns,qspi-nor.yaml > +++ b/Documentation/devicetree/bindings/spi/cdns,qspi-nor.yaml > @@ -30,6 +30,7 @@ properties: > - intel,lgm-qspi > - xlnx,versal-ospi-1.0 > - intel,socfpga-qspi > + - pensando,elba-qspi > - const: cdns,qspi-nor > - const: cdns,qspi-nor > > @@ -48,7 +49,7 @@ properties: > description: > Size of the data FIFO in words. > $ref: "/schemas/types.yaml#/definitions/uint32" > - enum: [ 128, 256 ] > + enum: [ 128, 256, 1024 ] > default: 128 > > cdns,fifo-width: > -- > 2.17.1 >