From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id F34ADC43219 for ; Tue, 12 Apr 2022 13:23:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1356167AbiDLNZf (ORCPT ); Tue, 12 Apr 2022 09:25:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38326 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1356061AbiDLNY6 (ORCPT ); Tue, 12 Apr 2022 09:24:58 -0400 Received: from mail-qt1-x830.google.com (mail-qt1-x830.google.com [IPv6:2607:f8b0:4864:20::830]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BC16BFD18 for ; Tue, 12 Apr 2022 06:16:17 -0700 (PDT) Received: by mail-qt1-x830.google.com with SMTP id bb38so4029528qtb.3 for ; Tue, 12 Apr 2022 06:16:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :in-reply-to; bh=lLpl+eKB5ywCYV7ZOI1Z8hkNi2P2AeJ4vWSgRSsH/wU=; b=MepoTfP66HCP439ybBrN+i5PFlwBPqhvgxpdch/gZtrBvLV86oANMm9B86t4rvgqjT LwlrrQNxGgupH3/dPlWJD4PTmPb/cfhWVu/lTIAGMDwY8YTcXOAHcvE1dadPhv+G3aT8 Dm5tqCEWe36wc6dhKEttsEgbRAshI6JdnUQmM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:in-reply-to; bh=lLpl+eKB5ywCYV7ZOI1Z8hkNi2P2AeJ4vWSgRSsH/wU=; b=mefMVfq4X+qYFvvzp5j56M7IXl+t57BHiH6w/UZBUjPT6J0wxKrlK1IPbOfrN4385J oi5llenT3bMus0QCuybnV45entr03oWPOH2CTJKK6vILb9dneHfJmIS1ufCkjpBNCfGH kzAJ++eZ1wwuSxgyoOC96UghWrBT20XyE/MPzRwGuN5WzzuIbrWQIdbvZ+gVL7wD6EHk GD0THgI8SSqOZHVdo+oUIcZxKkpFyJTWeHlWtYtOgEjVL+G+G3a9TyhfjRZ3yBamGxjz 3zKBwRscqERoPigkaIdVsLwqXo+SlbIrkN4pzZgPKwLRQkx6fuV/XLk7cHWkSV51p4bj smAw== X-Gm-Message-State: AOAM531gPk8kc5rv+ievip48iMRQHrbUS9no3nW/0bxLQ/9D0iUnSmwf K7vy1dyFzDrh58UmiX71dY9QrLE35oMD9DPwizM= X-Google-Smtp-Source: ABdhPJxOH93Ycro9DTEzDmyWsRidTtXFRHyyaMYi+y6Soz4Wuy1dPLlTHWlSxzUfkud7IIEVjOziyA== X-Received: by 2002:ac8:46d6:0:b0:2eb:dc8c:eaa6 with SMTP id h22-20020ac846d6000000b002ebdc8ceaa6mr3226216qto.286.1649769376468; Tue, 12 Apr 2022 06:16:16 -0700 (PDT) Received: from noodle ([192.19.250.250]) by smtp.gmail.com with ESMTPSA id bm1-20020a05620a198100b0047bf910892bsm22661300qkb.65.2022.04.12.06.16.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Apr 2022 06:16:15 -0700 (PDT) Date: Tue, 12 Apr 2022 16:16:10 +0300 From: Boris Sukholitko To: Jiri Pirko Cc: netdev@vger.kernel.org, "David S . Miller" , Jakub Kicinski , Jamal Hadi Salim , Cong Wang , "Gustavo A . R . Silva" , Vladimir Oltean , Eric Dumazet , zhang kai , Yoshiki Komachi , Ilya Lifshits Subject: Re: [PATCH net-next v2 5/5] net/sched: flower: Consider the number of tags for vlan filters Message-ID: <20220412131610.GB2451@noodle> References: <20220412100236.27244-1-boris.sukholitko@broadcom.com> <20220412100236.27244-6-boris.sukholitko@broadcom.com> <20220412114049.GA2451@noodle> MIME-Version: 1.0 In-Reply-To: Content-Type: multipart/signed; protocol="application/pkcs7-signature"; micalg=sha-256; boundary="000000000000af5bab05dc74dd3a" Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org --000000000000af5bab05dc74dd3a Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, Apr 12, 2022 at 02:12:15PM +0200, Jiri Pirko wrote: > Tue, Apr 12, 2022 at 01:40:49PM CEST, boris.sukholitko@broadcom.com wrote: > >On Tue, Apr 12, 2022 at 01:09:35PM +0200, Jiri Pirko wrote: > >> Tue, Apr 12, 2022 at 12:02:36PM CEST, boris.sukholitko@broadcom.com wrote: > >> >Currently the existence of vlan filters is conditional on the vlan > >> >protocol being matched in the tc rule. I.e. the following rule: > >> > > >> >tc filter add dev eth1 ingress flower vlan_prio 5 > >> > > >> >is illegal because we lack protocol 802.1q in the rule. > >> > > >> >Having the num_of_vlans filter configured removes this restriction. The > >> >following rule becomes ok: > >> > > >> >tc filter add dev eth1 ingress flower num_of_vlans 1 vlan_prio 5 > >> > > >> >because we know that the packet is single tagged. > >> > > >> >We achieve the above by having is_vlan_key helper look at the number of > >> > >> Sorry to be a nitpicker, but who's "we"? When I read the patch > >> description, I need to understand clearly what the patch is doing, which > >> is not this case. You suppose to command the codebase what to do. > >> I fail to see that :/ > >> > >> > > > >What do you think of the following description? The description consists > >of two parts: the first provides motivation for the patch, the second is > >the way the motivation is implemented. I've judiciously edited out the > >"we"-word. :) > > > > > > > >Currently the existence of vlan filters is conditional on the vlan > >protocol being matched in the tc rule. I.e. the following rule: > > > >tc filter add dev eth1 ingress flower vlan_prio 5 > > > >is illegal because vlan protocol (e.g. 802.1q) does not appear in the rule. > > > >Having the num_of_vlans filter configured removes this restriction. The > >following rule becomes ok: > > > >tc filter add dev eth1 ingress flower num_of_vlans 1 vlan_prio 5 > > So this is what this patch allows? Yes. > You are talking about it as it is > already possible with the code before this patch being applied. > Sorry for the confusion. In the updated description I try to make the distinction much clearer. > > > > >because having num_of_vlans==1 implies that the packet is single tagged. > > > >To make the above possible, is_vlan_key helper is changed to look at the > >number of vlans in addition to the vlan ethertype. > > What "is changed"? You should tell the codebase what to do, what toadd, > remove or change. If you did that, it would be very clear to the reader > what the patch is supposed to do. > The "changed" refers to the code of is_vlan_key function which is changed by this patch. Please see the updated description. > > > > >Outer tag vlan filters (e.g. vlan_prio) require the number of vlan tags > >be greater than 0. Inner filters (e.g. cvlan_prio) require the number of > >vlan tags be greater than 1. > > Again, unclear what this describes, if the current code before the patch > or the state after this patch. > What about the following: Before this commit the existence of vlan filters was conditional on the vlan protocol being matched in the tc rule. For example, the following rule: tc filter add dev eth1 ingress flower vlan_prio 5 was illegal because vlan protocol (e.g. 802.1q) does not appear in the rule. This commit removes the above restriction. Having the num_of_vlans filter configured allows further matching on vlan attributes. The following rule is ok now: tc filter add dev eth1 ingress flower num_of_vlans 1 vlan_prio 5 because having num_of_vlans==1 implies that the packet is single tagged. To do this, this commit changes is_vlan_key helper to look at the number of vlans in addition to the vlan ethertype. Outer (e.g. vlan_prio) and inner (e.g. cvlan_prio) tag vlan filters require the number of vlan tags to be greater then 0 and 1 accordingly. As a result of this commit, the ethertype may be set to 0 when matching on the number of vlans. This commit changes fl_set_key_vlan to avoid setting key, mask vlan_tpid for the 0 ethertype. Is this going into the right direction? Thanks, Boris. --000000000000af5bab05dc74dd3a Content-Type: application/pkcs7-signature; name="smime.p7s" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="smime.p7s" Content-Description: S/MIME Cryptographic Signature MIIQeQYJKoZIhvcNAQcCoIIQajCCEGYCAQExDzANBglghkgBZQMEAgEFADALBgkqhkiG9w0BBwGg gg3QMIIFDTCCA/WgAwIBAgIQeEqpED+lv77edQixNJMdADANBgkqhkiG9w0BAQsFADBMMSAwHgYD VQQLExdHbG9iYWxTaWduIFJvb3QgQ0EgLSBSMzETMBEGA1UEChMKR2xvYmFsU2lnbjETMBEGA1UE AxMKR2xvYmFsU2lnbjAeFw0yMDA5MTYwMDAwMDBaFw0yODA5MTYwMDAwMDBaMFsxCzAJBgNVBAYT AkJFMRkwFwYDVQQKExBHbG9iYWxTaWduIG52LXNhMTEwLwYDVQQDEyhHbG9iYWxTaWduIEdDQyBS MyBQZXJzb25hbFNpZ24gMiBDQSAyMDIwMIIBIjANBgkqhkiG9w0BAQEFAAOCAQ8AMIIBCgKCAQEA vbCmXCcsbZ/a0fRIQMBxp4gJnnyeneFYpEtNydrZZ+GeKSMdHiDgXD1UnRSIudKo+moQ6YlCOu4t rVWO/EiXfYnK7zeop26ry1RpKtogB7/O115zultAz64ydQYLe+a1e/czkALg3sgTcOOcFZTXk38e aqsXsipoX1vsNurqPtnC27TWsA7pk4uKXscFjkeUE8JZu9BDKaswZygxBOPBQBwrA5+20Wxlk6k1 e6EKaaNaNZUy30q3ArEf30ZDpXyfCtiXnupjSK8WU2cK4qsEtj09JS4+mhi0CTCrCnXAzum3tgcH cHRg0prcSzzEUDQWoFxyuqwiwhHu3sPQNmFOMwIDAQABo4IB2jCCAdYwDgYDVR0PAQH/BAQDAgGG MGAGA1UdJQRZMFcGCCsGAQUFBwMCBggrBgEFBQcDBAYKKwYBBAGCNxQCAgYKKwYBBAGCNwoDBAYJ KwYBBAGCNxUGBgorBgEEAYI3CgMMBggrBgEFBQcDBwYIKwYBBQUHAxEwEgYDVR0TAQH/BAgwBgEB /wIBADAdBgNVHQ4EFgQUljPR5lgXWzR1ioFWZNW+SN6hj88wHwYDVR0jBBgwFoAUj/BLf6guRSSu TVD6Y5qL3uLdG7wwegYIKwYBBQUHAQEEbjBsMC0GCCsGAQUFBzABhiFodHRwOi8vb2NzcC5nbG9i YWxzaWduLmNvbS9yb290cjMwOwYIKwYBBQUHMAKGL2h0dHA6Ly9zZWN1cmUuZ2xvYmFsc2lnbi5j b20vY2FjZXJ0L3Jvb3QtcjMuY3J0MDYGA1UdHwQvMC0wK6ApoCeGJWh0dHA6Ly9jcmwuZ2xvYmFs c2lnbi5jb20vcm9vdC1yMy5jcmwwWgYDVR0gBFMwUTALBgkrBgEEAaAyASgwQgYKKwYBBAGgMgEo CjA0MDIGCCsGAQUFBwIBFiZodHRwczovL3d3dy5nbG9iYWxzaWduLmNvbS9yZXBvc2l0b3J5LzAN BgkqhkiG9w0BAQsFAAOCAQEAdAXk/XCnDeAOd9nNEUvWPxblOQ/5o/q6OIeTYvoEvUUi2qHUOtbf jBGdTptFsXXe4RgjVF9b6DuizgYfy+cILmvi5hfk3Iq8MAZsgtW+A/otQsJvK2wRatLE61RbzkX8 9/OXEZ1zT7t/q2RiJqzpvV8NChxIj+P7WTtepPm9AIj0Keue+gS2qvzAZAY34ZZeRHgA7g5O4TPJ /oTd+4rgiU++wLDlcZYd/slFkaT3xg4qWDepEMjT4T1qFOQIL+ijUArYS4owpPg9NISTKa1qqKWJ jFoyms0d0GwOniIIbBvhI2MJ7BSY9MYtWVT5jJO3tsVHwj4cp92CSFuGwunFMzCCA18wggJHoAMC AQICCwQAAAAAASFYUwiiMA0GCSqGSIb3DQEBCwUAMEwxIDAeBgNVBAsTF0dsb2JhbFNpZ24gUm9v dCBDQSAtIFIzMRMwEQYDVQQKEwpHbG9iYWxTaWduMRMwEQYDVQQDEwpHbG9iYWxTaWduMB4XDTA5 MDMxODEwMDAwMFoXDTI5MDMxODEwMDAwMFowTDEgMB4GA1UECxMXR2xvYmFsU2lnbiBSb290IENB IC0gUjMxEzARBgNVBAoTCkdsb2JhbFNpZ24xEzARBgNVBAMTCkdsb2JhbFNpZ24wggEiMA0GCSqG SIb3DQEBAQUAA4IBDwAwggEKAoIBAQDMJXaQeQZ4Ihb1wIO2hMoonv0FdhHFrYhy/EYCQ8eyip0E XyTLLkvhYIJG4VKrDIFHcGzdZNHr9SyjD4I9DCuul9e2FIYQebs7E4B3jAjhSdJqYi8fXvqWaN+J J5U4nwbXPsnLJlkNc96wyOkmDoMVxu9bi9IEYMpJpij2aTv2y8gokeWdimFXN6x0FNx04Druci8u nPvQu7/1PQDhBjPogiuuU6Y6FnOM3UEOIDrAtKeh6bJPkC4yYOlXy7kEkmho5TgmYHWyn3f/kRTv riBJ/K1AFUjRAjFhGV64l++td7dkmnq/X8ET75ti+w1s4FRpFqkD2m7pg5NxdsZphYIXAgMBAAGj QjBAMA4GA1UdDwEB/wQEAwIBBjAPBgNVHRMBAf8EBTADAQH/MB0GA1UdDgQWBBSP8Et/qC5FJK5N UPpjmove4t0bvDANBgkqhkiG9w0BAQsFAAOCAQEAS0DbwFCq/sgM7/eWVEVJu5YACUGssxOGhigH M8pr5nS5ugAtrqQK0/Xx8Q+Kv3NnSoPHRHt44K9ubG8DKY4zOUXDjuS5V2yq/BKW7FPGLeQkbLmU Y/vcU2hnVj6DuM81IcPJaP7O2sJTqsyQiunwXUaMld16WCgaLx3ezQA3QY/tRG3XUyiXfvNnBB4V 14qWtNPeTCekTBtzc3b0F5nCH3oO4y0IrQocLP88q1UOD5F+NuvDV0m+4S4tfGCLw0FREyOdzvcy a5QBqJnnLDMfOjsl0oZAzjsshnjJYS8Uuu7bVW/fhO4FCU29KNhyztNiUGUe65KXgzHZs7XKR1g/ XzCCBVgwggRAoAMCAQICDDSzinKpvcPTN4ZIJTANBgkqhkiG9w0BAQsFADBbMQswCQYDVQQGEwJC RTEZMBcGA1UEChMQR2xvYmFsU2lnbiBudi1zYTExMC8GA1UEAxMoR2xvYmFsU2lnbiBHQ0MgUjMg UGVyc29uYWxTaWduIDIgQ0EgMjAyMDAeFw0yMTAyMjIwNzMwMDRaFw0yMjA5MDUwNzM3NTVaMIGW MQswCQYDVQQGEwJJTjESMBAGA1UECBMJS2FybmF0YWthMRIwEAYDVQQHEwlCYW5nYWxvcmUxFjAU BgNVBAoTDUJyb2FkY29tIEluYy4xGTAXBgNVBAMTEEJvcmlzIFN1a2hvbGl0a28xLDAqBgkqhkiG 9w0BCQEWHWJvcmlzLnN1a2hvbGl0a29AYnJvYWRjb20uY29tMIIBIjANBgkqhkiG9w0BAQEFAAOC AQ8AMIIBCgKCAQEAy/C7bjpxs+95egWV8sWrK9KO0SQi6Nxu14tJBgP+MOK5tvokizPFHoiXTymZ 7ClfnmbcqT4PzWgI3thyfk64bgUo1nQkCTApn7ov3IRsWjmHExLSNoJ/siUHagO6BPAk4JSycrj5 9tC9sL4FnIAbAHmOSILCyGyyaBAcmiyH/3toYqXyjJkK+vbWQSTxk2NlqJLIN/ypLJ1pYffVZGUs 52g1hlQtHhgLIznB1Qx3Fop3nOUk8nNpQLON/aM8K5sl18964c7aXh7YZnalUQv3md4p2rAQQqIR rZ8HBc7YjlZynwOnZl1NrK4cP5aM9lMkbfRGIUitHTIhoDYp8IZ1dwIDAQABo4IB3jCCAdowDgYD VR0PAQH/BAQDAgWgMIGjBggrBgEFBQcBAQSBljCBkzBOBggrBgEFBQcwAoZCaHR0cDovL3NlY3Vy ZS5nbG9iYWxzaWduLmNvbS9jYWNlcnQvZ3NnY2NyM3BlcnNvbmFsc2lnbjJjYTIwMjAuY3J0MEEG CCsGAQUFBzABhjVodHRwOi8vb2NzcC5nbG9iYWxzaWduLmNvbS9nc2djY3IzcGVyc29uYWxzaWdu MmNhMjAyMDBNBgNVHSAERjBEMEIGCisGAQQBoDIBKAowNDAyBggrBgEFBQcCARYmaHR0cHM6Ly93 d3cuZ2xvYmFsc2lnbi5jb20vcmVwb3NpdG9yeS8wCQYDVR0TBAIwADBJBgNVHR8EQjBAMD6gPKA6 hjhodHRwOi8vY3JsLmdsb2JhbHNpZ24uY29tL2dzZ2NjcjNwZXJzb25hbHNpZ24yY2EyMDIwLmNy bDAoBgNVHREEITAfgR1ib3Jpcy5zdWtob2xpdGtvQGJyb2FkY29tLmNvbTATBgNVHSUEDDAKBggr BgEFBQcDBDAfBgNVHSMEGDAWgBSWM9HmWBdbNHWKgVZk1b5I3qGPzzAdBgNVHQ4EFgQUtBmGs9S4 t1FcFSfkrP2LKQQwBKMwDQYJKoZIhvcNAQELBQADggEBAJMAjVBkRmr1lvVvEjMaLfvMhwGpUfh6 CMZsKICyz/ZZmvTmIZNwy+7b9r6gjLCV4tP63tz4U72X9qJwfzldAlYLYWIq9e/DKDjwJRYlzN8H 979QJ0DHPSJ9EpvSKXob7Ci/FMkTfq1eOLjkPRF72mn8KPbHjeN3VVcn7oTe5IdIXaaZTryjM5Ud bR7s0ZZh6mOhJtqk3k1L1DbDTVB4tOZXZHRDghEGaQSnwU/qxCNlvQ52fImLFVwXKPnw6+9dUvFR ORaZ1pZbapCGbs/4QLplv8UaBmpFfK6MW/44zcsDbtCFfgIP3fEJBByIREhvRC5mtlRtdM+SSjgS ZiNfUggxggJtMIICaQIBATBrMFsxCzAJBgNVBAYTAkJFMRkwFwYDVQQKExBHbG9iYWxTaWduIG52 LXNhMTEwLwYDVQQDEyhHbG9iYWxTaWduIEdDQyBSMyBQZXJzb25hbFNpZ24gMiBDQSAyMDIwAgw0 s4pyqb3D0zeGSCUwDQYJYIZIAWUDBAIBBQCggdQwLwYJKoZIhvcNAQkEMSIEIHZF5jofrSssfny9 OScYW1Ond7vEcmBhnalWpWgFcj0uMBgGCSqGSIb3DQEJAzELBgkqhkiG9w0BBwEwHAYJKoZIhvcN AQkFMQ8XDTIyMDQxMjEzMTYxN1owaQYJKoZIhvcNAQkPMVwwWjALBglghkgBZQMEASowCwYJYIZI AWUDBAEWMAsGCWCGSAFlAwQBAjAKBggqhkiG9w0DBzALBgkqhkiG9w0BAQowCwYJKoZIhvcNAQEH MAsGCWCGSAFlAwQCATANBgkqhkiG9w0BAQEFAASCAQA97vZBDF2QSphVMDgWdqQzLKe+2Mo+H+VM 3cbKfBQgvQ8WoX4kN+RmKWNKEAb9JRHIAJei3qA+Z1MAwOdioilNsX5x9ZmCE+s5WuNTmjk6xmYK nDhquLjzbabHLpXjgEgATjAf+BnaPxVuWH1nUdFy5zZKRg0haiEZkg/Xe3ZZEk3gf2Ye1KQ7bArK NNG9qx16zQyqYbMMTXiEuoInRB6tdtXmlmvhYQNeNqm8ntRoxjZiaigHxvDlrXfzuFz4z8hca3xg 3+Zw5LTei5YlZt5fVGCBW8hh7QQ/lJA0nrWzqU7CN4VaEUsvFzOx2W25VygMZLTl/aMcIt6jEI07 x3pI --000000000000af5bab05dc74dd3a--