From: kernel test robot <lkp@intel.com>
To: "Rafael J. Wysocki" <rjw@rjwysocki.net>,
Linux ACPI <linux-acpi@vger.kernel.org>
Cc: llvm@lists.linux.dev, kbuild-all@lists.01.org,
LKML <linux-kernel@vger.kernel.org>,
Bob Moore <robert.moore@intel.com>
Subject: Re: [PATCH 15/20] ACPICA: executer/exsystem: Warn about sleeps greater than 10 ms
Date: Tue, 12 Apr 2022 13:22:00 +0800 [thread overview]
Message-ID: <202204121322.P9yX0gKP-lkp@intel.com> (raw)
In-Reply-To: <4200238.ejJDZkT8p0@kreacher>
Hi "Rafael,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on rafael-pm/linux-next]
[also build test ERROR on linus/master linux/master v5.18-rc2 next-20220411]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/intel-lab-lkp/linux/commits/Rafael-J-Wysocki/ACPICA-ACPICA-20220331/20220412-030922
base: https://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git linux-next
config: i386-randconfig-a006-20220411 (https://download.01.org/0day-ci/archive/20220412/202204121322.P9yX0gKP-lkp@intel.com/config)
compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project fe2478d44e4f7f191c43fef629ac7a23d0251e72)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/intel-lab-lkp/linux/commit/22c298d3a077e7ea8503e9acf7ac83e6b1e10148
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review Rafael-J-Wysocki/ACPICA-ACPICA-20220331/20220412-030922
git checkout 22c298d3a077e7ea8503e9acf7ac83e6b1e10148
# save the config file to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=i386 SHELL=/bin/bash
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Note: the linux-review/Rafael-J-Wysocki/ACPICA-ACPICA-20220331/20220412-030922 HEAD 32181ae3d3173aeee41f709612dfa4d52951b39d builds fine.
It only hurts bisectability.
All errors (new ones prefixed by >>):
drivers/acpi/acpica/exsystem.c:140:7: error: use of undeclared identifier 'how_long_US'; did you mean 'how_long_us'?
if (how_long_US > 100) {
^~~~~~~~~~~
how_long_us
drivers/acpi/acpica/exsystem.c:123:41: note: 'how_long_us' declared here
acpi_status acpi_ex_system_do_stall(u32 how_long_us)
^
>> drivers/acpi/acpica/exsystem.c:179:10: error: use of undeclared identifier 'how_long_us'; did you mean 'how_long_ms'?
how_long_us));
^~~~~~~~~~~
how_long_ms
include/acpi/acoutput.h:203:54: note: expanded from macro 'ACPI_WARNING'
#define ACPI_WARNING(plist) acpi_warning plist
^
drivers/acpi/acpica/exsystem.c:164:41: note: 'how_long_ms' declared here
acpi_status acpi_ex_system_do_sleep(u64 how_long_ms)
^
2 errors generated.
vim +179 drivers/acpi/acpica/exsystem.c
150
151 /*******************************************************************************
152 *
153 * FUNCTION: acpi_ex_system_do_sleep
154 *
155 * PARAMETERS: how_long_ms - The amount of time to sleep,
156 * in milliseconds
157 *
158 * RETURN: None
159 *
160 * DESCRIPTION: Sleep the running thread for specified amount of time.
161 *
162 ******************************************************************************/
163
164 acpi_status acpi_ex_system_do_sleep(u64 how_long_ms)
165 {
166 ACPI_FUNCTION_ENTRY();
167
168 /* Since this thread will sleep, we must release the interpreter */
169
170 acpi_ex_exit_interpreter();
171
172 /*
173 * Warn users about excessive sleep times, so ASL code can be improved to
174 * use polling or similar techniques.
175 */
176 if (how_long_ms > 10) {
177 ACPI_WARNING((AE_INFO,
178 "Firmware issue: Excessive sleep time (%llu ms > 10 ms) in ACPI Control Method",
> 179 how_long_us));
180 }
181
182 /*
183 * For compatibility with other ACPI implementations and to prevent
184 * accidental deep sleeps, limit the sleep time to something reasonable.
185 */
186 if (how_long_ms > ACPI_MAX_SLEEP) {
187 how_long_ms = ACPI_MAX_SLEEP;
188 }
189
190 acpi_os_sleep(how_long_ms);
191
192 /* And now we must get the interpreter again */
193
194 acpi_ex_enter_interpreter();
195 return (AE_OK);
196 }
197
--
0-DAY CI Kernel Test Service
https://01.org/lkp
next prev parent reply other threads:[~2022-04-12 5:22 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-11 18:46 [PATCH 00/20] ACPICA: ACPICA 20220331 Rafael J. Wysocki
2022-04-11 18:47 ` [PATCH 01/20] ACPICA: Add support for the Windows 11 _OSI string Rafael J. Wysocki
2022-04-11 18:47 ` [PATCH 02/20] ACPICA: Add the subtable CFMWS to the CEDT table Rafael J. Wysocki
2022-04-11 18:48 ` [PATCH 03/20] ACPICA: iASL: NHLT: Treat Terminator as specific_config Rafael J. Wysocki
2022-04-11 18:49 ` [PATCH 04/20] ACPICA: iASL: NHLT: Fix parsing undocumented bytes at the end of Endpoint Descriptor Rafael J. Wysocki
2022-04-11 18:50 ` [PATCH 05/20] ACPICA: iASL: NHLT: Rename linux specific strucures to device_info Rafael J. Wysocki
2022-04-11 18:51 ` [PATCH 06/20] ACPICA: Add new ACPI 6.4 semantics to the Load() operator Rafael J. Wysocki
2022-04-11 18:52 ` [PATCH 07/20] ACPICA: Add new ACPI 6.4 semantics for LoadTable() operator Rafael J. Wysocki
2022-04-11 18:53 ` [PATCH 08/20] ACPICA: Clean up double word in comment Rafael J. Wysocki
2022-04-11 18:54 ` [PATCH 09/20] ACPICA: Update copyright notices to the year 2022 Rafael J. Wysocki
2022-04-11 18:55 ` [PATCH 10/20] ACPICA: Removed some tabs and // comments Rafael J. Wysocki
2022-04-11 18:56 ` [PATCH 11/20] ACPICA: Headers: Replace zero-length array with flexible-array member Rafael J. Wysocki
2022-04-11 18:57 ` [PATCH 12/20] ACPICA: executer/exsystem: Add units to time variable names Rafael J. Wysocki
2022-04-11 18:58 ` [PATCH 13/20] ACPICA: Add support for ARM Performance Monitoring Unit Table Rafael J. Wysocki
2022-04-11 18:59 ` [PATCH 14/20] ACPICA: executer/exsystem: Inform users about ACPI spec violation Rafael J. Wysocki
2022-04-12 2:53 ` kernel test robot
2022-04-12 12:47 ` Rafael J. Wysocki
2022-04-12 12:47 ` Rafael J. Wysocki
2022-04-11 18:59 ` [PATCH 15/20] ACPICA: executer/exsystem: Warn about sleeps greater than 10 ms Rafael J. Wysocki
2022-04-12 5:22 ` kernel test robot [this message]
2022-05-21 16:11 ` Rafael J. Wysocki
2022-05-21 23:28 ` Paul Menzel
2022-06-14 13:25 ` Rafael J. Wysocki
2022-04-11 19:00 ` [PATCH 16/20] ACPICA: iASL/MADT: Add OEM-defined subtable Rafael J. Wysocki
2022-04-11 19:01 ` [PATCH 17/20] ACPICA: executer/exsystem: Fix some typo mistakes Rafael J. Wysocki
2022-04-11 19:02 ` [PATCH 18/20] ACPICA: IORT: Updates for revision E.d Rafael J. Wysocki
2022-04-11 19:03 ` [PATCH 19/20] ACPICA: exsystem.c: Use ACPI_FORMAT_UINT64 for 64-bit output Rafael J. Wysocki
2022-04-11 19:04 ` [PATCH 20/20] ACPICA: Update version to 20220331 Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202204121322.P9yX0gKP-lkp@intel.com \
--to=lkp@intel.com \
--cc=kbuild-all@lists.01.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=rjw@rjwysocki.net \
--cc=robert.moore@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.