From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D7B36C433EF for ; Tue, 12 Apr 2022 17:53:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1358558AbiDLRzS (ORCPT ); Tue, 12 Apr 2022 13:55:18 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56056 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1350027AbiDLRzS (ORCPT ); Tue, 12 Apr 2022 13:55:18 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D606C4C782; Tue, 12 Apr 2022 10:52:59 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 908CFB81CA2; Tue, 12 Apr 2022 17:52:58 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4E6A5C385A5; Tue, 12 Apr 2022 17:52:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1649785977; bh=FumHdIwjFx7Vjc1i+cxZ5P/0VK42wXm0RyZNOdWpUaM=; h=Date:From:To:Subject:References:In-Reply-To:From; b=XjF4C/e+C2wW8Ri0VJPglb+rYRaAOZubWCVFmuxpXH2dD90Wf+0b3QhogWZrcJD3D 1Mwhg9gBWDncDNnlbxm8h6PmCr8SboUl3TdPIOqnxHp8l9+pq8FLQgLuxK1BjJuEai YBymiHye15sVMBYtDdbuSUZx2NKbH/ZftNsBQn9ojwbwK1b32WfgDRIVdDVqCQyta5 m/H0Z7b5KR0aCAB/nroa00Bd89Wc3wCFnXsYglndUlJJCVftiA8xJsduYzl2zXAP4x 7hrt10yr5964c8DL/pFhwTFp168QhvLGDoxnP2bhhIUbfvL0m3f9Yvki+fce0NnbIT YdrE+q3IoUw1A== Date: Tue, 12 Apr 2022 10:52:56 -0700 From: "Darrick J. Wong" To: linux-xfs@vger.kernel.org, fstests@vger.kernel.org Subject: Re: [PATCH 3/4] generic: test that linking into a directory fails with EDQUOT Message-ID: <20220412175256.GH16799@magnolia> References: <164971767143.169983.12905331894414458027.stgit@magnolia> <164971768834.169983.11537125892654404197.stgit@magnolia> <20220412171723.owphga4kmx3im7zv@zlang-mailbox> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220412171723.owphga4kmx3im7zv@zlang-mailbox> Precedence: bulk List-ID: X-Mailing-List: fstests@vger.kernel.org On Wed, Apr 13, 2022 at 01:17:23AM +0800, Zorro Lang wrote: > On Mon, Apr 11, 2022 at 03:54:48PM -0700, Darrick J. Wong wrote: > > From: Darrick J. Wong > > > > Add a regression test to make sure that unprivileged userspace linking > > into a directory fails with EDQUOT when the directory quota limits have > > been exceeded. > > > > Signed-off-by: Darrick J. Wong > > --- > > tests/generic/832 | 67 +++++++++++++++++++++++++++++++++++++++++++++++++ > > tests/generic/832.out | 3 ++ > > 2 files changed, 70 insertions(+) > > create mode 100755 tests/generic/832 > > create mode 100644 tests/generic/832.out > > > > > > diff --git a/tests/generic/832 b/tests/generic/832 > > new file mode 100755 > > index 00000000..1190b795 > > --- /dev/null > > +++ b/tests/generic/832 > > @@ -0,0 +1,67 @@ > > +#! /bin/bash > > +# SPDX-License-Identifier: GPL-2.0 > > +# Copyright (c) 2022 Oracle. All Rights Reserved. > > +# > > +# FS QA Test No. 832 > > +# > > +# Ensure that unprivileged userspace hits EDQUOT while linking files into a > > +# directory when the directory's quota limits have been exceeded. > > +# > > +# Regression test for commit: > > +# > > +# 871b9316e7a7 ("xfs: reserve quota for dir expansion when linking/unlinking files") > > +# > > +. ./common/preamble > > +_begin_fstest auto quick quota > > + > > +# Import common functions. > > +. ./common/filter > > +. ./common/quota > > + > > +# real QA test starts here > > + > > +# Modify as appropriate. > > +_supported_fs generic > > +_require_quota > > +_require_user > > +_require_scratch > > + > > +_scratch_mkfs > "$seqres.full" 2>&1 > > +_qmount_option usrquota > > +_qmount > > + > > +blocksize=$(_get_block_size $SCRATCH_MNT) > > +scratchdir=$SCRATCH_MNT/dir > > +scratchfile=$SCRATCH_MNT/file > > +mkdir $scratchdir > > +touch $scratchfile > > + > > +# Create a 2-block directory for our 1-block quota limit > > +total_size=$((blocksize * 2)) > > +dirents=$((total_size / 255)) > > + > > +for ((i = 0; i < dirents; i++)); do > > + name=$(printf "x%0254d" $i) > > + ln $scratchfile $scratchdir/$name > > +done > > + > > +# Set a low quota hardlimit for an unprivileged uid and chown the files to it > > +echo "set up quota" >> $seqres.full > > +setquota -u $qa_user 0 "$((blocksize / 1024))" 0 0 $SCRATCH_MNT > > +chown $qa_user $scratchdir $scratchfile > > +repquota -upn $SCRATCH_MNT >> $seqres.full > > + > > +# Fail at appending the directory as qa_user to ensure quota enforcement works > > +echo "fail quota" >> $seqres.full > > +for ((i = 0; i < dirents; i++)); do > > + name=$(printf "y%0254d" $i) > > + su - "$qa_user" -c "ln $scratchfile $scratchdir/$name" 2>&1 | \ > > All looks good to me. Only one question about this "su -". Is the "-" necessary? > I checked all cases in fstests, no one use "--login" when try to su to $qa_user. > I'm not sure if "login $qa_user" will affect the testing, I just know it affect > environment variables. It's not strictly necessary since it's unlikely that qa_user="-luser", but it seems like a Good Idea to prevent su cli option injection attacks. --D > Thanks, > Zorro > > > + _filter_scratch | sed -e 's/y[0-9]*/yXXX/g' > > + test "${PIPESTATUS[0]}" -ne 0 && break > > +done > > +repquota -upn $SCRATCH_MNT >> $seqres.full > > + > > +# success, all done > > +echo Silence is golden > > +status=0 > > +exit > > diff --git a/tests/generic/832.out b/tests/generic/832.out > > new file mode 100644 > > index 00000000..593afe8b > > --- /dev/null > > +++ b/tests/generic/832.out > > @@ -0,0 +1,3 @@ > > +QA output created by 832 > > +ln: failed to create hard link 'SCRATCH_MNT/dir/yXXX': Disk quota exceeded > > +Silence is golden > > >