All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] drm/tidss: Soft Reset DISPC on startup
@ 2022-03-14 11:37 ` Devarsh Thakkar
  0 siblings, 0 replies; 18+ messages in thread
From: Devarsh Thakkar @ 2022-03-14 11:37 UTC (permalink / raw)
  To: linux-kernel, jyri.sarha, tomba, airlied, daniel, dri-devel
  Cc: nm, a-bhatia1, r-ravikumar, nikhil.nd, linux-arm-kernel,
	devarsht, vigneshr, tomi.valkeinen, laurent.pinchart

Soft reset the display subsystem controller on startup and wait for
the reset to complete. This helps the scenario where display was
already in use by some other core before the linux was booted.

Signed-off-by: Devarsh Thakkar <devarsht@ti.com>
---
 drivers/gpu/drm/tidss/tidss_dispc.c | 18 ++++++++++++++++++
 1 file changed, 18 insertions(+)

diff --git a/drivers/gpu/drm/tidss/tidss_dispc.c b/drivers/gpu/drm/tidss/tidss_dispc.c
index 60b92df615aa..dae47853b728 100644
--- a/drivers/gpu/drm/tidss/tidss_dispc.c
+++ b/drivers/gpu/drm/tidss/tidss_dispc.c
@@ -2650,6 +2650,20 @@ static void dispc_init_errata(struct dispc_device *dispc)
 	}
 }
 
+static void dispc_softreset(struct dispc_device *dispc)
+{
+	u32 val;
+	int ret = 0;
+
+	/* Soft reset */
+	REG_FLD_MOD(dispc, DSS_SYSCONFIG, 1, 1, 1);
+	/* Wait for reset to complete */
+	ret = readl_poll_timeout(dispc->base_common + DSS_SYSSTATUS,
+				 val, val & 1, 100, 5000);
+	if (ret)
+		dev_warn(dispc->dev, "failed to reset dispc\n");
+}
+
 int dispc_init(struct tidss_device *tidss)
 {
 	struct device *dev = tidss->dev;
@@ -2709,6 +2723,10 @@ int dispc_init(struct tidss_device *tidss)
 			return r;
 	}
 
+	/* K2G display controller does not support soft reset */
+	if (feat->subrev != DISPC_K2G)
+		dispc_softreset(dispc);
+
 	for (i = 0; i < dispc->feat->num_vps; i++) {
 		u32 gamma_size = dispc->feat->vp_feat.color.gamma_size;
 		u32 *gamma_table;
-- 
2.17.1


^ permalink raw reply related	[flat|nested] 18+ messages in thread

end of thread, other threads:[~2022-04-19 13:32 UTC | newest]

Thread overview: 18+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-03-14 11:37 [PATCH] drm/tidss: Soft Reset DISPC on startup Devarsh Thakkar
2022-03-14 11:37 ` Devarsh Thakkar
2022-03-14 11:37 ` Devarsh Thakkar
2022-04-12  9:10 ` Devarsh Thakkar
2022-04-12  9:10   ` Devarsh Thakkar
2022-04-12  9:10   ` Devarsh Thakkar
2022-04-12 14:24 ` Tomi Valkeinen
2022-04-12 14:24   ` Tomi Valkeinen
2022-04-12 14:24   ` Tomi Valkeinen
2022-04-12 21:20   ` Nishanth Menon
2022-04-12 21:20     ` Nishanth Menon
2022-04-12 21:20     ` Nishanth Menon
2022-04-13  5:32     ` Tony Lindgren
2022-04-13  5:32       ` Tony Lindgren
2022-04-13  5:32       ` Tony Lindgren
2022-04-19 12:19 ` Tomi Valkeinen
2022-04-19 12:19   ` Tomi Valkeinen
2022-04-19 12:19   ` Tomi Valkeinen

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.