From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BE6B0C433EF for ; Wed, 13 Apr 2022 04:17:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232266AbiDMEUP (ORCPT ); Wed, 13 Apr 2022 00:20:15 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60114 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229633AbiDMEUN (ORCPT ); Wed, 13 Apr 2022 00:20:13 -0400 Received: from NAM02-BN1-obe.outbound.protection.outlook.com (mail-bn1nam07on2081.outbound.protection.outlook.com [40.107.212.81]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B32D827CFA for ; Tue, 12 Apr 2022 21:17:53 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=lfawpoyPrJ1Eb00j2Pm9pvyHFN2oQV4/1/Dwk3tex3E4KGVy7XyEPWGEH2VHgcsH0Bb1zt2PKRRoNxltfV3AraOYwyESP6eUljQgk2tNDMd7IX23dwvz5CIo+W6RYDANkCMVPvVSbCZ2Rr2vkiaFylmzoBsTw4/+NkTXXujqhBSK4uLrSjSdbe3GWbdhrzFDkRYTqx+2irMc3JSUXmQt8NRuvBpbDbThQ2y3GtXQYRgBU41eUOOTeXToCTJOWmtuKVdNX4ttj3B2y0acyrqwMOYYLoyFQyj1dilFd3Frdh42/UcAZk8pg6B+dgEiKTXDBi1J61ClbiU0DMAT66Eb6g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Dixg6jFAlPeT+UGDhnY516ejVCvmVQWOWNK9DlYnwdM=; b=avvbg2b0uzkZ00OMdkCJ0DfgzZKORtVDUgA/bNmnn3/OPU7J9XC+Il/Oy1sCB9AocaVkw8oFzTnzUMwE8teZFg8h+92+NiyPADrIYlYsEHuoEWpafWVaJLikh8lShcn9iyGwOP9ZypFAwz+eptA0vf/BtiF8rBmgrYY7Zg4X/V5wnojRucWYx2ufxfDWBU7RYigh+JmbbxsapWwRaB9/jqYFTJPX6NSAhS6TWyXFlZoeOqASyHuyhzwPTagIqFazSAgZ+ABaZpbLw/qatWcIDmhlmZH9ZlCQdpmHSFKIOLsy5PfglX/BPLp1xFFh72GhnuqQ/uNPShBPjSC26U3gBw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 12.22.5.234) smtp.rcpttodomain=wanadoo.fr smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Dixg6jFAlPeT+UGDhnY516ejVCvmVQWOWNK9DlYnwdM=; b=ALoILaBdo34QMf1REYocrqxDEqkqIITz9Ao4wZ6l9UHst1kqjDt2GNLqK3U67brIpmzIdbDGs0b0cyu8kl0kukkzcOoeSfCYVPh3L+JFcEPCtCNvXw+1aADC5s5yR8cwQDLgFW/nVILX7LBQLq2E1TpE32os0Win5rHh2AD01JLHlzSh5VMh752lD64ev2ywhEZTqkk7iEERjoKa/+Z99Gc1ofxP16oF6FJ8kI7K/AmucnGAGF1JADF80FWQk+2L4kYEFSVSXDMnUpkmFWbPUVYDsJgh5cYomyOaEGjTycGBULy1Q93YD1IAntR7lX3168XSkzUiYJkPXNvuhPxFRA== Received: from DS7P222CA0028.NAMP222.PROD.OUTLOOK.COM (2603:10b6:8:2e::21) by MN2PR12MB3149.namprd12.prod.outlook.com (2603:10b6:208:d2::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5144.29; Wed, 13 Apr 2022 04:17:51 +0000 Received: from DM6NAM11FT044.eop-nam11.prod.protection.outlook.com (2603:10b6:8:2e:cafe::2c) by DS7P222CA0028.outlook.office365.com (2603:10b6:8:2e::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5164.20 via Frontend Transport; Wed, 13 Apr 2022 04:17:51 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 12.22.5.234) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 12.22.5.234 as permitted sender) receiver=protection.outlook.com; client-ip=12.22.5.234; helo=mail.nvidia.com; Received: from mail.nvidia.com (12.22.5.234) by DM6NAM11FT044.mail.protection.outlook.com (10.13.173.185) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.5164.19 via Frontend Transport; Wed, 13 Apr 2022 04:17:51 +0000 Received: from rnnvmail205.nvidia.com (10.129.68.10) by DRHQMAIL101.nvidia.com (10.27.9.10) with Microsoft SMTP Server (TLS) id 15.0.1497.32; Wed, 13 Apr 2022 04:17:51 +0000 Received: from rnnvmail202.nvidia.com (10.129.68.7) by rnnvmail205.nvidia.com (10.129.68.10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.22; Tue, 12 Apr 2022 21:17:50 -0700 Received: from Asurada-Nvidia.nvidia.com (10.127.8.11) by mail.nvidia.com (10.129.68.7) with Microsoft SMTP Server id 15.2.986.22 via Frontend Transport; Tue, 12 Apr 2022 21:17:49 -0700 From: Nicolin Chen To: , , CC: , , , , , , , , Subject: [PATCH] iommu/arm-smmu-v3: Align size in __arm_smmu_tlb_inv_range Date: Tue, 12 Apr 2022 21:17:45 -0700 Message-ID: <20220413041745.35174-1-nicolinc@nvidia.com> X-Mailer: git-send-email 2.17.1 MIME-Version: 1.0 Content-Type: text/plain X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 5a23d60f-b60f-4172-d852-08da1d049379 X-MS-TrafficTypeDiagnostic: MN2PR12MB3149:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: WpPWD7KbqdSdvS+DyJn1aA8mNkO4TaCz19zotjPN2Lkgu8XH4KaT0nuRWMZu3RKq+W/i/BUfLFgTULGVbCmKoGERK4I5BVyDo/HSLYNBXeOzufIorzG0nZY1qTcQKU87IUyV1X2m8XzS946RyEMQ9RBPuLYsBJ/4cApm6p32tsD3QTFkAMenIXixICWNP3Y7h3vWtqqD+6VKCRBJ3U5/0CE4bi3rUAkzB+iycLfyTMrua/ASPccR5fT3pJBVwJsOVECuoEGOwpDucdr6N8V5qKRqchyiK1Av7sln1zMIpYt5Sxk71d3l+o2givwJ3Sw238JhNxOFIVLXJPALQMKX25684KXhBS2bTfnbm9X0wc/7PDcrhhGt3viE67rb28N4dTetpe7ExWTq7nZvcdyOPRL58nXLjDo0uDYgNT2obTufAJAxf1x7T6a/c7tCijUkLO1ytzhOki9Kf43un1JuAGZW458t6LUcuR0IxQKElbh26RfNiUlafBPIsGvorBF3o1mVpfm1qNExlHr/0PCIUaFvviR7hFYYIwtXUN1P3uEXneEyAhHeZudSGz6FTyBGn07K+l8YBIMrsLgCfvarCl61aftebERnn6UdqoWJIc/0z3a8g2ZtOyEeAydbtSzdi8pGPClGGnDAVeclu9uu8fqZfVWq+ku+OEc7prB0UKx6iWJp193k74iDT9UOjyJZ41bJlYYBLWppALfvQs44YA== X-Forefront-Antispam-Report: CIP:12.22.5.234;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:mail.nvidia.com;PTR:InfoNoRecords;CAT:NONE;SFS:(13230001)(4636009)(36840700001)(46966006)(40470700004)(4744005)(508600001)(6666004)(36860700001)(5660300002)(316002)(336012)(83380400001)(47076005)(356005)(36756003)(40460700003)(70586007)(70206006)(86362001)(82310400005)(4326008)(81166007)(8676002)(426003)(8936002)(2906002)(7416002)(54906003)(110136005)(26005)(186003)(7696005)(1076003)(2616005)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Apr 2022 04:17:51.6407 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 5a23d60f-b60f-4172-d852-08da1d049379 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[12.22.5.234];Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: DM6NAM11FT044.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR12MB3149 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org To calculate num_pages, the size should be aligned with "page size", determined by the tg value. Otherwise, its following "while (iova < end)" might become an infinite loop if unaligned size is slightly greater than 1 << tg. Signed-off-by: Nicolin Chen --- drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c b/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c index 627a3ed5ee8f..8249dad5ae44 100644 --- a/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c +++ b/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c @@ -1879,7 +1879,7 @@ static void __arm_smmu_tlb_inv_range(struct arm_smmu_cmdq_ent *cmd, /* Determine what level the granule is at */ cmd->tlbi.ttl = 4 - ((ilog2(granule) - 3) / (tg - 3)); - num_pages = size >> tg; + num_pages = ALIGN(size, 1 << tg) >> tg; } cmds.num = 0; -- 2.17.1 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3C4A3C433F5 for ; Wed, 13 Apr 2022 04:18:01 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id ADB5A60F29; Wed, 13 Apr 2022 04:18:00 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id jJraMVQ36K3H; Wed, 13 Apr 2022 04:17:59 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by smtp3.osuosl.org (Postfix) with ESMTPS id 492F1605B7; Wed, 13 Apr 2022 04:17:59 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 1533EC0033; Wed, 13 Apr 2022 04:17:59 +0000 (UTC) Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) by lists.linuxfoundation.org (Postfix) with ESMTP id 0F037C002C for ; Wed, 13 Apr 2022 04:17:57 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id EA907410A2 for ; Wed, 13 Apr 2022 04:17:56 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Authentication-Results: smtp4.osuosl.org (amavisd-new); dkim=pass (2048-bit key) header.d=nvidia.com Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 9mkmMhxwkAbT for ; Wed, 13 Apr 2022 04:17:55 +0000 (UTC) X-Greylist: whitelisted by SQLgrey-1.8.0 Received: from NAM02-BN1-obe.outbound.protection.outlook.com (mail-bn1nam07on2060e.outbound.protection.outlook.com [IPv6:2a01:111:f400:7eb2::60e]) by smtp4.osuosl.org (Postfix) with ESMTPS id 5C27F409FB for ; Wed, 13 Apr 2022 04:17:55 +0000 (UTC) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=lfawpoyPrJ1Eb00j2Pm9pvyHFN2oQV4/1/Dwk3tex3E4KGVy7XyEPWGEH2VHgcsH0Bb1zt2PKRRoNxltfV3AraOYwyESP6eUljQgk2tNDMd7IX23dwvz5CIo+W6RYDANkCMVPvVSbCZ2Rr2vkiaFylmzoBsTw4/+NkTXXujqhBSK4uLrSjSdbe3GWbdhrzFDkRYTqx+2irMc3JSUXmQt8NRuvBpbDbThQ2y3GtXQYRgBU41eUOOTeXToCTJOWmtuKVdNX4ttj3B2y0acyrqwMOYYLoyFQyj1dilFd3Frdh42/UcAZk8pg6B+dgEiKTXDBi1J61ClbiU0DMAT66Eb6g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Dixg6jFAlPeT+UGDhnY516ejVCvmVQWOWNK9DlYnwdM=; b=avvbg2b0uzkZ00OMdkCJ0DfgzZKORtVDUgA/bNmnn3/OPU7J9XC+Il/Oy1sCB9AocaVkw8oFzTnzUMwE8teZFg8h+92+NiyPADrIYlYsEHuoEWpafWVaJLikh8lShcn9iyGwOP9ZypFAwz+eptA0vf/BtiF8rBmgrYY7Zg4X/V5wnojRucWYx2ufxfDWBU7RYigh+JmbbxsapWwRaB9/jqYFTJPX6NSAhS6TWyXFlZoeOqASyHuyhzwPTagIqFazSAgZ+ABaZpbLw/qatWcIDmhlmZH9ZlCQdpmHSFKIOLsy5PfglX/BPLp1xFFh72GhnuqQ/uNPShBPjSC26U3gBw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 12.22.5.234) smtp.rcpttodomain=wanadoo.fr smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Dixg6jFAlPeT+UGDhnY516ejVCvmVQWOWNK9DlYnwdM=; b=ALoILaBdo34QMf1REYocrqxDEqkqIITz9Ao4wZ6l9UHst1kqjDt2GNLqK3U67brIpmzIdbDGs0b0cyu8kl0kukkzcOoeSfCYVPh3L+JFcEPCtCNvXw+1aADC5s5yR8cwQDLgFW/nVILX7LBQLq2E1TpE32os0Win5rHh2AD01JLHlzSh5VMh752lD64ev2ywhEZTqkk7iEERjoKa/+Z99Gc1ofxP16oF6FJ8kI7K/AmucnGAGF1JADF80FWQk+2L4kYEFSVSXDMnUpkmFWbPUVYDsJgh5cYomyOaEGjTycGBULy1Q93YD1IAntR7lX3168XSkzUiYJkPXNvuhPxFRA== Received: from DS7P222CA0028.NAMP222.PROD.OUTLOOK.COM (2603:10b6:8:2e::21) by MN2PR12MB3149.namprd12.prod.outlook.com (2603:10b6:208:d2::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5144.29; Wed, 13 Apr 2022 04:17:51 +0000 Received: from DM6NAM11FT044.eop-nam11.prod.protection.outlook.com (2603:10b6:8:2e:cafe::2c) by DS7P222CA0028.outlook.office365.com (2603:10b6:8:2e::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5164.20 via Frontend Transport; Wed, 13 Apr 2022 04:17:51 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 12.22.5.234) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 12.22.5.234 as permitted sender) receiver=protection.outlook.com; client-ip=12.22.5.234; helo=mail.nvidia.com; Received: from mail.nvidia.com (12.22.5.234) by DM6NAM11FT044.mail.protection.outlook.com (10.13.173.185) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.5164.19 via Frontend Transport; Wed, 13 Apr 2022 04:17:51 +0000 Received: from rnnvmail205.nvidia.com (10.129.68.10) by DRHQMAIL101.nvidia.com (10.27.9.10) with Microsoft SMTP Server (TLS) id 15.0.1497.32; Wed, 13 Apr 2022 04:17:51 +0000 Received: from rnnvmail202.nvidia.com (10.129.68.7) by rnnvmail205.nvidia.com (10.129.68.10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.22; Tue, 12 Apr 2022 21:17:50 -0700 Received: from Asurada-Nvidia.nvidia.com (10.127.8.11) by mail.nvidia.com (10.129.68.7) with Microsoft SMTP Server id 15.2.986.22 via Frontend Transport; Tue, 12 Apr 2022 21:17:49 -0700 To: , , Subject: [PATCH] iommu/arm-smmu-v3: Align size in __arm_smmu_tlb_inv_range Date: Tue, 12 Apr 2022 21:17:45 -0700 Message-ID: <20220413041745.35174-1-nicolinc@nvidia.com> X-Mailer: git-send-email 2.17.1 MIME-Version: 1.0 X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 5a23d60f-b60f-4172-d852-08da1d049379 X-MS-TrafficTypeDiagnostic: MN2PR12MB3149:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: WpPWD7KbqdSdvS+DyJn1aA8mNkO4TaCz19zotjPN2Lkgu8XH4KaT0nuRWMZu3RKq+W/i/BUfLFgTULGVbCmKoGERK4I5BVyDo/HSLYNBXeOzufIorzG0nZY1qTcQKU87IUyV1X2m8XzS946RyEMQ9RBPuLYsBJ/4cApm6p32tsD3QTFkAMenIXixICWNP3Y7h3vWtqqD+6VKCRBJ3U5/0CE4bi3rUAkzB+iycLfyTMrua/ASPccR5fT3pJBVwJsOVECuoEGOwpDucdr6N8V5qKRqchyiK1Av7sln1zMIpYt5Sxk71d3l+o2givwJ3Sw238JhNxOFIVLXJPALQMKX25684KXhBS2bTfnbm9X0wc/7PDcrhhGt3viE67rb28N4dTetpe7ExWTq7nZvcdyOPRL58nXLjDo0uDYgNT2obTufAJAxf1x7T6a/c7tCijUkLO1ytzhOki9Kf43un1JuAGZW458t6LUcuR0IxQKElbh26RfNiUlafBPIsGvorBF3o1mVpfm1qNExlHr/0PCIUaFvviR7hFYYIwtXUN1P3uEXneEyAhHeZudSGz6FTyBGn07K+l8YBIMrsLgCfvarCl61aftebERnn6UdqoWJIc/0z3a8g2ZtOyEeAydbtSzdi8pGPClGGnDAVeclu9uu8fqZfVWq+ku+OEc7prB0UKx6iWJp193k74iDT9UOjyJZ41bJlYYBLWppALfvQs44YA== X-Forefront-Antispam-Report: CIP:12.22.5.234; CTRY:US; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:mail.nvidia.com; PTR:InfoNoRecords; CAT:NONE; SFS:(13230001)(4636009)(36840700001)(46966006)(40470700004)(4744005)(508600001)(6666004)(36860700001)(5660300002)(316002)(336012)(83380400001)(47076005)(356005)(36756003)(40460700003)(70586007)(70206006)(86362001)(82310400005)(4326008)(81166007)(8676002)(426003)(8936002)(2906002)(7416002)(54906003)(110136005)(26005)(186003)(7696005)(1076003)(2616005)(36900700001); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Apr 2022 04:17:51.6407 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 5a23d60f-b60f-4172-d852-08da1d049379 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[12.22.5.234]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: DM6NAM11FT044.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR12MB3149 Cc: jean-philippe@linaro.org, linux-kernel@vger.kernel.org, jgg@ziepe.ca, iommu@lists.linux-foundation.org, christophe.jaillet@wanadoo.fr, tglx@linutronix.de, linux-arm-kernel@lists.infradead.org X-BeenThere: iommu@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Development issues for Linux IOMMU support List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Nicolin Chen via iommu Reply-To: Nicolin Chen Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: iommu-bounces@lists.linux-foundation.org Sender: "iommu" To calculate num_pages, the size should be aligned with "page size", determined by the tg value. Otherwise, its following "while (iova < end)" might become an infinite loop if unaligned size is slightly greater than 1 << tg. Signed-off-by: Nicolin Chen --- drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c b/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c index 627a3ed5ee8f..8249dad5ae44 100644 --- a/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c +++ b/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c @@ -1879,7 +1879,7 @@ static void __arm_smmu_tlb_inv_range(struct arm_smmu_cmdq_ent *cmd, /* Determine what level the granule is at */ cmd->tlbi.ttl = 4 - ((ilog2(granule) - 3) / (tg - 3)); - num_pages = size >> tg; + num_pages = ALIGN(size, 1 << tg) >> tg; } cmds.num = 0; -- 2.17.1 _______________________________________________ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 08A34C433F5 for ; Wed, 13 Apr 2022 04:33:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:Subject:CC :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=3qhdCAya6sY8l97u3Tzx2rIAU0Pwb7fZhg0xXnT/IH4=; b=CADJyeywZqYmEh dgIAY/o5xYzVUzTuUTi8FjGFZ9o0Db2iTarqZa3dsP1VLkJKikxvCAcNv2k21zj/ZOehNPLDPH3Ri oHwNiiTFoQFfSU4dR6h4PcN+HaXBB0YinPJsyl0/VPC/LpsgYNX2eUMhdJJDgnFgTDA7AWjYrA70J vU+XXGFXhC5OTUmPX/XOnhe3HH36PEOBrN88LmyRcLhhI7kDWO66CBiRB3HW2nNDaLHt4dL0LGLC7 mMi02QMauQ5vJxOPkCrQbyNP5uzRVcklvnx1C+dyQkzLSzyYbOPso9oYIWWvuu3pWIAaOM+wOYQ+L AYT48Ekl6ptgZO9k+VjA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1neUg2-00GkMu-63; Wed, 13 Apr 2022 04:32:22 +0000 Received: from mail-mw2nam10on20620.outbound.protection.outlook.com ([2a01:111:f400:7e89::620] helo=NAM10-MW2-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1neUfz-00GkMY-Bn for linux-arm-kernel@lists.infradead.org; Wed, 13 Apr 2022 04:32:20 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=lfawpoyPrJ1Eb00j2Pm9pvyHFN2oQV4/1/Dwk3tex3E4KGVy7XyEPWGEH2VHgcsH0Bb1zt2PKRRoNxltfV3AraOYwyESP6eUljQgk2tNDMd7IX23dwvz5CIo+W6RYDANkCMVPvVSbCZ2Rr2vkiaFylmzoBsTw4/+NkTXXujqhBSK4uLrSjSdbe3GWbdhrzFDkRYTqx+2irMc3JSUXmQt8NRuvBpbDbThQ2y3GtXQYRgBU41eUOOTeXToCTJOWmtuKVdNX4ttj3B2y0acyrqwMOYYLoyFQyj1dilFd3Frdh42/UcAZk8pg6B+dgEiKTXDBi1J61ClbiU0DMAT66Eb6g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Dixg6jFAlPeT+UGDhnY516ejVCvmVQWOWNK9DlYnwdM=; b=avvbg2b0uzkZ00OMdkCJ0DfgzZKORtVDUgA/bNmnn3/OPU7J9XC+Il/Oy1sCB9AocaVkw8oFzTnzUMwE8teZFg8h+92+NiyPADrIYlYsEHuoEWpafWVaJLikh8lShcn9iyGwOP9ZypFAwz+eptA0vf/BtiF8rBmgrYY7Zg4X/V5wnojRucWYx2ufxfDWBU7RYigh+JmbbxsapWwRaB9/jqYFTJPX6NSAhS6TWyXFlZoeOqASyHuyhzwPTagIqFazSAgZ+ABaZpbLw/qatWcIDmhlmZH9ZlCQdpmHSFKIOLsy5PfglX/BPLp1xFFh72GhnuqQ/uNPShBPjSC26U3gBw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 12.22.5.234) smtp.rcpttodomain=wanadoo.fr smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Dixg6jFAlPeT+UGDhnY516ejVCvmVQWOWNK9DlYnwdM=; b=ALoILaBdo34QMf1REYocrqxDEqkqIITz9Ao4wZ6l9UHst1kqjDt2GNLqK3U67brIpmzIdbDGs0b0cyu8kl0kukkzcOoeSfCYVPh3L+JFcEPCtCNvXw+1aADC5s5yR8cwQDLgFW/nVILX7LBQLq2E1TpE32os0Win5rHh2AD01JLHlzSh5VMh752lD64ev2ywhEZTqkk7iEERjoKa/+Z99Gc1ofxP16oF6FJ8kI7K/AmucnGAGF1JADF80FWQk+2L4kYEFSVSXDMnUpkmFWbPUVYDsJgh5cYomyOaEGjTycGBULy1Q93YD1IAntR7lX3168XSkzUiYJkPXNvuhPxFRA== Received: from DS7P222CA0028.NAMP222.PROD.OUTLOOK.COM (2603:10b6:8:2e::21) by MN2PR12MB3149.namprd12.prod.outlook.com (2603:10b6:208:d2::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5144.29; Wed, 13 Apr 2022 04:17:51 +0000 Received: from DM6NAM11FT044.eop-nam11.prod.protection.outlook.com (2603:10b6:8:2e:cafe::2c) by DS7P222CA0028.outlook.office365.com (2603:10b6:8:2e::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5164.20 via Frontend Transport; Wed, 13 Apr 2022 04:17:51 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 12.22.5.234) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 12.22.5.234 as permitted sender) receiver=protection.outlook.com; client-ip=12.22.5.234; helo=mail.nvidia.com; Received: from mail.nvidia.com (12.22.5.234) by DM6NAM11FT044.mail.protection.outlook.com (10.13.173.185) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.5164.19 via Frontend Transport; Wed, 13 Apr 2022 04:17:51 +0000 Received: from rnnvmail205.nvidia.com (10.129.68.10) by DRHQMAIL101.nvidia.com (10.27.9.10) with Microsoft SMTP Server (TLS) id 15.0.1497.32; Wed, 13 Apr 2022 04:17:51 +0000 Received: from rnnvmail202.nvidia.com (10.129.68.7) by rnnvmail205.nvidia.com (10.129.68.10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.22; Tue, 12 Apr 2022 21:17:50 -0700 Received: from Asurada-Nvidia.nvidia.com (10.127.8.11) by mail.nvidia.com (10.129.68.7) with Microsoft SMTP Server id 15.2.986.22 via Frontend Transport; Tue, 12 Apr 2022 21:17:49 -0700 From: Nicolin Chen To: , , CC: , , , , , , , , Subject: [PATCH] iommu/arm-smmu-v3: Align size in __arm_smmu_tlb_inv_range Date: Tue, 12 Apr 2022 21:17:45 -0700 Message-ID: <20220413041745.35174-1-nicolinc@nvidia.com> X-Mailer: git-send-email 2.17.1 MIME-Version: 1.0 X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 5a23d60f-b60f-4172-d852-08da1d049379 X-MS-TrafficTypeDiagnostic: MN2PR12MB3149:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: WpPWD7KbqdSdvS+DyJn1aA8mNkO4TaCz19zotjPN2Lkgu8XH4KaT0nuRWMZu3RKq+W/i/BUfLFgTULGVbCmKoGERK4I5BVyDo/HSLYNBXeOzufIorzG0nZY1qTcQKU87IUyV1X2m8XzS946RyEMQ9RBPuLYsBJ/4cApm6p32tsD3QTFkAMenIXixICWNP3Y7h3vWtqqD+6VKCRBJ3U5/0CE4bi3rUAkzB+iycLfyTMrua/ASPccR5fT3pJBVwJsOVECuoEGOwpDucdr6N8V5qKRqchyiK1Av7sln1zMIpYt5Sxk71d3l+o2givwJ3Sw238JhNxOFIVLXJPALQMKX25684KXhBS2bTfnbm9X0wc/7PDcrhhGt3viE67rb28N4dTetpe7ExWTq7nZvcdyOPRL58nXLjDo0uDYgNT2obTufAJAxf1x7T6a/c7tCijUkLO1ytzhOki9Kf43un1JuAGZW458t6LUcuR0IxQKElbh26RfNiUlafBPIsGvorBF3o1mVpfm1qNExlHr/0PCIUaFvviR7hFYYIwtXUN1P3uEXneEyAhHeZudSGz6FTyBGn07K+l8YBIMrsLgCfvarCl61aftebERnn6UdqoWJIc/0z3a8g2ZtOyEeAydbtSzdi8pGPClGGnDAVeclu9uu8fqZfVWq+ku+OEc7prB0UKx6iWJp193k74iDT9UOjyJZ41bJlYYBLWppALfvQs44YA== X-Forefront-Antispam-Report: CIP:12.22.5.234; CTRY:US; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:mail.nvidia.com; PTR:InfoNoRecords; CAT:NONE; SFS:(13230001)(4636009)(36840700001)(46966006)(40470700004)(4744005)(508600001)(6666004)(36860700001)(5660300002)(316002)(336012)(83380400001)(47076005)(356005)(36756003)(40460700003)(70586007)(70206006)(86362001)(82310400005)(4326008)(81166007)(8676002)(426003)(8936002)(2906002)(7416002)(54906003)(110136005)(26005)(186003)(7696005)(1076003)(2616005)(36900700001); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Apr 2022 04:17:51.6407 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 5a23d60f-b60f-4172-d852-08da1d049379 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[12.22.5.234]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: DM6NAM11FT044.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR12MB3149 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220412_213219_436347_71B0B5CC X-CRM114-Status: GOOD ( 10.86 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org To calculate num_pages, the size should be aligned with "page size", determined by the tg value. Otherwise, its following "while (iova < end)" might become an infinite loop if unaligned size is slightly greater than 1 << tg. Signed-off-by: Nicolin Chen --- drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c b/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c index 627a3ed5ee8f..8249dad5ae44 100644 --- a/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c +++ b/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c @@ -1879,7 +1879,7 @@ static void __arm_smmu_tlb_inv_range(struct arm_smmu_cmdq_ent *cmd, /* Determine what level the granule is at */ cmd->tlbi.ttl = 4 - ((ilog2(granule) - 3) / (tg - 3)); - num_pages = size >> tg; + num_pages = ALIGN(size, 1 << tg) >> tg; } cmds.num = 0; -- 2.17.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel