From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 69587C433F5 for ; Wed, 13 Apr 2022 08:14:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231370AbiDMIQz (ORCPT ); Wed, 13 Apr 2022 04:16:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37640 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229765AbiDMIQy (ORCPT ); Wed, 13 Apr 2022 04:16:54 -0400 Received: from mail-pg1-x535.google.com (mail-pg1-x535.google.com [IPv6:2607:f8b0:4864:20::535]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B794C6242 for ; Wed, 13 Apr 2022 01:14:33 -0700 (PDT) Received: by mail-pg1-x535.google.com with SMTP id s137so1120852pgs.5 for ; Wed, 13 Apr 2022 01:14:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :in-reply-to; bh=4fUoTI72AZWMVBQILm9a8ofTl+CJ34gLfpsg1GVIJKk=; b=YSz851A45q9hJe/ioUMTz/BkxJjJ3SRUYPbe2fQsJpUA4jfoCvHnSLrCIQWgx029EL nDHmdJCYZqyILyIoyWIvKGES0uoRDbz2FCwlY1F/qX0YEZytqc/pC4bo50bnq+uyNsnn dpICCyM/vA/XPEZpBRYnEQt7j3I/VfsVlckr8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:in-reply-to; bh=4fUoTI72AZWMVBQILm9a8ofTl+CJ34gLfpsg1GVIJKk=; b=y/lMag9HcV2abotGX+ZNZErvkzYRJFUEU2R+nirgTPN02SOStSLpLndAj6w/9yz1ZD QGHzFUZ76WPzvPiOlmYWf7/Y8FNKhHf8T0fOHkDYqx5EsP+/WL1+twSIO4kTgaeafros m2eWmFic0Dyo+4NihBOSbsiEK8qo/DC/r95yOWCO9w+foMzX+vf81ZzzzXDC5VewlJ8U vAsMQKHNqTfl+Rt9q7kierC9mANNsjOt70RK1VHrWOBcjsxMOWMi4GofintdjDEa17fx qdTctsx6O1UgMeKydq8ZfSoaYz32iJg3kEYHkn0UfbB1x/A4E9CKGBzizfndOukDlJ1k qzhA== X-Gm-Message-State: AOAM53115qzacADBYuKs3s5/OPT4eUO5U5gTeLizz1poB5t9K+j372Sc SVMZO5Su+lvRYKgQpzozzqkT/w== X-Google-Smtp-Source: ABdhPJx/c3rSe4Fy9NM2Hvy2dPDF7WPq1ooyR398VYTcDb2M2u6SIgCS75WK2O1INPw4Ajzl6wElbg== X-Received: by 2002:a63:1d0d:0:b0:382:5f9c:9391 with SMTP id d13-20020a631d0d000000b003825f9c9391mr34806598pgd.617.1649837673216; Wed, 13 Apr 2022 01:14:33 -0700 (PDT) Received: from noodle ([192.19.250.250]) by smtp.gmail.com with ESMTPSA id 21-20020a630115000000b00382a0895661sm5249264pgb.11.2022.04.13.01.14.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Apr 2022 01:14:31 -0700 (PDT) Date: Wed, 13 Apr 2022 11:14:17 +0300 From: Boris Sukholitko To: Jiri Pirko Cc: netdev@vger.kernel.org, "David S . Miller" , Jakub Kicinski , Jamal Hadi Salim , Cong Wang , "Gustavo A . R . Silva" , Vladimir Oltean , Eric Dumazet , zhang kai , Yoshiki Komachi , Ilya Lifshits Subject: Re: [PATCH net-next v2 5/5] net/sched: flower: Consider the number of tags for vlan filters Message-ID: <20220413081417.GA12128@noodle> References: <20220412100236.27244-1-boris.sukholitko@broadcom.com> <20220412100236.27244-6-boris.sukholitko@broadcom.com> <20220412114049.GA2451@noodle> <20220412131610.GB2451@noodle> MIME-Version: 1.0 In-Reply-To: Content-Type: multipart/signed; protocol="application/pkcs7-signature"; micalg=sha-256; boundary="0000000000007764ce05dc84c45a" Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org --0000000000007764ce05dc84c45a Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, Apr 12, 2022 at 04:17:01PM +0200, Jiri Pirko wrote: > Tue, Apr 12, 2022 at 03:16:10PM CEST, boris.sukholitko@broadcom.com wrote: > >On Tue, Apr 12, 2022 at 02:12:15PM +0200, Jiri Pirko wrote: > >> Tue, Apr 12, 2022 at 01:40:49PM CEST, boris.sukholitko@broadcom.com wrote: > >> >On Tue, Apr 12, 2022 at 01:09:35PM +0200, Jiri Pirko wrote: > >> >> Tue, Apr 12, 2022 at 12:02:36PM CEST, boris.sukholitko@broadcom.com wrote: > >> >> >Currently the existence of vlan filters is conditional on the vlan > >> >> >protocol being matched in the tc rule. I.e. the following rule: > >> >> > > >> >> >tc filter add dev eth1 ingress flower vlan_prio 5 > >> >> > > >> >> >is illegal because we lack protocol 802.1q in the rule. > >> >> > > >> >> >Having the num_of_vlans filter configured removes this restriction. The > >> >> >following rule becomes ok: > >> >> > > >> >> >tc filter add dev eth1 ingress flower num_of_vlans 1 vlan_prio 5 > >> >> > > >> >> >because we know that the packet is single tagged. > >> >> > > >> >> >We achieve the above by having is_vlan_key helper look at the number of > >> >> > >> >> Sorry to be a nitpicker, but who's "we"? When I read the patch > >> >> description, I need to understand clearly what the patch is doing, which > >> >> is not this case. You suppose to command the codebase what to do. > >> >> I fail to see that :/ > >> >> > >> >> > >> > > >> >What do you think of the following description? The description consists > >> >of two parts: the first provides motivation for the patch, the second is > >> >the way the motivation is implemented. I've judiciously edited out the > >> >"we"-word. :) > >> > > >> > > >> > > >> >Currently the existence of vlan filters is conditional on the vlan > >> >protocol being matched in the tc rule. I.e. the following rule: > >> > > >> >tc filter add dev eth1 ingress flower vlan_prio 5 > >> > > >> >is illegal because vlan protocol (e.g. 802.1q) does not appear in the rule. > >> > > >> >Having the num_of_vlans filter configured removes this restriction. The > >> >following rule becomes ok: > >> > > >> >tc filter add dev eth1 ingress flower num_of_vlans 1 vlan_prio 5 > >> > >> So this is what this patch allows? > > > >Yes. > > > >> You are talking about it as it is > >> already possible with the code before this patch being applied. > >> > > > >Sorry for the confusion. In the updated description I try to make the > >distinction much clearer. > > > >> > >> > > >> >because having num_of_vlans==1 implies that the packet is single tagged. > >> > > >> >To make the above possible, is_vlan_key helper is changed to look at the > >> >number of vlans in addition to the vlan ethertype. > >> > >> What "is changed"? You should tell the codebase what to do, what toadd, > >> remove or change. If you did that, it would be very clear to the reader > >> what the patch is supposed to do. > >> > > > >The "changed" refers to the code of is_vlan_key function which is > >changed by this patch. Please see the updated description. > > > >> > >> > > >> >Outer tag vlan filters (e.g. vlan_prio) require the number of vlan tags > >> >be greater than 0. Inner filters (e.g. cvlan_prio) require the number of > >> >vlan tags be greater than 1. > >> > >> Again, unclear what this describes, if the current code before the patch > >> or the state after this patch. > >> > > > >What about the following: > > > > > > > >Before this commit the existence of vlan filters was conditional on the vlan > >protocol being matched in the tc rule. For example, the following rule: > > > >tc filter add dev eth1 ingress flower vlan_prio 5 > > > >was illegal because vlan protocol (e.g. 802.1q) does not appear in the rule. > > > >This commit removes the above restriction. Having the num_of_vlans > > Say rather just "Remove the above restriction. ..." > > > >filter configured allows further matching on vlan attributes. The > >following rule is ok now: > > > >tc filter add dev eth1 ingress flower num_of_vlans 1 vlan_prio 5 > > > >because having num_of_vlans==1 implies that the packet is single tagged. > > > >To do this, this commit changes is_vlan_key helper to look at the number > > "Change the is_vlan_key helper to look..." > > Don't talk about "this commit". > OK. The following incorporates both of the above suggestions: Before this commit the existence of vlan filters was conditional on the vlan protocol being matched in the tc rule. For example, the following rule: tc filter add dev eth1 ingress flower vlan_prio 5 was illegal because vlan protocol (e.g. 802.1q) does not appear in the rule. Remove the above restriction by looking at the num_of_vlans filter to allow further matching on vlan attributes. The following rule is ok now: tc filter add dev eth1 ingress flower num_of_vlans 1 vlan_prio 5 because having num_of_vlans==1 implies that the packet is single tagged. Change is_vlan_key helper to look at the number of vlans in addition to the vlan ethertype. Outer (e.g. vlan_prio) and inner (e.g. cvlan_prio) tag vlan filters require the number of vlan tags to be greater then 0 and 1 accordingly. As a result of is_vlan_key change, the ethertype may be set to 0 when matching on the number of vlans. Update fl_set_key_vlan to avoid setting key, mask vlan_tpid for the 0 ethertype. Thanks, Boris. --0000000000007764ce05dc84c45a Content-Type: application/pkcs7-signature; name="smime.p7s" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="smime.p7s" Content-Description: S/MIME Cryptographic Signature MIIQeQYJKoZIhvcNAQcCoIIQajCCEGYCAQExDzANBglghkgBZQMEAgEFADALBgkqhkiG9w0BBwGg gg3QMIIFDTCCA/WgAwIBAgIQeEqpED+lv77edQixNJMdADANBgkqhkiG9w0BAQsFADBMMSAwHgYD VQQLExdHbG9iYWxTaWduIFJvb3QgQ0EgLSBSMzETMBEGA1UEChMKR2xvYmFsU2lnbjETMBEGA1UE AxMKR2xvYmFsU2lnbjAeFw0yMDA5MTYwMDAwMDBaFw0yODA5MTYwMDAwMDBaMFsxCzAJBgNVBAYT AkJFMRkwFwYDVQQKExBHbG9iYWxTaWduIG52LXNhMTEwLwYDVQQDEyhHbG9iYWxTaWduIEdDQyBS MyBQZXJzb25hbFNpZ24gMiBDQSAyMDIwMIIBIjANBgkqhkiG9w0BAQEFAAOCAQ8AMIIBCgKCAQEA vbCmXCcsbZ/a0fRIQMBxp4gJnnyeneFYpEtNydrZZ+GeKSMdHiDgXD1UnRSIudKo+moQ6YlCOu4t rVWO/EiXfYnK7zeop26ry1RpKtogB7/O115zultAz64ydQYLe+a1e/czkALg3sgTcOOcFZTXk38e aqsXsipoX1vsNurqPtnC27TWsA7pk4uKXscFjkeUE8JZu9BDKaswZygxBOPBQBwrA5+20Wxlk6k1 e6EKaaNaNZUy30q3ArEf30ZDpXyfCtiXnupjSK8WU2cK4qsEtj09JS4+mhi0CTCrCnXAzum3tgcH cHRg0prcSzzEUDQWoFxyuqwiwhHu3sPQNmFOMwIDAQABo4IB2jCCAdYwDgYDVR0PAQH/BAQDAgGG MGAGA1UdJQRZMFcGCCsGAQUFBwMCBggrBgEFBQcDBAYKKwYBBAGCNxQCAgYKKwYBBAGCNwoDBAYJ KwYBBAGCNxUGBgorBgEEAYI3CgMMBggrBgEFBQcDBwYIKwYBBQUHAxEwEgYDVR0TAQH/BAgwBgEB /wIBADAdBgNVHQ4EFgQUljPR5lgXWzR1ioFWZNW+SN6hj88wHwYDVR0jBBgwFoAUj/BLf6guRSSu TVD6Y5qL3uLdG7wwegYIKwYBBQUHAQEEbjBsMC0GCCsGAQUFBzABhiFodHRwOi8vb2NzcC5nbG9i YWxzaWduLmNvbS9yb290cjMwOwYIKwYBBQUHMAKGL2h0dHA6Ly9zZWN1cmUuZ2xvYmFsc2lnbi5j b20vY2FjZXJ0L3Jvb3QtcjMuY3J0MDYGA1UdHwQvMC0wK6ApoCeGJWh0dHA6Ly9jcmwuZ2xvYmFs c2lnbi5jb20vcm9vdC1yMy5jcmwwWgYDVR0gBFMwUTALBgkrBgEEAaAyASgwQgYKKwYBBAGgMgEo CjA0MDIGCCsGAQUFBwIBFiZodHRwczovL3d3dy5nbG9iYWxzaWduLmNvbS9yZXBvc2l0b3J5LzAN BgkqhkiG9w0BAQsFAAOCAQEAdAXk/XCnDeAOd9nNEUvWPxblOQ/5o/q6OIeTYvoEvUUi2qHUOtbf jBGdTptFsXXe4RgjVF9b6DuizgYfy+cILmvi5hfk3Iq8MAZsgtW+A/otQsJvK2wRatLE61RbzkX8 9/OXEZ1zT7t/q2RiJqzpvV8NChxIj+P7WTtepPm9AIj0Keue+gS2qvzAZAY34ZZeRHgA7g5O4TPJ /oTd+4rgiU++wLDlcZYd/slFkaT3xg4qWDepEMjT4T1qFOQIL+ijUArYS4owpPg9NISTKa1qqKWJ jFoyms0d0GwOniIIbBvhI2MJ7BSY9MYtWVT5jJO3tsVHwj4cp92CSFuGwunFMzCCA18wggJHoAMC AQICCwQAAAAAASFYUwiiMA0GCSqGSIb3DQEBCwUAMEwxIDAeBgNVBAsTF0dsb2JhbFNpZ24gUm9v dCBDQSAtIFIzMRMwEQYDVQQKEwpHbG9iYWxTaWduMRMwEQYDVQQDEwpHbG9iYWxTaWduMB4XDTA5 MDMxODEwMDAwMFoXDTI5MDMxODEwMDAwMFowTDEgMB4GA1UECxMXR2xvYmFsU2lnbiBSb290IENB IC0gUjMxEzARBgNVBAoTCkdsb2JhbFNpZ24xEzARBgNVBAMTCkdsb2JhbFNpZ24wggEiMA0GCSqG SIb3DQEBAQUAA4IBDwAwggEKAoIBAQDMJXaQeQZ4Ihb1wIO2hMoonv0FdhHFrYhy/EYCQ8eyip0E XyTLLkvhYIJG4VKrDIFHcGzdZNHr9SyjD4I9DCuul9e2FIYQebs7E4B3jAjhSdJqYi8fXvqWaN+J J5U4nwbXPsnLJlkNc96wyOkmDoMVxu9bi9IEYMpJpij2aTv2y8gokeWdimFXN6x0FNx04Druci8u nPvQu7/1PQDhBjPogiuuU6Y6FnOM3UEOIDrAtKeh6bJPkC4yYOlXy7kEkmho5TgmYHWyn3f/kRTv riBJ/K1AFUjRAjFhGV64l++td7dkmnq/X8ET75ti+w1s4FRpFqkD2m7pg5NxdsZphYIXAgMBAAGj QjBAMA4GA1UdDwEB/wQEAwIBBjAPBgNVHRMBAf8EBTADAQH/MB0GA1UdDgQWBBSP8Et/qC5FJK5N UPpjmove4t0bvDANBgkqhkiG9w0BAQsFAAOCAQEAS0DbwFCq/sgM7/eWVEVJu5YACUGssxOGhigH M8pr5nS5ugAtrqQK0/Xx8Q+Kv3NnSoPHRHt44K9ubG8DKY4zOUXDjuS5V2yq/BKW7FPGLeQkbLmU Y/vcU2hnVj6DuM81IcPJaP7O2sJTqsyQiunwXUaMld16WCgaLx3ezQA3QY/tRG3XUyiXfvNnBB4V 14qWtNPeTCekTBtzc3b0F5nCH3oO4y0IrQocLP88q1UOD5F+NuvDV0m+4S4tfGCLw0FREyOdzvcy a5QBqJnnLDMfOjsl0oZAzjsshnjJYS8Uuu7bVW/fhO4FCU29KNhyztNiUGUe65KXgzHZs7XKR1g/ XzCCBVgwggRAoAMCAQICDDSzinKpvcPTN4ZIJTANBgkqhkiG9w0BAQsFADBbMQswCQYDVQQGEwJC RTEZMBcGA1UEChMQR2xvYmFsU2lnbiBudi1zYTExMC8GA1UEAxMoR2xvYmFsU2lnbiBHQ0MgUjMg UGVyc29uYWxTaWduIDIgQ0EgMjAyMDAeFw0yMTAyMjIwNzMwMDRaFw0yMjA5MDUwNzM3NTVaMIGW MQswCQYDVQQGEwJJTjESMBAGA1UECBMJS2FybmF0YWthMRIwEAYDVQQHEwlCYW5nYWxvcmUxFjAU BgNVBAoTDUJyb2FkY29tIEluYy4xGTAXBgNVBAMTEEJvcmlzIFN1a2hvbGl0a28xLDAqBgkqhkiG 9w0BCQEWHWJvcmlzLnN1a2hvbGl0a29AYnJvYWRjb20uY29tMIIBIjANBgkqhkiG9w0BAQEFAAOC AQ8AMIIBCgKCAQEAy/C7bjpxs+95egWV8sWrK9KO0SQi6Nxu14tJBgP+MOK5tvokizPFHoiXTymZ 7ClfnmbcqT4PzWgI3thyfk64bgUo1nQkCTApn7ov3IRsWjmHExLSNoJ/siUHagO6BPAk4JSycrj5 9tC9sL4FnIAbAHmOSILCyGyyaBAcmiyH/3toYqXyjJkK+vbWQSTxk2NlqJLIN/ypLJ1pYffVZGUs 52g1hlQtHhgLIznB1Qx3Fop3nOUk8nNpQLON/aM8K5sl18964c7aXh7YZnalUQv3md4p2rAQQqIR rZ8HBc7YjlZynwOnZl1NrK4cP5aM9lMkbfRGIUitHTIhoDYp8IZ1dwIDAQABo4IB3jCCAdowDgYD VR0PAQH/BAQDAgWgMIGjBggrBgEFBQcBAQSBljCBkzBOBggrBgEFBQcwAoZCaHR0cDovL3NlY3Vy ZS5nbG9iYWxzaWduLmNvbS9jYWNlcnQvZ3NnY2NyM3BlcnNvbmFsc2lnbjJjYTIwMjAuY3J0MEEG CCsGAQUFBzABhjVodHRwOi8vb2NzcC5nbG9iYWxzaWduLmNvbS9nc2djY3IzcGVyc29uYWxzaWdu MmNhMjAyMDBNBgNVHSAERjBEMEIGCisGAQQBoDIBKAowNDAyBggrBgEFBQcCARYmaHR0cHM6Ly93 d3cuZ2xvYmFsc2lnbi5jb20vcmVwb3NpdG9yeS8wCQYDVR0TBAIwADBJBgNVHR8EQjBAMD6gPKA6 hjhodHRwOi8vY3JsLmdsb2JhbHNpZ24uY29tL2dzZ2NjcjNwZXJzb25hbHNpZ24yY2EyMDIwLmNy bDAoBgNVHREEITAfgR1ib3Jpcy5zdWtob2xpdGtvQGJyb2FkY29tLmNvbTATBgNVHSUEDDAKBggr BgEFBQcDBDAfBgNVHSMEGDAWgBSWM9HmWBdbNHWKgVZk1b5I3qGPzzAdBgNVHQ4EFgQUtBmGs9S4 t1FcFSfkrP2LKQQwBKMwDQYJKoZIhvcNAQELBQADggEBAJMAjVBkRmr1lvVvEjMaLfvMhwGpUfh6 CMZsKICyz/ZZmvTmIZNwy+7b9r6gjLCV4tP63tz4U72X9qJwfzldAlYLYWIq9e/DKDjwJRYlzN8H 979QJ0DHPSJ9EpvSKXob7Ci/FMkTfq1eOLjkPRF72mn8KPbHjeN3VVcn7oTe5IdIXaaZTryjM5Ud bR7s0ZZh6mOhJtqk3k1L1DbDTVB4tOZXZHRDghEGaQSnwU/qxCNlvQ52fImLFVwXKPnw6+9dUvFR ORaZ1pZbapCGbs/4QLplv8UaBmpFfK6MW/44zcsDbtCFfgIP3fEJBByIREhvRC5mtlRtdM+SSjgS ZiNfUggxggJtMIICaQIBATBrMFsxCzAJBgNVBAYTAkJFMRkwFwYDVQQKExBHbG9iYWxTaWduIG52 LXNhMTEwLwYDVQQDEyhHbG9iYWxTaWduIEdDQyBSMyBQZXJzb25hbFNpZ24gMiBDQSAyMDIwAgw0 s4pyqb3D0zeGSCUwDQYJYIZIAWUDBAIBBQCggdQwLwYJKoZIhvcNAQkEMSIEILFnZOGK8gK/3RXm DXO/BDifBajB1eXk/U4w9XAL/1dYMBgGCSqGSIb3DQEJAzELBgkqhkiG9w0BBwEwHAYJKoZIhvcN AQkFMQ8XDTIyMDQxMzA4MTQzM1owaQYJKoZIhvcNAQkPMVwwWjALBglghkgBZQMEASowCwYJYIZI AWUDBAEWMAsGCWCGSAFlAwQBAjAKBggqhkiG9w0DBzALBgkqhkiG9w0BAQowCwYJKoZIhvcNAQEH MAsGCWCGSAFlAwQCATANBgkqhkiG9w0BAQEFAASCAQA0i8ML9a6P9Aj6uFNxEGn215CPjLS5odoJ VgMwwvrabq3Lv7ozJLSELxw2XoFg5fGPzOe2Ak1UOQHuShC8OuRp0LhOXhPZkbiEiU0WH5GoG+zZ 2vdo50NgnjbGSJ78c7vkv+hq+RSqShSwjU/mwOKUhrixqyLyf/EWKQO6VTu/6S89N8TxvuYXxCSG NBIuig0gHUVvrkSvAK1o2UZRITj/zYEJolL9XFHh26DuiNcl4Deicnztzy3fIbA9juUr9vvEN4JI Oyf+qVvnfZbUMHKDxtgcfMcRha1peBE6/LoQeEdfOFmBJtHN8HRlAgoCiUj5wtZRamveHFDZYfxl txZg --0000000000007764ce05dc84c45a--