From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D3D2FC433EF for ; Wed, 13 Apr 2022 09:37:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234555AbiDMJkB (ORCPT ); Wed, 13 Apr 2022 05:40:01 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54930 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232868AbiDMJj4 (ORCPT ); Wed, 13 Apr 2022 05:39:56 -0400 Received: from mail-pj1-x102c.google.com (mail-pj1-x102c.google.com [IPv6:2607:f8b0:4864:20::102c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D383853E0C for ; Wed, 13 Apr 2022 02:37:35 -0700 (PDT) Received: by mail-pj1-x102c.google.com with SMTP id bx5so1420668pjb.3 for ; Wed, 13 Apr 2022 02:37:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=+A5GVMcDGs/YmPVYcCBNQNZhaB0wrRWQ2z4fJdwmcdY=; b=jgh+bv3SOSc/tjzMNsXiwiYM+gfdwL5raMVyitWjPhH/R8gBrFvkUZrGY5b0LDl3ry f+G7OuHGZGdZCrYDPjZvlPfzB8NL/pJQGfnKrRXYHGzZu5UP6aEwTRA/VxpsMAaLkyoB QLn0HNAUNjbUFV0+nYM/+voPduv4K7GtE1ZH4Ln8ecyqjaryWIKADGPhhcYW7GFNyE/j F4pdta8zpeXZ3O74O4zxPBUNGuKIGkriBBOLMbQaZNbqj1eBnzo8f09dgppoKKSE3uPQ lVacDStXWLfjfegjV7fEqXAlBXhE9sScM0/Iz/N+hD9hA5wX7Is8WXvxWxAc4dnbfigN 1yxA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=+A5GVMcDGs/YmPVYcCBNQNZhaB0wrRWQ2z4fJdwmcdY=; b=NiUUKUdG/NtqnI3HmnhesW/wMzRrvp5JUJzoapHtdaG/7GGnCfNLhUkCNmKGy/P497 XvpJSnsHYeo0a/DRSpjP4A/ljNLkPrGM71MQt9hBuEj9GS9iWET7PFqdMRWHyJo4qDZ8 bUME4GfdAwRHDLTXIeXdINEdpxCM+0fT1S3nMmqL8ZE7jfzjptMBdmxt9U45jcoHaJMQ WMuX2AxHSk8mDupk7ndbqVP3py/H5BiSlAbTAvmyfhfz/0vFoN1L6M/FvFbEep65qwd/ 1U9cA7Ufd6vF05SeoycBnuRGO6KOwy0wDnf+uS2D3VNdMSTxCOerlDUb1CcKYOdV2T9r IVPw== X-Gm-Message-State: AOAM530YybmnGYGuwMrXjkjTAUxpI8q6Whj7tpRFp8YgwfNAEQvnNCsy b0Y6rh6CHZ/22x+b/5n9Poc= X-Google-Smtp-Source: ABdhPJxT6kdacq6sagnqkQ+1zInpVIOkCQ7hD7tZFQFCbrx+Iy3F3TlFWePcVpcacDAbaU5n+1NagA== X-Received: by 2002:a17:902:b710:b0:156:47a6:c575 with SMTP id d16-20020a170902b71000b0015647a6c575mr7305869pls.37.1649842655423; Wed, 13 Apr 2022 02:37:35 -0700 (PDT) Received: from localhost.localdomain ([193.203.214.57]) by smtp.gmail.com with ESMTPSA id m1-20020a17090ade0100b001cb3feaddfcsm3415685pjv.2.2022.04.13.02.37.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Apr 2022 02:37:35 -0700 (PDT) From: cgel.zte@gmail.com X-Google-Original-From: chi.minghao@zte.com.cn To: shawnguo@kernel.org Cc: s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com, l.stach@pengutronix.de, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Minghao Chi , Zeal Robot Subject: [PATCH] soc: img: using pm_runtime_resume_and_get instead of pm_runtime_get_sync Date: Wed, 13 Apr 2022 09:37:30 +0000 Message-Id: <20220413093730.2538566-1-chi.minghao@zte.com.cn> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Minghao Chi Using pm_runtime_resume_and_get is more appropriate for simplifing code Reported-by: Zeal Robot Signed-off-by: Minghao Chi --- drivers/soc/imx/imx8m-blk-ctrl.c | 15 +++++---------- 1 file changed, 5 insertions(+), 10 deletions(-) diff --git a/drivers/soc/imx/imx8m-blk-ctrl.c b/drivers/soc/imx/imx8m-blk-ctrl.c index 122f9c884b38..f85517767829 100644 --- a/drivers/soc/imx/imx8m-blk-ctrl.c +++ b/drivers/soc/imx/imx8m-blk-ctrl.c @@ -81,9 +81,8 @@ static int imx8m_blk_ctrl_power_on(struct generic_pm_domain *genpd) int ret; /* make sure bus domain is awake */ - ret = pm_runtime_get_sync(bc->bus_power_dev); + ret = pm_runtime_resume_and_get(bc->bus_power_dev); if (ret < 0) { - pm_runtime_put_noidle(bc->bus_power_dev); dev_err(bc->dev, "failed to power up bus domain\n"); return ret; } @@ -335,20 +334,16 @@ static int imx8m_blk_ctrl_suspend(struct device *dev) * in the system suspend/resume paths due to the device parent/child * hierarchy. */ - ret = pm_runtime_get_sync(bc->bus_power_dev); - if (ret < 0) { - pm_runtime_put_noidle(bc->bus_power_dev); + ret = pm_runtime_resume_and_get(bc->bus_power_dev); + if (ret < 0) return ret; - } for (i = 0; i < bc->onecell_data.num_domains; i++) { struct imx8m_blk_ctrl_domain *domain = &bc->domains[i]; - ret = pm_runtime_get_sync(domain->power_dev); - if (ret < 0) { - pm_runtime_put_noidle(domain->power_dev); + ret = pm_runtime_resume_and_get(domain->power_dev); + if (ret < 0) goto out_fail; - } } return 0; -- 2.25.1 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7C904C433EF for ; Wed, 13 Apr 2022 09:38:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=jf303AovPYT2sjPikcW+dKVgUL6MXmsRBGwvNSA/4/A=; b=1xKflpKRI6chst cyOIPVNIDbJgViLqqOwKtVCTOiHBvWJ23u0VTIXQs6kveFSmdu4OL9pMJi2G33Og70844cW6zOATD l0dPhEUYl+cc9rtnRWyJ73ofO0U+Ha2sNiYGjsogvK8Q0G99WH187iPk+pr+kWTQrRc1g96/eTStI v0Yj5UroU8dXUoLoRDV5XvE7v4nJe8YicdXNZClAf/hpCmyudn8/hKpVwWPx3H0J0OKzVLk0JFy6F JOsYe86Gkyy/wRyV81hzjwE+OTQe8M1R1p+e3FSVwzo6qDCG+Ww7jwClWUmLaIrgznr/y1u8O0sHo uOG7lFqZhjvJ8VwlQMjw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1neZRZ-000MoJ-1r; Wed, 13 Apr 2022 09:37:45 +0000 Received: from mail-pj1-x1036.google.com ([2607:f8b0:4864:20::1036]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1neZRQ-000Mm0-2z for linux-arm-kernel@lists.infradead.org; Wed, 13 Apr 2022 09:37:42 +0000 Received: by mail-pj1-x1036.google.com with SMTP id 2so1429365pjw.2 for ; Wed, 13 Apr 2022 02:37:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=+A5GVMcDGs/YmPVYcCBNQNZhaB0wrRWQ2z4fJdwmcdY=; b=jgh+bv3SOSc/tjzMNsXiwiYM+gfdwL5raMVyitWjPhH/R8gBrFvkUZrGY5b0LDl3ry f+G7OuHGZGdZCrYDPjZvlPfzB8NL/pJQGfnKrRXYHGzZu5UP6aEwTRA/VxpsMAaLkyoB QLn0HNAUNjbUFV0+nYM/+voPduv4K7GtE1ZH4Ln8ecyqjaryWIKADGPhhcYW7GFNyE/j F4pdta8zpeXZ3O74O4zxPBUNGuKIGkriBBOLMbQaZNbqj1eBnzo8f09dgppoKKSE3uPQ lVacDStXWLfjfegjV7fEqXAlBXhE9sScM0/Iz/N+hD9hA5wX7Is8WXvxWxAc4dnbfigN 1yxA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=+A5GVMcDGs/YmPVYcCBNQNZhaB0wrRWQ2z4fJdwmcdY=; b=F2mNe3dto22+G5tVVPxKfOnH2iKo4mlPkXSAzhHs3l8WDb9WC5op9sZM+Fxb06po6v kYwUWULOuKTTcvrMcuLFnE20fvlYiv24EzdU+4t4XFkpJMyB+dFVqR7dsDnMmqUABmQD ACM1TA0NNBru0OIUwLEfM/6uxba1jyjhcYe0o7NvzhDAkxCNMIf/qPbWZ/sO8yqxjzuH NWhD7hiCinJUiLCxkVgDx2sz9Asda/BVPZR6m4sA/tYQ4qLACSriG2SjceL5wMlK2sYx xerHBQ1sOkir6CaEuEFtQo/w92LEb+E/iPSO4hV/w6U9T2oNyhaiJ89VrfnTAD44m4rF TLZg== X-Gm-Message-State: AOAM531zglnWYVUDu+ZbUXkC/q0XXoZv5z5NxJ3l6zNuqb/klUPguhC1 TtrP+PHx4u9xAbXNIikf6zw= X-Google-Smtp-Source: ABdhPJxT6kdacq6sagnqkQ+1zInpVIOkCQ7hD7tZFQFCbrx+Iy3F3TlFWePcVpcacDAbaU5n+1NagA== X-Received: by 2002:a17:902:b710:b0:156:47a6:c575 with SMTP id d16-20020a170902b71000b0015647a6c575mr7305869pls.37.1649842655423; Wed, 13 Apr 2022 02:37:35 -0700 (PDT) Received: from localhost.localdomain ([193.203.214.57]) by smtp.gmail.com with ESMTPSA id m1-20020a17090ade0100b001cb3feaddfcsm3415685pjv.2.2022.04.13.02.37.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Apr 2022 02:37:35 -0700 (PDT) From: cgel.zte@gmail.com X-Google-Original-From: chi.minghao@zte.com.cn To: shawnguo@kernel.org Cc: s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com, l.stach@pengutronix.de, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Minghao Chi , Zeal Robot Subject: [PATCH] soc: img: using pm_runtime_resume_and_get instead of pm_runtime_get_sync Date: Wed, 13 Apr 2022 09:37:30 +0000 Message-Id: <20220413093730.2538566-1-chi.minghao@zte.com.cn> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220413_023736_193830_40CACF99 X-CRM114-Status: GOOD ( 13.27 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org From: Minghao Chi Using pm_runtime_resume_and_get is more appropriate for simplifing code Reported-by: Zeal Robot Signed-off-by: Minghao Chi --- drivers/soc/imx/imx8m-blk-ctrl.c | 15 +++++---------- 1 file changed, 5 insertions(+), 10 deletions(-) diff --git a/drivers/soc/imx/imx8m-blk-ctrl.c b/drivers/soc/imx/imx8m-blk-ctrl.c index 122f9c884b38..f85517767829 100644 --- a/drivers/soc/imx/imx8m-blk-ctrl.c +++ b/drivers/soc/imx/imx8m-blk-ctrl.c @@ -81,9 +81,8 @@ static int imx8m_blk_ctrl_power_on(struct generic_pm_domain *genpd) int ret; /* make sure bus domain is awake */ - ret = pm_runtime_get_sync(bc->bus_power_dev); + ret = pm_runtime_resume_and_get(bc->bus_power_dev); if (ret < 0) { - pm_runtime_put_noidle(bc->bus_power_dev); dev_err(bc->dev, "failed to power up bus domain\n"); return ret; } @@ -335,20 +334,16 @@ static int imx8m_blk_ctrl_suspend(struct device *dev) * in the system suspend/resume paths due to the device parent/child * hierarchy. */ - ret = pm_runtime_get_sync(bc->bus_power_dev); - if (ret < 0) { - pm_runtime_put_noidle(bc->bus_power_dev); + ret = pm_runtime_resume_and_get(bc->bus_power_dev); + if (ret < 0) return ret; - } for (i = 0; i < bc->onecell_data.num_domains; i++) { struct imx8m_blk_ctrl_domain *domain = &bc->domains[i]; - ret = pm_runtime_get_sync(domain->power_dev); - if (ret < 0) { - pm_runtime_put_noidle(domain->power_dev); + ret = pm_runtime_resume_and_get(domain->power_dev); + if (ret < 0) goto out_fail; - } } return 0; -- 2.25.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel